From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Wed, 2 Jan 2008 21:27:31 +0000 (+0000)
Subject: don't call LogLastRepeatIfNeeded() from dtor, it's too late to do it there anyhow... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/6f6b48f176abb12da9d9fecdfa23daa49256c3c3

don't call LogLastRepeatIfNeeded() from dtor, it's too late to do it there anyhow; do call it from Flush() however (replaces patch 1857589)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@50994 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/log.cpp b/src/common/log.cpp
index 250b7b3924..262477de40 100644
--- a/src/common/log.cpp
+++ b/src/common/log.cpp
@@ -490,7 +490,17 @@ unsigned wxLog::LogLastRepeatIfNeededUnlocked()
 
 wxLog::~wxLog()
 {
-    LogLastRepeatIfNeeded();
+    // Flush() must be called before destroying the object as otherwise some
+    // messages could be lost
+    if ( ms_prevCounter )
+    {
+        wxMessageOutputDebug().Printf
+        (
+            wxS("Last repeated message (\"%s\", %lu times) wasn't output"),
+            ms_prevString,
+            ms_prevCounter
+        );
+    }
 }
 
 /* static */
@@ -705,7 +715,7 @@ void wxLog::DoLogString(const wxString& szString, time_t t)
 
 void wxLog::Flush()
 {
-    // nothing to do here
+    LogLastRepeatIfNeeded();
 }
 
 /*static*/ bool wxLog::IsAllowedTraceMask(const wxString& mask)