From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Mon, 9 Apr 2007 15:52:27 +0000 (+0000)
Subject: don't overwrite the buffer if extending it failed
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/6859e6fcca54ae7a1f09c136b6f3c2214ed05c07

don't overwrite the buffer if extending it failed


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@45356 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/stringimpl.cpp b/src/common/stringimpl.cpp
index 0575bd8fc5..e8750dc4f0 100644
--- a/src/common/stringimpl.cpp
+++ b/src/common/stringimpl.cpp
@@ -298,6 +298,7 @@ wxStringImpl& wxStringImpl::append(size_t n, wxStringCharType ch)
 
     if ( !Alloc(len + n) || !CopyBeforeWrite() ) {
       wxFAIL_MSG( _T("out of memory in wxStringImpl::append") );
+      return *this;
     }
     GetStringData()->nDataLength = len + n;
     m_pchData[len + n] = '\0';
@@ -419,6 +420,7 @@ wxStringImpl& wxStringImpl::insert(size_t nPos, const wxChar *sz, size_t n)
 
     if ( !Alloc(length() + n) || !CopyBeforeWrite() ) {
         wxFAIL_MSG( _T("out of memory in wxStringImpl::insert") );
+        return *this;
     }
 
     memmove(m_pchData + nPos + n, m_pchData + nPos,