From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Sat, 19 Jan 2002 21:48:30 +0000 (+0000)
Subject: dismiss the popup when an unprocessed key is pressed
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/60178eb439b4624d6663a997b6a29d0e93b20f70?ds=inline

dismiss the popup when an unprocessed key is pressed


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@13663 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/popupcmn.cpp b/src/common/popupcmn.cpp
index 0da4939868..2fabd49c70 100644
--- a/src/common/popupcmn.cpp
+++ b/src/common/popupcmn.cpp
@@ -81,6 +81,7 @@ public:
 protected:
     // event handlers
     void OnKillFocus(wxFocusEvent& event);
+    void OnKeyUp(wxKeyEvent& event);
 
 private:
     wxPopupTransientWindow *m_popup;
@@ -98,6 +99,7 @@ END_EVENT_TABLE()
 
 BEGIN_EVENT_TABLE(wxPopupFocusHandler, wxEvtHandler)
     EVT_KILL_FOCUS(wxPopupFocusHandler::OnKillFocus)
+    EVT_KEY_UP(wxPopupFocusHandler::OnKeyUp)
 END_EVENT_TABLE()
 
 // ============================================================================
@@ -204,7 +206,7 @@ void wxPopupTransientWindow::Popup(wxWindow *winFocus)
         m_child = this;
     }
 
-    // we can't capture mouse before the window is shown in wxGTL
+    // we can't capture mouse before the window is shown in wxGTK
 #ifdef __WXGTK__
     Show();
 #endif
@@ -217,8 +219,23 @@ void wxPopupTransientWindow::Popup(wxWindow *winFocus)
 #endif
 
     m_focus = winFocus ? winFocus : this;
-    m_focus->PushEventHandler(new wxPopupFocusHandler(this));
     m_focus->SetFocus();
+
+    // FIXME: I don't know why does this happen but sometimes SetFocus() simply
+    //        refuses to work under MSW - no error happens but the focus is not
+    //        given to the window, i.e. the assert below is triggered
+    //
+    //        Try work around this as we can...
+#if 0
+    wxASSERT_MSG( FindFocus() == m_focus, _T("setting focus failed") );
+#else
+    m_focus = FindFocus();
+#endif
+
+    if ( m_focus )
+    {
+        m_focus->PushEventHandler(new wxPopupFocusHandler(this));
+    }
 }
 
 void wxPopupTransientWindow::Dismiss()
@@ -362,12 +379,20 @@ void wxPopupWindowHandler::OnLeftDown(wxMouseEvent& event)
 
 void wxPopupFocusHandler::OnKillFocus(wxFocusEvent& event)
 {
-    // when we lose focus we always disappear
+    // when we lose focus we always disappear - unless it goes to the popup (in
+    // which case we don't really lose it)
+    if ( event.GetWindow() != m_popup )
+        m_popup->DismissAndNotify();
+}
 
-    // But if m_popup was about to get the focus,
-    // don't disappear.
-    if (event.GetWindow() != m_popup)
+void wxPopupFocusHandler::OnKeyUp(wxKeyEvent& event)
+{
+    // let the window have it first, it might process the keys
+    if ( !m_popup->ProcessEvent(event) )
+    {
+        // by default, dismiss the popup
         m_popup->DismissAndNotify();
+    }
 }
 
 #endif // wxUSE_POPUPWIN