From: Julian Smart <julian@anthemion.co.uk>
Date: Tue, 12 Feb 2002 15:39:18 +0000 (+0000)
Subject: Pass correct length to XTextExtents
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/56cb684ab2df095cfbbab7a74c5666e719c87f0a

Pass correct length to XTextExtents


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@14157 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/x11/dcclient.cpp b/src/x11/dcclient.cpp
index 93746522bd..509325d628 100644
--- a/src/x11/dcclient.cpp
+++ b/src/x11/dcclient.cpp
@@ -1233,7 +1233,10 @@ void wxWindowDC::DoDrawText( const wxString &text, wxCoord x, wxCoord y )
     y = YLOG2DEV(y);
 
     XCharStruct overall_return;
-    int direction, slen, ascent, descent;
+    int direction = 0;
+    int slen = text.Length();
+    int ascent = 0;
+    int descent = 0;
     (void)XTextExtents((XFontStruct*) xfont, (char*) (const char*) text, slen, &direction,
                                &ascent, &descent, &overall_return);
 #if 0
diff --git a/src/x11/toplevel.cpp b/src/x11/toplevel.cpp
index fb3be5d0fd..648bb6ac3a 100644
--- a/src/x11/toplevel.cpp
+++ b/src/x11/toplevel.cpp
@@ -95,7 +95,8 @@ bool wxTopLevelWindowX11::Create(wxWindow *parent,
     // TODO: For dialogs, this should be wxSYS_COLOUR_3DFACE
     m_backgroundColour = wxSystemSettings::GetColour(wxSYS_COLOUR_APPWORKSPACE);
     m_backgroundColour.CalcPixel( (WXColormap) cm );
-
+    m_hasBgCol = TRUE;
+	
     XSetWindowAttributes xattributes;
     XSizeHints size_hints;
     XWMHints wm_hints;
diff --git a/src/x11/window.cpp b/src/x11/window.cpp
index ec6674bbf1..041217aa9e 100644
--- a/src/x11/window.cpp
+++ b/src/x11/window.cpp
@@ -138,6 +138,7 @@ bool wxWindowX11::Create(wxWindow *parent, wxWindowID id,
 
     m_backgroundColour = wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE);
     m_backgroundColour.CalcPixel( (WXColormap) cm ); 
+    m_hasBgCol = TRUE;
     
     m_foregroundColour = *wxBLACK;
     m_foregroundColour.CalcPixel( (WXColormap) cm ); 
@@ -1313,8 +1314,7 @@ int wxComputeColours (Display *display, wxColour * back, wxColour * fore)
 
 bool wxWindowX11::SetBackgroundColour(const wxColour& col)
 {
-    if ( !wxWindowBase::SetBackgroundColour(col) )
-        return FALSE;
+    wxWindowBase::SetBackgroundColour(col);
 
     if (!GetMainWindow())
         return FALSE;