From: Vadim Zeitlin Date: Mon, 27 Nov 2006 15:01:58 +0000 (+0000) Subject: ensure that image data is always freed by using wxON_BLOCK_EXIT in ReadTGA() (coverit... X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/566921195a13be04c3b17dd338f3a3ad740e2388 ensure that image data is always freed by using wxON_BLOCK_EXIT in ReadTGA() (coverity id 202) git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@43681 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- diff --git a/src/common/imagtga.cpp b/src/common/imagtga.cpp index 281682cbb9..6d65dd7889 100644 --- a/src/common/imagtga.cpp +++ b/src/common/imagtga.cpp @@ -30,6 +30,7 @@ #include "wx/imagtga.h" #include "wx/log.h" +#include "wx/scopeguard.h" // ---------------------------------------------------------------------------- // constants @@ -187,6 +188,8 @@ int ReadTGA(wxImage* image, wxInputStream& stream) return wxTGA_MEMERR; } + wxON_BLOCK_EXIT1(free, imageData); + unsigned char *dst = image->GetData(); unsigned char* alpha = NULL; @@ -626,8 +629,6 @@ int ReadTGA(wxImage* image, wxInputStream& stream) return wxTGA_INVFORMAT; } - free(imageData); - return wxTGA_OK; }