From: Jaakko Salli <jaakko.salli@dnainternet.net>
Date: Sun, 4 Jul 2010 08:53:07 +0000 (+0000)
Subject: Changed wxPropertyGrid default property validation failure behavior to more user... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/4fb5dadb132f8244a10c60f06fa94485710c1afd

Changed wxPropertyGrid default property validation failure behavior to more user-friendly wxPG_VFB_MARK_CELL | wxPG_VFB_SHOW_MESSAGEBOX

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64808 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/docs/doxygen/overviews/propgrid.h b/docs/doxygen/overviews/propgrid.h
index 75565ee9d5..9a40a468c7 100644
--- a/docs/doxygen/overviews/propgrid.h
+++ b/docs/doxygen/overviews/propgrid.h
@@ -725,7 +725,7 @@ message.
                     event.Veto();
                     event.SetValidationFailureBehavior(wxPG_VFB_STAY_IN_PROPERTY |
                                                        wxPG_VFB_BEEP |
-                                                       wxPG_VFB_SHOW_MESSAGE);
+                                                       wxPG_VFB_SHOW_MESSAGEBOX);
                 }
             }
         }
@@ -979,6 +979,12 @@ without warnings or errors.
 
   - Extended window style wxPG_EX_LEGACY_VALIDATORS was removed.
 
+  - Default property validation failure behavior has been changed to
+    (wxPG_VFB_MARK_CELL | wxPG_VFB_SHOW_MESSAGEBOX), which means that the
+    cell is marked red and wxMessageBox is shown. This is more user-friendly
+    than the old behavior, which simply beeped and prevented leaving the
+    property editor until a valid value was entered.
+
   - wxPropertyGridManager now has same Get/SetSelection() semantics as
     wxPropertyGrid.
 
diff --git a/include/wx/propgrid/propgrid.h b/include/wx/propgrid/propgrid.h
index d50bc95238..7d37883174 100644
--- a/include/wx/propgrid/propgrid.h
+++ b/include/wx/propgrid/propgrid.h
@@ -415,7 +415,8 @@ wxPG_VFB_SHOW_MESSAGEBOX            = 0x10,
 wxPG_VFB_SHOW_MESSAGE_ON_STATUSBAR  = 0x20,
 
 /** Defaults. */
-wxPG_VFB_DEFAULT                    = wxPG_VFB_STAY_IN_PROPERTY|wxPG_VFB_BEEP,
+wxPG_VFB_DEFAULT                    = wxPG_VFB_MARK_CELL |
+                                      wxPG_VFB_SHOW_MESSAGEBOX,
 
 /** Only used internally. */
 wxPG_VFB_UNDEFINED                  = 0x80
diff --git a/interface/wx/propgrid/propgrid.h b/interface/wx/propgrid/propgrid.h
index 754c1989b0..2bed98ecf1 100644
--- a/interface/wx/propgrid/propgrid.h
+++ b/interface/wx/propgrid/propgrid.h
@@ -260,7 +260,8 @@ wxPG_VFB_SHOW_MESSAGE_ON_STATUSBAR  = 0x20,
 /**
     Defaults.
 */
-wxPG_VFB_DEFAULT                    = wxPG_VFB_STAY_IN_PROPERTY|wxPG_VFB_BEEP,
+wxPG_VFB_DEFAULT                    = wxPG_VFB_MARK_CELL |
+                                      wxPG_VFB_SHOW_MESSAGEBOX,
 };
 
 /** @}