From: Vadim Zeitlin <vadim@wxwidgets.org> Date: Sun, 25 Nov 2012 23:17:56 +0000 (+0000) Subject: Fix TAB navigation in wxGTK broken by r72663. X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/4b5a12ecea0b35b83f4f1e918f2c5cf6cfa451b9 Fix TAB navigation in wxGTK broken by r72663. Don't call SetCanFocus(true) for container windows with focusable children, this doesn't play well at all with wxGTK focus handling and in particular totally disabled TAB navigation. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73018 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- diff --git a/src/common/containr.cpp b/src/common/containr.cpp index ecc7570e70..fbd3ea33d2 100644 --- a/src/common/containr.cpp +++ b/src/common/containr.cpp @@ -54,7 +54,10 @@ bool wxControlContainerBase::UpdateCanFocusChildren() { m_acceptsFocusChildren = acceptsFocusChildren; - m_winParent->SetCanFocus(AcceptsFocusRecursively()); + // In the ports where it does something non trivial, the parent window + // should only be focusable if it doesn't have any focusable children + // (e.g. native focus handling in wxGTK totally breaks down otherwise). + m_winParent->SetCanFocus(m_acceptsFocusSelf && !m_acceptsFocusChildren); } return m_acceptsFocusChildren;