From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Wed, 7 Mar 2007 23:46:03 +0000 (+0000)
Subject: update the value shown in the combobox itself correctly in SetValue() (patch 1669275... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/4738d6746be3a987f106ef75a92ddfc7afbad935

update the value shown in the combobox itself correctly in SetValue() (patch 1669275; bug 1667563)


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@44669 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/combocmn.cpp b/src/common/combocmn.cpp
index 2595b6ad92..d1c34dfbeb 100644
--- a/src/common/combocmn.cpp
+++ b/src/common/combocmn.cpp
@@ -2191,16 +2191,18 @@ void wxComboCtrlBase::SetValueWithEvent(const wxString& value, bool withEvent)
             m_text->SelectAll();
     }
 
-    m_valueString = value;
-
-    Refresh();
-
     // Since wxComboPopup may want to paint the combo as well, we need
     // to set the string value here (as well as sometimes in ShowPopup).
-    if ( m_valueString != value && m_popupInterface )
+    if ( m_valueString != value )
     {
+        m_valueString = value;
+
+        EnsurePopupControl();
+
         m_popupInterface->SetStringValue(value);
     }
+
+    Refresh();
 }
 
 void wxComboCtrlBase::SetValue(const wxString& value)