From: Václav Slavík <vslavik@fastmail.fm>
Date: Sun, 11 Apr 2004 21:36:06 +0000 (+0000)
Subject: don't use strcpy to copy between overlapping strings, it's undefined operation
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/37c2a8dab05154b396e20a9de1de7a10adb2b88a

don't use strcpy to copy between overlapping strings, it's undefined operation


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@26719 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/xpmdecod.cpp b/src/common/xpmdecod.cpp
index 358131f241..f8524971a0 100644
--- a/src/common/xpmdecod.cpp
+++ b/src/common/xpmdecod.cpp
@@ -178,7 +178,10 @@ wxImage wxXPMDecoder::ReadFile(wxInputStream& stream)
             if ( (*q == '*') && (*(q + 1) == '/') )
                 break;
         }
-        strcpy(p, q + 2);
+        
+        // memmove allows overlaps (unlike strcpy):
+        size_t cpylen = strlen(q + 2) + 1;
+        memmove(p, q + 2, cpylen); 
     }
 
     /*