From: Gilles Depeyrot Date: Sat, 1 Dec 2001 13:34:50 +0000 (+0000) Subject: don't use wxTheXXXList in wxXXX ctor/dtor, only objects explicitly created X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/2edd0e7c6689e0668a9fcc4fcde74dcdee3e69d8 don't use wxTheXXXList in wxXXX ctor/dtor, only objects explicitly created with FindOrCreateXXX() are managed by the lists git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@12799 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- diff --git a/src/mac/bitmap.cpp b/src/mac/bitmap.cpp index 95bc8f1612..688ce82584 100644 --- a/src/mac/bitmap.cpp +++ b/src/mac/bitmap.cpp @@ -367,15 +367,10 @@ bool wxBitmap::CopyFromIcon(const wxIcon& icon) wxBitmap::wxBitmap() { m_refData = NULL; - - if ( wxTheBitmapList ) - wxTheBitmapList->AddBitmap(this); } wxBitmap::~wxBitmap() { - if (wxTheBitmapList) - wxTheBitmapList->DeleteObject(this); } wxBitmap::wxBitmap(const char bits[], int the_width, int the_height, int no_bits) @@ -437,34 +432,21 @@ wxBitmap::wxBitmap(const char bits[], int the_width, int the_height, int no_bits { wxFAIL_MSG(wxT("multicolor BITMAPs not yet implemented")); } - - if ( wxTheBitmapList ) { - wxTheBitmapList->AddBitmap(this); - } } wxBitmap::wxBitmap(int w, int h, int d) { (void)Create(w, h, d); - - if ( wxTheBitmapList ) - wxTheBitmapList->AddBitmap(this); } wxBitmap::wxBitmap(void *data, wxBitmapType type, int width, int height, int depth) { (void) Create(data, type, width, height, depth); - - if ( wxTheBitmapList ) - wxTheBitmapList->AddBitmap(this); } wxBitmap::wxBitmap(const wxString& filename, wxBitmapType type) { LoadFile(filename, type); - - if ( wxTheBitmapList ) - wxTheBitmapList->AddBitmap(this); } bool wxBitmap::CreateFromXpm(const char **bits) @@ -474,7 +456,6 @@ bool wxBitmap::CreateFromXpm(const char **bits) wxImage img = decoder.ReadData(bits); wxCHECK_MSG( img.Ok(), FALSE, wxT("invalid bitmap data") ) *this = wxBitmap(img); - if ( wxTheBitmapList ) wxTheBitmapList->AddBitmap(this); return TRUE; } @@ -656,8 +637,6 @@ wxBitmap::wxBitmap(const wxImage& image, int depth) m_refData = new wxBitmapRefData(); - if (wxTheBitmapList) wxTheBitmapList->AddBitmap(this); - // width and height of the device-dependent bitmap int width = image.GetWidth(); int height = image.GetHeight(); diff --git a/src/mac/carbon/bitmap.cpp b/src/mac/carbon/bitmap.cpp index 95bc8f1612..688ce82584 100644 --- a/src/mac/carbon/bitmap.cpp +++ b/src/mac/carbon/bitmap.cpp @@ -367,15 +367,10 @@ bool wxBitmap::CopyFromIcon(const wxIcon& icon) wxBitmap::wxBitmap() { m_refData = NULL; - - if ( wxTheBitmapList ) - wxTheBitmapList->AddBitmap(this); } wxBitmap::~wxBitmap() { - if (wxTheBitmapList) - wxTheBitmapList->DeleteObject(this); } wxBitmap::wxBitmap(const char bits[], int the_width, int the_height, int no_bits) @@ -437,34 +432,21 @@ wxBitmap::wxBitmap(const char bits[], int the_width, int the_height, int no_bits { wxFAIL_MSG(wxT("multicolor BITMAPs not yet implemented")); } - - if ( wxTheBitmapList ) { - wxTheBitmapList->AddBitmap(this); - } } wxBitmap::wxBitmap(int w, int h, int d) { (void)Create(w, h, d); - - if ( wxTheBitmapList ) - wxTheBitmapList->AddBitmap(this); } wxBitmap::wxBitmap(void *data, wxBitmapType type, int width, int height, int depth) { (void) Create(data, type, width, height, depth); - - if ( wxTheBitmapList ) - wxTheBitmapList->AddBitmap(this); } wxBitmap::wxBitmap(const wxString& filename, wxBitmapType type) { LoadFile(filename, type); - - if ( wxTheBitmapList ) - wxTheBitmapList->AddBitmap(this); } bool wxBitmap::CreateFromXpm(const char **bits) @@ -474,7 +456,6 @@ bool wxBitmap::CreateFromXpm(const char **bits) wxImage img = decoder.ReadData(bits); wxCHECK_MSG( img.Ok(), FALSE, wxT("invalid bitmap data") ) *this = wxBitmap(img); - if ( wxTheBitmapList ) wxTheBitmapList->AddBitmap(this); return TRUE; } @@ -656,8 +637,6 @@ wxBitmap::wxBitmap(const wxImage& image, int depth) m_refData = new wxBitmapRefData(); - if (wxTheBitmapList) wxTheBitmapList->AddBitmap(this); - // width and height of the device-dependent bitmap int width = image.GetWidth(); int height = image.GetHeight(); diff --git a/src/mac/carbon/font.cpp b/src/mac/carbon/font.cpp index d425b3cf95..2d3e5f9033 100644 --- a/src/mac/carbon/font.cpp +++ b/src/mac/carbon/font.cpp @@ -121,8 +121,6 @@ void wxFontRefData::MacFindFont() void wxFont::Init() { - if ( wxTheFontList ) - wxTheFontList->Append(this); } bool wxFont::Create(const wxNativeFontInfo& info) @@ -157,8 +155,6 @@ bool wxFont::Create(int pointSize, wxFont::~wxFont() { - if (wxTheFontList) - wxTheFontList->DeleteObject(this); } bool wxFont::RealizeResource() diff --git a/src/mac/font.cpp b/src/mac/font.cpp index d425b3cf95..2d3e5f9033 100644 --- a/src/mac/font.cpp +++ b/src/mac/font.cpp @@ -121,8 +121,6 @@ void wxFontRefData::MacFindFont() void wxFont::Init() { - if ( wxTheFontList ) - wxTheFontList->Append(this); } bool wxFont::Create(const wxNativeFontInfo& info) @@ -157,8 +155,6 @@ bool wxFont::Create(int pointSize, wxFont::~wxFont() { - if (wxTheFontList) - wxTheFontList->DeleteObject(this); } bool wxFont::RealizeResource()