From: Václav Slavík <vslavik@fastmail.fm>
Date: Sat, 3 Sep 2011 13:14:23 +0000 (+0000)
Subject: Slightly more efficient wxDataViewCtrl::StartEditor().
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/2c336e249e8c3dac4390ba0c23a22d5ba35b579b

Slightly more efficient wxDataViewCtrl::StartEditor().

Don't compute item rect until we know for sure that the item actually is
editable.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@68993 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/generic/datavgen.cpp b/src/generic/datavgen.cpp
index 8cd3e24a25..a69ac5b4bc 100644
--- a/src/generic/datavgen.cpp
+++ b/src/generic/datavgen.cpp
@@ -4632,10 +4632,12 @@ void wxDataViewCtrl::StartEditor( const wxDataViewItem & item, unsigned int colu
     if (!col)
         return;
 
-    wxRect itemRect = GetItemRect(item, col);
     wxDataViewRenderer* renderer = col->GetRenderer();
-    if (renderer->GetMode() == wxDATAVIEW_CELL_EDITABLE)
-        renderer->StartEditing(item, itemRect);
+    if (renderer->GetMode() != wxDATAVIEW_CELL_EDITABLE)
+        return;
+
+    const wxRect itemRect = GetItemRect(item, col);
+    renderer->StartEditing(item, itemRect);
 }
 
 #endif // !wxUSE_GENERICDATAVIEWCTRL