From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Mon, 24 Mar 2003 19:54:13 +0000 (+0000)
Subject: don't unselect all radio buttons if there are 2 consecutive radio groups, just those... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/2b17e39106ba94605169908fa029290ec3aba018

don't unselect all radio buttons if there are 2 consecutive radio groups, just those in the second one, when its first button is pressed (bug 705441)


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@19769 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/docs/toback24.txt b/docs/toback24.txt
index dfcf8f04e4..41ac59f0f3 100644
--- a/docs/toback24.txt
+++ b/docs/toback24.txt
@@ -474,3 +474,11 @@ Checking in src/msw/textctrl.cpp;
 /pack/cvsroots/wxwindows/wxWindows/src/msw/textctrl.cpp,v  <--  textctrl.cpp
 new revision: 1.164; previous revision: 1.163
 
+41. Radio button consecutive groups bug
+
+http://sf.net/tracker/index.php?func=detail&aid=705441&group_id=9863&atid=109863
+
+Checking in src/msw/radiobut.cpp;
+/pack/cvsroots/wxwindows/wxWindows/src/msw/radiobut.cpp,v  <--  radiobut.cpp
+new revision: 1.32; previous revision: 1.31
+
diff --git a/src/msw/radiobut.cpp b/src/msw/radiobut.cpp
index 9dd4865998..aee70d4034 100644
--- a/src/msw/radiobut.cpp
+++ b/src/msw/radiobut.cpp
@@ -117,31 +117,35 @@ void wxRadioButton::SetValue(bool value)
         wxWindowList::Node *nodeThis = siblings.Find(this);
         wxCHECK_RET( nodeThis, _T("radio button not a child of its parent?") );
 
-        // turn off all radio buttons before this one
-        for ( wxWindowList::Node *nodeBefore = nodeThis->GetPrevious();
-              nodeBefore;
-              nodeBefore = nodeBefore->GetPrevious() )
+        // if it's not the first item of the group ...
+        if ( !HasFlag(wxRB_GROUP) )
         {
-            wxRadioButton *btn = wxDynamicCast(nodeBefore->GetData(),
-                                               wxRadioButton);
-            if ( !btn )
-            {
-                // the radio buttons in a group must be consecutive, so there
-                // are no more of them
-                break;
-            }
-
-            btn->SetValue(FALSE);
-
-            if ( btn->HasFlag(wxRB_GROUP) )
+            // ... turn off all radio buttons before it
+            for ( wxWindowList::Node *nodeBefore = nodeThis->GetPrevious();
+                  nodeBefore;
+                  nodeBefore = nodeBefore->GetPrevious() )
             {
-                // even if there are other radio buttons before this one,
-                // they're not in the same group with us
-                break;
+                wxRadioButton *btn = wxDynamicCast(nodeBefore->GetData(),
+                                                   wxRadioButton);
+                if ( !btn )
+                {
+                    // the radio buttons in a group must be consecutive, so
+                    // there are no more of them
+                    break;
+                }
+
+                btn->SetValue(FALSE);
+
+                if ( btn->HasFlag(wxRB_GROUP) )
+                {
+                    // even if there are other radio buttons before this one,
+                    // they're not in the same group with us
+                    break;
+                }
             }
         }
 
-        // ... and all after this one
+        // ... and also turn off all buttons after this one
         for ( wxWindowList::Node *nodeAfter = nodeThis->GetNext();
               nodeAfter;
               nodeAfter = nodeAfter->GetNext() )