From: Robin Dunn <robin@alldunn.com>
Date: Sun, 6 Apr 2008 02:13:08 +0000 (+0000)
Subject: Slight reorg of last change
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/247ca48fec9fda5eba6ffa9fbd39053173dc1f7a

Slight reorg of last change

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@53037 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/mac/carbon/databrow.cpp b/src/mac/carbon/databrow.cpp
index 5118740c29..e9fd7f3a81 100644
--- a/src/mac/carbon/databrow.cpp
+++ b/src/mac/carbon/databrow.cpp
@@ -699,26 +699,22 @@ OSStatus wxMacDataViewDataBrowserListViewControl::DataBrowserGetSetItemDataProc(
                // variable definition and initialization:
                 wxVariant modifiedData(true);
 
-                if (dataViewCtrlPtr->GetModel()->SetValue(modifiedData, dvItem, col))
-                {
-                    dataViewCtrlPtr->GetModel()->ValueChanged(dvItem, col);
+                if (dataViewCtrlPtr->GetModel()->SetValue(modifiedData, dvItem, col) &&
+                    dataViewCtrlPtr->GetModel()->ValueChanged(dvItem, col))
                     return noErr;
-                }
                 else
-                    return errDataBrowserNotConfigured;
+                    return errDataBrowserInvalidPropertyData;
               } /* if */
               else if (buttonValue == kThemeButtonOff)
               {
                // variable definition and initialization:
                 wxVariant modifiedData(false);
 
-                if (dataViewCtrlPtr->GetModel()->SetValue(modifiedData, dvItem, col))
-                {
-                    dataViewCtrlPtr->GetModel()->ValueChanged(dvItem, col);
+                if (dataViewCtrlPtr->GetModel()->SetValue(modifiedData, dvItem, col) &&
+                    dataViewCtrlPtr->GetModel()->ValueChanged(dvItem, col))
                     return noErr;
-                }
                 else
-                    return errDataBrowserNotConfigured;
+                    return errDataBrowserInvalidPropertyData;
               } /* if */
               else
                 return errDataBrowserInvalidPropertyData;
@@ -742,13 +738,11 @@ OSStatus wxMacDataViewDataBrowserListViewControl::DataBrowserGetSetItemDataProc(
 #endif
               wxVariant           modifiedData(modifiedString.AsString());
               
-              if (dataViewCtrlPtr->GetModel()->SetValue(modifiedData, dvItem, col))
-              {
-                  dataViewCtrlPtr->GetModel()->ValueChanged(dvItem, col);
-                  return noErr;
-              }
-              else
-                return errDataBrowserNotConfigured;
+                if (dataViewCtrlPtr->GetModel()->SetValue(modifiedData, dvItem, col) &&
+                    dataViewCtrlPtr->GetModel()->ValueChanged(dvItem, col))
+                    return noErr;
+                else
+                    return errDataBrowserInvalidPropertyData;
             } /* if */
             else
               return errorStatus;