From: Michael Wetherell <mike.wetherell@ntlworld.com>
Date: Wed, 6 Apr 2005 08:34:01 +0000 (+0000)
Subject: Add comments explaining the workaround for mingw 3.2.3
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/21bd196564d8483879a57c40ec1eea64114f9bd4

Add comments explaining the workaround for mingw 3.2.3


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@33379 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/debugrpt.cpp b/src/common/debugrpt.cpp
index eaa1ea0d04..bec6676423 100644
--- a/src/common/debugrpt.cpp
+++ b/src/common/debugrpt.cpp
@@ -549,6 +549,7 @@ bool wxDebugReport::DoProcess()
 
 #if wxUSE_ZIPSTREAM
 
+// leave the default name wxZipOutputStreamPtr free for users
 wxDECLARE_SCOPED_PTR(wxZipOutputStream, wxDbgZipOutputStreamPtr)
 wxDEFINE_SCOPED_PTR(wxZipOutputStream, wxDbgZipOutputStreamPtr)
 
@@ -565,6 +566,10 @@ bool wxDebugReportCompress::DoProcess()
     // create the streams
     wxFileName fn(GetDirectory(), GetReportName(), _T("zip"));
     wxFFileOutputStream os(fn.GetFullPath(), _T("wb"));
+
+    // create this one on the heap as a workaround since otherwise the mingw
+    // 3.2.3 linker cannot find ~wxZipOutputStream() when building a dll
+    // version of the library.
     wxDbgZipOutputStreamPtr zos(new wxZipOutputStream(os, 9));
 
     // add all files to the ZIP one