From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Mon, 27 Nov 2006 15:02:32 +0000 (+0000)
Subject: fixed missing initialization of line variable in InitFrames() (coverity id 213)
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/1d2c115e44e0d74bcda27b1bfe6a7d28d2541489?ds=sidebyside

fixed missing initialization of line variable in InitFrames() (coverity id 213)


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@43683 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/unix/stackwalk.cpp b/src/unix/stackwalk.cpp
index 6b8b6051c1..34c812366d 100644
--- a/src/unix/stackwalk.cpp
+++ b/src/unix/stackwalk.cpp
@@ -239,8 +239,9 @@ int wxStackWalker::InitFrames(wxStackFrame *arr, size_t n, void **addresses, cha
     // parse addr2line output (should be exactly 2 lines for each address)
     // reusing the g_buf used for building the command line above
     wxString name, filename;
-    unsigned long line, curr=0;
-    for (size_t i=0; i<n; i++)
+    unsigned long line = 0,
+                  curr = 0;
+    for  ( size_t i = 0; i < n; i++ )
     {
         // 1st line has function name
         if ( fgets(g_buf, WXSIZEOF(g_buf), fp) )
@@ -266,10 +267,9 @@ int wxStackWalker::InitFrames(wxStackFrame *arr, size_t n, void **addresses, cha
             const size_t posColon = filename.find(_T(':'));
             if ( posColon != wxString::npos )
             {
-                // parse line number
-                if ( !wxString(filename, posColon + 1, wxString::npos).
-                        ToULong(&line) )
-                    line = 0;
+                // parse line number (it's ok if it fails, this will just leave
+                // line at its current, invalid, 0 value)
+                wxString(filename, posColon + 1, wxString::npos).ToULong(&line);
 
                 // remove line number from 'filename'
                 filename.erase(posColon);