From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Wed, 29 Feb 2012 13:58:55 +0000 (+0000)
Subject: Initialize m_isShown correctly in wxGenericDragImage::BeginDrag().
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/14aed066ad1a572673a1b9603725c60cc108c009

Initialize m_isShown correctly in wxGenericDragImage::BeginDrag().

The code initialized m_isDirty twice which was clearly wrong. The original
intention was probably to set both m_isDirty and m_isShown to false.

Thanks to PVS-Studio for finding this bug.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@70749 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/generic/dragimgg.cpp b/src/generic/dragimgg.cpp
index 6e3fbad8be..99286fbd28 100644
--- a/src/generic/dragimgg.cpp
+++ b/src/generic/dragimgg.cpp
@@ -247,7 +247,7 @@ bool wxGenericDragImage::BeginDrag(const wxPoint& hotspot,
         m_boundingRect = * rect;
 
     m_isDirty = false;
-    m_isDirty = false;
+    m_isShown = false;
 
     if (m_cursor.IsOk())
     {