From: Julian Smart <julian@anthemion.co.uk>
Date: Wed, 29 Aug 2001 11:24:50 +0000 (+0000)
Subject: Removed wxLogSysError call in wxHandleProcessTermination, and ensured
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/09d68ec1c35deb4fe3bd5b3ad61d7adcbd260bb3?ds=inline;hp=e126b44d229ae637922a0532c3d11222b024c4a9

Removed wxLogSysError call in wxHandleProcessTermination, and ensured
the cleanup always happens. I hope this is right... but if processes
are killed elsewhere, we don't want this function to generate an error
and not do the correct cleanup.


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@11510 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/unix/utilsunx.cpp b/src/unix/utilsunx.cpp
index 3bd19ffbf6..9118bcb7b1 100644
--- a/src/unix/utilsunx.cpp
+++ b/src/unix/utilsunx.cpp
@@ -301,14 +301,19 @@ void wxHandleProcessTermination(wxEndProcessData *proc_data)
 
     if( rc == -1 || ! (WIFEXITED(status) || WIFSIGNALED(status)) )
     {
-       wxLogSysError(_("Waiting for subprocess termination failed"));
+       // wxLogSysError(_("Waiting for subprocess termination failed"));
        /* AFAIK, this can only happen if something went wrong within
           wxGTK, i.e. due to a race condition or some serious bug.
           After having fixed the order of statements in
           GTK_EndProcessDetector(). (KB)
+
+          JACS adds -- I have other code that kills a process recursively
+          and calls waitpid; so this function then generates an error.
+          I've commented out the wxLogSysError and the 'else' so that
+          termination is always done properly.
        */
     }
-    else
+    // else
     {
         // notify user about termination if required
         if (proc_data->process)