From: Vadim Zeitlin Date: Thu, 5 Apr 2007 15:00:24 +0000 (+0000) Subject: changed wxLongLongNative(hi, lo) ctor to take wxInt32, not long, as it was completely... X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/05059b3a489671d24a06396a8fb2d5f96f8ecb94 changed wxLongLongNative(hi, lo) ctor to take wxInt32, not long, as it was completely broken on LP64 architectures otherwise git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@45256 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- diff --git a/include/wx/longlong.h b/include/wx/longlong.h index b6cc42b479..5eff9cd900 100644 --- a/include/wx/longlong.h +++ b/include/wx/longlong.h @@ -113,9 +113,9 @@ public: // from long long wxLongLongNative(wxLongLong_t ll) : m_ll(ll) { } // from 2 longs - wxLongLongNative(long hi, unsigned long lo) : m_ll(0) + wxLongLongNative(wxInt32 hi, wxUint32 lo) { - // assign first to avoid precision loss! + // cast to wxLongLong_t first to avoid precision loss! m_ll = ((wxLongLong_t) hi) << 32; m_ll |= (wxLongLong_t) lo; } @@ -160,11 +160,11 @@ public: // accessors // get high part - long GetHi() const - { return wx_truncate_cast(long, m_ll >> 32); } + wxInt32 GetHi() const + { return wx_truncate_cast(wxInt32, m_ll >> 32); } // get low part - unsigned long GetLo() const - { return wx_truncate_cast(unsigned long, m_ll); } + wxUint32 GetLo() const + { return wx_truncate_cast(wxUint32, m_ll); } // get absolute value wxLongLongNative Abs() const { return wxLongLongNative(*this).Abs(); } @@ -350,9 +350,9 @@ public: // from long long wxULongLongNative(wxULongLong_t ll) : m_ll(ll) { } // from 2 longs - wxULongLongNative(unsigned long hi, unsigned long lo) : m_ll(0) + wxULongLongNative(wxUint32 hi, wxUint32 lo) : m_ll(0) { - // assign first to avoid precision loss! + // cast to wxLongLong_t first to avoid precision loss! m_ll = ((wxULongLong_t) hi) << 32; m_ll |= (wxULongLong_t) lo; } @@ -392,11 +392,11 @@ public: // accessors // get high part - unsigned long GetHi() const - { return wx_truncate_cast(unsigned long, m_ll >> 32); } + wxUint32 GetHi() const + { return wx_truncate_cast(wxUint32, m_ll >> 32); } // get low part - unsigned long GetLo() const - { return wx_truncate_cast(unsigned long, m_ll); } + wxUint32 GetLo() const + { return wx_truncate_cast(wxUint32, m_ll); } // convert to native ulong long wxULongLong_t GetValue() const { return m_ll; }