From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Thu, 2 May 2013 22:08:19 +0000 (+0000)
Subject: Mention using wxString::c_str() with vararg functions in the change log.
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/0492f62e0bee1c391a4557f5af84b838430902a0

Mention using wxString::c_str() with vararg functions in the change log.

This is sufficiently important to be mentioned here in addition to the main
documentation. Especially considering that this results in run-time crashes
instead of (just) compile-time errors with MSVC.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73906 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/docs/changes.txt b/docs/changes.txt
index 193a1fb0e5..916824f6d7 100644
--- a/docs/changes.txt
+++ b/docs/changes.txt
@@ -87,6 +87,19 @@ The "stc" and "svg" contribs instead have been moved respectively into a new
 Changes in behaviour not resulting in compilation errors, please read this!
 ---------------------------------------------------------------------------
 
+- Don't pass wxString::c_str() to vararg functions any more! Due to Unicode
+  changes, c_str() now returns an object and not a simple char pointer, so
+  using it with vararg functions does not work any more. The preferred
+  solution is to use wx-provided equivalents, e.g. wxPrintf() instead of
+  printf() which has the added benefit that you don't need to call c_str()
+  any more and can pass wxString objects directly. If this is impossible,
+  add explicit casts to "const char*" or "const wchar_t*". See wxString
+  documentation for more details.
+
+  Notice that using wxString::c_str() with vararg functions does result in
+  compilation errors with g++ and most other compilers but not MSVC. Try to
+  build your code with g++ to detect all such problems at compile-time.
+
 - Default location of wxFileConfig files has changed under Windows, you will
   need to update your code if you access these files directly.