wxCHECK/wxCHECK_RET changes

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@132 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

diff --git a/include/wx/dynarray.h b/include/wx/dynarray.h
index c7d94ac6d4744460bbc7cd8884786f4e909d7e11..a73954ae7365bb0ed9d9b170246668673af474d7 100644 (file)
--- a/include/wx/dynarray.h
+++ b/include/wx/dynarray.h
@@ -184,7 +184,8 @@ public:                                                             \
   void Remove(uint uiIndex) { wxBaseArray::Remove(uiIndex); }       \
   void Remove(T Item)                                               \
     { int iIndex = Index(Item);                                     \
-      wxCHECK( iIndex != NOT_FOUND );                               \
+      wxCHECK2_MSG( iIndex != NOT_FOUND, return,                    \
+        "removing inexisting element in wxArray::Remove" );         \
       wxBaseArray::Remove((uint)iIndex); }                          \
                                                                     \
   void Sort(CMPFUNC##T fCmp) { wxBaseArray::Sort((CMPFUNC)fCmp); }  \

diff --git a/src/common/dynarray.cpp b/src/common/dynarray.cpp
index eb67d34504bf1846d33f7075d20a9e9691325fe0..ee700fbb0c1cb7863c552faa3dff21d1e1ba5e26 100644 (file)
--- a/src/common/dynarray.cpp
+++ b/src/common/dynarray.cpp
@@ -179,7 +179,7 @@ void wxBaseArray::Add(long lItem)
 // add item at the given position
 void wxBaseArray::Insert(long lItem, uint uiIndex)
 {
-  wxCHECK( uiIndex <= m_uiCount );
+  wxCHECK_RET( uiIndex <= m_uiCount, "bad index in wxArray::Insert" );
 
   Grow();
 
@@ -192,7 +192,7 @@ void wxBaseArray::Insert(long lItem, uint uiIndex)
 // removes item from array (by index)
 void wxBaseArray::Remove(uint uiIndex)
 {
-  wxCHECK( uiIndex <= m_uiCount );
+  wxCHECK_RET( uiIndex <= m_uiCount, "bad index in wxArray::Remove" );
 
   memmove(&m_pItems[uiIndex], &m_pItems[uiIndex + 1], 
           (m_uiCount - uiIndex - 1)*sizeof(long));
@@ -204,7 +204,8 @@ void wxBaseArray::Remove(long lItem)
 {
   int iIndex = Index(lItem);
 
-  wxCHECK( iIndex != NOT_FOUND );
+  wxCHECK_RET( iIndex != NOT_FOUND, 
+               "removing inexistent item in wxArray::Remove" );
 
   Remove((uint)iIndex);
 }

diff --git a/src/common/file.cpp b/src/common/file.cpp
index 9f2093cccdebd550416dd1d8185d69e3e3529446..e6a8a9c8787b68d572206aaa71ca476c38c3232d 100644 (file)
--- a/src/common/file.cpp
+++ b/src/common/file.cpp
@@ -190,7 +190,7 @@ bool wxFile::Close()
 // read
 off_t wxFile::Read(void *pBuf, off_t nCount)
 {
-  wxCHECK_RET( (pBuf != NULL) && IsOpened(), 0 );
+  wxCHECK( (pBuf != NULL) && IsOpened(), 0 );
 
   int iRc = ::read(m_fd, pBuf, nCount);
   if ( iRc == -1 ) {
@@ -204,7 +204,7 @@ off_t wxFile::Read(void *pBuf, off_t nCount)
 // write
 bool wxFile::Write(const void *pBuf, uint nCount)
 {
-  wxCHECK_RET( (pBuf != NULL) && IsOpened(), 0 );
+  wxCHECK( (pBuf != NULL) && IsOpened(), 0 );
 
   int iRc = ::write(m_fd, pBuf, nCount);
   if ( iRc == -1 ) {

diff --git a/src/common/filefn.cpp b/src/common/filefn.cpp
index a85dae4c696530243e2345c6a921e733b30b4435..b47d856e660a21447b6fbb2a81ab9ef7540d25e7 100644 (file)
--- a/src/common/filefn.cpp
+++ b/src/common/filefn.cpp
@@ -1066,7 +1066,7 @@ static struct _find_t wxFileStruc;
 static wxString wxFileSpec = "";
 static int wxFindFileFlags;
 
-char *wxFindFirstFile(const wxString& spec, int flags)
+char *wxFindFirstFile(const char *spec, int flags)
 {
   wxFileSpec = spec;
   wxFindFileFlags = flags; /* MATTHEW: [5] Remember flags */
@@ -1284,7 +1284,8 @@ bool wxEndsWithPathSeparator(const char *pszFileName)
 bool wxFindFileInPath(wxString *pStr, const char *pszPath, const char *pszFile)
 {
   // we assume that it's not empty
-  wxCHECK_RET( Strlen(pszFile) != 0, FALSE);
+  wxCHECK_MSG( !IsEmpty(pszFile), FALSE, 
+               "empty file name in wxFindFileInPath");
 
   // skip path separator in the beginning of the file name if present
   if ( wxIsPathSeparator(*pszFile) )

diff --git a/src/msw/frame.cpp b/src/msw/frame.cpp
index 55889420fa607c53496d7ac5432b13c3b2fba286..ce0c0b0edf81a7d0c3763be09c067d1d1d54adc4 100644 (file)
--- a/src/msw/frame.cpp
+++ b/src/msw/frame.cpp
@@ -381,7 +381,8 @@ wxStatusBar *wxFrame::OnCreateStatusBar(const int number)
 bool wxFrame::CreateStatusBar(const int number)
 {
   // VZ: calling CreateStatusBar twice is an error - why anyone would do it?
-  wxCHECK_RET( m_frameStatusBar == NULL, FALSE );
+  wxCHECK_MSG( m_frameStatusBar == NULL, FALSE, 
+               "recreating status bar in wxFrame" );
 
   m_frameStatusBar = OnCreateStatusBar(number);
   if ( m_frameStatusBar )
@@ -395,14 +396,14 @@ bool wxFrame::CreateStatusBar(const int number)
 
 void wxFrame::SetStatusText(const wxString& text, const int number)
 {
-  wxCHECK( m_frameStatusBar != NULL );
+  wxCHECK_RET( m_frameStatusBar != NULL, "no statusbar to set text for" );
 
   m_frameStatusBar->SetStatusText(text, number);
 }
 
 void wxFrame::SetStatusWidths(const int n, const int *widths_field)
 {
-  wxCHECK( m_frameStatusBar != NULL );
+  wxCHECK_RET( m_frameStatusBar != NULL, "no statusbar to set widths for" );
 
   m_frameStatusBar->SetStatusWidths(n, widths_field);
   PositionStatusBar();

diff --git a/src/msw/menu.cpp b/src/msw/menu.cpp
index 1004cd16e88b54914b3ed19aba29e14b3a365dff..d3dcc650444d8a374361ac4861decbc5c587099f 100644 (file)
--- a/src/msw/menu.cpp
+++ b/src/msw/menu.cpp
@@ -139,7 +139,7 @@ void wxMenu::Break(void)
 // function appends a new item or submenu to the menu
 void wxMenu::Append(wxMenuItem *pItem)
 {
-  wxCHECK( pItem != NULL );
+  wxCHECK_RET( pItem != NULL, "can't append NULL item to the menu" );
 
   m_menuItems.Append(pItem);
 
@@ -269,7 +269,7 @@ void wxMenu::Delete(int id)
 void wxMenu::Enable(int Id, bool Flag)
 {
   wxMenuItem *item = FindItemForId(Id);
-  wxCHECK( item != NULL );
+  wxCHECK_RET( item != NULL, "can't enable non-existing menu item" );
 
   item->Enable(Flag);
 }
@@ -277,7 +277,7 @@ void wxMenu::Enable(int Id, bool Flag)
 bool wxMenu::Enabled(int Id) const
 {
   wxMenuItem *item = FindItemForId(Id);
-  wxCHECK_RET( item != NULL, FALSE );
+  wxCHECK( item != NULL, FALSE );
 
   return item->IsEnabled();
 }
@@ -285,7 +285,7 @@ bool wxMenu::Enabled(int Id) const
 void wxMenu::Check(int Id, bool Flag)
 {
   wxMenuItem *item = FindItemForId(Id);
-  wxCHECK( item != NULL );
+  wxCHECK_RET( item != NULL, "can't get status of non-existing menu item" );
 
   item->Check(Flag);
 }
@@ -293,7 +293,7 @@ void wxMenu::Check(int Id, bool Flag)
 bool wxMenu::Checked(int Id) const
 {
   wxMenuItem *item = FindItemForId(Id);
-  wxCHECK_RET( item != NULL, FALSE );
+  wxCHECK( item != NULL, FALSE );
 
   return item->IsChecked();
 }

diff --git a/src/msw/menuitem.cpp b/src/msw/menuitem.cpp
index 8d7d27379b32423dbca876932851f8f5e0d658d9..3cde92823209a29f6352c2d65bbd1d6fbbb1ec02 100644 (file)
--- a/src/msw/menuitem.cpp
+++ b/src/msw/menuitem.cpp
@@ -134,7 +134,7 @@ void wxMenuItem::Enable(bool bDoEnable)
 
 void wxMenuItem::Check(bool bDoCheck)
 {
-  wxCHECK ( IsCheckable() );
+  wxCHECK_RET( IsCheckable(), "only checkable items may be checked" );
 
   if ( m_bChecked != bDoCheck ) {
     CheckMenuItem((HMENU)m_pParentMenu->GetHMenu(), m_idItem, 

diff --git a/src/msw/registry.cpp b/src/msw/registry.cpp
index ffd1e6fa2dd208bc6d1d5c5ff2e8cf5e74f7398a..713ca417c3f942e9ae116d1255a7711390ef14b3 100644 (file)
--- a/src/msw/registry.cpp
+++ b/src/msw/registry.cpp
@@ -122,7 +122,7 @@ const size_t wxRegKey::nStdKeys = WXSIZEOF(aStdKeys);
 const char *wxRegKey::GetStdKeyName(uint key)
 {
   // return empty string if key is invalid
-  wxCHECK_RET( key < nStdKeys, "" );
+  wxCHECK_MSG( key < nStdKeys, "", "invalid key in wxRegKey::GetStdKeyName" );
 
   return aStdKeys[key].szName;
 }
@@ -130,7 +130,7 @@ const char *wxRegKey::GetStdKeyName(uint key)
 const char *wxRegKey::GetStdKeyShortName(uint key)
 {
   // return empty string if key is invalid
-  wxCHECK_RET( key < nStdKeys, "" );
+  wxCHECK( key < nStdKeys, "" );
 
   return aStdKeys[key].szShortName;
 }