X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/fde87a82768ea971a9832e39d87137100e382422..404b319a85dadd7decf7a5a5331020520031a41c:/src/msw/gdiimage.cpp diff --git a/src/msw/gdiimage.cpp b/src/msw/gdiimage.cpp index e7aaa0c36f..d19d26afd9 100644 --- a/src/msw/gdiimage.cpp +++ b/src/msw/gdiimage.cpp @@ -39,6 +39,18 @@ #include "wx/msw/dib.h" #endif +// By default, use PNG resource handler if we can, i.e. have support for +// loading PNG images in the library. This symbol could be predefined as 0 to +// avoid doing this if anybody ever needs to do it for some reason. +#if !defined(wxUSE_PNG_RESOURCE_HANDLER) && wxUSE_LIBPNG && wxUSE_IMAGE + #define wxUSE_PNG_RESOURCE_HANDLER 1 +#endif + +#if wxUSE_PNG_RESOURCE_HANDLER + #include "wx/image.h" + #include "wx/utils.h" // For wxLoadUserResource() +#endif + #ifdef __WXWINCE__ #include #include @@ -61,7 +73,7 @@ WX_DEFINE_LIST(wxGDIImageHandlerList) class WXDLLEXPORT wxBMPFileHandler : public wxBitmapHandler { public: - wxBMPFileHandler() : wxBitmapHandler(_T("Windows bitmap file"), _T("bmp"), + wxBMPFileHandler() : wxBitmapHandler(wxT("Windows bitmap file"), wxT("bmp"), wxBITMAP_TYPE_BMP) { } @@ -80,7 +92,7 @@ private: class WXDLLEXPORT wxBMPResourceHandler: public wxBitmapHandler { public: - wxBMPResourceHandler() : wxBitmapHandler(_T("Windows bitmap resource"), + wxBMPResourceHandler() : wxBitmapHandler(wxT("Windows bitmap resource"), wxEmptyString, wxBITMAP_TYPE_BMP_RESOURCE) { @@ -126,7 +138,7 @@ public: int desiredWidth, int desiredHeight) { wxIcon *icon = wxDynamicCast(image, wxIcon); - wxCHECK_MSG( icon, false, _T("wxIconHandler only works with icons") ); + wxCHECK_MSG( icon, false, wxT("wxIconHandler only works with icons") ); return LoadIcon(icon, name, flags, desiredWidth, desiredHeight); } @@ -140,8 +152,8 @@ protected: class WXDLLEXPORT wxICOFileHandler : public wxIconHandler { public: - wxICOFileHandler() : wxIconHandler(_T("ICO icon file"), - _T("ico"), + wxICOFileHandler() : wxIconHandler(wxT("ICO icon file"), + wxT("ico"), wxBITMAP_TYPE_ICO) { } @@ -158,8 +170,8 @@ private: class WXDLLEXPORT wxICOResourceHandler: public wxIconHandler { public: - wxICOResourceHandler() : wxIconHandler(_T("ICO resource"), - _T("ico"), + wxICOResourceHandler() : wxIconHandler(wxT("ICO resource"), + wxT("ico"), wxBITMAP_TYPE_ICO_RESOURCE) { } @@ -173,6 +185,27 @@ private: DECLARE_DYNAMIC_CLASS(wxICOResourceHandler) }; +#if wxUSE_PNG_RESOURCE_HANDLER + +class WXDLLEXPORT wxPNGResourceHandler : public wxBitmapHandler +{ +public: + wxPNGResourceHandler() : wxBitmapHandler(wxS("Windows PNG resource"), + wxString(), + wxBITMAP_TYPE_PNG_RESOURCE) + { + } + + virtual bool LoadFile(wxBitmap *bitmap, + const wxString& name, wxBitmapType flags, + int desiredWidth, int desiredHeight); + +private: + wxDECLARE_DYNAMIC_CLASS(wxPNGResourceHandler); +}; + +#endif // wxUSE_PNG_RESOURCE_HANDLER + // ---------------------------------------------------------------------------- // wxWin macros // ---------------------------------------------------------------------------- @@ -181,6 +214,9 @@ IMPLEMENT_DYNAMIC_CLASS(wxBMPFileHandler, wxBitmapHandler) IMPLEMENT_DYNAMIC_CLASS(wxBMPResourceHandler, wxBitmapHandler) IMPLEMENT_DYNAMIC_CLASS(wxICOFileHandler, wxObject) IMPLEMENT_DYNAMIC_CLASS(wxICOResourceHandler, wxObject) +#if wxUSE_PNG_RESOURCE_HANDLER +IMPLEMENT_DYNAMIC_CLASS(wxPNGResourceHandler, wxBitmapHandler) +#endif // wxUSE_PNG_RESOURCE_HANDLER // ---------------------------------------------------------------------------- // private functions @@ -306,8 +342,11 @@ void wxGDIImage::InitStandardHandlers() #ifndef __WXMICROWIN__ AddHandler(new wxBMPResourceHandler); AddHandler(new wxBMPFileHandler); - AddHandler(new wxICOResourceHandler); AddHandler(new wxICOFileHandler); + AddHandler(new wxICOResourceHandler); +#if wxUSE_PNG_RESOURCE_HANDLER + AddHandler(new wxPNGResourceHandler); +#endif // wxUSE_PNG_RESOURCE_HANDLER #endif } @@ -323,9 +362,9 @@ bool wxBMPResourceHandler::LoadFile(wxBitmap *bitmap, int WXUNUSED(desiredHeight)) { // TODO: load colourmap. - bitmap->SetHBITMAP((WXHBITMAP)::LoadBitmap(wxGetInstance(), name.wx_str())); + bitmap->SetHBITMAP((WXHBITMAP)::LoadBitmap(wxGetInstance(), name.t_str())); - if ( !bitmap->Ok() ) + if ( !bitmap->IsOk() ) { // it's probably not found wxLogError(wxT("Can't load bitmap '%s' from resources! Check .rc file."), @@ -356,7 +395,7 @@ bool wxBMPFileHandler::LoadFile(wxBitmap *bitmap, int WXUNUSED(desiredHeight)) { #if wxUSE_WXDIB - wxCHECK_MSG( bitmap, false, _T("NULL bitmap in LoadFile") ); + wxCHECK_MSG( bitmap, false, wxT("NULL bitmap in LoadFile") ); wxDIB dib(name); @@ -372,7 +411,7 @@ bool wxBMPFileHandler::SaveFile(const wxBitmap *bitmap, const wxPalette * WXUNUSED(pal)) const { #if wxUSE_WXDIB - wxCHECK_MSG( bitmap, false, _T("NULL bitmap in SaveFile") ); + wxCHECK_MSG( bitmap, false, wxT("NULL bitmap in SaveFile") ); wxDIB dib(*bitmap); @@ -393,9 +432,6 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, { icon->UnRef(); - // actual size - wxSize size; - HICON hicon = NULL; // Parse the filename: it may be of the form "filename;n" in order to @@ -438,12 +474,12 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, desiredHeight == ::GetSystemMetrics(SM_CYICON) ) { // get the specified large icon from file - if ( !::ExtractIconEx(nameReal.wx_str(), iconIndex, &hicon, NULL, 1) ) + if ( !::ExtractIconEx(nameReal.t_str(), iconIndex, &hicon, NULL, 1) ) { // it is not an error, but it might still be useful to be informed // about it optionally - wxLogTrace(_T("iconload"), - _T("No large icons found in the file '%s'."), + wxLogTrace(wxT("iconload"), + wxT("No large icons found in the file '%s'."), name.c_str()); } } @@ -451,10 +487,10 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, desiredHeight == ::GetSystemMetrics(SM_CYSMICON) ) { // get the specified small icon from file - if ( !::ExtractIconEx(nameReal.wx_str(), iconIndex, NULL, &hicon, 1) ) + if ( !::ExtractIconEx(nameReal.t_str(), iconIndex, NULL, &hicon, 1) ) { - wxLogTrace(_T("iconload"), - _T("No small icons found in the file '%s'."), + wxLogTrace(wxT("iconload"), + wxT("No small icons found in the file '%s'."), name.c_str()); } } @@ -464,37 +500,35 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, if ( !hicon ) { // take any size icon from the file by index - hicon = ::ExtractIcon(wxGetInstance(), nameReal.wx_str(), iconIndex); + hicon = ::ExtractIcon(wxGetInstance(), nameReal.t_str(), iconIndex); } #endif if ( !hicon ) { - wxLogSysError(_T("Failed to load icon from the file '%s'"), + wxLogSysError(wxT("Failed to load icon from the file '%s'"), name.c_str()); return false; } - size = wxGetHiconSize(hicon); + if ( !icon->CreateFromHICON(hicon) ) + return false; - if ( (desiredWidth != -1 && desiredWidth != size.x) || - (desiredHeight != -1 && desiredHeight != size.y) ) + if ( (desiredWidth != -1 && desiredWidth != icon->GetWidth()) || + (desiredHeight != -1 && desiredHeight != icon->GetHeight()) ) { - wxLogTrace(_T("iconload"), - _T("Returning false from wxICOFileHandler::Load because of the size mismatch: actual (%d, %d), requested (%d, %d)"), - size.x, size.y, + wxLogTrace(wxT("iconload"), + wxT("Returning false from wxICOFileHandler::Load because of the size mismatch: actual (%d, %d), requested (%d, %d)"), + icon->GetWidth(), icon->GetHeight(), desiredWidth, desiredHeight); - ::DestroyIcon(hicon); + icon->UnRef(); return false; } - icon->SetHICON((WXHICON)hicon); - icon->SetSize(size.x, size.y); - - return icon->Ok(); + return true; } bool wxICOResourceHandler::LoadIcon(wxIcon *icon, @@ -508,7 +542,7 @@ bool wxICOResourceHandler::LoadIcon(wxIcon *icon, bool hasSize = desiredWidth != -1 || desiredHeight != -1; wxASSERT_MSG( !hasSize || (desiredWidth != -1 && desiredHeight != -1), - _T("width and height should be either both -1 or not") ); + wxT("width and height should be either both -1 or not") ); // try to load the icon from this program first to allow overriding the // standard icons (although why one would want to do it considering that @@ -518,13 +552,13 @@ bool wxICOResourceHandler::LoadIcon(wxIcon *icon, // some icon rescaling internally which results in very ugly 16x16 icons if ( hasSize ) { - hicon = (HICON)::LoadImage(wxGetInstance(), name.wx_str(), IMAGE_ICON, + hicon = (HICON)::LoadImage(wxGetInstance(), name.t_str(), IMAGE_ICON, desiredWidth, desiredHeight, LR_DEFAULTCOLOR); } else { - hicon = ::LoadIcon(wxGetInstance(), name.wx_str()); + hicon = ::LoadIcon(wxGetInstance(), name.t_str()); } // next check if it's not a standard icon @@ -554,14 +588,58 @@ bool wxICOResourceHandler::LoadIcon(wxIcon *icon, } #endif - wxSize size = wxGetHiconSize(hicon); - icon->SetSize(size.x, size.y); + return icon->CreateFromHICON((WXHICON)hicon); +} + +#if wxUSE_PNG_RESOURCE_HANDLER - icon->SetHICON((WXHICON)hicon); +// ---------------------------------------------------------------------------- +// PNG handler +// ---------------------------------------------------------------------------- - return icon->Ok(); +bool wxPNGResourceHandler::LoadFile(wxBitmap *bitmap, + const wxString& name, + wxBitmapType WXUNUSED(flags), + int WXUNUSED(desiredWidth), + int WXUNUSED(desiredHeight)) +{ + const void* pngData = NULL; + size_t pngSize = 0; + + // Currently we hardcode RCDATA resource type as this is what is usually + // used for the embedded images. We could allow specifying the type as part + // of the name in the future (e.g. "type:name" or something like this) if + // really needed. + if ( !wxLoadUserResource(&pngData, &pngSize, + name, + RT_RCDATA, + wxGetInstance()) ) + { + // Notice that this message is not translated because only the + // programmer (and not the end user) can make any use of it. + wxLogError(wxS("Bitmap in PNG format \"%s\" not found, check ") + wxS("that the resource file contains \"RCDATA\" ") + wxS("resource with this name."), + name); + + return false; + } + + *bitmap = wxBitmap::NewFromPNGData(pngData, pngSize); + if ( !bitmap->IsOk() ) + { + wxLogError(wxS("Couldn't load resource bitmap \"%s\" as a PNG. "), + wxS("Have you registered PNG image handler?"), + name); + + return false; + } + + return true; } +#endif // wxUSE_PNG_RESOURCE_HANDLER + // ---------------------------------------------------------------------------- // private functions // ----------------------------------------------------------------------------