X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/fd3a4cb92d936976027b884fcd9db5b75fb4b8c7..ff534ba469473a9ace193e736ca131144df307f9:/src/common/string.cpp?ds=sidebyside diff --git a/src/common/string.cpp b/src/common/string.cpp index 6cfea4102c..3dea38ec67 100644 --- a/src/common/string.cpp +++ b/src/common/string.cpp @@ -41,9 +41,9 @@ #include "wx/vector.h" #include "wx/xlocale.h" -#ifdef __WXMSW__ +#ifdef __WINDOWS__ #include "wx/msw/wrapwin.h" -#endif // __WXMSW__ +#endif // __WINDOWS__ #if wxUSE_STD_IOSTREAM #include @@ -1169,12 +1169,6 @@ int wxString::CmpNoCase(const wxString& s) const #if wxUSE_UNICODE -#ifdef __MWERKS__ -#ifndef __SCHAR_MAX__ -#define __SCHAR_MAX__ 127 -#endif -#endif - wxString wxString::FromAscii(const char *ascii, size_t len) { if (!ascii || len == 0) @@ -1442,7 +1436,7 @@ size_t wxString::Replace(const wxString& strOld, } else if ( !bReplaceAll) { - size_t pos = m_impl.find(strOld, 0); + size_t pos = m_impl.find(strOld.m_impl, 0); if ( pos != npos ) { m_impl.replace(pos, strOld.m_impl.length(), strNew.m_impl); @@ -2008,16 +2002,16 @@ int wxString::DoPrintfUtf8(const char *format, ...) Since EILSEQ and EINVAL are rather common but EOVERFLOW is not and since EILSEQ and EINVAL are specifically defined to mean the error is other than an undersized buffer and no other errno are defined we treat those two - as meaning hard errors and everything else gets the old behavior which + as meaning hard errors and everything else gets the old behaviour which is to keep looping and increasing buffer size until the function succeeds. - In practice it's impossible to determine before compilation which behavior - may be used. The vswprintf function may have vsnprintf-like behavior or - vice-versa. Behavior detected on one release can theoretically change + In practice it's impossible to determine before compilation which behaviour + may be used. The vswprintf function may have vsnprintf-like behaviour or + vice-versa. Behaviour detected on one release can theoretically change with an updated release. Not to mention that configure testing for it would require the test to be run on the host system, not the build system which makes cross compilation difficult. Therefore, we make no assumptions - about behavior and try our best to handle every known case, including the + about behaviour and try our best to handle every known case, including the case where wxVsnprintf returns a negative number and fails to set errno. There is yet one more non-standard implementation and that is our own. @@ -2028,9 +2022,9 @@ int wxString::DoPrintfUtf8(const char *format, ...) at the given buffer size minus 1. It is supposed to do this even if it turns out that the buffer is sized too small. - Darwin (tested on 10.5) follows the C99 behavior exactly. + Darwin (tested on 10.5) follows the C99 behaviour exactly. - Glibc 2.6 almost follows the C99 behavior except vswprintf never sets + Glibc 2.6 almost follows the C99 behaviour except vswprintf never sets errno even when it fails. However, it only seems to ever fail due to an undersized buffer. */