X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/eea9eca563844f84f92c738b1d2fd01fe9d472fc..b404a8f3b072129c107c6d9a5e0f6f53cd34807b:/src/common/unichar.cpp

diff --git a/src/common/unichar.cpp b/src/common/unichar.cpp
index d75555acd9..645435641f 100644
--- a/src/common/unichar.cpp
+++ b/src/common/unichar.cpp
@@ -44,36 +44,45 @@ wxUniChar::value_type wxUniChar::FromHi8bit(char c)
 
     return wxT('?'); // FIXME-UTF8: what to use as failure character?
 #else
-    wchar_t buf[2];
-    if ( wxConvLibc.ToWChar(buf, 2, &c, 1) != 2 )
+    char cbuf[2];
+    cbuf[0] = c;
+    cbuf[1] = '\0';
+    wchar_t wbuf[2];
+    if ( wxConvLibc.ToWChar(wbuf, 2, cbuf, 2) != 2 )
     {
         wxFAIL_MSG( "invalid multibyte character" );
         return wxT('?'); // FIXME-UTF8: what to use as failure character?
     }
-    return buf[0];
+    return wbuf[0];
 #endif
 }
 
 /* static */
-char wxUniChar::ToHi8bit(wxUniChar::value_type c)
+char wxUniChar::ToHi8bit(wxUniChar::value_type v)
 {
-#if wxUSE_UTF8_LOCALE_ONLY
-    wxFAIL_MSG( "character cannot be converted to single UTF-8 byte" );
-    wxUnusedVar(c);
-
-    return '?'; // FIXME-UTF8: what to use as failure character?
-#else
-    wchar_t in = c;
-    char buf[2];
-    if ( wxConvLibc.FromWChar(buf, 2, &in, 1) != 2 )
+    char c;
+    if ( !GetAsHi8bit(v, &c) )
     {
         wxFAIL_MSG( "character cannot be converted to single byte" );
-        return '?'; // FIXME-UTF8: what to use as failure character?
+        c = '?'; // FIXME-UTF8: what to use as failure character?
     }
-    return buf[0];
-#endif
+
+    return c;
 }
 
+/* static */
+bool wxUniChar::GetAsHi8bit(value_type v, char *c)
+{
+    wchar_t wbuf[2];
+    wbuf[0] = v;
+    wbuf[1] = L'\0';
+    char cbuf[2];
+    if ( wxConvLibc.FromWChar(cbuf, 2, wbuf, 2) != 2 )
+        return false;
+
+    *c = cbuf[0];
+    return true;
+}
 
 // ---------------------------------------------------------------------------
 // wxUniCharRef
@@ -100,14 +109,13 @@ wxUniCharRef& wxUniCharRef::operator=(const wxUniChar& c)
         for ( size_t i = 0; i < lenNew; ++i, ++pos )
             *pos = utf[i];
     }
-    else
+    else // length of character encoding in UTF-8 changed
     {
         // the worse case is when the new value has either longer or shorter
         // code -- in that case, we have to use wxStringImpl::replace() and
         // this invalidates all iterators, so we have to update them too:
 
-        wxString& str = *wx_const_cast(wxString*, m_node.m_str);
-        wxStringImpl& strimpl = str.m_impl;
+        wxStringImpl& strimpl = m_str.m_impl;
 
         int iterDiff = lenNew - lenOld;
         size_t posIdx = m_pos - strimpl.begin();
@@ -121,13 +129,13 @@ wxUniCharRef& wxUniCharRef::operator=(const wxUniChar& c)
         size_t *indexes = indexes_a;
         size_t iterNum = 0;
         wxStringIteratorNode *it;
-        for ( it = str.m_iterators.ptr; it; it = it->m_next, ++iterNum )
+        for ( it = m_str.m_iterators.ptr; it; it = it->m_next, ++iterNum )
         {
             wxASSERT( it->m_iter || it->m_citer );
 
             if ( iterNum == STATIC_SIZE )
             {
-                wxLogTrace( _T("utf8"), _T("unexpectedly many iterators") );
+                wxLogTrace( wxT("utf8"), wxT("unexpectedly many iterators") );
 
                 size_t total = iterNum + 1;
                 for ( wxStringIteratorNode *it2 = it; it2; it2 = it2->m_next )
@@ -149,10 +157,14 @@ wxUniCharRef& wxUniCharRef::operator=(const wxUniChar& c)
         // update the string:
         strimpl.replace(m_pos, m_pos + lenOld, utf, lenNew);
 
+#if wxUSE_STRING_POS_CACHE
+        m_str.InvalidateCache();
+#endif // wxUSE_STRING_POS_CACHE
+
         // finally, set the iterators to valid values again (note that this
         // updates m_pos as well):
         size_t i;
-        for ( i = 0, it = str.m_iterators.ptr; it; it = it->m_next, ++i )
+        for ( i = 0, it = m_str.m_iterators.ptr; it; it = it->m_next, ++i )
         {
             wxASSERT( i < iterNum );
             wxASSERT( it->m_iter || it->m_citer );