X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/eb22f2a6dc1d8cafc91482b6ba45df86fc54f626..da0766ab2ae2357cd4dc111415731ee85aa45984:/src/mac/carbon/window.cpp

diff --git a/src/mac/carbon/window.cpp b/src/mac/carbon/window.cpp
index 2515e88ca5..9587ffa3a7 100644
--- a/src/mac/carbon/window.cpp
+++ b/src/mac/carbon/window.cpp
@@ -1,11 +1,11 @@
 /////////////////////////////////////////////////////////////////////////////
 // Name:        windows.cpp
 // Purpose:     wxWindowMac
-// Author:      AUTHOR
+// Author:      Stefan Csomor
 // Modified by:
-// Created:     ??/??/98
+// Created:     1998-01-01
 // RCS-ID:      $Id$
-// Copyright:   (c) AUTHOR
+// Copyright:   (c) Stefan Csomor
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
@@ -77,6 +77,7 @@ BEGIN_EVENT_TABLE(wxWindowMac, wxWindowBase)
   EVT_INIT_DIALOG(wxWindowMac::OnInitDialog)
   EVT_IDLE(wxWindowMac::OnIdle)
   EVT_SET_FOCUS(wxWindowMac::OnSetFocus)
+  EVT_MOUSE_EVENTS(wxWindowMac::OnMouseEvent)
 END_EVENT_TABLE()
 
 #endif
@@ -103,17 +104,7 @@ void wxWindowMac::Init()
     // generic
     InitBase();
 
-    // MSW specific
-    m_doubleClickAllowed = 0;
-    m_winCaptured = FALSE;
-
     m_isBeingDeleted = FALSE;
-
-    m_useCtl3D = FALSE;
-    m_mouseInWindow = FALSE;
-
-    m_xThumbSize = 0;
-    m_yThumbSize = 0;
     m_backgroundTransparent = FALSE;
 
     // as all windows are created with WS_VISIBLE style...
@@ -133,6 +124,8 @@ void wxWindowMac::Init()
 // Destructor
 wxWindowMac::~wxWindowMac()
 {
+    SendDestroyEvent();
+
     // deleting a window while it is shown invalidates the region
     if ( IsShown() ) {
         wxWindowMac* iter = this ;
@@ -169,12 +162,12 @@ wxWindowMac::~wxWindowMac()
     {
         s_lastMouseWindow = NULL ;
     }
-    
+
     wxFrame* frame = wxDynamicCast( wxGetTopLevelParent( this ) , wxFrame ) ;
     if ( frame )
     {
-    	if ( frame->GetLastFocus() == this )
-    		frame->SetLastFocus( NULL ) ;
+        if ( frame->GetLastFocus() == this )
+            frame->SetLastFocus( NULL ) ;
     }
 
     if ( gFocusWindow == this )
@@ -182,10 +175,23 @@ wxWindowMac::~wxWindowMac()
         gFocusWindow = NULL ;
     }
 
+	// CS: copied from MSW :
+    // VS: destroy children first and _then_ detach *this from its parent.
+    //     If we'd do it the other way around, children wouldn't be able
+    //     find their parent frame (see above).
+    DestroyChildren();
+
     if ( m_parent )
         m_parent->RemoveChild(this);
 
-    DestroyChildren();
+    // delete our drop target if we've got one
+#if wxUSE_DRAG_AND_DROP
+    if ( m_dropTarget != NULL )
+    {
+        delete m_dropTarget;
+        m_dropTarget = NULL;
+    }
+#endif // wxUSE_DRAG_AND_DROP
 }
 
 // Constructor
@@ -197,6 +203,17 @@ bool wxWindowMac::Create(wxWindowMac *parent, wxWindowID id,
 {
     wxCHECK_MSG( parent, FALSE, wxT("can't create wxWindowMac without parent") );
 
+#if wxUSE_STATBOX
+    // wxGTK doesn't allow to create controls with static box as the parent so
+    // this will result in a crash when the program is ported to wxGTK - warn
+    // about it
+    //
+    // the correct solution is to create the controls as siblings of the
+    // static box
+    wxASSERT_MSG( !wxDynamicCast(parent, wxStaticBox),
+                  _T("wxStaticBox can't be used as a window parent!") );
+#endif // wxUSE_STATBOX
+
     if ( !CreateBase(parent, id, pos, size, style, wxDefaultValidator, name) )
         return FALSE;
 
@@ -227,24 +244,32 @@ void wxWindowMac::SetFocus()
     {
         if (gFocusWindow )
         {
-            #if wxUSE_CARET
+#if wxUSE_CARET
                 // Deal with caret
                 if ( gFocusWindow->m_caret )
                 {
                       gFocusWindow->m_caret->OnKillFocus();
                 }
-            #endif // wxUSE_CARET
-      #ifndef __WXUNIVERSAL__
+#endif // wxUSE_CARET
+#ifndef __WXUNIVERSAL__
             wxControl* control = wxDynamicCast( gFocusWindow , wxControl ) ;
             if ( control && control->GetMacControl() )
             {
                 UMASetKeyboardFocus( (WindowRef) gFocusWindow->MacGetRootWindow() , (ControlHandle) control->GetMacControl()  , kControlFocusNoPart ) ;
                 control->MacRedrawControl() ;
             }
-            #endif
-            wxFocusEvent event(wxEVT_KILL_FOCUS, gFocusWindow->m_windowId);
-            event.SetEventObject(gFocusWindow);
-            gFocusWindow->GetEventHandler()->ProcessEvent(event) ;
+#endif
+            // Without testing the window id, for some reason
+            // a kill focus event can still be sent to
+            // the control just being focussed.
+            int thisId = this->m_windowId;
+            int gFocusWindowId = gFocusWindow->m_windowId;
+            if (gFocusWindowId != thisId)
+            {
+                wxFocusEvent event(wxEVT_KILL_FOCUS, gFocusWindow->m_windowId);
+                event.SetEventObject(gFocusWindow);
+                gFocusWindow->GetEventHandler()->ProcessEvent(event) ;
+            }
         }
         gFocusWindow = this ;
         {
@@ -302,15 +327,15 @@ void wxWindowMac::DoReleaseMouse()
 
 void wxWindowMac::SetDropTarget(wxDropTarget *pDropTarget)
 {
-  if ( m_dropTarget != 0 ) {
-    delete m_dropTarget;
-  }
+    if ( m_dropTarget != 0 ) {
+        delete m_dropTarget;
+    }
 
-  m_dropTarget = pDropTarget;
-  if ( m_dropTarget != 0 )
-  {
-    // TODO
-  }
+    m_dropTarget = pDropTarget;
+    if ( m_dropTarget != 0 )
+    {
+        // TODO
+    }
 }
 
 #endif
@@ -351,20 +376,23 @@ bool wxWindowMac::DoPopupMenu(wxMenu *menu, int x, int y)
     menu->UpdateUI();
     ClientToScreen( &x , &y ) ;
 
-    ::InsertMenu( (MenuHandle) menu->GetHMenu() , -1 ) ;
+    menu->MacBeforeDisplay( true ) ;
     long menuResult = ::PopUpMenuSelect((MenuHandle) menu->GetHMenu() ,y,x, 0) ;
     if ( HiWord(menuResult) != 0 )
     {
         MenuCommand id ;
         GetMenuItemCommandID( GetMenuHandle(HiWord(menuResult)) , LoWord(menuResult) , &id ) ;
-
-        wxCommandEvent event(wxEVT_COMMAND_MENU_SELECTED, id );
-        event.m_timeStamp =  TickCount() ;
-        event.SetEventObject(this->GetEventHandler());
-        event.SetInt( id );
-        GetEventHandler()->ProcessEvent(event);
+        wxMenuItem* item = NULL ;
+        wxMenu* realmenu ;
+        item = menu->FindItem(id, &realmenu) ;
+        if (item->IsCheckable())
+        {
+            item->Check( !item->IsChecked() ) ;
+        }
+        menu->SendEvent( id , item->IsCheckable() ? item->IsChecked() : -1 ) ;
     }
-    ::DeleteMenu( menu->MacGetMenuId() ) ;
+    menu->MacAfterDisplay( true ) ;
+
     menu->SetInvokingWindow(NULL);
 
   return TRUE;
@@ -391,9 +419,9 @@ void wxWindowMac::DoScreenToClient(int *x, int *y) const
 
     MacRootWindowToWindow( x , y ) ;
     if ( x )
-            *x -= MacGetLeftBorderSize() ;
+        *x -= MacGetLeftBorderSize() ;
     if ( y )
-            *y -= MacGetTopBorderSize() ;
+        *y -= MacGetTopBorderSize() ;
 }
 
 void wxWindowMac::DoClientToScreen(int *x, int *y) const
@@ -401,9 +429,9 @@ void wxWindowMac::DoClientToScreen(int *x, int *y) const
     WindowRef window = (WindowRef) MacGetRootWindow() ;
 
     if ( x )
-            *x += MacGetLeftBorderSize() ;
+        *x += MacGetLeftBorderSize() ;
     if ( y )
-            *y += MacGetTopBorderSize() ;
+        *y += MacGetTopBorderSize() ;
 
     MacWindowToRootWindow( x , y ) ;
 
@@ -461,37 +489,37 @@ void wxWindowMac::MacRootWindowToWindow( int *x , int *y ) const
 bool wxWindowMac::SetCursor(const wxCursor& cursor)
 {
     if (m_cursor == cursor)
-       return FALSE;
+        return FALSE;
 
     if (wxNullCursor == cursor)
     {
-       if ( ! wxWindowBase::SetCursor( *wxSTANDARD_CURSOR ) )
-        return FALSE ;
+        if ( ! wxWindowBase::SetCursor( *wxSTANDARD_CURSOR ) )
+            return FALSE ;
     }
     else
     {
-       if ( ! wxWindowBase::SetCursor( cursor ) )
-        return FALSE ;
+        if ( ! wxWindowBase::SetCursor( cursor ) )
+            return FALSE ;
     }
 
-  wxASSERT_MSG( m_cursor.Ok(),
-                  wxT("cursor must be valid after call to the base version"));
+    wxASSERT_MSG( m_cursor.Ok(),
+        wxT("cursor must be valid after call to the base version"));
 
-  Point pt ;
-  wxWindowMac *mouseWin ;
-  GetMouse( &pt ) ;
+    Point pt ;
+    wxWindowMac *mouseWin ;
+    GetMouse( &pt ) ;
 
-  // Change the cursor NOW if we're within the correct window
+    // Change the cursor NOW if we're within the correct window
 
-  if ( MacGetWindowFromPoint( wxPoint( pt.h , pt.v ) , &mouseWin ) )
-  {
-    if ( mouseWin == this && !wxIsBusy() )
+    if ( MacGetWindowFromPoint( wxPoint( pt.h , pt.v ) , &mouseWin ) )
     {
-        m_cursor.MacInstall() ;
+        if ( mouseWin == this && !wxIsBusy() )
+        {
+            m_cursor.MacInstall() ;
+        }
     }
-  }
 
-  return TRUE ;
+    return TRUE ;
 }
 
 
@@ -505,50 +533,50 @@ void wxWindowMac::DoGetClientSize(int *x, int *y) const
     ww -= MacGetLeftBorderSize(  )  + MacGetRightBorderSize(  ) ;
     hh -= MacGetTopBorderSize(  ) + MacGetBottomBorderSize( );
 
-  if ( (m_vScrollBar && m_vScrollBar->IsShown()) || (m_hScrollBar  && m_hScrollBar->IsShown()) )
-  {
-    int x1 = 0 ;
-    int y1 = 0 ;
-    int w = m_width ;
-    int h = m_height ;
+    if ( (m_vScrollBar && m_vScrollBar->IsShown()) || (m_hScrollBar  && m_hScrollBar->IsShown()) )
+    {
+        int x1 = 0 ;
+        int y1 = 0 ;
+        int w = m_width ;
+        int h = m_height ;
 
-    MacClientToRootWindow( &x1 , &y1 ) ;
-    MacClientToRootWindow( &w , &h ) ;
+        MacClientToRootWindow( &x1 , &y1 ) ;
+        MacClientToRootWindow( &w , &h ) ;
 
-    wxWindowMac *iter = (wxWindowMac*)this ;
+        wxWindowMac *iter = (wxWindowMac*)this ;
 
-    int totW = 10000 , totH = 10000;
-    while( iter )
-    {
-        if ( iter->IsTopLevel() )
+        int totW = 10000 , totH = 10000;
+        while( iter )
         {
-            totW = iter->m_width ;
-            totH = iter->m_height ;
-            break ;
-        }
+            if ( iter->IsTopLevel() )
+            {
+                totW = iter->m_width ;
+                totH = iter->m_height ;
+                break ;
+            }
 
-        iter = iter->GetParent() ;
-    }
+            iter = iter->GetParent() ;
+        }
 
-    if (m_hScrollBar  && m_hScrollBar->IsShown() )
-    {
-        hh -= MAC_SCROLLBAR_SIZE;
-        if ( h-y1 >= totH )
+        if (m_hScrollBar  && m_hScrollBar->IsShown() )
         {
-            hh += 1 ;
+            hh -= MAC_SCROLLBAR_SIZE;
+            if ( h-y1 >= totH )
+            {
+                hh += 1 ;
+            }
         }
-    }
-    if (m_vScrollBar  && m_vScrollBar->IsShown() )
-    {
-        ww -= MAC_SCROLLBAR_SIZE;
-        if ( w-x1 >= totW )
+        if (m_vScrollBar  && m_vScrollBar->IsShown() )
         {
-            ww += 1 ;
+            ww -= MAC_SCROLLBAR_SIZE;
+            if ( w-x1 >= totW )
+            {
+                ww += 1 ;
+            }
         }
     }
-  }
-  if(x)   *x = ww;
-  if(y)   *y = hh;
+    if(x)   *x = ww;
+    if(y)   *y = hh;
 }
 
 
@@ -575,10 +603,10 @@ void wxWindowMac::DoMoveWindow(int x, int y, int width, int height)
     int former_w = m_width ;
     int former_h = m_height ;
 
-  int actualWidth = width;
-  int actualHeight = height;
-  int actualX = x;
-  int actualY = y;
+    int actualWidth = width;
+    int actualHeight = height;
+    int actualX = x;
+    int actualY = y;
 
     if ((m_minWidth != -1) && (actualWidth < m_minWidth))
         actualWidth = m_minWidth;
@@ -609,7 +637,7 @@ void wxWindowMac::DoMoveWindow(int x, int y, int width, int height)
 
         if ( HasFlag(wxNO_FULL_REPAINT_ON_RESIZE) )
         {
-            wxPoint oldPos( m_x , m_y ) ; 
+            wxPoint oldPos( m_x , m_y ) ;
             wxPoint newPos( actualX , actualY ) ;
             MacWindowToRootWindow( &oldPos.x , &oldPos.y ) ;
             MacWindowToRootWindow( &newPos.x , &newPos.y ) ;
@@ -640,9 +668,9 @@ void wxWindowMac::DoMoveWindow(int x, int y, int width, int height)
         m_width = actualWidth ;
         m_height = actualHeight ;
 
-		// update any low-level frame-relative positions
+        // update any low-level frame-relative positions
 
-		MacUpdateDimensions() ;
+        MacUpdateDimensions() ;
         // erase new position
 
         if ( !partialRepaint )
@@ -660,11 +688,11 @@ void wxWindowMac::DoMoveWindow(int x, int y, int width, int height)
         }
         if ( doResize )
         {
-             MacRepositionScrollBars() ;
-             wxSize size(m_width, m_height);
-             wxSizeEvent event(size, m_windowId);
-             event.SetEventObject(this);
-             GetEventHandler()->ProcessEvent(event);
+            MacRepositionScrollBars() ;
+            wxSize size(m_width, m_height);
+            wxSizeEvent event(size, m_windowId);
+            event.SetEventObject(this);
+            GetEventHandler()->ProcessEvent(event);
         }
     }
 
@@ -689,7 +717,7 @@ void wxWindowMac::DoSetSize(int x, int y, int width, int height, int sizeFlags)
 
     // ... and don't do anything (avoiding flicker) if it's already ok
     if ( x == currentX && y == currentY &&
-         width == currentW && height == currentH )
+        width == currentW && height == currentH )
     {
         MacRepositionScrollBars() ; // we might have a real position shift
         return;
@@ -762,25 +790,9 @@ bool wxWindowMac::Show(bool show)
     if ( !wxWindowBase::Show(show) )
         return FALSE;
 
-/*
-    WindowRef window = (WindowRef) MacGetRootWindow() ;
-    wxWindowMac* win = wxFindWinFromMacWindow( window ) ;
-    if ( win == NULL && win->m_isBeingDeleted )
-        return FALSE ;
-*/
     MacSuperShown( show ) ;
     Refresh() ;
-/*
-    if ( !show )
-    {
-        if ( win && !win->m_isBeingDeleted )
-            Refresh() ;
-    }
-    else
-    {
-        Refresh() ;
-    }
-*/
+
     return TRUE;
 }
 
@@ -789,7 +801,7 @@ void wxWindowMac::MacSuperShown( bool show )
     wxWindowListNode *node = GetChildren().GetFirst();
     while ( node )
     {
-        wxWindowMac *child = (wxWindowMac *)node->GetData();
+        wxWindowMac *child = node->GetData();
         if ( child->m_isShown )
             child->MacSuperShown( show ) ;
         node = node->GetNext();
@@ -959,7 +971,7 @@ wxWindowMac *wxGetActiveWindow()
 // Coordinates relative to the window
 void wxWindowMac::WarpPointer (int x_pos, int y_pos)
 {
-    // We really dont move the mouse programmatically under mac
+    // We really don't move the mouse programmatically under Mac.
 }
 
 const wxBrush& wxWindowMac::MacGetBackgroundBrush()
@@ -974,49 +986,49 @@ const wxBrush& wxWindowMac::MacGetBackgroundBrush()
         // it is on a notebook panel or not, in order to take care of that we walk up the hierarchy until we have
         // either a non gray background color or a non control window
 
-            WindowRef window = (WindowRef) MacGetRootWindow() ;
+        WindowRef window = (WindowRef) MacGetRootWindow() ;
+
+        wxWindowMac* parent = GetParent() ;
+        while( parent )
+        {
+            if ( parent->MacGetRootWindow() != window )
+            {
+                // we are in a different window on the mac system
+                parent = NULL ;
+                break ;
+            }
 
-            wxWindowMac* parent = GetParent() ;
-            while( parent )
             {
-                if ( parent->MacGetRootWindow() != window )
+                if ( parent->m_backgroundColour != wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE )
+                    && parent->m_backgroundColour != wxSystemSettings::GetColour(wxSYS_COLOUR_APPWORKSPACE) )
                 {
-                    // we are in a different window on the mac system
-                    parent = NULL ;
+                    // if we have any other colours in the hierarchy
+                    m_macBackgroundBrush.SetColour( parent->m_backgroundColour ) ;
                     break ;
                 }
-
+                // if we have the normal colours in the hierarchy but another control etc. -> use it's background
+                if ( parent->IsKindOf( CLASSINFO( wxNotebook ) ) || parent->IsKindOf( CLASSINFO( wxTabCtrl ) ))
                 {
-                    if ( parent->m_backgroundColour != wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE )
-                      && parent->m_backgroundColour != wxSystemSettings::GetColour(wxSYS_COLOUR_APPWORKSPACE) )
-                    {
-                        // if we have any other colours in the hierarchy
-                        m_macBackgroundBrush.SetColour( parent->m_backgroundColour ) ;
-                        break ;
-                    }
-                    // if we have the normal colours in the hierarchy but another control etc. -> use it's background
-                    if ( parent->IsKindOf( CLASSINFO( wxNotebook ) ) || parent->IsKindOf( CLASSINFO( wxTabCtrl ) ))
-                    {
-                        Rect extent = { 0 , 0 , 0 , 0 } ;
-                        int x , y ;
-                        x = y = 0 ;
-                        wxSize size = parent->GetSize() ;
-                        parent->MacClientToRootWindow( &x , &y ) ;
-                        extent.left = x ;
-                        extent.top = y ;
-                        extent.top-- ;
-                        extent.right = x + size.x ;
-                        extent.bottom = y + size.y ;
-                        m_macBackgroundBrush.SetMacThemeBackground( kThemeBackgroundTabPane , (WXRECTPTR) &extent ) ; // todo eventually change for inactive
-                        break ;
-                    }
+                    Rect extent = { 0 , 0 , 0 , 0 } ;
+                    int x , y ;
+                    x = y = 0 ;
+                    wxSize size = parent->GetSize() ;
+                    parent->MacClientToRootWindow( &x , &y ) ;
+                    extent.left = x ;
+                    extent.top = y ;
+                    extent.top-- ;
+                    extent.right = x + size.x ;
+                    extent.bottom = y + size.y ;
+                    m_macBackgroundBrush.SetMacThemeBackground( kThemeBackgroundTabPane , (WXRECTPTR) &extent ) ; // todo eventually change for inactive
+                    break ;
                 }
-                parent = parent->GetParent() ;
-            }
-            if ( !parent )
-            {
-              m_macBackgroundBrush.SetMacTheme( kThemeBrushDialogBackgroundActive ) ; // todo eventually change for inactive
             }
+            parent = parent->GetParent() ;
+        }
+        if ( !parent )
+        {
+            m_macBackgroundBrush.SetMacTheme( kThemeBrushDialogBackgroundActive ) ; // todo eventually change for inactive
+        }
     }
     else
     {
@@ -1024,7 +1036,6 @@ const wxBrush& wxWindowMac::MacGetBackgroundBrush()
     }
 
     return m_macBackgroundBrush ;
-
 }
 
 void wxWindowMac::OnEraseBackground(wxEraseEvent& event)
@@ -1178,41 +1189,41 @@ void wxWindowMac::RemoveChild( wxWindowBase *child )
 void wxWindowMac::SetScrollbar(int orient, int pos, int thumbVisible,
     int range, bool refresh)
 {
-        if ( orient == wxHORIZONTAL )
+    if ( orient == wxHORIZONTAL )
+    {
+        if ( m_hScrollBar )
         {
-            if ( m_hScrollBar )
+            if ( range == 0 || thumbVisible >= range )
             {
-                if ( range == 0 || thumbVisible >= range )
-                {
-                    if ( m_hScrollBar->IsShown() )
-                        m_hScrollBar->Show(false) ;
-                }
-                else
-                {
-                    if ( !m_hScrollBar->IsShown() )
-                        m_hScrollBar->Show(true) ;
-                    m_hScrollBar->SetScrollbar( pos , thumbVisible , range , thumbVisible , refresh ) ;
-                }
+                if ( m_hScrollBar->IsShown() )
+                    m_hScrollBar->Show(false) ;
+            }
+            else
+            {
+                if ( !m_hScrollBar->IsShown() )
+                    m_hScrollBar->Show(true) ;
+                m_hScrollBar->SetScrollbar( pos , thumbVisible , range , thumbVisible , refresh ) ;
             }
         }
-        else
+    }
+    else
+    {
+        if ( m_vScrollBar )
         {
-            if ( m_vScrollBar )
+            if ( range == 0 || thumbVisible >= range )
             {
-                if ( range == 0 || thumbVisible >= range )
-                {
-                    if ( m_vScrollBar->IsShown() )
-                        m_vScrollBar->Show(false) ;
-                }
-                else
-                {
-                    if ( !m_vScrollBar->IsShown() )
-                        m_vScrollBar->Show(true) ;
-                    m_vScrollBar->SetScrollbar( pos , thumbVisible , range , thumbVisible , refresh ) ;
-                }
+                if ( m_vScrollBar->IsShown() )
+                    m_vScrollBar->Show(false) ;
+            }
+            else
+            {
+                if ( !m_vScrollBar->IsShown() )
+                    m_vScrollBar->Show(true) ;
+                m_vScrollBar->SetScrollbar( pos , thumbVisible , range , thumbVisible , refresh ) ;
             }
         }
-        MacRepositionScrollBars() ;
+    }
+    MacRepositionScrollBars() ;
 }
 
 // Does a physical scroll
@@ -1231,7 +1242,7 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect)
         if ( rect )
         {
             Rect r = { dc.YLOG2DEVMAC(rect->y) , dc.XLOG2DEVMAC(rect->x) , dc.YLOG2DEVMAC(rect->y + rect->height) ,
-              dc.XLOG2DEVMAC(rect->x + rect->width) } ;
+                dc.XLOG2DEVMAC(rect->x + rect->width) } ;
             SectRect( &scrollrect , &r , &scrollrect ) ;
         }
         ScrollRect( &scrollrect , dx , dy , updateRgn ) ;
@@ -1241,11 +1252,11 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect)
 
     for (wxWindowListNode *node = GetChildren().GetFirst(); node; node = node->GetNext())
     {
-        wxWindowMac *child = (wxWindowMac*)node->GetData();
+        wxWindowMac *child = node->GetData();
         if (child == m_vScrollBar) continue;
         if (child == m_hScrollBar) continue;
         if (child->IsTopLevel()) continue;
-        
+
         int x,y;
         child->GetPosition( &x, &y );
         int w,h;
@@ -1264,27 +1275,22 @@ void wxWindowMac::MacOnScroll(wxScrollEvent &event )
         wevent.SetOrientation(event.GetOrientation());
         wevent.m_eventObject = this;
 
-        if (event.m_eventType == wxEVT_SCROLL_TOP) {
+        if (event.m_eventType == wxEVT_SCROLL_TOP)
             wevent.m_eventType = wxEVT_SCROLLWIN_TOP;
-        } else
-        if (event.m_eventType == wxEVT_SCROLL_BOTTOM) {
+        else if (event.m_eventType == wxEVT_SCROLL_BOTTOM)
             wevent.m_eventType = wxEVT_SCROLLWIN_BOTTOM;
-        } else
-        if (event.m_eventType == wxEVT_SCROLL_LINEUP) {
+        else if (event.m_eventType == wxEVT_SCROLL_LINEUP)
             wevent.m_eventType = wxEVT_SCROLLWIN_LINEUP;
-        } else
-        if (event.m_eventType == wxEVT_SCROLL_LINEDOWN) {
+        else if (event.m_eventType == wxEVT_SCROLL_LINEDOWN)
             wevent.m_eventType = wxEVT_SCROLLWIN_LINEDOWN;
-        } else
-        if (event.m_eventType == wxEVT_SCROLL_PAGEUP) {
+        else if (event.m_eventType == wxEVT_SCROLL_PAGEUP)
             wevent.m_eventType = wxEVT_SCROLLWIN_PAGEUP;
-        } else
-        if (event.m_eventType == wxEVT_SCROLL_PAGEDOWN) {
+        else if (event.m_eventType == wxEVT_SCROLL_PAGEDOWN)
             wevent.m_eventType = wxEVT_SCROLLWIN_PAGEDOWN;
-        } else
-        if (event.m_eventType == wxEVT_SCROLL_THUMBTRACK) {
+        else if (event.m_eventType == wxEVT_SCROLL_THUMBTRACK)
             wevent.m_eventType = wxEVT_SCROLLWIN_THUMBTRACK;
-        }
+        else if (event.m_eventType == wxEVT_SCROLL_THUMBRELEASE)
+            wevent.m_eventType = wxEVT_SCROLLWIN_THUMBRELEASE;
 
         GetEventHandler()->ProcessEvent(wevent);
     }
@@ -1360,21 +1366,6 @@ void wxWindowMac::SetupColours()
 
 void wxWindowMac::OnIdle(wxIdleEvent& event)
 {
-/*
-   // Check if we need to send a LEAVE event
-   if (m_mouseInWindow)
-   {
-       POINT pt;
-       ::GetCursorPos(&pt);
-       if (::WindowFromPoint(pt) != (HWND) GetHWND())
-       {
-           // Generate a LEAVE event
-           m_mouseInWindow = FALSE;
-           MSWOnMouseLeave(pt.x, pt.y, 0);
-       }
-    }
-*/
-
     // This calls the UI-update mechanism (querying windows for
     // menu/toolbar/control state information)
     UpdateWindowUI();
@@ -1414,15 +1405,15 @@ bool wxWindowMac::MacGetWindowFromPointSub( const wxPoint &point , wxWindowMac**
 {
     if ( IsTopLevel() )
     {
-      if ((point.x < 0) || (point.y < 0) ||
-          (point.x > (m_width)) || (point.y > (m_height)))
-          return FALSE;
+        if ((point.x < 0) || (point.y < 0) ||
+            (point.x > (m_width)) || (point.y > (m_height)))
+            return FALSE;
     }
     else
     {
-      if ((point.x < m_x) || (point.y < m_y) ||
-          (point.x > (m_x + m_width)) || (point.y > (m_y + m_height)))
-          return FALSE;
+        if ((point.x < m_x) || (point.y < m_y) ||
+            (point.x > (m_x + m_width)) || (point.y > (m_y + m_height)))
+            return FALSE;
     }
 
     WindowRef window = (WindowRef) MacGetRootWindow() ;
@@ -1431,13 +1422,13 @@ bool wxWindowMac::MacGetWindowFromPointSub( const wxPoint &point , wxWindowMac**
 
     if ( !IsTopLevel() )
     {
-      newPoint.x -= m_x;
-      newPoint.y -= m_y;
+        newPoint.x -= m_x;
+        newPoint.y -= m_y;
     }
 
     for (wxWindowListNode *node = GetChildren().GetFirst(); node; node = node->GetNext())
     {
-        wxWindowMac *child = (wxWindowMac*)node->GetData();
+        wxWindowMac *child = node->GetData();
         // added the m_isShown test --dmazzoni
         if ( child->MacGetRootWindow() == window && child->m_isShown )
         {
@@ -1480,25 +1471,25 @@ bool wxWindowMac::MacGetWindowFromPoint( const wxPoint &screenpoint , wxWindowMa
 
 static wxWindow *gs_lastWhich = NULL;
 
-bool wxWindowMac::MacSetupCursor( const wxPoint& pt) 
+bool wxWindowMac::MacSetupCursor( const wxPoint& pt)
 {
     // first trigger a set cursor event
-    
+
     wxPoint clientorigin = GetClientAreaOrigin() ;
     wxSize clientsize = GetClientSize() ;
     wxCursor cursor ;
     if ( wxRect2DInt( clientorigin.x , clientorigin.y , clientsize.x , clientsize.y ).Contains( wxPoint2DInt( pt ) ) )
-    {  
+    {
         wxSetCursorEvent event( pt.x , pt.y );
 
         bool processedEvtSetCursor = GetEventHandler()->ProcessEvent(event);
         if ( processedEvtSetCursor && event.HasCursor() )
         {
-           cursor = event.GetCursor() ;
+            cursor = event.GetCursor() ;
         }
         else
         {
-            
+
             // the test for processedEvtSetCursor is here to prevent using m_cursor
             // if the user code caught EVT_SET_CURSOR() and returned nothing from
             // it - this is a way to say that our cursor shouldn't be used for this
@@ -1542,7 +1533,7 @@ bool wxWindowMac::MacDispatchMouseEvent(wxMouseEvent& event)
 
     for (wxWindowListNode *node = GetChildren().GetFirst(); node; node = node->GetNext())
     {
-        wxWindowMac *child = (wxWindowMac*)node->GetData();
+        wxWindowMac *child = node->GetData();
         if ( child->MacGetRootWindow() == window && child->IsShown() && child->IsEnabled() )
         {
             if (child->MacDispatchMouseEvent(event))
@@ -1572,8 +1563,8 @@ bool wxWindowMac::MacDispatchMouseEvent(wxMouseEvent& event)
 
 #if wxUSE_TOOLTIPS
     if ( event.GetEventType() == wxEVT_MOTION
-            || event.GetEventType() == wxEVT_ENTER_WINDOW
-            || event.GetEventType() == wxEVT_LEAVE_WINDOW )
+        || event.GetEventType() == wxEVT_ENTER_WINDOW
+        || event.GetEventType() == wxEVT_LEAVE_WINDOW )
         wxToolTip::RelayEvent( this , event);
 #endif // wxUSE_TOOLTIPS
 
@@ -1605,7 +1596,7 @@ wxString wxWindowMac::MacGetToolTipString( wxPoint &pt )
     {
         return m_tooltip->GetTip() ;
     }
-    return "" ;
+    return wxEmptyString ;
 }
 
 void wxWindowMac::Update()
@@ -1636,105 +1627,105 @@ wxTopLevelWindowMac* wxWindowMac::MacGetTopLevelWindow() const
 
 const wxRegion& wxWindowMac::MacGetVisibleRegion( bool respectChildrenAndSiblings )
 {
-  RgnHandle visRgn = NewRgn() ;
-  RgnHandle tempRgn = NewRgn() ;
-  RgnHandle tempStaticBoxRgn = NewRgn() ;
-
-  SetRectRgn( visRgn , 0 , 0 , m_width , m_height ) ;
-
-  //TODO : as soon as the new scheme has proven to work correctly, move this to wxStaticBox
-  if ( IsKindOf( CLASSINFO( wxStaticBox ) ) )
-  {
-    int borderTop = 14 ;
-    int borderOther = 4 ;
-
-    SetRectRgn( tempStaticBoxRgn , borderOther , borderTop , m_width - borderOther , m_height - borderOther ) ;
-    DiffRgn( visRgn , tempStaticBoxRgn , visRgn ) ;
-  }
-
-  if ( !IsTopLevel() )
-  {
-    wxWindow* parent = GetParent() ;
-    while( parent )
-    {
-      wxSize size = parent->GetSize() ;
-      int x , y ;
-      x = y = 0 ;
-      parent->MacWindowToRootWindow( &x, &y ) ;
-      MacRootWindowToWindow( &x , &y ) ;
-
-      SetRectRgn( tempRgn , 
-      	x + parent->MacGetLeftBorderSize() , y + parent->MacGetTopBorderSize() , 
-      	x + size.x - parent->MacGetRightBorderSize(), 
-      	y + size.y - parent->MacGetBottomBorderSize()) ;
-
-      SectRgn( visRgn , tempRgn , visRgn ) ;
-      if ( parent->IsTopLevel() )
-        break ;
-      parent = parent->GetParent() ;
-    }
-  }
-  if ( respectChildrenAndSiblings )
-  {
-      if ( GetWindowStyle() & wxCLIP_CHILDREN )
-      {
-        for (wxWindowListNode *node = GetChildren().GetFirst(); node; node = node->GetNext())
-        {
-            wxWindowMac *child = (wxWindowMac*)node->GetData();
+    RgnHandle visRgn = NewRgn() ;
+    RgnHandle tempRgn = NewRgn() ;
+    RgnHandle tempStaticBoxRgn = NewRgn() ;
+
+    SetRectRgn( visRgn , 0 , 0 , m_width , m_height ) ;
+
+    //TODO : as soon as the new scheme has proven to work correctly, move this to wxStaticBox
+    if ( IsKindOf( CLASSINFO( wxStaticBox ) ) )
+    {
+        int borderTop = 14 ;
+        int borderOther = 4 ;
+
+        SetRectRgn( tempStaticBoxRgn , borderOther , borderTop , m_width - borderOther , m_height - borderOther ) ;
+        DiffRgn( visRgn , tempStaticBoxRgn , visRgn ) ;
+    }
 
-            if ( !child->IsTopLevel() && child->IsShown() )
+    if ( !IsTopLevel() )
+    {
+        wxWindow* parent = GetParent() ;
+        while( parent )
+        {
+            wxSize size = parent->GetSize() ;
+            int x , y ;
+            x = y = 0 ;
+            parent->MacWindowToRootWindow( &x, &y ) ;
+            MacRootWindowToWindow( &x , &y ) ;
+
+            SetRectRgn( tempRgn ,
+                x + parent->MacGetLeftBorderSize() , y + parent->MacGetTopBorderSize() ,
+                x + size.x - parent->MacGetRightBorderSize(),
+                y + size.y - parent->MacGetBottomBorderSize()) ;
+
+            SectRgn( visRgn , tempRgn , visRgn ) ;
+            if ( parent->IsTopLevel() )
+                break ;
+            parent = parent->GetParent() ;
+        }
+    }
+    if ( respectChildrenAndSiblings )
+    {
+        if ( GetWindowStyle() & wxCLIP_CHILDREN )
+        {
+            for (wxWindowListNode *node = GetChildren().GetFirst(); node; node = node->GetNext())
             {
-                SetRectRgn( tempRgn , child->m_x , child->m_y , child->m_x + child->m_width ,  child->m_y + child->m_height ) ;
-                if ( child->IsKindOf( CLASSINFO( wxStaticBox ) ) )
+                wxWindowMac *child = node->GetData();
+
+                if ( !child->IsTopLevel() && child->IsShown() )
                 {
-                    int borderTop = 14 ;
-                    int borderOther = 4 ;
+                    SetRectRgn( tempRgn , child->m_x , child->m_y , child->m_x + child->m_width ,  child->m_y + child->m_height ) ;
+                    if ( child->IsKindOf( CLASSINFO( wxStaticBox ) ) )
+                    {
+                        int borderTop = 14 ;
+                        int borderOther = 4 ;
 
-                    SetRectRgn( tempStaticBoxRgn , child->m_x + borderOther , child->m_y + borderTop , child->m_x + child->m_width - borderOther , child->m_y + child->m_height - borderOther ) ;
-                    DiffRgn( tempRgn , tempStaticBoxRgn , tempRgn ) ;
+                        SetRectRgn( tempStaticBoxRgn , child->m_x + borderOther , child->m_y + borderTop , child->m_x + child->m_width - borderOther , child->m_y + child->m_height - borderOther ) ;
+                        DiffRgn( tempRgn , tempStaticBoxRgn , tempRgn ) ;
+                    }
+                    DiffRgn( visRgn , tempRgn , visRgn ) ;
                 }
-                DiffRgn( visRgn , tempRgn , visRgn ) ;
             }
         }
-      }
 
-      if ( (GetWindowStyle() & wxCLIP_SIBLINGS) && GetParent() )
-      {
-        bool thisWindowThrough = false ;
-        for (wxWindowListNode *node = GetParent()->GetChildren().GetFirst(); node; node = node->GetNext())
+        if ( (GetWindowStyle() & wxCLIP_SIBLINGS) && GetParent() )
         {
-            wxWindowMac *sibling = (wxWindowMac*)node->GetData();
-            if ( sibling == this )
-            {
-              thisWindowThrough = true ;
-              continue ;
-            }
-            if( !thisWindowThrough )
+            bool thisWindowThrough = false ;
+            for (wxWindowListNode *node = GetParent()->GetChildren().GetFirst(); node; node = node->GetNext())
             {
-              continue ;
-            }
+                wxWindowMac *sibling = node->GetData();
+                if ( sibling == this )
+                {
+                    thisWindowThrough = true ;
+                    continue ;
+                }
+                if( !thisWindowThrough )
+                {
+                    continue ;
+                }
 
-            if ( !sibling->IsTopLevel() && sibling->IsShown() )
-            {
-                SetRectRgn( tempRgn , sibling->m_x - m_x , sibling->m_y - m_y , sibling->m_x + sibling->m_width - m_x ,  sibling->m_y + sibling->m_height - m_y ) ;
-                if ( sibling->IsKindOf( CLASSINFO( wxStaticBox ) ) )
+                if ( !sibling->IsTopLevel() && sibling->IsShown() )
                 {
-                    int borderTop = 14 ;
-                    int borderOther = 4 ;
+                    SetRectRgn( tempRgn , sibling->m_x - m_x , sibling->m_y - m_y , sibling->m_x + sibling->m_width - m_x ,  sibling->m_y + sibling->m_height - m_y ) ;
+                    if ( sibling->IsKindOf( CLASSINFO( wxStaticBox ) ) )
+                    {
+                        int borderTop = 14 ;
+                        int borderOther = 4 ;
 
-                    SetRectRgn( tempStaticBoxRgn , sibling->m_x - m_x + borderOther , sibling->m_y - m_y + borderTop , sibling->m_x + sibling->m_width - m_x - borderOther , sibling->m_y + sibling->m_height - m_y - borderOther ) ;
-                    DiffRgn( tempRgn , tempStaticBoxRgn , tempRgn ) ;
+                        SetRectRgn( tempStaticBoxRgn , sibling->m_x - m_x + borderOther , sibling->m_y - m_y + borderTop , sibling->m_x + sibling->m_width - m_x - borderOther , sibling->m_y + sibling->m_height - m_y - borderOther ) ;
+                        DiffRgn( tempRgn , tempStaticBoxRgn , tempRgn ) ;
+                    }
+                    DiffRgn( visRgn , tempRgn , visRgn ) ;
                 }
-                DiffRgn( visRgn , tempRgn , visRgn ) ;
             }
         }
-      }
-  }
-  m_macVisibleRegion = visRgn ;
-  DisposeRgn( visRgn ) ;
-  DisposeRgn( tempRgn ) ;
-  DisposeRgn( tempStaticBoxRgn ) ;
-  return m_macVisibleRegion ;
+    }
+    m_macVisibleRegion = visRgn ;
+    DisposeRgn( visRgn ) ;
+    DisposeRgn( tempRgn ) ;
+    DisposeRgn( tempStaticBoxRgn ) ;
+    return m_macVisibleRegion ;
 }
 
 void wxWindowMac::MacRedraw( WXHRGN updatergnr , long time, bool erase)
@@ -1764,23 +1755,24 @@ void wxWindowMac::MacRedraw( WXHRGN updatergnr , long time, bool erase)
 
         if ( erase && !EmptyRgn(ownUpdateRgn) )
         {
-          wxWindowDC dc(this);
-          dc.SetClippingRegion(wxRegion(ownUpdateRgn));
-          wxEraseEvent eevent( GetId(), &dc );
-          eevent.SetEventObject( this );
-          GetEventHandler()->ProcessEvent( eevent );
-
-          wxNcPaintEvent eventNc( GetId() );
-          eventNc.SetEventObject( this );
-          GetEventHandler()->ProcessEvent( eventNc );
+            wxWindowDC dc(this);
+            if (!EmptyRgn(ownUpdateRgn))
+                dc.SetClippingRegion(wxRegion(ownUpdateRgn));
+            wxEraseEvent eevent( GetId(), &dc );
+            eevent.SetEventObject( this );
+            GetEventHandler()->ProcessEvent( eevent );
+
+            wxNcPaintEvent eventNc( GetId() );
+            eventNc.SetEventObject( this );
+            GetEventHandler()->ProcessEvent( eventNc );
         }
         DisposeRgn( ownUpdateRgn ) ;
         if ( !m_updateRegion.Empty() )
         {
-          wxPaintEvent event;
-          event.m_timeStamp = time ;
-          event.SetEventObject(this);
-          GetEventHandler()->ProcessEvent(event);
+            wxPaintEvent event;
+            event.m_timeStamp = time ;
+            event.SetEventObject(this);
+            GetEventHandler()->ProcessEvent(event);
         }
     }
 
@@ -1791,7 +1783,7 @@ void wxWindowMac::MacRedraw( WXHRGN updatergnr , long time, bool erase)
     {
         // calculate the update region for the child windows by intersecting the window rectangle with our own
         // passed in update region and then offset it to be client-wise window coordinates again
-        wxWindowMac *child = (wxWindowMac*)node->GetData();
+        wxWindowMac *child = node->GetData();
         SetRectRgn( childupdate , child->m_x , child->m_y , child->m_x + child->m_width ,  child->m_y + child->m_height ) ;
         SectRgn( childupdate , updatergn , childupdate ) ;
         OffsetRgn( childupdate , -child->m_x , -child->m_y ) ;
@@ -1817,13 +1809,13 @@ WXHWND wxWindowMac::MacGetRootWindow() const
 
         iter = iter->GetParent() ;
     }
-    wxASSERT_MSG( 1 , "No valid mac root window" ) ;
+    wxASSERT_MSG( 1 , wxT("No valid mac root window") ) ;
     return NULL ;
 }
 
 void wxWindowMac::MacCreateScrollBars( long style )
 {
-    wxASSERT_MSG( m_vScrollBar == NULL && m_hScrollBar == NULL , "attempt to create window twice" ) ;
+    wxASSERT_MSG( m_vScrollBar == NULL && m_hScrollBar == NULL , wxT("attempt to create window twice") ) ;
 
     bool hasBoth = ( style & wxVSCROLL ) && ( style & wxHSCROLL ) ;
     int adjust = hasBoth ? MAC_SCROLLBAR_SIZE - 1: 0 ;
@@ -1951,7 +1943,7 @@ void wxWindowMac::MacSuperChangedPosition()
     wxWindowListNode *node = GetChildren().GetFirst();
     while ( node )
     {
-        wxWindowMac *child = (wxWindowMac *)node->GetData();
+        wxWindowMac *child = node->GetData();
         child->MacSuperChangedPosition() ;
         node = node->GetNext();
     }
@@ -1964,7 +1956,7 @@ void wxWindowMac::MacTopLevelWindowChangedPosition()
     wxWindowListNode *node = GetChildren().GetFirst();
     while ( node )
     {
-        wxWindowMac *child = (wxWindowMac *)node->GetData();
+        wxWindowMac *child = node->GetData();
         child->MacTopLevelWindowChangedPosition() ;
         node = node->GetNext();
     }
@@ -2041,3 +2033,26 @@ wxPoint wxGetMousePosition()
     return wxPoint(x, y);
 }
 
+void wxWindowMac::OnMouseEvent( wxMouseEvent &event )
+{
+	if ( event.GetEventType() == wxEVT_RIGHT_DOWN )
+	{
+		// copied from wxGTK : CS
+        // generate a "context menu" event: this is similar to wxEVT_RIGHT_DOWN
+        // except that:
+        //
+        // (a) it's a command event and so is propagated to the parent
+        // (b) under MSW it can be generated from kbd too
+        // (c) it uses screen coords (because of (a))
+        wxContextMenuEvent evtCtx(wxEVT_CONTEXT_MENU,
+                                  this->GetId(),
+                                  this->ClientToScreen(event.GetPosition()));
+        if ( ! GetEventHandler()->ProcessEvent(evtCtx) )
+            event.Skip() ;
+	}
+	else
+	{
+		event.Skip() ;
+	}
+}
+