X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/e15f0a5ea372e3a6c693fb6aa4fe73893a9af797..2a2e63652d9580770e28a3241c061eecdf0f5603:/src/mac/carbon/window.cpp diff --git a/src/mac/carbon/window.cpp b/src/mac/carbon/window.cpp index 713bdeeab9..bc118c7741 100644 --- a/src/mac/carbon/window.cpp +++ b/src/mac/carbon/window.cpp @@ -41,10 +41,15 @@ #include "wx/caret.h" #endif +#if wxUSE_DRAG_AND_DROP +#include "wx/dnd.h" +#endif + +#include "wx/mac/uma.h" + #define MAC_SCROLLBAR_SIZE 15 #define MAC_SMALL_SCROLLBAR_SIZE 11 -#include "wx/mac/uma.h" #ifndef __DARWIN__ #include #include @@ -58,19 +63,15 @@ #endif #endif -#if wxUSE_DRAG_AND_DROP -#include "wx/dnd.h" -#endif - #include extern wxList wxPendingDelete; #ifdef __WXUNIVERSAL__ IMPLEMENT_ABSTRACT_CLASS(wxWindowMac, wxWindowBase) -#else // __WXMAC__ +#else IMPLEMENT_DYNAMIC_CLASS(wxWindow, wxWindowBase) -#endif // __WXUNIVERSAL__/__WXMAC__ +#endif BEGIN_EVENT_TABLE(wxWindowMac, wxWindowBase) EVT_NC_PAINT(wxWindowMac::OnNcPaint) @@ -147,8 +148,9 @@ pascal OSStatus wxMacSetupControlBackground( ControlRef iControl , SInt16 iMessa #if TARGET_API_MAC_OSX #if MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_3 -enum { - kEventControlVisibilityChanged = 157 +enum +{ + kEventControlVisibilityChanged = 157 }; #endif @@ -156,8 +158,14 @@ enum { static const EventTypeSpec eventList[] = { + { kEventClassCommand, kEventProcessCommand } , + { kEventClassCommand, kEventCommandUpdateStatus } , + { kEventClassControl , kEventControlHit } , -#if TARGET_API_MAC_OSX + + { kEventClassTextInput, kEventTextInputUnicodeForKeyEvent } , + { kEventClassTextInput, kEventTextInputUpdateActiveInputArea } , + { kEventClassControl , kEventControlDraw } , { kEventClassControl , kEventControlVisibilityChanged } , { kEventClassControl , kEventControlEnabledStateChanged } , @@ -168,9 +176,8 @@ static const EventTypeSpec eventList[] = { kEventClassService , kEventServiceCopy }, { kEventClassService , kEventServicePaste }, - // { kEventClassControl , kEventControlInvalidateForSizeChange } , // 10.3 only -// { kEventClassControl , kEventControlBoundsChanged } , -#endif +// { kEventClassControl , kEventControlInvalidateForSizeChange } , // 10.3 only +// { kEventClassControl , kEventControlBoundsChanged } , } ; static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handler , EventRef event , void *data ) @@ -184,7 +191,7 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl cEvent.GetParameter( kEventParamDirectObject , &controlRef ) ; - switch( GetEventKind( event ) ) + switch ( GetEventKind( event ) ) { #if TARGET_API_MAC_OSX case kEventControlDraw : @@ -193,12 +200,13 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl RgnHandle allocatedRgn = NULL ; wxRegion visRegion = thisWindow->MacGetVisibleRegion() ; Rect controlBounds ; - if ( thisWindow->GetPeer()->IsCompositing() == false ) + + if ( ! thisWindow->GetPeer()->IsCompositing() ) { - if ( thisWindow->GetPeer()->IsRootControl() == false ) - GetControlBounds( thisWindow->GetPeer()->GetControlRef() , &controlBounds ) ; - else + if ( thisWindow->GetPeer()->IsRootControl() ) thisWindow->GetPeer()->GetRect( &controlBounds ) ; + else + GetControlBounds( thisWindow->GetPeer()->GetControlRef() , &controlBounds ) ; } if ( cEvent.GetParameter(kEventParamRgnHandle, &updateRgn) != noErr ) @@ -207,11 +215,12 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl } else { - if ( thisWindow->GetPeer()->IsCompositing() == false ) + if ( ! thisWindow->GetPeer()->IsCompositing() ) { allocatedRgn = NewRgn() ; CopyRgn( updateRgn , allocatedRgn ) ; OffsetRgn( allocatedRgn , -controlBounds.left , -controlBounds.top ) ; + // hide the given region by the new region that must be shifted wxMacNativeToWindow( thisWindow , allocatedRgn ) ; updateRgn = allocatedRgn ; @@ -223,6 +232,7 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl // as this update region is in native window locals we must adapt it to wx window local allocatedRgn = NewRgn() ; CopyRgn( updateRgn , allocatedRgn ) ; + // hide the given region by the new region that must be shifted wxMacNativeToWindow( thisWindow , allocatedRgn ) ; updateRgn = allocatedRgn ; @@ -232,14 +242,16 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl Rect rgnBounds ; GetRegionBounds( updateRgn , &rgnBounds ) ; + #if wxMAC_DEBUG_REDRAW if ( thisWindow->MacIsUserPane() ) { - CGContextRef cgContext = cEvent.GetParameter(kEventParamCGContextRef) ; static float color = 0.5 ; static channel = 0 ; - HIRect bounds; - HIViewGetBounds( controlRef, &bounds ); + HIRect bounds; + CGContextRef cgContext = cEvent.GetParameter(kEventParamCGContextRef) ; + + HIViewGetBounds( controlRef, &bounds ); CGContextSetRGBFillColor( cgContext, channel == 0 ? color : 0.5 , channel == 1 ? color : 0.5 , channel == 2 ? color : 0.5 , 1 ); CGContextFillRect( cgContext, bounds ); @@ -253,16 +265,18 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl } } #endif + { #if wxMAC_USE_CORE_GRAPHICS bool created = false ; - CGContextRef cgContext = 0 ; + CGContextRef cgContext = NULL ; if ( cEvent.GetParameter(kEventParamCGContextRef, &cgContext) != noErr ) { wxASSERT( thisWindow->GetPeer()->IsCompositing() == false ) ; // this parameter is not provided on non-composited windows created = true ; + // rest of the code expects this to be already transformed and clipped for local CGrafPtr port = GetWindowPort( (WindowRef) thisWindow->MacGetTopLevelWindowRef() ) ; Rect bounds ; @@ -282,21 +296,25 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl #if 0 CGContextSetRGBFillColor( cgContext , 1.0 , 1.0 , 1.0 , 1.0 ) ; - CGContextFillRect(cgContext , CGRectMake( 0 , 0 , - controlBounds.right - controlBounds.left , - controlBounds.bottom - controlBounds.top ) ); + CGContextFillRect( cgContext , + CGRectMake( 0 , 0 , + controlBounds.right - controlBounds.left , + controlBounds.bottom - controlBounds.top ) ); #endif - } + thisWindow->MacSetCGContextRef( cgContext ) ; + { wxMacCGContextStateSaver sg( cgContext ) ; #endif if ( thisWindow->MacDoRedraw( updateRgn , cEvent.GetTicks() ) ) result = noErr ; + #if wxMAC_USE_CORE_GRAPHICS thisWindow->MacSetCGContextRef( NULL ) ; } + if ( created ) CGContextRelease( cgContext ) ; #endif @@ -325,6 +343,7 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl { Boolean focusEverything = false ; ControlPartCode controlPart = cEvent.GetParameter(kEventParamControlPart , typeControlPartCode ); + #ifdef __WXMAC_OSX__ if ( cEvent.GetParameter(kEventParamControlFocusEverything , &focusEverything ) == noErr ) { @@ -339,6 +358,7 @@ static pascal OSStatus wxMacWindowControlEventHandler( EventHandlerCallRef handl #endif static bool inKillFocusEvent = false ; + if ( !inKillFocusEvent ) { inKillFocusEvent = true ; @@ -405,16 +425,16 @@ static pascal OSStatus wxMacWindowServiceEventHandler( EventHandlerCallRef handl if ( textCtrl->IsEditable() ) pasteTypes = cEvent.GetParameter< CFMutableArrayRef >( kEventParamServicePasteTypes , typeCFMutableArrayRef ) ; - static const OSType textDataTypes[] = { kTXNTextData /* , 'utxt' , 'PICT', 'MooV', 'AIFF' */ }; + static const OSType textDataTypes[] = { kTXNTextData /* , 'utxt', 'PICT', 'MooV', 'AIFF' */ }; for ( size_t i = 0 ; i < WXSIZEOF(textDataTypes) ; ++i ) { CFStringRef typestring = CreateTypeStringWithOSType(textDataTypes[i]); if ( typestring ) { if ( copyTypes ) - CFArrayAppendValue (copyTypes, typestring) ; + CFArrayAppendValue(copyTypes, typestring) ; if ( pasteTypes ) - CFArrayAppendValue (pasteTypes, typestring) ; + CFArrayAppendValue(pasteTypes, typestring) ; CFRelease( typestring ) ; } @@ -444,14 +464,14 @@ static pascal OSStatus wxMacWindowServiceEventHandler( EventHandlerCallRef handl { ScrapRef scrapRef = cEvent.GetParameter< ScrapRef > ( kEventParamScrapRef , typeScrapRef ) ; Size textSize, pastedSize ; - verify_noerr( GetScrapFlavorSize (scrapRef, kTXNTextData, &textSize) ) ; + verify_noerr( GetScrapFlavorSize(scrapRef, kTXNTextData, &textSize) ) ; textSize++ ; char *content = new char[textSize] ; - GetScrapFlavorData (scrapRef, kTXNTextData, &pastedSize, content ); - content[textSize-1] = 0 ; + GetScrapFlavorData(scrapRef, kTXNTextData, &pastedSize, content ); + content[textSize - 1] = 0 ; #if wxUSE_UNICODE - textCtrl->WriteText( wxString( content , wxConvLocal ) ); + textCtrl->WriteText( wxString( content , wxConvLocal ) ); #else textCtrl->WriteText( wxString( content ) ) ; #endif @@ -468,6 +488,205 @@ static pascal OSStatus wxMacWindowServiceEventHandler( EventHandlerCallRef handl return result ; } +pascal OSStatus wxMacUnicodeTextEventHandler( EventHandlerCallRef handler , EventRef event , void *data ) +{ + OSStatus result = eventNotHandledErr ; + wxWindowMac* focus = (wxWindowMac*) data ; + + wchar_t* uniChars = NULL ; + UInt32 when = EventTimeToTicks( GetEventTime( event ) ) ; + + UniChar* charBuf; + UInt32 dataSize = 0 ; + int numChars = 0 ; + UniChar buf[2] ; + if ( GetEventParameter( event, kEventParamTextInputSendText, typeUnicodeText, NULL, 0 , &dataSize, NULL ) == noErr ) + { + numChars = dataSize / sizeof( UniChar) ; + charBuf = buf ; + + if ( dataSize > sizeof(buf) ) + charBuf = new UniChar[ numChars ] ; + else + charBuf = buf ; + + uniChars = new wchar_t[ numChars ] ; + GetEventParameter( event, kEventParamTextInputSendText, typeUnicodeText, NULL, dataSize , NULL , charBuf ) ; +#if SIZEOF_WCHAR_T == 2 + uniChars = charBuf ; + memcpy( uniChars , charBuf , dataSize ) ; +#else + // the resulting string will never have more chars than the utf16 version, so this is safe + wxMBConvUTF16 converter ; + numChars = converter.MB2WC( uniChars , (const char*)charBuf , numChars ) ; +#endif + } + + switch ( GetEventKind( event ) ) + { + case kEventTextInputUpdateActiveInputArea : + { + // An IME input event may return several characters, but we need to send one char at a time to + // EVT_CHAR + for (int pos=0 ; pos < numChars ; pos++) + { + WXEVENTREF formerEvent = wxTheApp->MacGetCurrentEvent() ; + WXEVENTHANDLERCALLREF formerHandler = wxTheApp->MacGetCurrentEventHandlerCallRef() ; + wxTheApp->MacSetCurrentEvent( event , handler ) ; + + UInt32 message = (0 << 8) + ((char)uniChars[pos] ); + if ( wxTheApp->MacSendCharEvent( + focus , message , 0 , when , 0 , 0 , uniChars[pos] ) ) + { + result = noErr ; + } + + wxTheApp->MacSetCurrentEvent( formerEvent , formerHandler ) ; + } + } + break ; + case kEventTextInputUnicodeForKeyEvent : + { + UInt32 keyCode, modifiers ; + Point point ; + EventRef rawEvent ; + unsigned char charCode ; + + GetEventParameter( event, kEventParamTextInputSendKeyboardEvent, typeEventRef, NULL, sizeof(rawEvent), NULL, &rawEvent ) ; + GetEventParameter( rawEvent, kEventParamKeyMacCharCodes, typeChar, NULL, sizeof(char), NULL, &charCode ); + GetEventParameter( rawEvent, kEventParamKeyCode, typeUInt32, NULL, sizeof(UInt32), NULL, &keyCode ); + GetEventParameter( rawEvent, kEventParamKeyModifiers, typeUInt32, NULL, sizeof(UInt32), NULL, &modifiers ); + GetEventParameter( rawEvent, kEventParamMouseLocation, typeQDPoint, NULL, sizeof(Point), NULL, &point ); + + UInt32 message = (keyCode << 8) + charCode; + + // An IME input event may return several characters, but we need to send one char at a time to + // EVT_CHAR + for (int pos=0 ; pos < numChars ; pos++) + { + WXEVENTREF formerEvent = wxTheApp->MacGetCurrentEvent() ; + WXEVENTHANDLERCALLREF formerHandler = wxTheApp->MacGetCurrentEventHandlerCallRef() ; + wxTheApp->MacSetCurrentEvent( event , handler ) ; + + if ( wxTheApp->MacSendCharEvent( + focus , message , modifiers , when , point.h , point.v , uniChars[pos] ) ) + { + result = noErr ; + } + + wxTheApp->MacSetCurrentEvent( formerEvent , formerHandler ) ; + } + } + break; + default: + break ; + } + + delete [] uniChars ; + if ( charBuf != buf ) + delete [] charBuf ; + + return result ; +} + +static pascal OSStatus wxMacWindowCommandEventHandler( EventHandlerCallRef handler , EventRef event , void *data ) +{ + OSStatus result = eventNotHandledErr ; + wxWindowMac* focus = (wxWindowMac*) data ; + + HICommand command ; + + wxMacCarbonEvent cEvent( event ) ; + cEvent.GetParameter(kEventParamDirectObject,typeHICommand,&command) ; + + wxMenuItem* item = NULL ; + wxMenu* itemMenu = wxFindMenuFromMacCommand( command , item ) ; + int id = wxMacCommandToId( command.commandID ) ; + + if ( item ) + { + wxASSERT( itemMenu != NULL ) ; + + switch ( cEvent.GetKind() ) + { + case kEventProcessCommand : + { + if (item->IsCheckable()) + item->Check( !item->IsChecked() ) ; + + if ( itemMenu->SendEvent( id , item->IsCheckable() ? item->IsChecked() : -1 ) ) + result = noErr ; + else + { + wxCommandEvent event(wxEVT_COMMAND_MENU_SELECTED , id); + event.SetEventObject(focus); + event.SetInt(item->IsCheckable() ? item->IsChecked() : -1); + + if ( focus->GetEventHandler()->ProcessEvent(event) ) + result = noErr ; + } + } + break ; + + case kEventCommandUpdateStatus: + { + wxUpdateUIEvent event(id); + event.SetEventObject( itemMenu ); + + bool processed = false; + + // Try the menu's event handler + { + wxEvtHandler *handler = itemMenu->GetEventHandler(); + if ( handler ) + processed = handler->ProcessEvent(event); + } + + // Try the window the menu was popped up from + // (and up through the hierarchy) + if ( !processed ) + { + const wxMenuBase *menu = itemMenu; + while ( menu ) + { + wxWindow *win = menu->GetInvokingWindow(); + if ( win ) + { + processed = win->GetEventHandler()->ProcessEvent(event); + break; + } + + menu = menu->GetParent(); + } + } + + if ( !processed ) + { + processed = focus->GetEventHandler()->ProcessEvent(event); + } + + if ( processed ) + { + // if anything changed, update the changed attribute + if (event.GetSetText()) + itemMenu->SetLabel(id, event.GetText()); + if (event.GetSetChecked()) + itemMenu->Check(id, event.GetChecked()); + if (event.GetSetEnabled()) + itemMenu->Enable(id, event.GetEnabled()); + + result = noErr ; + } + } + break ; + + default : + break ; + } + } + return result ; +} + pascal OSStatus wxMacWindowEventHandler( EventHandlerCallRef handler , EventRef event , void *data ) { EventRef formerEvent = (EventRef) wxTheApp->MacGetCurrentEvent() ; @@ -477,6 +696,10 @@ pascal OSStatus wxMacWindowEventHandler( EventHandlerCallRef handler , EventRef switch ( GetEventClass( event ) ) { + case kEventClassCommand : + result = wxMacWindowCommandEventHandler( handler , event , data ) ; + break ; + case kEventClassControl : result = wxMacWindowControlEventHandler( handler, event, data ) ; break ; @@ -485,6 +708,10 @@ pascal OSStatus wxMacWindowEventHandler( EventHandlerCallRef handler , EventRef result = wxMacWindowServiceEventHandler( handler, event , data ) ; break ; + case kEventClassTextInput : + result = wxMacUnicodeTextEventHandler( handler , event , data ) ; + break ; + default : break ; } @@ -579,7 +806,7 @@ void wxWindowMac::MacControlUserPaneDrawProc(wxInt16 part) int x = 0 , y = 0; RgnHandle rgn = NewRgn() ; GetClip( rgn ) ; - MacWindowToRootWindow( &x,&y ) ; + MacWindowToRootWindow( &x, &y ) ; OffsetRgn( rgn , -x , -y ) ; wxMacWindowStateSaver sv( this ) ; SectRgn( rgn , (RgnHandle) MacGetVisibleRegion().GetWXHRGN() , rgn ) ; @@ -711,6 +938,7 @@ void wxWindowMac::Init() { m_peer = NULL ; m_frozenness = 0 ; + #if WXWIN_COMPATIBILITY_2_4 m_backgroundTransparent = false; #endif @@ -734,7 +962,6 @@ void wxWindowMac::Init() wxWindowBase::SetFont(wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT)); } -// Destructor wxWindowMac::~wxWindowMac() { SendDestroyEvent(); @@ -755,7 +982,7 @@ wxWindowMac::~wxWindowMac() break; } } -#endif // __WXUNIVERSAL__ +#endif // destroy children before destroying this window itself DestroyChildren(); @@ -807,35 +1034,35 @@ WXWidget wxWindowMac::GetHandle() const return (WXWidget) m_peer->GetControlRef() ; } - void wxWindowMac::MacInstallEventHandler( WXWidget control ) { - wxAssociateControlWithMacControl( (ControlRef) control , this ) ; - InstallControlEventHandler( (ControlRef) control , GetwxMacWindowEventHandlerUPP(), + wxAssociateControlWithMacControl( (ControlRef) control , this ) ; + InstallControlEventHandler( (ControlRef)control , GetwxMacWindowEventHandlerUPP(), GetEventTypeCount(eventList), eventList, this, (EventHandlerRef *)&m_macControlEventHandler); #if !TARGET_API_MAC_OSX if ( (ControlRef) control == m_peer->GetControlRef() ) { - m_peer->SetData(kControlEntireControl,kControlUserPaneDrawProcTag,GetwxMacControlUserPaneDrawProc()) ; - m_peer->SetData(kControlEntireControl,kControlUserPaneHitTestProcTag,GetwxMacControlUserPaneHitTestProc()) ; - m_peer->SetData(kControlEntireControl,kControlUserPaneTrackingProcTag,GetwxMacControlUserPaneTrackingProc()) ; - m_peer->SetData(kControlEntireControl,kControlUserPaneIdleProcTag,GetwxMacControlUserPaneIdleProc()) ; - m_peer->SetData(kControlEntireControl,kControlUserPaneKeyDownProcTag,GetwxMacControlUserPaneKeyDownProc()) ; - m_peer->SetData(kControlEntireControl,kControlUserPaneActivateProcTag,GetwxMacControlUserPaneActivateProc()) ; - m_peer->SetData(kControlEntireControl,kControlUserPaneFocusProcTag,GetwxMacControlUserPaneFocusProc()) ; - m_peer->SetData(kControlEntireControl,kControlUserPaneBackgroundProcTag,GetwxMacControlUserPaneBackgroundProc()) ; + m_peer->SetData(kControlEntireControl, kControlUserPaneDrawProcTag, GetwxMacControlUserPaneDrawProc()) ; + m_peer->SetData(kControlEntireControl, kControlUserPaneHitTestProcTag, GetwxMacControlUserPaneHitTestProc()) ; + m_peer->SetData(kControlEntireControl, kControlUserPaneTrackingProcTag, GetwxMacControlUserPaneTrackingProc()) ; + m_peer->SetData(kControlEntireControl, kControlUserPaneIdleProcTag, GetwxMacControlUserPaneIdleProc()) ; + m_peer->SetData(kControlEntireControl, kControlUserPaneKeyDownProcTag, GetwxMacControlUserPaneKeyDownProc()) ; + m_peer->SetData(kControlEntireControl, kControlUserPaneActivateProcTag, GetwxMacControlUserPaneActivateProc()) ; + m_peer->SetData(kControlEntireControl, kControlUserPaneFocusProcTag, GetwxMacControlUserPaneFocusProc()) ; + m_peer->SetData(kControlEntireControl, kControlUserPaneBackgroundProcTag, GetwxMacControlUserPaneBackgroundProc()) ; } #endif } // Constructor -bool wxWindowMac::Create(wxWindowMac *parent, wxWindowID id, - const wxPoint& pos, - const wxSize& size, - long style, - const wxString& name) +bool wxWindowMac::Create(wxWindowMac *parent, + wxWindowID id, + const wxPoint& pos, + const wxSize& size, + long style, + const wxString& name) { wxCHECK_MSG( parent, false, wxT("can't create wxWindowMac without parent") ); @@ -857,19 +1084,19 @@ bool wxWindowMac::Create(wxWindowMac *parent, wxWindowID id, | kControlHandlesTracking | kControlSupportsFocus | kControlWantsActivate - | kControlWantsIdle - ; + | kControlWantsIdle ; m_peer = new wxMacControl(this) ; - ::CreateUserPaneControl( MAC_WXHWND(GetParent()->MacGetTopLevelWindowRef()) , &bounds, features , m_peer->GetControlRefAddr() ); - + OSStatus err =::CreateUserPaneControl( MAC_WXHWND(GetParent()->MacGetTopLevelWindowRef()) , &bounds, features , m_peer->GetControlRefAddr() ); + verify_noerr( err ); - MacPostControlCreate(pos,size) ; + MacPostControlCreate(pos, size) ; } + #ifndef __WXUNIVERSAL__ // Don't give scrollbars to wxControls unless they ask for them - if ( (! IsKindOf(CLASSINFO(wxControl)) && ! IsKindOf(CLASSINFO(wxStatusBar))) || - (IsKindOf(CLASSINFO(wxControl)) && ( style & wxHSCROLL || style & wxVSCROLL))) + if ( (! IsKindOf(CLASSINFO(wxControl)) && ! IsKindOf(CLASSINFO(wxStatusBar))) + || (IsKindOf(CLASSINFO(wxControl)) && ((style & wxHSCROLL) || (style & wxVSCROLL)))) { MacCreateScrollBars( style ) ; } @@ -893,8 +1120,8 @@ void wxWindowMac::MacPostControlCreate(const wxPoint& pos, const wxSize& size) { wxASSERT_MSG( m_peer != NULL && m_peer->Ok() , wxT("No valid mac control") ) ; - m_peer->SetReference( (long) this ) ; - GetParent()->AddChild(this); + m_peer->SetReference( (long)this ) ; + GetParent()->AddChild( this ); MacInstallEventHandler( (WXWidget) m_peer->GetControlRef() ); @@ -968,7 +1195,7 @@ void wxWindowMac::DoSetWindowVariant( wxWindowVariant variant ) break ; } - m_peer->SetData(kControlEntireControl, kControlSizeTag,&size ) ; + m_peer->SetData(kControlEntireControl, kControlSizeTag, &size ) ; wxFont font ; font.MacCreateThemeFont( themeFont ) ; @@ -983,7 +1210,7 @@ void wxWindowMac::MacUpdateControlFont() bool wxWindowMac::SetFont(const wxFont& font) { - bool retval = wxWindowBase::SetFont( font ) ; + bool retval = wxWindowBase::SetFont( font ); MacUpdateControlFont() ; @@ -992,12 +1219,12 @@ bool wxWindowMac::SetFont(const wxFont& font) bool wxWindowMac::SetForegroundColour(const wxColour& col ) { - if ( !wxWindowBase::SetForegroundColour(col) ) - return false ; + bool retval = wxWindowBase::SetForegroundColour( col ); - MacUpdateControlFont() ; + if (retval) + MacUpdateControlFont(); - return true ; + return retval; } bool wxWindowMac::SetBackgroundColour(const wxColour& col ) @@ -1007,15 +1234,15 @@ bool wxWindowMac::SetBackgroundColour(const wxColour& col ) wxBrush brush ; wxColour newCol(GetBackgroundColour()); - if ( newCol == wxSystemSettings::GetColour(wxSYS_COLOUR_APPWORKSPACE) ) + + if ( newCol == wxSystemSettings::GetColour( wxSYS_COLOUR_APPWORKSPACE ) ) brush.MacSetTheme( kThemeBrushDocumentWindowBackground ) ; - else if ( newCol == wxSystemSettings::GetColour(wxSYS_COLOUR_3DFACE ) ) + else if ( newCol == wxSystemSettings::GetColour( wxSYS_COLOUR_3DFACE ) ) brush.MacSetTheme( kThemeBrushDialogBackgroundActive ) ; else brush.SetColour( newCol ) ; MacSetBackgroundBrush( brush ) ; - MacUpdateControlFont() ; return true ; @@ -1029,14 +1256,22 @@ void wxWindowMac::MacSetBackgroundBrush( const wxBrush &brush ) bool wxWindowMac::MacCanFocus() const { - // there is currently no way to determine whether the window is running in full keyboard - // access mode, therefore we cannot rely on these features, yet the only other way would be - // to issue a SetKeyboardFocus event and verify after whether it succeeded, this would risk problems - // in event handlers... - UInt32 features = 0 ; - m_peer->GetFeatures( & features ) ; + // TODO : evaluate performance hits by looking up this value, eventually cache the results for a 1 sec or so + // CAUTION : the value returned currently is 0 or 2, I've also found values of 1 having the same meaning, but the value range + // is nowhere documented + Boolean keyExistsAndHasValidFormat ; + CFIndex fullKeyboardAccess = CFPreferencesGetAppIntegerValue ( CFSTR("AppleKeyboardUIMode" ) , + kCFPreferencesCurrentApplication, &keyExistsAndHasValidFormat); + + if ( keyExistsAndHasValidFormat && fullKeyboardAccess > 0 ) + return true ; + else + { + UInt32 features = 0 ; + m_peer->GetFeatures( &features ) ; - return features & ( kControlSupportsFocus | kControlGetsFocusOnClick ) ; + return features & ( kControlSupportsFocus | kControlGetsFocusOnClick ) ; + } } void wxWindowMac::SetFocus() @@ -1054,39 +1289,42 @@ void wxWindowMac::SetFocus() if ( err == errCouldntSetFocus ) return ; - // enable for patch 1376506 - perhaps? (Stefan's version) -#if 0 SetUserFocusWindow( (WindowRef)MacGetTopLevelWindowRef() ); -#endif #if !TARGET_API_MAC_OSX // emulate carbon events when running under CarbonLib where they are not natively available if ( former ) { EventRef evRef = NULL ; - verify_noerr( MacCreateEvent( NULL , kEventClassControl , kEventControlSetFocusPart , TicksToEventTime( TickCount() ) , kEventAttributeUserEvent , - &evRef ) ); + + err = MacCreateEvent( + NULL , kEventClassControl , kEventControlSetFocusPart , TicksToEventTime( TickCount() ) , + kEventAttributeUserEvent , &evRef ); + verify_noerr( err ); wxMacCarbonEvent cEvent( evRef ) ; cEvent.SetParameter( kEventParamDirectObject , (ControlRef) former->GetHandle() ) ; cEvent.SetParameter(kEventParamControlPart , typeControlPartCode , kControlFocusNoPart ) ; wxMacWindowEventHandler( NULL , evRef , former ) ; - ReleaseEvent(evRef) ; + ReleaseEvent( evRef ) ; } // send new focus event { EventRef evRef = NULL ; - verify_noerr( MacCreateEvent( NULL , kEventClassControl , kEventControlSetFocusPart , TicksToEventTime( TickCount() ) , kEventAttributeUserEvent , - &evRef ) ); + + err = MacCreateEvent( + NULL , kEventClassControl , kEventControlSetFocusPart , TicksToEventTime( TickCount() ) , + kEventAttributeUserEvent , &evRef ); + verify_noerr( err ); wxMacCarbonEvent cEvent( evRef ) ; cEvent.SetParameter( kEventParamDirectObject , (ControlRef) GetHandle() ) ; cEvent.SetParameter(kEventParamControlPart , typeControlPartCode , kControlFocusNextPart ) ; wxMacWindowEventHandler( NULL , evRef , this ) ; - ReleaseEvent(evRef) ; + ReleaseEvent( evRef ) ; } #endif } @@ -1116,7 +1354,7 @@ void wxWindowMac::SetDropTarget(wxDropTarget *pDropTarget) m_dropTarget = pDropTarget; if ( m_dropTarget != NULL ) { - // TODO + // TODO: } } @@ -1125,7 +1363,7 @@ void wxWindowMac::SetDropTarget(wxDropTarget *pDropTarget) // Old style file-manager drag&drop void wxWindowMac::DragAcceptFiles(bool accept) { - // TODO + // TODO: } // Returns the size of the native control. In the case of the toplevel window @@ -1134,15 +1372,16 @@ void wxWindowMac::DragAcceptFiles(bool accept) void wxWindowMac::MacGetPositionAndSizeFromControl(int& x, int& y, int& w, int& h) const { - wxFAIL_MSG( wxT("Not supported anymore") ) ; + wxFAIL_MSG( wxT("Not currently supported") ) ; } // From a wx position / size calculate the appropriate size of the native control -bool wxWindowMac::MacGetBoundsForControl(const wxPoint& pos, - const wxSize& size, - int& x, int& y, - int& w, int& h , bool adjustOrigin ) const +bool wxWindowMac::MacGetBoundsForControl( + const wxPoint& pos, + const wxSize& size, + int& x, int& y, + int& w, int& h , bool adjustOrigin ) const { bool isCompositing = MacGetTopLevelWindow()->MacUsesCompositing() ; @@ -1150,9 +1389,10 @@ bool wxWindowMac::MacGetBoundsForControl(const wxPoint& pos, x = (int)pos.x; y = (int)pos.y; - // todo the default calls may be used as soon as PostCreateControl Is moved here - w = wxMax(size.x,0) ; // WidthDefault( size.x ); - h = wxMax(size.y,0) ; // HeightDefault( size.y ) ; + + // TODO: the default calls may be used as soon as PostCreateControl Is moved here + w = wxMax(size.x, 0) ; // WidthDefault( size.x ); + h = wxMax(size.y, 0) ; // HeightDefault( size.y ) ; if ( !isCompositing ) GetParent()->MacWindowToRootWindow( &x , &y ) ; @@ -1226,24 +1466,21 @@ void wxWindowMac::DoGetPosition(int *x, int *y) const void wxWindowMac::DoScreenToClient(int *x, int *y) const { WindowRef window = (WindowRef) MacGetTopLevelWindowRef() ; + wxCHECK_RET( window , wxT("TopLevel Window missing") ) ; - wxCHECK_RET( window , wxT("TopLevel Window Missing") ) ; - - { - Point localwhere = {0, 0} ; + Point localwhere = { 0, 0 } ; - if (x) - localwhere.h = *x ; - if (y) - localwhere.v = *y ; + if (x) + localwhere.h = *x ; + if (y) + localwhere.v = *y ; - QDGlobalToLocalPoint( GetWindowPort( window ) , &localwhere ) ; + QDGlobalToLocalPoint( GetWindowPort( window ) , &localwhere ) ; - if (x) - *x = localwhere.h ; - if (y) - *y = localwhere.v ; - } + if (x) + *x = localwhere.h ; + if (y) + *y = localwhere.v ; MacRootWindowToWindow( x , y ) ; @@ -1257,7 +1494,7 @@ void wxWindowMac::DoScreenToClient(int *x, int *y) const void wxWindowMac::DoClientToScreen(int *x, int *y) const { WindowRef window = (WindowRef) MacGetTopLevelWindowRef() ; - wxCHECK_RET( window , wxT("TopLevel Window Missing") ) ; + wxCHECK_RET( window , wxT("TopLevel window missing") ) ; wxPoint origin = GetClientAreaOrigin() ; if (x) @@ -1267,20 +1504,18 @@ void wxWindowMac::DoClientToScreen(int *x, int *y) const MacWindowToRootWindow( x , y ) ; - { - Point localwhere = { 0,0 }; - if (x) - localwhere.h = * x ; - if (y) - localwhere.v = * y ; + Point localwhere = { 0, 0 }; + if (x) + localwhere.h = *x ; + if (y) + localwhere.v = *y ; - QDLocalToGlobalPoint( GetWindowPort( window ) , &localwhere ) ; + QDLocalToGlobalPoint( GetWindowPort( window ) , &localwhere ) ; - if (x) - *x = localwhere.h ; - if (y) - *y = localwhere.v ; - } + if (x) + *x = localwhere.h ; + if (y) + *y = localwhere.v ; } void wxWindowMac::MacClientToRootWindow( int *x , int *y ) const @@ -1308,6 +1543,7 @@ void wxWindowMac::MacRootWindowToClient( int *x , int *y ) const void wxWindowMac::MacWindowToRootWindow( int *x , int *y ) const { wxPoint pt ; + if (x) pt.x = *x ; if (y) @@ -1393,16 +1629,17 @@ void wxWindowMac::MacRootWindowToWindow( short *x , short *y ) const void wxWindowMac::MacGetContentAreaInset( int &left , int &top , int &right , int &bottom ) { RgnHandle rgn = NewRgn() ; + if ( m_peer->GetRegion( kControlContentMetaPart , rgn ) == noErr ) { - Rect structure ; - Rect content ; + Rect structure, content ; + GetRegionBounds( rgn , &content ) ; m_peer->GetRect( &structure ) ; OffsetRect( &structure, -structure.left , -structure.top ) ; left = content.left - structure.left ; - top = content.top - structure.top ; + top = content.top - structure.top ; right = structure.right - content.right ; bottom = structure.bottom - content.bottom ; } @@ -1410,6 +1647,7 @@ void wxWindowMac::MacGetContentAreaInset( int &left , int &top , int &right , in { left = top = right = bottom = 0 ; } + DisposeRgn( rgn ) ; } @@ -1420,16 +1658,16 @@ wxSize wxWindowMac::DoGetSizeFromClientSize( const wxSize & size ) const RgnHandle rgn = NewRgn() ; if ( m_peer->GetRegion( kControlContentMetaPart , rgn ) == noErr ) { - Rect content ; - Rect structure ; + Rect content, structure ; GetRegionBounds( rgn , &content ) ; - m_peer->GetRect( &structure ) ; + // structure is in parent coordinates, but we only need width and height, so it's ok sizeTotal.x += (structure.right - structure.left) - (content.right - content.left) ; - sizeTotal.y += (structure.bottom - structure.top) - (content.bottom - content.top ) ; + sizeTotal.y += (structure.bottom - structure.top) - (content.bottom - content.top) ; } + DisposeRgn( rgn ) ; sizeTotal.x += MacGetLeftBorderSize() + MacGetRightBorderSize() ; @@ -1464,7 +1702,6 @@ void wxWindowMac::DoGetClientSize( int *x, int *y ) const *x = ww; if (y) *y = hh; - } bool wxWindowMac::SetCursor(const wxCursor& cursor) @@ -1493,13 +1730,14 @@ bool wxWindowMac::SetCursor(const wxCursor& cursor) CGrafPtr savePort ; Boolean swapped = QDSwapPort( GetWindowPort( window ) , &savePort ) ; - // TODO If we ever get a GetCurrentEvent.. replacement for the mouse - // position, use it... + // TODO: If we ever get a GetCurrentEvent... replacement + // for the mouse position, use it... Point pt ; - GetMouse( &pt ) ; ControlPartCode part ; ControlRef control ; + + GetMouse( &pt ) ; control = wxMacFindControlUnderMouse( tlw , pt , window , &part ) ; if ( control ) mouseWin = wxFindControlFromMacControl( control ) ; @@ -1523,7 +1761,8 @@ bool wxWindowMac::DoPopupMenu(wxMenu *menu, int x, int y) if ( x == -1 && y == -1 ) { wxPoint mouse = wxGetMousePosition(); - x = mouse.x; y = mouse.y; + x = mouse.x; + y = mouse.y; } else { @@ -1531,22 +1770,26 @@ bool wxWindowMac::DoPopupMenu(wxMenu *menu, int x, int y) } menu->MacBeforeDisplay( true ) ; - long menuResult = ::PopUpMenuSelect((MenuHandle) menu->GetHMenu() ,y,x, 0) ; + long menuResult = ::PopUpMenuSelect((MenuHandle) menu->GetHMenu() , y, x, 0) ; if ( HiWord(menuResult) != 0 ) { - MenuCommand id ; - GetMenuItemCommandID( GetMenuHandle(HiWord(menuResult)) , LoWord(menuResult) , &id ) ; + MenuCommand macid; + GetMenuItemCommandID( GetMenuHandle(HiWord(menuResult)) , LoWord(menuResult) , &macid ); + int id = wxMacCommandToId( macid ); wxMenuItem* item = NULL ; wxMenu* realmenu ; - item = menu->FindItem(id, &realmenu) ; - if (item->IsCheckable()) - item->Check( !item->IsChecked() ) ; + item = menu->FindItem( id, &realmenu ) ; + if ( item ) + { + if (item->IsCheckable()) + item->Check( !item->IsChecked() ) ; - menu->SendEvent( id , item->IsCheckable() ? item->IsChecked() : -1 ) ; + menu->SendEvent( id , item->IsCheckable() ? item->IsChecked() : -1 ) ; + } } - menu->MacAfterDisplay( true ) ; - menu->SetInvokingWindow(NULL); + menu->MacAfterDisplay( true ) ; + menu->SetInvokingWindow( NULL ); return true; } @@ -1566,7 +1809,7 @@ void wxWindowMac::DoSetToolTip(wxToolTip *tooltip) m_tooltip->SetWindow(this); } -#endif // wxUSE_TOOLTIPS +#endif void wxWindowMac::MacInvalidateBorders() { @@ -1587,16 +1830,18 @@ void wxWindowMac::MacInvalidateBorders() // now we know that we have something to do at all // as the borders are drawn on the parent we have to properly invalidate all these areas - RgnHandle updateInner = NewRgn() , - updateOuter = NewRgn() ; + RgnHandle updateInner , updateOuter; + Rect rect ; // this rectangle is in HIViewCoordinates under OSX and in Window Coordinates under Carbon - Rect rect ; + updateInner = NewRgn() ; + updateOuter = NewRgn() ; + m_peer->GetRect( &rect ) ; - RectRgn( updateInner , &rect ) ; + RectRgn( updateInner, &rect ) ; InsetRect( &rect , -outerBorder , -outerBorder ) ; - RectRgn( updateOuter , &rect ) ; - DiffRgn( updateOuter , updateInner ,updateOuter ) ; + RectRgn( updateOuter, &rect ) ; + DiffRgn( updateOuter, updateInner , updateOuter ) ; #ifdef __WXMAC_OSX__ GetParent()->m_peer->SetNeedsDisplay( updateOuter ) ; @@ -1606,103 +1851,8 @@ void wxWindowMac::MacInvalidateBorders() InvalWindowRgn( tlw , updateOuter ) ; #endif - DisposeRgn(updateOuter) ; - DisposeRgn(updateInner) ; - -#if 0 - RgnHandle updateInner = NewRgn() , updateOuter = NewRgn() ; - RectRgn( updateInner , &rect ) ; - InsetRect( &rect , -4 , -4 ) ; - RectRgn( updateOuter , &rect ) ; - DiffRgn( updateOuter , updateInner ,updateOuter ) ; - wxPoint parent(0,0); - GetParent()->MacWindowToRootWindow( &parent.x , &parent.y ) ; - parent -= GetParent()->GetClientAreaOrigin() ; - OffsetRgn( updateOuter , -parent.x , -parent.y ) ; - GetParent()->m_peer->SetNeedsDisplay( true , updateOuter ) ; - DisposeRgn(updateOuter) ; - DisposeRgn(updateInner) ; -#endif - -#if 0 - if ( m_peer ) - { - // deleting a window while it is shown invalidates the region occupied by border or - // focus - - if ( IsShown() && ( outerBorder > 0 ) ) - { - // as the borders are drawn on the parent we have to properly invalidate all these areas - RgnHandle updateInner = NewRgn() , updateOuter = NewRgn() , updateTotal = NewRgn() ; - - Rect rect ; - - m_peer->GetRect( &rect ) ; - RectRgn( updateInner , &rect ) ; - InsetRect( &rect , -outerBorder , -outerBorder ) ; - RectRgn( updateOuter , &rect ) ; - DiffRgn( updateOuter , updateInner ,updateOuter ) ; - wxPoint parent(0,0); - GetParent()->MacWindowToRootWindow( &parent.x , &parent.y ) ; - parent -= GetParent()->GetClientAreaOrigin() ; - OffsetRgn( updateOuter , -parent.x , -parent.y ) ; - CopyRgn( updateOuter , updateTotal ) ; - - GetParent()->m_peer->SetNeedsDisplay( true , updateTotal ) ; - DisposeRgn(updateOuter) ; - DisposeRgn(updateInner) ; - DisposeRgn(updateTotal) ; - } - } -#endif - -#if 0 - Rect r = wxMacGetBoundsForControl(this , wxPoint( actualX,actualY), wxSize( actualWidth, actualHeight ) , false ) ; - - int outerBorder = MacGetLeftBorderSize() ; - if ( m_peer->NeedsFocusRect() && m_peer->HasFocus() ) - outerBorder += 4 ; - - if ( vis && ( outerBorder > 0 ) ) - { - // as the borders are drawn on the parent we have to properly invalidate all these areas - RgnHandle updateInner = NewRgn() , updateOuter = NewRgn() , updateTotal = NewRgn() ; - - Rect rect ; - - m_peer->GetRect( &rect ) ; - RectRgn( updateInner , &rect ) ; - InsetRect( &rect , -outerBorder , -outerBorder ) ; - RectRgn( updateOuter , &rect ) ; - DiffRgn( updateOuter , updateInner ,updateOuter ) ; - /* - wxPoint parent(0,0); -#if TARGET_API_MAC_OSX - // no offsetting needed when compositing -#else - GetParent()->MacWindowToRootWindow( &parent.x , &parent.y ) ; - parent -= GetParent()->GetClientAreaOrigin() ; - OffsetRgn( updateOuter , -parent.x , -parent.y ) ; -#endif - */ - CopyRgn( updateOuter , updateTotal ) ; - - rect = r ; - RectRgn( updateInner , &rect ) ; - InsetRect( &rect , -outerBorder , -outerBorder ) ; - RectRgn( updateOuter , &rect ) ; - DiffRgn( updateOuter , updateInner ,updateOuter ) ; -/* - OffsetRgn( updateOuter , -parent.x , -parent.y ) ; -*/ - UnionRgn( updateOuter , updateTotal , updateTotal ) ; - - GetParent()->m_peer->SetNeedsDisplay( updateTotal ) ; - DisposeRgn(updateOuter) ; - DisposeRgn(updateInner) ; - DisposeRgn(updateTotal) ; - } -#endif + DisposeRgn( updateOuter ) ; + DisposeRgn( updateInner ) ; } void wxWindowMac::DoMoveWindow(int x, int y, int width, int height) @@ -1736,8 +1886,7 @@ void wxWindowMac::DoMoveWindow(int x, int y, int width, int height) if ((m_maxHeight != -1) && (actualHeight > m_maxHeight)) actualHeight = m_maxHeight; - bool doMove = false ; - bool doResize = false ; + bool doMove = false, doResize = false ; if ( actualX != former_x || actualY != former_y ) doMove = true ; @@ -1771,7 +1920,7 @@ void wxWindowMac::DoMoveWindow(int x, int y, int width, int height) MacRepositionScrollBars() ; if ( doMove ) { - wxPoint point(actualX,actualY); + wxPoint point(actualX, actualY); wxMoveEvent event(point, m_windowId); event.SetEventObject(this); GetEventHandler()->ProcessEvent(event) ; @@ -1795,13 +1944,15 @@ wxSize wxWindowMac::DoGetBestSize() const Rect bestsize = { 0 , 0 , 0 , 0 } ; int bestWidth, bestHeight ; - m_peer->GetBestRect( &bestsize ) ; + m_peer->GetBestRect( &bestsize ) ; if ( EmptyRect( &bestsize ) ) { - bestsize.left = bestsize.top = 0 ; - bestsize.right = 16 ; + bestsize.left = + bestsize.top = 0 ; + bestsize.right = bestsize.bottom = 16 ; + if ( IsKindOf( CLASSINFO( wxScrollBar ) ) ) { bestsize.bottom = 16 ; @@ -1811,7 +1962,7 @@ wxSize wxWindowMac::DoGetBestSize() const { bestsize.bottom = 24 ; } -#endif // wxUSE_SPINBTN +#endif else { // return wxWindowBase::DoGetBestSize() ; @@ -1838,9 +1989,9 @@ void wxWindowMac::DoSetSize(int x, int y, int width, int height, int sizeFlags) { // get the current size and position... int currentX, currentY; - GetPosition(¤tX, ¤tY); + int currentW, currentH; - int currentW,currentH; + GetPosition(¤tX, ¤tY); GetSize(¤tW, ¤tH); // ... and don't do anything (avoiding flicker) if it's already ok @@ -1849,15 +2000,19 @@ void wxWindowMac::DoSetSize(int x, int y, int width, int height, int sizeFlags) { // TODO: REMOVE MacRepositionScrollBars() ; // we might have a real position shift + return; } - if ( x == wxDefaultCoord && !(sizeFlags & wxSIZE_ALLOW_MINUS_ONE) ) - x = currentX; - if ( y == wxDefaultCoord && !(sizeFlags & wxSIZE_ALLOW_MINUS_ONE) ) - y = currentY; + if ( !(sizeFlags & wxSIZE_ALLOW_MINUS_ONE) ) + { + if ( x == wxDefaultCoord ) + x = currentX; + if ( y == wxDefaultCoord ) + y = currentY; + } - AdjustForParentClientOrigin(x, y, sizeFlags); + AdjustForParentClientOrigin( x, y, sizeFlags ); wxSize size = wxDefaultSize; if ( width == wxDefaultCoord ) @@ -1879,10 +2034,8 @@ void wxWindowMac::DoSetSize(int x, int y, int width, int height, int sizeFlags) if ( sizeFlags & wxSIZE_AUTO_HEIGHT ) { if ( size.x == wxDefaultCoord ) - { size = DoGetBestSize(); - } - //else: already called DoGetBestSize() above + // else: already called DoGetBestSize() above height = size.y; } @@ -1893,7 +2046,7 @@ void wxWindowMac::DoSetSize(int x, int y, int width, int height, int sizeFlags) } } - DoMoveWindow(x, y, width, height); + DoMoveWindow( x, y, width, height ); } wxPoint wxWindowMac::GetClientAreaOrigin() const @@ -1906,8 +2059,10 @@ wxPoint wxWindowMac::GetClientAreaOrigin() const } else { - content.left = content.top = 0 ; + content.left = + content.top = 0 ; } + DisposeRgn( rgn ) ; return wxPoint( content.left + MacGetLeftBorderSize() , content.top + MacGetTopBorderSize() ); @@ -1949,12 +2104,13 @@ bool wxWindowMac::Show(bool show) if ( !wxWindowBase::Show(show) ) return false; - // TODO use visibilityChanged Carbon Event for OSX + // TODO: use visibilityChanged Carbon Event for OSX if ( m_peer ) m_peer->SetVisibility( show , true ) ; if ( former != MacIsReallyShown() ) MacPropagateVisibilityChanged() ; + return true; } @@ -2023,7 +2179,7 @@ void wxWindowMac::MacPropagateHiliteChanged() while ( node ) { child = node->GetData(); - // if ( child->IsEnabled() ) + if (child /* && child->IsEnabled() */) child->MacPropagateHiliteChanged() ; node = node->GetNext(); @@ -2063,7 +2219,7 @@ bool wxWindowMac::MacIsReallyShown() #endif wxWindow* win = this ; - while ( win->IsShown() ) + while ( win->IsShown() ) { if ( win->IsTopLevel() ) return true ; @@ -2143,6 +2299,7 @@ void wxWindowMac::Refresh(bool eraseBack, const wxRect *rect) if ( rect ) { Rect r ; + wxMacRectToNative( rect , &r ) ; m_peer->SetNeedsDisplay( &r ) ; } @@ -2166,7 +2323,7 @@ void wxWindowMac::Freeze() void wxWindowMac::Thaw() { #if TARGET_API_MAC_OSX - wxASSERT_MSG( m_frozenness > 0, _T("Thaw() without matching Freeze()") ); + wxASSERT_MSG( m_frozenness > 0, wxT("Thaw() without matching Freeze()") ); if ( !--m_frozenness ) { @@ -2186,7 +2343,7 @@ wxWindowMac *wxGetActiveWindow() } // Coordinates relative to the window -void wxWindowMac::WarpPointer (int x_pos, int y_pos) +void wxWindowMac::WarpPointer(int x_pos, int y_pos) { // We really don't move the mouse programmatically under Mac. } @@ -2195,8 +2352,9 @@ void wxWindowMac::OnEraseBackground(wxEraseEvent& event) { if ( MacGetTopLevelWindow() == NULL ) return ; + #if TARGET_API_MAC_OSX - if ( MacGetTopLevelWindow()->MacUsesCompositing() && (m_macBackgroundBrush.Ok() == false || m_macBackgroundBrush.GetStyle() == wxTRANSPARENT ) ) + if ( MacGetTopLevelWindow()->MacUsesCompositing() && (!m_macBackgroundBrush.Ok() || m_macBackgroundBrush.GetStyle() == wxTRANSPARENT ) ) { event.Skip() ; } @@ -2290,8 +2448,8 @@ void wxWindowMac::MacPaintBorders( int leftOrigin , int rightOrigin ) bool hasFocus = m_peer->NeedsFocusRect() && m_peer->HasFocus() ; bool hasBothScrollbars = (m_hScrollBar && m_hScrollBar->IsShown()) && (m_vScrollBar && m_vScrollBar->IsShown()) ; - m_peer->GetRect( &rect ) ; // back to the surrounding frame rectangle + m_peer->GetRect( &rect ) ; InsetRect( &rect, -1 , -1 ) ; #if wxMAC_USE_CORE_GRAPHICS && MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_3 @@ -2301,7 +2459,7 @@ void wxWindowMac::MacPaintBorders( int leftOrigin , int rightOrigin ) rect.bottom - rect.top ) ; HIThemeFrameDrawInfo info ; - memset( &info, 0 , sizeof( info ) ) ; + memset( &info, 0 , sizeof(info) ) ; info.version = 0 ; info.kind = 0 ; @@ -2383,20 +2541,15 @@ void wxWindowMac::RemoveChild( wxWindowBase *child ) void wxWindowMac::SetScrollbar(int orient, int pos, int thumbVisible, int range, bool refresh) { + bool showScroller; + if ( orient == wxHORIZONTAL ) { if ( m_hScrollBar ) { - if ( range == 0 || thumbVisible >= range ) - { - if ( m_hScrollBar->IsShown() ) - m_hScrollBar->Show(false) ; - } - else - { - if ( !m_hScrollBar->IsShown() ) - m_hScrollBar->Show(true) ; - } + showScroller = ((range != 0) && (range > thumbVisible)); + if ( m_hScrollBar->IsShown() != showScroller ) + m_hScrollBar->Show( showScroller ) ; m_hScrollBar->SetScrollbar( pos , thumbVisible , range , thumbVisible , refresh ) ; } @@ -2405,16 +2558,9 @@ void wxWindowMac::SetScrollbar(int orient, int pos, int thumbVisible, { if ( m_vScrollBar ) { - if ( range == 0 || thumbVisible >= range ) - { - if ( m_vScrollBar->IsShown() ) - m_vScrollBar->Show(false) ; - } - else - { - if ( !m_vScrollBar->IsShown() ) - m_vScrollBar->Show(true) ; - } + showScroller = ((range != 0) && (range > thumbVisible)); + if ( m_vScrollBar->IsShown() != showScroller ) + m_vScrollBar->Show( showScroller ) ; m_vScrollBar->SetScrollbar( pos , thumbVisible , range , thumbVisible , refresh ) ; } @@ -2426,7 +2572,7 @@ void wxWindowMac::SetScrollbar(int orient, int pos, int thumbVisible, // Does a physical scroll void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect) { - if ( dx == 0 && dy ==0 ) + if ( dx == 0 && dy == 0 ) return ; int width , height ; @@ -2437,14 +2583,14 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect) { // note there currently is a bug in OSX which makes inefficient refreshes in case an entire control // area is scrolled, this does not occur if width and height are 2 pixels less, - // TODO write optimal workaround - wxRect scrollrect( MacGetLeftBorderSize() , MacGetTopBorderSize() , width , height ) ; + // TODO: write optimal workaround + wxRect scrollrect( MacGetLeftBorderSize() , MacGetTopBorderSize() , width , height ) ; if ( rect ) scrollrect.Intersect( *rect ) ; if ( m_peer->GetNeedsDisplay() ) { - // becuase HIViewScrollRect does not scroll the already invalidated area we have two options + // because HIViewScrollRect does not scroll the already invalidated area we have two options: // either immediate redraw or full invalidate #if 1 // is the better overall solution, as it does not slow down scrolling @@ -2463,7 +2609,7 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect) // as the native control might be not a 0/0 wx window coordinates, we have to offset scrollrect.Offset( -MacGetLeftBorderSize() , -MacGetTopBorderSize() ) ; - m_peer->ScrollRect( (&scrollrect) , dx , dy ) ; + m_peer->ScrollRect( &scrollrect , dx , dy ) ; // becuase HIViewScrollRect does not scroll the already invalidated area we have two options // either immediate redraw or full invalidate @@ -2479,15 +2625,14 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect) else #endif Update() ; - #endif } else #endif { - wxPoint pos; - pos.x = pos.y = 0; + pos.x = + pos.y = 0; Rect scrollrect; RgnHandle updateRgn = NewRgn() ; @@ -2517,7 +2662,7 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect) RgnHandle scrollRgn = NewRgn() ; RectRgn( scrollRgn , &scrollrect ) ; GetWindowUpdateRgn( rootWindow , formerUpdateRgn ) ; - Point pt = {0,0} ; + Point pt = {0, 0} ; LocalToGlobal( &pt ) ; OffsetRgn( formerUpdateRgn , -pt.h , -pt.v ) ; SectRgn( formerUpdateRgn , scrollRgn , formerUpdateRgn ) ; @@ -2526,10 +2671,10 @@ void wxWindowMac::ScrollWindow(int dx, int dy, const wxRect *rect) { MacOffsetRgn( formerUpdateRgn , dx , dy ) ; SectRgn( formerUpdateRgn , scrollRgn , formerUpdateRgn ) ; - InvalWindowRgn( rootWindow, formerUpdateRgn ) ; + InvalWindowRgn( rootWindow, formerUpdateRgn ) ; } - InvalWindowRgn(rootWindow , updateRgn ) ; + InvalWindowRgn(rootWindow, updateRgn ) ; DisposeRgn( updateRgn ) ; DisposeRgn( formerUpdateRgn ) ; DisposeRgn( scrollRgn ) ; @@ -2618,16 +2763,6 @@ void wxWindowMac::OnSetFocus( wxFocusEvent& event ) //wxChildFocusEvent eventFocus(this); //(void)GetEventHandler()->ProcessEvent(eventFocus); - bool bIsFocusEvent = (event.GetEventType() == wxEVT_SET_FOCUS); - - // enable for patch 1376506 - perhaps? -#if 0 - if ( bIsFocusEvent ) - SetUserFocusWindow( GetControlOwner( GetPeer()->GetControlRef() ) ); - else - SetUserFocusWindow( kUserFocusAuto ); -#endif - if ( MacGetTopLevelWindow() && m_peer->NeedsFocusRect() ) { #if wxMAC_USE_CORE_GRAPHICS @@ -2643,7 +2778,7 @@ void wxWindowMac::OnSetFocus( wxFocusEvent& event ) wxTopLevelWindowMac* top = MacGetTopLevelWindow(); if ( top ) { - wxPoint pt(0,0) ; + wxPoint pt(0, 0) ; wxMacControl::Convert( &pt , GetParent()->m_peer , top->m_peer ) ; rect.left += pt.x ; rect.right += pt.x ; @@ -2651,6 +2786,7 @@ void wxWindowMac::OnSetFocus( wxFocusEvent& event ) rect.bottom += pt.y ; } + bool bIsFocusEvent = (event.GetEventType() == wxEVT_SET_FOCUS); DrawThemeFocusRect( &rect , bIsFocusEvent ) ; if ( !bIsFocusEvent ) { @@ -2782,6 +2918,7 @@ const wxRect&wxWindowMac:: MacGetClippedRectWithOuterStructure() const const wxRegion& wxWindowMac::MacGetVisibleRegion( bool includeOuterStructures ) { static wxRegion emptyrgn ; + if ( !m_isBeingDeleted && MacIsReallyShown() /*m_peer->IsVisible() */ ) { MacUpdateClippedRects() ; @@ -2829,6 +2966,7 @@ void wxWindowMac::MacUpdateClippedRects() const wxSize size ; const wxWindow* child = this ; const wxWindow* parent = NULL ; + while ( !child->IsTopLevel() && ( parent = child->GetParent() ) != NULL ) { if ( parent->MacIsChildOfClientArea(child) ) @@ -2984,7 +3122,7 @@ bool wxWindowMac::MacDoRedraw( WXHRGN updatergnr , long time ) wxWindowDC dc(this) ; dc.SetClippingRegion(wxRegion(updatergn)); wxMacPortSetter helper(&dc) ; - child->MacPaintBorders(0, 0) ; + child->MacPaintBorders(0, 0) ; } } } @@ -3031,10 +3169,10 @@ void wxWindowMac::MacCreateScrollBars( long style ) int width, height ; GetClientSize( &width , &height ) ; - wxPoint vPoint(width-scrlsize, 0) ; + wxPoint vPoint(width - scrlsize, 0) ; wxSize vSize(scrlsize, height - adjust) ; - wxPoint hPoint(0 , height-scrlsize ) ; - wxSize hSize( width - adjust, scrlsize) ; + wxPoint hPoint(0, height - scrlsize) ; + wxSize hSize(width - adjust, scrlsize) ; if ( style & wxVSCROLL ) m_vScrollBar = new wxScrollBar(this, wxID_ANY, vPoint, vSize , wxVERTICAL); @@ -3050,10 +3188,9 @@ void wxWindowMac::MacCreateScrollBars( long style ) bool wxWindowMac::MacIsChildOfClientArea( const wxWindow* child ) const { - if ( child != NULL && ( child == m_hScrollBar || child == m_vScrollBar ) ) - return false ; - else - return true ; + bool result = ((child == NULL) || ((child != m_hScrollBar) && (child != m_vScrollBar))); + + return result ; } void wxWindowMac::MacRepositionScrollBars() @@ -3173,13 +3310,15 @@ long wxWindowMac::MacGetLeftBorderSize() const if (HasFlag(wxRAISED_BORDER) || HasFlag( wxSUNKEN_BORDER) || HasFlag(wxDOUBLE_BORDER)) { + // this metric is only the 'outset' outside the simple frame rect GetThemeMetric( kThemeMetricEditTextFrameOutset , &border ) ; - border += 1 ; // the metric above is only the 'outset' outside the simple frame rect + border += 1 ; } else if (HasFlag(wxSIMPLE_BORDER)) { + // this metric is only the 'outset' outside the simple frame rect GetThemeMetric( kThemeMetricListBoxFrameOutset , &border ) ; - border += 1 ; // the metric above is only the 'outset' outside the simple frame rect + border += 1 ; } return border ; @@ -3233,6 +3372,8 @@ void wxWindowMac::OnMouseEvent( wxMouseEvent &event ) if ( event.GetEventType() == wxEVT_RIGHT_DOWN ) { // copied from wxGTK : CS + // VZ: shouldn't we move this to base class then? + // generate a "context menu" event: this is similar to wxEVT_RIGHT_DOWN // except that: // @@ -3267,8 +3408,8 @@ Rect wxMacGetBoundsForControl( wxWindow* window , const wxPoint& pos , const wxS { int x, y, w, h ; - window->MacGetBoundsForControl( pos , size , x , y, w, h , adjustForOrigin) ; - Rect bounds = { y, x, y + h, x + w }; + window->MacGetBoundsForControl( pos , size , x , y, w, h , adjustForOrigin ) ; + Rect bounds = { y, x, y + h, x + w }; return bounds ; } @@ -3281,7 +3422,6 @@ wxInt32 wxWindowMac::MacControlHit(WXEVENTHANDLERREF WXUNUSED(handler) , WXEVENT bool wxWindowMac::Reparent(wxWindowBase *newParentBase) { wxWindowMac *newParent = (wxWindowMac *)newParentBase; - if ( !wxWindowBase::Reparent(newParent) ) return false;