X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/d2c7e39b9bc603738a8aebd4b4838b398b175daa..737255678cb96a8296348fb62603afdd28133ec5:/src/msw/iniconf.cpp diff --git a/src/msw/iniconf.cpp b/src/msw/iniconf.cpp index 22199a3f39..e65785791d 100644 --- a/src/msw/iniconf.cpp +++ b/src/msw/iniconf.cpp @@ -21,18 +21,18 @@ #endif #ifndef WX_PRECOMP - #include - #include - #include - #include - #include + #include "wx/string.h" + #include "wx/intl.h" + #include "wx/event.h" + #include "wx/app.h" + #include "wx/utils.h" #endif //WX_PRECOMP -#include -#include -#include +#include "wx/dynarray.h" +#include "wx/log.h" +#include "wx/config.h" -#include +#include "wx/msw/iniconf.h" // _WINDOWS_ is defined when windows.h is included, // __WXMSW__ is defined for MS Windows compilation @@ -344,16 +344,22 @@ bool wxIniConfig::Read(const wxString& szKey, long *pl) const // is it really nMagic? lVal = GetPrivateProfileInt(m_strGroup, strKey, nMagic2, m_strLocalFilename); - if ( lVal == nMagic2 ) { + if ( lVal != nMagic2 ) { // the nMagic it returned was indeed read from the file *pl = lVal; return TRUE; } + // CS : I have no idea why they should look up in win.ini + // and if at all they have to do the same procedure using the two magic numbers + // otherwise it always returns true, even if the key was not there at all +#if 0 // no, it was just returning the default value, so now look in win.ini - *pl = GetProfileInt(GetVendorName(), GetKeyName(szKey), *pl); + *pl = GetProfileInt(GetVendorName(), GetKeyName(szKey), *pl); return TRUE; +#endif + return FALSE ; } bool wxIniConfig::Write(const wxString& szKey, const wxString& szValue) @@ -442,9 +448,13 @@ bool wxIniConfig::DeleteAll() char szBuf[MAX_PATH]; size_t nRc = GetWindowsDirectory(szBuf, WXSIZEOF(szBuf)); if ( nRc == 0 ) + { wxLogLastError("GetWindowsDirectory"); + } else if ( nRc > WXSIZEOF(szBuf) ) + { wxFAIL_MSG("buffer is too small for Windows directory."); + } wxString strFile = szBuf; strFile << '\\' << m_strLocalFilename;