X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/d2c7e39b9bc603738a8aebd4b4838b398b175daa..12335fa6aa8db0d0044ff4dbfa9ea056b57b0a66:/src/msw/iniconf.cpp diff --git a/src/msw/iniconf.cpp b/src/msw/iniconf.cpp index 22199a3f39..7bcce6e8f2 100644 --- a/src/msw/iniconf.cpp +++ b/src/msw/iniconf.cpp @@ -21,18 +21,22 @@ #endif #ifndef WX_PRECOMP - #include - #include - #include - #include - #include + #include "wx/string.h" + #include "wx/intl.h" + #include "wx/event.h" + #include "wx/app.h" + #include "wx/utils.h" #endif //WX_PRECOMP -#include -#include -#include +// Doesn't yet compile in Unicode mode -#include +#if wxUSE_CONFIG && !wxUSE_UNICODE + +#include "wx/dynarray.h" +#include "wx/log.h" +#include "wx/config.h" + +#include "wx/msw/iniconf.h" // _WINDOWS_ is defined when windows.h is included, // __WXMSW__ is defined for MS Windows compilation @@ -60,29 +64,38 @@ wxIniConfig::wxIniConfig(const wxString& strAppName, const wxString& localFilename, const wxString& globalFilename, long style) - : wxConfigBase(!strAppName && wxTheApp ? wxTheApp->GetAppName() + : wxConfigBase(strAppName, strVendor, localFilename, globalFilename, style) + +#if 0 // This is too complex for some compilers, e.g. BC++ 5.01 + : wxConfigBase((strAppName.IsEmpty() && wxTheApp) ? wxTheApp->GetAppName() : strAppName, - !strVendor ? (wxTheApp ? wxTheApp->GetVendorName() + strVendor.IsEmpty() ? (wxTheApp ? wxTheApp->GetVendorName() : strAppName) : strVendor, localFilename, globalFilename, style) +#endif { + if (strAppName.IsEmpty() && wxTheApp) + SetAppName(wxTheApp->GetAppName()); + if (strVendor.IsEmpty() && wxTheApp) + SetVendorName(wxTheApp->GetVendorName()); + m_strLocalFilename = localFilename; if (m_strLocalFilename.IsEmpty()) { - m_strLocalFilename = GetAppName() + ".ini"; + m_strLocalFilename = GetAppName() + wxT(".ini"); } // append the extension if none given and it's not an absolute file name // (otherwise we assume that they know what they're doing) if ( !wxIsPathSeparator(m_strLocalFilename[0u]) && - m_strLocalFilename.Find('.') == wxNOT_FOUND ) + m_strLocalFilename.Find(wxT('.')) == wxNOT_FOUND ) { - m_strLocalFilename << ".ini"; + m_strLocalFilename << wxT(".ini"); } // set root path - SetPath(""); + SetPath(wxT("")); } wxIniConfig::~wxIniConfig() @@ -269,7 +282,7 @@ bool wxIniConfig::IsEmpty() const // read/write // ---------------------------------------------------------------------------- -bool wxIniConfig::Read(const wxString& szKey, wxString *pstr) const +bool wxIniConfig::DoReadString(const wxString& szKey, wxString *pstr) const { wxConfigPathChanger path(this, szKey); wxString strKey = GetPrivateKeyName(path.Name()); @@ -287,45 +300,14 @@ bool wxIniConfig::Read(const wxString& szKey, wxString *pstr) const GetProfileString(m_strGroup, strKey, "", szBuf, WXSIZEOF(szBuf)); } - if ( ::IsEmpty(szBuf) ) { + if ( ::IsEmpty(szBuf) ) return FALSE; - } - else { - *pstr = szBuf ; - return TRUE; - } -} - -bool wxIniConfig::Read(const wxString& szKey, wxString *pstr, - const wxString& szDefault) const -{ - wxConfigPathChanger path(this, szKey); - wxString strKey = GetPrivateKeyName(path.Name()); - - char szBuf[1024]; // @@ should dynamically allocate memory... - - // first look in the private INI file - - // NB: the lpDefault param to GetPrivateProfileString can't be NULL - GetPrivateProfileString(m_strGroup, strKey, "", - szBuf, WXSIZEOF(szBuf), m_strLocalFilename); - if ( ::IsEmpty(szBuf) ) { - // now look in win.ini - wxString strKey = GetKeyName(path.Name()); - GetProfileString(m_strGroup, strKey, "", szBuf, WXSIZEOF(szBuf)); - } - if ( ::IsEmpty(szBuf) ) { - *pstr = szDefault; - return FALSE; - } - else { - *pstr = szBuf ; - return TRUE; - } + *pstr = szBuf; + return TRUE; } -bool wxIniConfig::Read(const wxString& szKey, long *pl) const +bool wxIniConfig::DoReadLong(const wxString& szKey, long *pl) const { wxConfigPathChanger path(this, szKey); wxString strKey = GetPrivateKeyName(path.Name()); @@ -344,19 +326,25 @@ bool wxIniConfig::Read(const wxString& szKey, long *pl) const // is it really nMagic? lVal = GetPrivateProfileInt(m_strGroup, strKey, nMagic2, m_strLocalFilename); - if ( lVal == nMagic2 ) { + if ( lVal != nMagic2 ) { // the nMagic it returned was indeed read from the file *pl = lVal; return TRUE; } + // CS : I have no idea why they should look up in win.ini + // and if at all they have to do the same procedure using the two magic numbers + // otherwise it always returns true, even if the key was not there at all +#if 0 // no, it was just returning the default value, so now look in win.ini - *pl = GetProfileInt(GetVendorName(), GetKeyName(szKey), *pl); + *pl = GetProfileInt(GetVendorName(), GetKeyName(szKey), *pl); return TRUE; +#endif + return FALSE ; } -bool wxIniConfig::Write(const wxString& szKey, const wxString& szValue) +bool wxIniConfig::DoWriteString(const wxString& szKey, const wxString& szValue) { wxConfigPathChanger path(this, szKey); wxString strKey = GetPrivateKeyName(path.Name()); @@ -365,12 +353,12 @@ bool wxIniConfig::Write(const wxString& szKey, const wxString& szValue) szValue, m_strLocalFilename) != 0; if ( !bOk ) - wxLogLastError("WritePrivateProfileString"); + wxLogLastError(wxT("WritePrivateProfileString")); return bOk; } -bool wxIniConfig::Write(const wxString& szKey, long lValue) +bool wxIniConfig::DoWriteLong(const wxString& szKey, long lValue) { // ltoa() is not ANSI :-( char szBuf[40]; // should be good for sizeof(long) <= 16 (128 bits) @@ -409,7 +397,7 @@ bool wxIniConfig::DeleteEntry(const wxString& szKey, bool bGroupIfEmptyAlso) NULL, m_strLocalFilename) != 0; if ( !bOk ) - wxLogLastError("WritePrivateProfileString"); + wxLogLastError(wxT("WritePrivateProfileString")); return bOk; } @@ -424,7 +412,7 @@ bool wxIniConfig::DeleteGroup(const wxString& szKey) NULL, m_strLocalFilename) != 0; if ( !bOk ) - wxLogLastError("WritePrivateProfileString"); + wxLogLastError(wxT("WritePrivateProfileString")); return bOk; } @@ -442,9 +430,13 @@ bool wxIniConfig::DeleteAll() char szBuf[MAX_PATH]; size_t nRc = GetWindowsDirectory(szBuf, WXSIZEOF(szBuf)); if ( nRc == 0 ) - wxLogLastError("GetWindowsDirectory"); + { + wxLogLastError(wxT("GetWindowsDirectory")); + } else if ( nRc > WXSIZEOF(szBuf) ) - wxFAIL_MSG("buffer is too small for Windows directory."); + { + wxFAIL_MSG(wxT("buffer is too small for Windows directory.")); + } wxString strFile = szBuf; strFile << '\\' << m_strLocalFilename; @@ -468,3 +460,6 @@ bool wxIniConfig::RenameGroup(const wxString& oldName, const wxString& newName) // Not implemented return FALSE; } + +#endif + // wxUSE_CONFIG && wxUSE_UNICODE