X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/cc26010927f5bb12825a32487949d063e6c605fc..d8eff331e23435d9d8d6483a40f6fd9997a13f87:/samples/toolbar/toolbar.cpp

diff --git a/samples/toolbar/toolbar.cpp b/samples/toolbar/toolbar.cpp
index 2c62dcd5c0..7d0a678acd 100644
--- a/samples/toolbar/toolbar.cpp
+++ b/samples/toolbar/toolbar.cpp
@@ -134,7 +134,6 @@ public:
 
     void OnToolbarStyle(wxCommandEvent& event);
     void OnToolbarBgCol(wxCommandEvent& event);
-    void OnToolbarCustomBg(wxCommandEvent& event);
     void OnToolbarCustomBitmap(wxCommandEvent& event);
 
     void OnToolLeftClick(wxCommandEvent& event);
@@ -149,8 +148,6 @@ public:
         { event.Enable( m_tbar != NULL ); }
 
 private:
-    void OnEraseToolBarBackground(wxEraseEvent& event);
-
     void DoEnablePrint();
     void DoDeletePrint();
     void DoToggleHelp();
@@ -209,7 +206,6 @@ enum
     IDM_TOOLBAR_SHOW_ICONS,
     IDM_TOOLBAR_SHOW_BOTH,
     IDM_TOOLBAR_BG_COL,
-    IDM_TOOLBAR_CUSTOM_BG,
     IDM_TOOLBAR_CUSTOM_PATH,
     IDM_TOOLBAR_TOP_ORIENTATION,
     IDM_TOOLBAR_LEFT_ORIENTATION,
@@ -268,7 +264,6 @@ BEGIN_EVENT_TABLE(MyFrame, wxFrame)
     EVT_MENU_RANGE(IDM_TOOLBAR_SHOW_TEXT, IDM_TOOLBAR_SHOW_BOTH,
                    MyFrame::OnToolbarStyle)
     EVT_MENU(IDM_TOOLBAR_BG_COL, MyFrame::OnToolbarBgCol)
-    EVT_MENU(IDM_TOOLBAR_CUSTOM_BG, MyFrame::OnToolbarCustomBg)
 
     EVT_MENU(IDM_TOOLBAR_CUSTOM_PATH, MyFrame::OnToolbarCustomBitmap)
 
@@ -376,17 +371,6 @@ void MyFrame::RecreateToolbar()
     toolBar = CreateToolBar(style, ID_TOOLBAR);
 #endif
 
-    if ( GetMenuBar()->IsChecked(IDM_TOOLBAR_CUSTOM_BG) )
-    {
-        toolBar->Connect
-                 (
-                    wxEVT_ERASE_BACKGROUND,
-                    wxEraseEventHandler(MyFrame::OnEraseToolBarBackground),
-                    NULL,
-                    this
-                 );
-    }
-
     PopulateToolbar(toolBar);
 }
 
@@ -612,7 +596,6 @@ MyFrame::MyFrame(wxFrame* parent,
     tbarMenu->AppendRadioItem(IDM_TOOLBAR_SHOW_BOTH, wxT("Show &both\tCtrl-Alt-B"));
     tbarMenu->AppendSeparator();
     tbarMenu->Append(IDM_TOOLBAR_BG_COL, wxT("Choose bac&kground colour..."));
-    tbarMenu->AppendCheckItem(IDM_TOOLBAR_CUSTOM_BG, wxT("Draw custom back&ground"));
     tbarMenu->Append(IDM_TOOLBAR_CUSTOM_PATH, wxT("Custom &bitmap...\tCtrl-B"));
 
     wxMenu *toolMenu = new wxMenu;
@@ -644,6 +627,7 @@ MyFrame::MyFrame(wxFrame* parent,
     // Associate the menu bar with the frame
     SetMenuBar(menuBar);
 
+    menuBar->Check(IDM_TOOLBAR_TOGGLE_TOOLBAR, true);
     menuBar->Check(IDM_TOOLBAR_SHOW_BOTH, true);
     menuBar->Check(IDM_TOOLBAR_TOGGLETOOLTIPS, true);
 
@@ -712,15 +696,6 @@ void MyFrame::OnSize(wxSizeEvent& event)
     }
 }
 
-void MyFrame::OnEraseToolBarBackground(wxEraseEvent& event)
-{
-    wxDC& dc = *event.GetDC();
-    const wxSize size = dc.GetSize();
-    dc.SetPen(*wxRED_PEN);
-    dc.DrawLine(0, 0, size.x, size.y);
-    dc.DrawLine(0, size.y, size.x, 0);
-}
-
 void MyFrame::OnToggleToolbar(wxCommandEvent& WXUNUSED(event))
 {
     wxToolBar *tbar = GetToolBar();
@@ -731,9 +706,11 @@ void MyFrame::OnToggleToolbar(wxCommandEvent& WXUNUSED(event))
     }
     else
     {
+        // notice that there is no need to call SetToolBar(NULL) here (although
+        // this it is harmless to do and it must be called if you do not delete
+        // the toolbar but keep it for later reuse), just delete the toolbar
+        // directly and it will reset the associated frame toolbar pointer
         delete tbar;
-
-        SetToolBar(NULL);
     }
 }
 
@@ -985,34 +962,6 @@ void MyFrame::OnToolbarBgCol(wxCommandEvent& WXUNUSED(event))
     }
 }
 
-void MyFrame::OnToolbarCustomBg(wxCommandEvent& event)
-{
-    wxToolBarBase *tb = GetToolBar();
-
-    if ( event.IsChecked() )
-    {
-        tb->Connect
-            (
-             wxEVT_ERASE_BACKGROUND,
-             wxEraseEventHandler(MyFrame::OnEraseToolBarBackground),
-             NULL,
-             this
-            );
-    }
-    else
-    {
-        tb->Disconnect
-            (
-             wxEVT_ERASE_BACKGROUND,
-             wxEraseEventHandler(MyFrame::OnEraseToolBarBackground),
-             NULL,
-             this
-            );
-    }
-
-    tb->Refresh();
-}
-
 void MyFrame::OnToolbarCustomBitmap(wxCommandEvent& WXUNUSED(event))
 {
     m_pathBmp = wxLoadFileSelector("custom bitmap", "");