X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/c2edb18a7dc443fc0902945956a355ed722144fa..1cff04deb5c17c95bef9c83e72645f105b90e750:/src/msw/gdiimage.cpp diff --git a/src/msw/gdiimage.cpp b/src/msw/gdiimage.cpp index 26e9292110..7fb451d303 100644 --- a/src/msw/gdiimage.cpp +++ b/src/msw/gdiimage.cpp @@ -45,6 +45,10 @@ #include "wx/msw/gdiimage.h" #include "wx/bitmap.h" +#include "wx/listimpl.cpp" +WX_DEFINE_LIST(wxGDIImageHandlerList); + + #ifdef __WIN16__ # include "wx/msw/curico.h" #endif // __WIN16__ @@ -110,14 +114,14 @@ public: int WXUNUSED(height), int WXUNUSED(depth) = 1) { - return FALSE; + return false; } virtual bool Save(wxGDIImage *WXUNUSED(image), const wxString& WXUNUSED(name), int WXUNUSED(type)) { - return FALSE; + return false; } virtual bool Load(wxGDIImage *image, @@ -126,7 +130,7 @@ public: int desiredWidth, int desiredHeight) { wxIcon *icon = wxDynamicCast(image, wxIcon); - wxCHECK_MSG( icon, FALSE, _T("wxIconHandler only works with icons") ); + wxCHECK_MSG( icon, false, _T("wxIconHandler only works with icons") ); return LoadIcon(icon, name, flags, desiredWidth, desiredHeight); } @@ -184,7 +188,6 @@ IMPLEMENT_DYNAMIC_CLASS(wxICOResourceHandler, wxObject) // private functions // ---------------------------------------------------------------------------- -static wxSize GetHiconSize(HICON hicon); #endif // __MICROWIN__ @@ -192,7 +195,7 @@ static wxSize GetHiconSize(HICON hicon); // implementation // ============================================================================ -wxList wxGDIImage::ms_handlers; +wxGDIImageHandlerList wxGDIImage::ms_handlers; // ---------------------------------------------------------------------------- // wxGDIImage functions forwarded to wxGDIImageRefData @@ -206,10 +209,10 @@ bool wxGDIImage::FreeResource(bool WXUNUSED(force)) GetGDIImageData()->m_handle = 0; } - return TRUE; + return true; } -WXHANDLE wxGDIImage::GetResourceHandle() +WXHANDLE wxGDIImage::GetResourceHandle() const { return GetHandle(); } @@ -234,21 +237,21 @@ bool wxGDIImage::RemoveHandler(const wxString& name) if ( handler ) { ms_handlers.DeleteObject(handler); - return TRUE; + return true; } else - return FALSE; + return false; } wxGDIImageHandler *wxGDIImage::FindHandler(const wxString& name) { - wxNode *node = ms_handlers.First(); + wxGDIImageHandlerList::Node *node = ms_handlers.GetFirst(); while ( node ) { - wxGDIImageHandler *handler = (wxGDIImageHandler *)node->Data(); + wxGDIImageHandler *handler = node->GetData(); if ( handler->GetName() == name ) return handler; - node = node->Next(); + node = node->GetNext(); } return NULL; @@ -257,31 +260,31 @@ wxGDIImageHandler *wxGDIImage::FindHandler(const wxString& name) wxGDIImageHandler *wxGDIImage::FindHandler(const wxString& extension, long type) { - wxNode *node = ms_handlers.First(); + wxGDIImageHandlerList::Node *node = ms_handlers.GetFirst(); while ( node ) { - wxGDIImageHandler *handler = (wxGDIImageHandler *)node->Data(); + wxGDIImageHandler *handler = node->GetData(); if ( (handler->GetExtension() = extension) && (type == -1 || handler->GetType() == type) ) { return handler; } - node = node->Next(); + node = node->GetNext(); } return NULL; } wxGDIImageHandler *wxGDIImage::FindHandler(long type) { - wxNode *node = ms_handlers.First(); + wxGDIImageHandlerList::Node *node = ms_handlers.GetFirst(); while ( node ) { - wxGDIImageHandler *handler = (wxGDIImageHandler *)node->Data(); + wxGDIImageHandler *handler = node->GetData(); if ( handler->GetType() == type ) return handler; - node = node->Next(); + node = node->GetNext(); } return NULL; @@ -289,11 +292,11 @@ wxGDIImageHandler *wxGDIImage::FindHandler(long type) void wxGDIImage::CleanUpHandlers() { - wxNode *node = ms_handlers.First(); + wxGDIImageHandlerList::Node *node = ms_handlers.GetFirst(); while ( node ) { - wxGDIImageHandler *handler = (wxGDIImageHandler *)node->Data(); - wxNode *next = node->Next(); + wxGDIImageHandler *handler = node->GetData(); + wxGDIImageHandlerList::Node *next = node->GetNext(); delete handler; delete node; node = next; @@ -324,27 +327,26 @@ bool wxBMPResourceHandler::LoadFile(wxBitmap *bitmap, // TODO: load colourmap. bitmap->SetHBITMAP((WXHBITMAP)::LoadBitmap(wxGetInstance(), name)); - wxBitmapRefData *data = bitmap->GetBitmapData(); - if ( bitmap->Ok() ) - { - BITMAP bm; - if ( !::GetObject(GetHbitmapOf(*bitmap), sizeof(BITMAP), (LPSTR) &bm) ) - { - wxLogLastError(wxT("GetObject(HBITMAP)")); - } - - data->m_width = bm.bmWidth; - data->m_height = bm.bmHeight; - data->m_depth = bm.bmBitsPixel; - } - else + if ( !bitmap->Ok() ) { // it's probably not found wxLogError(wxT("Can't load bitmap '%s' from resources! Check .rc file."), name.c_str()); + + return false; } - return bitmap->Ok(); + BITMAP bm; + if ( !::GetObject(GetHbitmapOf(*bitmap), sizeof(BITMAP), (LPSTR) &bm) ) + { + wxLogLastError(wxT("GetObject(HBITMAP)")); + } + + bitmap->SetWidth(bm.bmWidth); + bitmap->SetHeight(bm.bmHeight); + bitmap->SetDepth(bm.bmBitsPixel); + + return true; } bool wxBMPFileHandler::LoadFile(wxBitmap *bitmap, @@ -368,7 +370,7 @@ bool wxBMPFileHandler::LoadFile(wxBitmap *bitmap, return success; #else - return FALSE; + return false; #endif } @@ -389,7 +391,7 @@ bool wxBMPFileHandler::SaveFile(wxBitmap *bitmap, return wxSaveBitmap(WXSTRINGCAST name, bitmap, actualPalette) != 0; #else - return FALSE; + return false; #endif } @@ -425,6 +427,27 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, nameReal = name.BeforeLast(wxT(';')); } +#if 0 + // If we don't know what size icon we're looking for, + // try to find out what's there. + // Unfortunately this doesn't work, because ExtractIconEx + // will scale the icon to the 'desired' size, even if that + // size of icon isn't explicitly stored. So we would have + // to parse the icon file outselves. + if ( desiredWidth == -1 && + desiredHeight == -1) + { + // Try loading a large icon first + if ( ::ExtractIconEx(nameReal, iconIndex, &hicon, NULL, 1) == 1) + { + } + // Then try loading a small icon + else if ( ::ExtractIconEx(nameReal, iconIndex, NULL, &hicon, 1) == 1) + { + } + } + else +#endif // were we asked for a large icon? if ( desiredWidth == ::GetSystemMetrics(SM_CXICON) && desiredHeight == ::GetSystemMetrics(SM_CYICON) ) @@ -454,8 +477,8 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, if ( !hicon ) { - // take any (the first one) icon from the file by default - hicon = ::ExtractIcon(wxGetInstance(), nameReal, 0 /* first */); + // take any size icon from the file by index + hicon = ::ExtractIcon(wxGetInstance(), nameReal, iconIndex); } if ( !hicon ) @@ -463,10 +486,10 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, wxLogSysError(_T("Failed to load icon from the file '%s'"), name.c_str()); - return FALSE; + return false; } - size = GetHiconSize(hicon); + size = wxGetHiconSize(hicon); #else // Win16 HICON hicon = ReadIconFile((wxChar *)name.c_str(), wxGetInstance(), @@ -477,13 +500,13 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, (desiredHeight != -1 && desiredHeight != size.y) ) { wxLogTrace(_T("iconload"), - _T("Returning FALSE from wxICOFileHandler::Load because of the size mismatch: actual (%d, %d), requested (%d, %d)"), + _T("Returning false from wxICOFileHandler::Load because of the size mismatch: actual (%d, %d), requested (%d, %d)"), size.x, size.y, desiredWidth, desiredHeight); ::DestroyIcon(hicon); - return FALSE; + return false; } icon->SetHICON((WXHICON)hicon); @@ -491,7 +514,7 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, return icon->Ok(); #else - return FALSE; + return false; #endif } @@ -551,7 +574,7 @@ bool wxICOResourceHandler::LoadIcon(wxIcon *icon, } } - wxSize size = GetHiconSize(hicon); + wxSize size = wxGetHiconSize(hicon); icon->SetSize(size.x, size.y); icon->SetHICON((WXHICON)hicon); @@ -563,7 +586,7 @@ bool wxICOResourceHandler::LoadIcon(wxIcon *icon, // private functions // ---------------------------------------------------------------------------- -static wxSize GetHiconSize(HICON hicon) +wxSize wxGetHiconSize(HICON hicon) { wxSize size(32, 32); // default