X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/b63b737dc855a9282e69ff6b60cd366157d00e40..222702b112dcc7bebe018d6f4d66fe469fefd02c:/src/os2/ownerdrw.cpp?ds=sidebyside diff --git a/src/os2/ownerdrw.cpp b/src/os2/ownerdrw.cpp index 9e9dd6568d..dabe508943 100644 --- a/src/os2/ownerdrw.cpp +++ b/src/os2/ownerdrw.cpp @@ -6,7 +6,7 @@ // Created: 10/12/99 // RCS-ID: $Id$ // Copyright: (c) David Webster -// Licence: wxWindows license +// Licence: wxWindows licence /////////////////////////////////////////////////////////////////////////////// #ifdef __GNUG__ @@ -18,7 +18,7 @@ #ifndef WX_PRECOMP #include "wx/window.h" - #include "wx/msw/private.h" + #include "wx/os2/private.h" #include "wx/font.h" #include "wx/bitmap.h" #include "wx/dcmemory.h" @@ -28,6 +28,7 @@ #if wxUSE_OWNER_DRAWN +#include "wx/settings.h" #include "wx/ownerdrw.h" #include "wx/menuitem.h" @@ -71,17 +72,100 @@ bool wxOwnerDrawn::OnMeasureItem( { wxMemoryDC vDC; - vDC.SetFont(GetFont()); wxString sStr = wxStripMenuCodes(m_strName); + // + // If we have a valid accel string, then pad out + // the menu string so that the menu and accel string are not + // placed on top of each other. + if (!m_strAccel.empty() ) + { + sStr.Pad(sStr.Length()%8); + sStr += m_strAccel; + } + vDC.SetFont(GetFont()); vDC.GetTextExtent( sStr ,(long *)pWidth ,(long *)pHeight ); + if (!m_strAccel.IsEmpty()) + { + // + // Measure the accelerator string, and add its width to + // the total item width, plus 16 (Accelerators are right justified, + // with the right edge of the text rectangle 16 pixels left of + // the right edge of the menu) + // + int nAccelWidth; + int nAccelHeight; + + vDC.GetTextExtent( m_strAccel + ,&nAccelWidth + ,&nAccelHeight + ); + *pWidth += nAccelWidth; + } + + // + // Add space at the end of the menu for the submenu expansion arrow. + // This will also allow offsetting the accel string from the right edge + // + *pWidth = (size_t)(*pWidth + GetDefaultMarginWidth() * 1.5); + + // + // JACS: items still look too tightly packed, so adding 5 pixels. + // + (*pHeight) += 5; + + // + // Ray Gilbert's changes - Corrects the problem of a BMP + // being placed next to text in a menu item, and the BMP does + // not match the size expected by the system. This will + // resize the space so the BMP will fit. Without this, BMPs + // must be no larger or smaller than 16x16. + // + if (m_bmpChecked.Ok()) + { + // + // Is BMP height larger then text height? + // + size_t nAdjustedHeight = m_bmpChecked.GetHeight() + + wxSystemSettings::GetMetric(wxSYS_EDGE_Y); + if (*pHeight < nAdjustedHeight) + *pHeight = nAdjustedHeight; + + // + // Does BMP encroach on default check menu position? + // + size_t nAdjustedWidth = m_bmpChecked.GetWidth() + + (wxSystemSettings::GetMetric(wxSYS_EDGE_X) * 2); + + // + // Do we need to widen margin to fit BMP? + // + if ((size_t)GetMarginWidth() < nAdjustedWidth) + SetMarginWidth(nAdjustedWidth); - (*pHeight) = (*pHeight) + 2; - m_nHeight = *pHeight; // remember height for use in OnDrawItem + // + // Add the size of the bitmap to our total size... + // + *pWidth += GetMarginWidth(); + } + + // + // Add the size of the bitmap to our total size - even if we don't have + // a bitmap we leave room for one... + // + *pWidth += GetMarginWidth(); + + // + // Make sure that this item is at least as + // tall as the user's system settings specify + // + if (*pHeight < m_nMinHeight) + *pHeight = m_nMinHeight; + m_nHeight = *pHeight; // remember height for use in OnDrawItem return TRUE; } // end of wxOwnerDrawn::OnMeasureItem @@ -126,11 +210,11 @@ bool wxOwnerDrawn::OnDrawItem( } // - // Base on the status of the menu item pick the right colors + // Based on the status of the menu item, pick the right colors // if (eStatus & wxODSelected) { - wxColour vCol2("WHITE"); + wxColour vCol2(wxT("WHITE")); vColBack.Set( (unsigned char)0 ,(unsigned char)0 ,(unsigned char)160 @@ -162,7 +246,7 @@ bool wxOwnerDrawn::OnDrawItem( // Fall back to default colors if none explicitly specified // vRef = ::WinQuerySysColor( HWND_DESKTOP - ,SYSCLR_MENU // we are using gray for all our window backgrounds in wxWindows + ,SYSCLR_MENU // we are using gray for all our window backgrounds in wxWidgets ,0L ); vColBack.Set( GetRValue(vRef) @@ -207,23 +291,23 @@ bool wxOwnerDrawn::OnDrawItem( // // Unfortunately, unlike Win32, PM has no owner drawn specific text // drawing methods like ::DrawState that can cleanly handle accel - // pneumonics and deal, automatically, with various states, so we have + // mnemonics and deal, automatically, with various states, so we have // to handle them ourselves. Notice Win32 can't handle \t in ownerdrawn - // strings either. We cannot handle mneumonics either. We display - // it, though, in hopes we can figure it out some day. + // strings either. We cannot handle mnemonics either. We display + // them, though, in the hope we can figure them out some day. // // - // Display main text and accel text separately to allign better + // Display main text and accel text separately to align better // - wxString sTgt = "\t"; + wxString sTgt = wxT("\t"); wxString sFullString = m_strName; // need to save the original text wxString sAccel; - size_t nIndex; + int nIndex; size_t nWidth; size_t nCharWidth; size_t nHeight; - bool bFoundMneumonic = FALSE; + bool bFoundMnemonic = FALSE; bool bFoundAccel = FALSE; // @@ -238,26 +322,26 @@ bool wxOwnerDrawn::OnDrawItem( } // - // Deal with the mneumonic character + // Deal with the mnemonic character // - sTgt = "~"; + sTgt = wxT("~"); nIndex = sFullString.Find(sTgt.c_str()); if (nIndex != -1) { wxString sTmp = sFullString; - bFoundMneumonic = TRUE; + bFoundMnemonic = TRUE; sTmp.Remove(nIndex); rDC.GetTextExtent( sTmp ,(long *)&nWidth ,(long *)&nHeight ); - sTmp = sFullString[nIndex + 1]; + sTmp = sFullString[(size_t)(nIndex + 1)]; rDC.GetTextExtent( sTmp ,(long *)&nCharWidth ,(long *)&nHeight ); - sFullString.Replace(sTgt.c_str(), "", TRUE); + sFullString.Replace(sTgt.c_str(), wxEmptyString, TRUE); } // @@ -269,10 +353,10 @@ bool wxOwnerDrawn::OnDrawItem( ,sFullString.length() ,(PCH)sFullString.c_str() ); - if (bFoundMneumonic) + if (bFoundMnemonic) { // - // Underline the mneumonic -- still won't work, but at least it "looks" right + // Underline the mnemonic -- still won't work, but at least it "looks" right // wxPen vPen; POINTL vPntEnd = {nX + nWidth + nCharWidth - 3, rRect.y + 2}; //CharWidth is bit wide @@ -380,11 +464,6 @@ bool wxOwnerDrawn::OnDrawItem( if (eStatus & wxODSelected) { - RECT vRectBmp = { rRect.x - ,rRect.y - ,rRect.x + GetMarginWidth() - 1 - ,rRect.y + m_nHeight - 1 - }; POINTL vPnt1 = {rRect.x + 1, rRect.y + 3}; // Leave a little background border POINTL vPnt2 = {rRect.x + GetMarginWidth(), rRect.y + m_nHeight - 3};