X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/afbe906abdf9aa69a56571b8b20b095351dd8f34..915a955caffbbc0982cc4a1952113bcd09d6d009:/src/gtk/textctrl.cpp diff --git a/src/gtk/textctrl.cpp b/src/gtk/textctrl.cpp index 1c63ae186e..46345f1820 100644 --- a/src/gtk/textctrl.cpp +++ b/src/gtk/textctrl.cpp @@ -23,9 +23,13 @@ #include #include // for fabs -#include "gdk/gdk.h" -#include "gtk/gtk.h" -#include "gdk/gdkkeysyms.h" +// TODO: reimplement wxTextCtrl using GtkTextView +#ifdef __WXGTK20__ + #define GTK_ENABLE_BROKEN // need this to get GtkText at all +#endif // __WXGTK20__ + +#include "wx/gtk/private.h" +#include //----------------------------------------------------------------------------- // idle system @@ -40,6 +44,7 @@ extern bool g_isIdle; extern bool g_blockEventsOnDrag; extern wxCursor g_globalCursor; +extern wxWindowGTK *g_delayedFocus; // ---------------------------------------------------------------------------- // helpers @@ -142,6 +147,39 @@ gtk_scrollbar_changed_callback( GtkWidget *WXUNUSED(widget), wxTextCtrl *win ) win->CalculateScrollbar(); } +// ---------------------------------------------------------------------------- +// redraw callback for multiline text +// ---------------------------------------------------------------------------- + +#ifndef __WXGTK20__ + +// redrawing a GtkText from inside a wxYield() call results in crashes (the +// text sample shows it in its "Add lines" command which shows wxProgressDialog +// which implicitly calls wxYield()) so we override GtkText::draw() and simply +// don't do anything if we're inside wxYield() + +extern bool wxIsInsideYield; + +extern "C" { + typedef void (*GtkDrawCallback)(GtkWidget *widget, GdkRectangle *rect); +} + +static GtkDrawCallback gs_gtk_text_draw = NULL; + +extern "C" +void wxgtk_text_draw( GtkWidget *widget, GdkRectangle *rect) +{ + if ( !wxIsInsideYield ) + { + wxCHECK_RET( gs_gtk_text_draw != wxgtk_text_draw, + _T("infinite recursion in wxgtk_text_draw aborted") ); + + gs_gtk_text_draw(widget, rect); + } +} + +#endif // __WXGTK20__ + //----------------------------------------------------------------------------- // wxTextCtrl //----------------------------------------------------------------------------- @@ -212,7 +250,7 @@ bool wxTextCtrl::Create( wxWindow *parent, bool multi_line = (style & wxTE_MULTILINE) != 0; if (multi_line) { -#if (GTK_MINOR_VERSION > 2) +#ifdef __WXGTK13__ /* a multi-line edit control: create a vertical scrollbar by default and horizontal if requested */ bool bHasHScrollbar = (style & wxHSCROLL) != 0; @@ -234,7 +272,7 @@ bool wxTextCtrl::Create( wxWindow *parent, /* always wrap words */ gtk_text_set_word_wrap( GTK_TEXT(m_text), TRUE ); -#if (GTK_MINOR_VERSION > 2) +#ifdef __WXGTK13__ /* put the horizontal scrollbar in the lower left hand corner */ if (bHasHScrollbar) { @@ -263,7 +301,7 @@ bool wxTextCtrl::Create( wxWindow *parent, { /* a single-line text control: no need for scrollbars */ m_widget = - m_text = gtk_entry_new(); + m_text = gtk_entry_new(); } m_parent->DoAddChild( this ); @@ -290,13 +328,27 @@ bool wxTextCtrl::Create( wxWindow *parent, { gtk_signal_connect(GTK_OBJECT(GTK_TEXT(m_text)->vadj), "changed", (GtkSignalFunc) gtk_scrollbar_changed_callback, (gpointer) this ); + +#ifndef __WXGTK20__ + // only initialize gs_gtk_text_draw once, starting from the next the + // klass::draw will already be wxgtk_text_draw + if ( !gs_gtk_text_draw ) + { + GtkDrawCallback& + draw = GTK_WIDGET_CLASS(GTK_OBJECT(m_text)->klass)->draw; + + gs_gtk_text_draw = draw; + + draw = wxgtk_text_draw; + } +#endif // GTK+ 1.x } if (!value.IsEmpty()) { gint tmp = 0; -#if GTK_MINOR_VERSION == 0 +#if !GTK_CHECK_VERSION(1, 2, 0) // if we don't realize it, GTK 1.0.6 dies with a SIGSEGV in // gtk_editable_insert_text() gtk_widget_realize(m_text); @@ -312,8 +364,7 @@ bool wxTextCtrl::Create( wxWindow *parent, if (multi_line) { /* bring editable's cursor uptodate. bug in GTK. */ - - GTK_EDITABLE(m_text)->current_pos = gtk_text_get_point( GTK_TEXT(m_text) ); + SET_EDITABLE_POS(m_text, gtk_text_get_point( GTK_TEXT(m_text) )); } } @@ -446,35 +497,27 @@ void wxTextCtrl::WriteText( const wxString &text ) if ( m_windowStyle & wxTE_MULTILINE ) { // After cursor movements, gtk_text_get_point() is wrong by one. - gtk_text_set_point( GTK_TEXT(m_text), GTK_EDITABLE(m_text)->current_pos ); - - // if we have any special style, use it - if ( !m_defaultStyle.IsDefault() ) - { - GetInsertionPoint(); + gtk_text_set_point( GTK_TEXT(m_text), GET_EDITABLE_POS(m_text) ); - wxGtkTextInsert(m_text, m_defaultStyle, txt, txtlen); - } - else // no style - { - gint len = GTK_EDITABLE(m_text)->current_pos; - gtk_editable_insert_text( GTK_EDITABLE(m_text), txt, txtlen, &len ); - } + // always use m_defaultStyle, even if it is empty as otherwise + // resetting the style and appending some more text wouldn't work: if + // we don't specify the style explicitly, the old style would be used + wxGtkTextInsert(m_text, m_defaultStyle, txt, txtlen); // Bring editable's cursor back uptodate. - GTK_EDITABLE(m_text)->current_pos = gtk_text_get_point( GTK_TEXT(m_text) ); + SET_EDITABLE_POS(m_text, gtk_text_get_point( GTK_TEXT(m_text) )); } else // single line { // This moves the cursor pos to behind the inserted text. - gint len = GTK_EDITABLE(m_text)->current_pos; + gint len = GET_EDITABLE_POS(m_text); gtk_editable_insert_text( GTK_EDITABLE(m_text), txt, txtlen, &len ); // Bring editable's cursor uptodate. - GTK_EDITABLE(m_text)->current_pos += text.Len(); + len += text.Len(); // Bring entry's cursor uptodate. - gtk_entry_set_position( GTK_ENTRY(m_text), GTK_EDITABLE(m_text)->current_pos ); + gtk_entry_set_position( GTK_ENTRY(m_text), len ); } m_modified = TRUE; @@ -643,7 +686,7 @@ void wxTextCtrl::SetInsertionPoint( long pos ) /* bring editable's cursor uptodate. another bug in GTK. */ - GTK_EDITABLE(m_text)->current_pos = gtk_text_get_point( GTK_TEXT(m_text) ); + SET_EDITABLE_POS(m_text, gtk_text_get_point( GTK_TEXT(m_text) )); } else { @@ -651,7 +694,7 @@ void wxTextCtrl::SetInsertionPoint( long pos ) /* bring editable's cursor uptodate. bug in GTK. */ - GTK_EDITABLE(m_text)->current_pos = (guint32)pos; + SET_EDITABLE_POS(m_text, (guint32)pos); } } @@ -810,7 +853,7 @@ long wxTextCtrl::GetInsertionPoint() const { wxCHECK_MSG( m_text != NULL, 0, wxT("invalid text ctrl") ); - return (long) GTK_EDITABLE(m_text)->current_pos; + return (long) GET_EDITABLE_POS(m_text); } long wxTextCtrl::GetLastPosition() const @@ -855,33 +898,21 @@ void wxTextCtrl::Cut() { wxCHECK_RET( m_text != NULL, wxT("invalid text ctrl") ); -#if (GTK_MINOR_VERSION > 0) - gtk_editable_cut_clipboard( GTK_EDITABLE(m_text) ); -#else - gtk_editable_cut_clipboard( GTK_EDITABLE(m_text), 0 ); -#endif + gtk_editable_cut_clipboard( GTK_EDITABLE(m_text) DUMMY_CLIPBOARD_ARG ); } void wxTextCtrl::Copy() { wxCHECK_RET( m_text != NULL, wxT("invalid text ctrl") ); -#if (GTK_MINOR_VERSION > 0) - gtk_editable_copy_clipboard( GTK_EDITABLE(m_text) ); -#else - gtk_editable_copy_clipboard( GTK_EDITABLE(m_text), 0 ); -#endif + gtk_editable_copy_clipboard( GTK_EDITABLE(m_text) DUMMY_CLIPBOARD_ARG ); } void wxTextCtrl::Paste() { wxCHECK_RET( m_text != NULL, wxT("invalid text ctrl") ); -#if (GTK_MINOR_VERSION > 0) - gtk_editable_paste_clipboard( GTK_EDITABLE(m_text) ); -#else - gtk_editable_paste_clipboard( GTK_EDITABLE(m_text), 0 ); -#endif + gtk_editable_paste_clipboard( GTK_EDITABLE(m_text) DUMMY_CLIPBOARD_ARG ); } // Undo/redo @@ -900,14 +931,14 @@ void wxTextCtrl::Redo() bool wxTextCtrl::CanUndo() const { // TODO - wxFAIL_MSG( wxT("wxTextCtrl::CanUndo not implemented") ); + //wxFAIL_MSG( wxT("wxTextCtrl::CanUndo not implemented") ); return FALSE; } bool wxTextCtrl::CanRedo() const { // TODO - wxFAIL_MSG( wxT("wxTextCtrl::CanRedo not implemented") ); + //wxFAIL_MSG( wxT("wxTextCtrl::CanRedo not implemented") ); return FALSE; } @@ -917,21 +948,27 @@ void wxTextCtrl::GetSelection(long* fromOut, long* toOut) const { wxCHECK_RET( m_text != NULL, wxT("invalid text ctrl") ); - long from, to; + gint from, to; +#ifdef __WXGTK20__ + if ( !gtk_editable_get_selection_bounds(GTK_EDITABLE(m_text), &from, &to) ) +#else if ( !(GTK_EDITABLE(m_text)->has_selection) ) +#endif { from = to = GetInsertionPoint(); } else // got selection { +#ifndef __WXGTK20__ from = (long) GTK_EDITABLE(m_text)->selection_start_pos; to = (long) GTK_EDITABLE(m_text)->selection_end_pos; +#endif if ( from > to ) { // exchange them to be compatible with wxMSW - long tmp = from; + gint tmp = from; from = to; to = tmp; } @@ -947,7 +984,11 @@ bool wxTextCtrl::IsEditable() const { wxCHECK_MSG( m_text != NULL, FALSE, wxT("invalid text ctrl") ); +#ifdef __WXGTK20__ + return gtk_editable_get_editable(GTK_EDITABLE(m_text)); +#else return GTK_EDITABLE(m_text)->editable; +#endif } bool wxTextCtrl::IsModified() const @@ -1244,6 +1285,15 @@ void wxTextCtrl::OnInternalIdle() gdk_window_set_cursor( window, cursor.GetCursor() ); } + if (g_delayedFocus == this) + { + if (GTK_WIDGET_REALIZED(m_widget)) + { + gtk_widget_grab_focus( m_widget ); + g_delayedFocus = NULL; + } + } + UpdateWindowUI(); }