X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/ad81651f00edc6f489d9b6a0839d316a964fd521..2ef31e80ee0e9c597ffca0fd7a0eb9d018a2f51b:/src/common/imagpcx.cpp

diff --git a/src/common/imagpcx.cpp b/src/common/imagpcx.cpp
index 93d3502870..d28a456f6a 100644
--- a/src/common/imagpcx.cpp
+++ b/src/common/imagpcx.cpp
@@ -8,10 +8,9 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
-/*
-   We don't put pragma implement in this file because it is already present in
-   src/common/image.cpp
-*/
+#ifdef __GNUG__
+#pragma implementation "imagpcx.h"
+#endif
 
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
@@ -26,14 +25,18 @@
 
 #if wxUSE_STREAMS && wxUSE_PCX
 
-#include "wx/image.h"
+#include "wx/imagpcx.h"
 #include "wx/wfstream.h"
 #include "wx/module.h"
 #include "wx/log.h"
 #include "wx/intl.h"
 
+#include "wx/hash.h"
+#include "wx/list.h"
+#include "wx/object.h"
+
 //-----------------------------------------------------------------------------
-// PCX decoding
+// RLE encoding and decoding
 //-----------------------------------------------------------------------------
 
 void RLEencode(unsigned char *p, unsigned int size, wxOutputStream& s)
@@ -73,7 +76,6 @@ void RLEencode(unsigned char *p, unsigned int size, wxOutputStream& s)
         }
     }
 
-
     // Write the last one and return;
     //
     if ((cont > 1) || ((last & 0xC0) == 0xC0))
@@ -117,7 +119,11 @@ void RLEdecode(unsigned char *p, unsigned int size, wxInputStream& s)
 }
 
 
-/* PCX header */
+//-----------------------------------------------------------------------------
+// PCX reading and saving
+//-----------------------------------------------------------------------------
+
+// PCX header
 #define HDR_MANUFACTURER    0
 #define HDR_VERSION         1
 #define HDR_ENCODING        2
@@ -144,6 +150,7 @@ enum {
     wxPCX_VERERR = 3        // error in pcx version number
 };
 
+
 // ReadPCX:
 //  Loads a PCX file into the wxImage object pointed by image.
 //  Returns wxPCX_OK on success, or an error code otherwise
@@ -161,8 +168,7 @@ int ReadPCX(wxImage *image, wxInputStream& stream)
     int nplanes;                    // number of planes
     int encoding;                   // is the image RLE encoded?
     int format;                     // image format (8 bit, 24 bit)
-    unsigned int i;
-    off_t pos;
+    unsigned int i, j;
 
     // Read PCX header and check the version number (it must
     // be at least 5 or higher for 8 bit and 24 bit images).
@@ -192,23 +198,19 @@ int ReadPCX(wxImage *image, wxInputStream& stream)
     else
         return wxPCX_INVFORMAT;
 
-    // If the image is of type wxPCX_8BIT, then there is a
-    // palette at the end of the file. Read it now before
-    // proceeding.
-    //
-    if (format == wxPCX_8BIT)
-    {
-        pos = stream.TellI();
-        stream.SeekI(-769, wxFromEnd);
-
-        if (stream.GetC() != 12)
-            return wxPCX_INVFORMAT;
+    // If the image is of type wxPCX_8BIT, then there is
+    // a palette at the end of the image data. If we were
+    // working with a file, we could seek at the end to the
+    // end (SeekI(-769, wxFromEnd) and read the palette
+    // before proceeding. Unfortunately, this would prevent
+    // loading several PCXs in a single stream, so we can't
+    // do it. Thus, 8-bit images will have to be decoded in
+    // two passes: one to read and decode the image data,
+    // and another to replace 'colour indexes' with RGB
+    // values.
 
-        stream.Read(pal, 768);
-        stream.SeekI(pos, wxFromStart);
-    }
 
-    // Allocate memory for a scanline and resize the image.
+    // Resize the image and allocate memory for a scanline.
     //
     image->Create(width, height);
 
@@ -223,7 +225,7 @@ int ReadPCX(wxImage *image, wxInputStream& stream)
     //
     dst = image->GetData();
 
-    for (; height; height--)
+    for (j = height; j; j--)
     {
         if (encoding)
             RLEdecode(p, bytesperline * nplanes, stream);
@@ -236,9 +238,9 @@ int ReadPCX(wxImage *image, wxInputStream& stream)
             {
                 for (i = 0; i < width; i++)
                 {
-                    *(dst++) = pal[ 3 * (p[i]) ];
-                    *(dst++) = pal[ 3 * (p[i]) + 1];
-                    *(dst++) = pal[ 3 * (p[i]) + 2];
+                    // first pass, just store the colour index
+                    *dst = p[i];
+                    dst += 3;
                 }
                 break;
             }
@@ -257,6 +259,28 @@ int ReadPCX(wxImage *image, wxInputStream& stream)
 
     free(p);
 
+    // For 8 bit images, we read the palette, and then do a second
+    // pass replacing indexes with their RGB values;
+    //
+    if (format == wxPCX_8BIT)
+    {
+        unsigned char index;
+
+        if (stream.GetC() != 12)
+            return wxPCX_INVFORMAT;
+
+        stream.Read(pal, 768);
+
+        p = image->GetData();
+        for (unsigned long k = height * width; k; k--)
+        {
+            index = *p;
+            *(p++) = pal[3 * index];
+            *(p++) = pal[3 * index + 1];
+            *(p++) = pal[3 * index + 2];
+        }
+    }
+
     return wxPCX_OK;
 }
 
@@ -269,24 +293,25 @@ int ReadPCX(wxImage *image, wxInputStream& stream)
 int SavePCX(wxImage *image, wxOutputStream& stream)
 {
     unsigned char hdr[128];         // PCX header
+    unsigned char pal[768];         // palette for 8 bit images
     unsigned char *p;               // space to store one scanline
     unsigned char *src;             // pointer into wxImage data
     unsigned int width, height;     // size of the image
     unsigned int bytesperline;      // bytes per line (each plane)
     int nplanes = 3;                // number of planes
     int format = wxPCX_24BIT;       // image format (8 bit, 24 bit)
+    wxHashTable h(wxKEY_INTEGER);   // image histogram
+    unsigned long key;              // key in the hashtable
     unsigned int i;
  
-    /* XXX
-    build_palette();
-    if (num_of_colors <= 256)
+    // See if we can save as 8 bit.
+    //
+    if (image->CountColours(256) <= 256)
     {
+        image->ComputeHistogram(h);
         format = wxPCX_8BIT;
         nplanes = 1;
     }
-    else
-        free_palette();
-    */
 
     // Get image dimensions, calculate bytesperline (must be even,
     // according to PCX specs) and allocate space for one complete
@@ -297,7 +322,6 @@ int SavePCX(wxImage *image, wxOutputStream& stream)
 
     width = image->GetWidth();
     height = image->GetHeight();
-    nplanes = 3;                    /* 1 for wxPCX_8BIT */
     bytesperline = width;
     if (bytesperline % 2)
         bytesperline++;
@@ -334,19 +358,22 @@ int SavePCX(wxImage *image, wxOutputStream& stream)
         switch (format)
         {
             case wxPCX_8BIT:
-            /* XXX
             {
+                unsigned char r, g, b;
+                wxHNode *hnode;
+
                 for (i = 0; i < width; i++)
                 {
-                    hash = *(src++) << 24 +
-                           *(src++) << 16 +
-                           *(src++) << 8;
+                    r = *(src++);
+                    g = *(src++);
+                    b = *(src++);
+                    key = (r << 16) | (g << 8) | b;
 
-                    p[i] = palette_lookup(hash);
+                    hnode = (wxHNode *) h.Get(key);
+                    p[i] = hnode->index;
                 }
                 break;
             }
-            */
             case wxPCX_24BIT:
             {
                 for (i = 0; i < width; i++)
@@ -358,24 +385,41 @@ int SavePCX(wxImage *image, wxOutputStream& stream)
                 break;
             }
         }
-    
+
         RLEencode(p, bytesperline * nplanes, stream);
     }
     
     free(p);
 
-    /* XXX
+    // For 8 bit images, build the palette and write it to the stream
+    //
     if (format == wxPCX_8BIT)
     {
+        wxNode *node;
+        wxHNode *hnode;
+
+        // zero unused colours
+        memset(pal, 0, sizeof(pal));
+
+        h.BeginFind();
+        while ((node = h.Next()) != NULL)
+        {
+            key = node->GetKeyInteger();
+            hnode = (wxHNode *) node->GetData();
+
+            pal[3 * hnode->index]     = (unsigned char)(key >> 16);
+            pal[3 * hnode->index + 1] = (unsigned char)(key >> 8);
+            pal[3 * hnode->index + 2] = (unsigned char)(key);
+            delete hnode;
+        }
+
         stream.PutC(12);
-        dump_palette();
+        stream.Write(pal, 768);
     }
-    */
 
     return wxPCX_OK;
 }
 
-
 //-----------------------------------------------------------------------------
 // wxPCXHandler
 //-----------------------------------------------------------------------------