X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/a9c317d27ce06a16238c7da1aee6712c07989b93..404b319a85dadd7decf7a5a5331020520031a41c:/src/msw/radiobut.cpp?ds=sidebyside diff --git a/src/msw/radiobut.cpp b/src/msw/radiobut.cpp index 261af8c3d3..6c8ed13480 100644 --- a/src/msw/radiobut.cpp +++ b/src/msw/radiobut.cpp @@ -1,279 +1,300 @@ ///////////////////////////////////////////////////////////////////////////// -// Name: radiobut.cpp +// Name: src/msw/radiobut.cpp // Purpose: wxRadioButton // Author: Julian Smart // Modified by: // Created: 04/01/98 // RCS-ID: $Id$ -// Copyright: (c) Julian Smart and Markus Holzem -// Licence: wxWindows license +// Copyright: (c) Julian Smart +// Licence: wxWindows licence ///////////////////////////////////////////////////////////////////////////// -#ifdef __GNUG__ -#pragma implementation "radiobut.h" -#endif +// ============================================================================ +// declarations +// ============================================================================ + +// ---------------------------------------------------------------------------- +// headers +// ---------------------------------------------------------------------------- // For compilers that support precompilation, includes "wx.h". #include "wx/wxprec.h" #ifdef __BORLANDC__ -#pragma hdrstop + #pragma hdrstop #endif -#ifndef WX_PRECOMP -#include -#include "wx/setup.h" +#if wxUSE_RADIOBTN + #include "wx/radiobut.h" -#include "wx/settings.h" -#include "wx/brush.h" + +#ifndef WX_PRECOMP + #include "wx/settings.h" + #include "wx/dcscreen.h" + #include "wx/toplevel.h" #endif #include "wx/msw/private.h" -IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl) -// IMPLEMENT_DYNAMIC_CLASS(wxBitmapRadioButton, wxRadioButton) +// ============================================================================ +// wxRadioButton implementation +// ============================================================================ + +// ---------------------------------------------------------------------------- +// wxRadioButton creation +// ---------------------------------------------------------------------------- -bool wxRadioButton::MSWCommand(WXUINT param, WXWORD id) +void wxRadioButton::Init() { - if (param == BN_CLICKED) - { - wxCommandEvent event(wxEVT_COMMAND_RADIOBUTTON_SELECTED, m_windowId); - event.SetEventObject( this ); - event.SetInt( GetValue() ); - ProcessCommand(event); - return TRUE; - } - else return FALSE; + m_isChecked = false; } -bool wxRadioButton::Create(wxWindow *parent, wxWindowID id, - const wxString& label, - const wxPoint& pos, - const wxSize& size, long style, - const wxValidator& validator, - const wxString& name) +bool wxRadioButton::Create(wxWindow *parent, + wxWindowID id, + const wxString& label, + const wxPoint& pos, + const wxSize& size, + long style, + const wxValidator& validator, + const wxString& name) { - SetName(name); -#if wxUSE_VALIDATORS - SetValidator(validator); -#endif // wxUSE_VALIDATORS - - if (parent) parent->AddChild(this); - - SetBackgroundColour(parent->GetBackgroundColour()); - SetForegroundColour(parent->GetForegroundColour()); + if ( !CreateControl(parent, id, pos, size, style, validator, name) ) + return false; - if ( id == -1 ) - m_windowId = (int)NewControlId(); - else - m_windowId = id; + WXDWORD exstyle = 0; + WXDWORD msStyle = MSWGetStyle(style, &exstyle); - int x = pos.x; - int y = pos.y; - int width = size.x; - int height = size.y; + if ( !MSWCreateControl(wxT("BUTTON"), msStyle, pos, size, label, exstyle) ) + return false; - m_windowStyle = style ; + // for compatibility with wxGTK, the first radio button in a group is + // always checked (this makes sense anyhow as you need to ensure that at + // least one button in the group is checked and this is the simplest way to + // do it) + if ( HasFlag(wxRB_GROUP) ) + SetValue(true); - long groupStyle = 0; - if (m_windowStyle & wxRB_GROUP) - groupStyle = WS_GROUP; + return true; +} -// long msStyle = groupStyle | RADIO_FLAGS; - long msStyle = groupStyle | BS_AUTORADIOBUTTON | WS_CHILD | WS_VISIBLE /* | WS_CLIPSIBLINGS */; +// ---------------------------------------------------------------------------- +// wxRadioButton functions +// ---------------------------------------------------------------------------- - bool want3D; - WXDWORD exStyle = Determine3DEffects(0, &want3D) ; +void wxRadioButton::SetValue(bool value) +{ + ::SendMessage(GetHwnd(), BM_SETCHECK, + value ? BST_CHECKED : BST_UNCHECKED, 0); + + m_isChecked = value; + + if ( !value ) + return; + + // if we set the value of one radio button we also must clear all the other + // buttons in the same group: Windows doesn't do it automatically + // + // moreover, if another radiobutton in the group currently has the focus, + // we have to set it to this radiobutton, else the old radiobutton will be + // reselected automatically, if a parent window loses the focus and regains + // it. + wxWindow * const focus = FindFocus(); + wxTopLevelWindow * const + tlw = wxDynamicCast(wxGetTopLevelParent(this), wxTopLevelWindow); + wxCHECK_RET( tlw, wxT("radio button outside of TLW?") ); + wxWindow * const focusInTLW = tlw->GetLastFocus(); + + const wxWindowList& siblings = GetParent()->GetChildren(); + wxWindowList::compatibility_iterator nodeThis = siblings.Find(this); + wxCHECK_RET( nodeThis, wxT("radio button not a child of its parent?") ); + + // this will be set to true in the code below if the focus is in our TLW + // and belongs to one of the other buttons in the same group + bool shouldSetFocus = false; + + // this will be set to true if the focus is outside of our TLW currently + // but the remembered focus of this TLW is one of the other buttons in the + // same group + bool shouldSetTLWFocus = false; + + // if it's not the first item of the group ... + if ( !HasFlag(wxRB_GROUP) ) + { + // ... turn off all radio buttons before it + for ( wxWindowList::compatibility_iterator nodeBefore = nodeThis->GetPrevious(); + nodeBefore; + nodeBefore = nodeBefore->GetPrevious() ) + { + wxRadioButton *btn = wxDynamicCast(nodeBefore->GetData(), + wxRadioButton); + if ( !btn ) + { + // don't stop on non radio buttons, we could have intermixed + // buttons and e.g. static labels + continue; + } + + if ( btn->HasFlag(wxRB_SINGLE) ) + { + // A wxRB_SINGLE button isn't part of this group + break; + } + + if ( btn == focus ) + shouldSetFocus = true; + else if ( btn == focusInTLW ) + shouldSetTLWFocus = true; + + btn->SetValue(false); + + if ( btn->HasFlag(wxRB_GROUP) ) + { + // even if there are other radio buttons before this one, + // they're not in the same group with us + break; + } + } + } - // Even with extended styles, need to combine with WS_BORDER - // for them to look right. -/* - if ( want3D || wxStyleHasBorder(m_windowStyle) ) - msStyle |= WS_BORDER; -*/ + // ... and also turn off all buttons after this one + for ( wxWindowList::compatibility_iterator nodeAfter = nodeThis->GetNext(); + nodeAfter; + nodeAfter = nodeAfter->GetNext() ) + { + wxRadioButton *btn = wxDynamicCast(nodeAfter->GetData(), + wxRadioButton); - m_hWnd = (WXHWND) CreateWindowEx(exStyle, RADIO_CLASS, (const wxChar *)label, - msStyle,0,0,0,0, - (HWND) parent->GetHWND(), (HMENU)m_windowId, wxGetInstance(), NULL); + if ( !btn ) + continue; - wxCHECK_MSG( m_hWnd, FALSE, wxT("Failed to create radiobutton") ); + if ( btn->HasFlag(wxRB_GROUP | wxRB_SINGLE) ) + { + // no more buttons or the first button of the next group + break; + } -#if wxUSE_CTL3D - if (want3D) - { - Ctl3dSubclassCtl((HWND) m_hWnd); - m_useCtl3D = TRUE; - } -#endif + if ( btn == focus ) + shouldSetFocus = true; + else if ( btn == focusInTLW ) + shouldSetTLWFocus = true; - SetFont(parent->GetFont()); + btn->SetValue(false); + } - // Subclass again for purposes of dialog editing mode - SubclassWin((WXHWND)m_hWnd); + if ( shouldSetFocus ) + SetFocus(); + else if ( shouldSetTLWFocus ) + tlw->SetLastFocus(this); +} -// SetValue(value); +bool wxRadioButton::GetValue() const +{ + wxASSERT_MSG( m_isChecked == + (::SendMessage(GetHwnd(), BM_GETCHECK, 0, 0L) != 0), + wxT("wxRadioButton::m_isChecked is out of sync?") ); - // start GRW fix - if (label != wxT("")) - { - int label_width, label_height; - GetTextExtent(label, &label_width, &label_height, NULL, NULL, & this->GetFont()); - if (width < 0) - width = (int)(label_width + RADIO_SIZE); - if (height<0) - { - height = (int)(label_height); - if (height < RADIO_SIZE) - height = RADIO_SIZE; - } - } - else - { - if (width < 0) - width = RADIO_SIZE; - if (height < 0) - height = RADIO_SIZE; - } - // end GRW fix - - SetSize(x, y, width, height); - - // for compatibility with wxGTK, the first radio button in a group is - // always checked (this makes sense anyhow as you need to ensure that at - // least one button in the group is checked and this is the simlpest way to - // do it) - if ( m_windowStyle & wxRB_GROUP ) - SetValue(TRUE); - - return TRUE; + return m_isChecked; } +// ---------------------------------------------------------------------------- +// wxRadioButton event processing +// ---------------------------------------------------------------------------- -void wxRadioButton::SetLabel(const wxString& label) +void wxRadioButton::Command (wxCommandEvent& event) { - SetWindowText((HWND) GetHWND(), (const wxChar *)label); + SetValue(event.GetInt() != 0); + ProcessCommand(event); } -void wxRadioButton::SetValue(bool value) +bool wxRadioButton::MSWCommand(WXUINT param, WXWORD WXUNUSED(id)) { -// Following necessary for Win32s, because Win32s translate BM_SETCHECK - SendMessage((HWND) GetHWND(), BM_SETCHECK, (WPARAM)value, 0L); -} + if ( param != BN_CLICKED ) + return false; -// Get single selection -bool wxRadioButton::GetValue(void) const -{ - return (SendMessage((HWND) GetHWND(), BM_GETCHECK, 0, 0L) != 0); -} + if ( !m_isChecked ) + { + // we need to manually update the button state as we use BS_RADIOBUTTON + // and not BS_AUTORADIOBUTTON + SetValue(true); -void wxRadioButton::Command (wxCommandEvent & event) -{ - SetValue ( (event.m_commandInt != 0) ); - ProcessCommand (event); + wxCommandEvent event(wxEVT_COMMAND_RADIOBUTTON_SELECTED, GetId()); + event.SetEventObject( this ); + event.SetInt(true); // always checked + + ProcessCommand(event); + } + + return true; } -WXHBRUSH wxRadioButton::OnCtlColor(WXHDC pDC, WXHWND pWnd, WXUINT nCtlColor, - WXUINT message, - WXWPARAM wParam, - WXLPARAM lParam) +// ---------------------------------------------------------------------------- +// wxRadioButton geometry +// ---------------------------------------------------------------------------- + +wxSize wxRadioButton::DoGetBestSize() const { -#if wxUSE_CTL3D - if ( m_useCtl3D ) + static int s_radioSize = 0; + + if ( !s_radioSize ) { - HBRUSH hbrush = Ctl3dCtlColorEx(message, wParam, lParam); - return (WXHBRUSH) hbrush; - } -#endif // wxUSE_CTL3D + wxScreenDC dc; + dc.SetFont(wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT)); - HDC hdc = (HDC)pDC; - if (GetParent()->GetTransparentBackground()) - SetBkMode(hdc, TRANSPARENT); - else - SetBkMode(hdc, OPAQUE); + s_radioSize = dc.GetCharHeight(); - wxColour colBack = GetBackgroundColour(); + // radio button bitmap size under CE is bigger than the font height, + // adding just one pixel seems to work fine for the default font but it + // would be nice to find some better way to find the correct height +#ifdef __WXWINCE__ + s_radioSize++; +#endif // __WXWINCE__ + } - if (!IsEnabled()) - colBack = wxSystemSettings::GetSystemColour(wxSYS_COLOUR_3DFACE); + wxString str = GetLabel(); - ::SetBkColor(hdc, wxColourToRGB(colBack)); - ::SetTextColor(hdc, wxColourToRGB(GetForegroundColour())); + int wRadio, hRadio; + if ( !str.empty() ) + { + GetTextExtent(GetLabelText(str), &wRadio, &hRadio); + wRadio += s_radioSize + GetCharWidth(); - wxBrush *brush = wxTheBrushList->FindOrCreateBrush(colBack, wxSOLID); + if ( hRadio < s_radioSize ) + hRadio = s_radioSize; + } + else + { + wRadio = s_radioSize; + hRadio = s_radioSize; + } - return (WXHBRUSH)brush->GetResourceHandle(); + wxSize best(wRadio, hRadio); + CacheBestSize(best); + return best; } -// Not implemented -#if 0 -bool wxBitmapRadioButton::Create(wxWindow *parent, wxWindowID id, - const wxBitmap *bitmap, - const wxPoint& pos, - const wxSize& size, long style, - const wxValidator& validator, - const wxString& name) +WXDWORD wxRadioButton::MSWGetStyle(long style, WXDWORD *exstyle) const { - SetName(name); - SetValidator(validator); - - if (parent) parent->AddChild(this); - SetBackgroundColour(parent->GetBackgroundColour()); - SetForegroundColour(parent->GetForegroundColour()); - - if ( id == -1 ) - m_windowId = (int)NewControlId(); - else - m_windowId = id; - - int x = pos.x; - int y = pos.y; - int width = size.x; - int height = size.y; - m_windowStyle = style ; - - long groupStyle = 0; - if (m_windowStyle & wxRB_GROUP) - groupStyle = WS_GROUP; - -// long msStyle = groupStyle | RADIO_FLAGS; - long msStyle = groupStyle | BS_RADIOBUTTON | WS_CHILD | WS_VISIBLE ; - - m_hWnd = (WXHWND) CreateWindowEx(MakeExtendedStyle(m_windowStyle), RADIO_CLASS, "toggle", - msStyle,0,0,0,0, - (HWND) parent->GetHWND(), (HMENU)m_windowId, wxGetInstance(), NULL); - - wxCHECK_MSG( m_hWnd, "Failed to create radio button", FALSE ); - -#if wxUSE_CTL3D - if (!(GetParent()->GetWindowStyleFlag() & wxUSER_COLOURS)) - { - Ctl3dSubclassCtl((HWND) GetHWND()); - m_useCtl3D = TRUE; - } -#endif - - // Subclass again for purposes of dialog editing mode - SubclassWin(GetHWND()); + WXDWORD msStyle = wxControl::MSWGetStyle(style, exstyle); - SetSize(x, y, width, height); + if ( HasFlag(wxRB_GROUP) ) + msStyle |= WS_GROUP; - return TRUE; -} + // we use BS_RADIOBUTTON and not BS_AUTORADIOBUTTON because the use of the + // latter can easily result in the application entering an infinite loop + // inside IsDialogMessage() + // + // we used to use BS_RADIOBUTTON only for wxRB_SINGLE buttons but there + // doesn't seem to be any harm to always use it and it prevents some hangs, + // see #9786 + msStyle |= BS_RADIOBUTTON; -void wxBitmapRadioButton::SetLabel(const wxBitmap *bitmap) -{ -} + if ( style & wxCLIP_SIBLINGS ) + msStyle |= WS_CLIPSIBLINGS; + if ( style & wxALIGN_RIGHT ) + msStyle |= BS_LEFTTEXT | BS_RIGHT; -void wxBitmapRadioButton::SetValue(bool value) -{ -// Following necessary for Win32s, because Win32s translate BM_SETCHECK - SendMessage((HWND) GetHWND(), BM_SETCHECK, (WPARAM)value, 0L); -} -// Get single selection, for single choice list items -bool wxBitmapRadioButton::GetValue(void) const -{ - return (bool)SendMessage((HWND) GetHWND(), BM_GETCHECK, 0, 0L); + return msStyle; } -#endif +#endif // wxUSE_RADIOBTN