X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/a8ff046ba980a89f11125477e736cf235ebd7186..a43a9e5521440dbb28037646ed4a07125c8823a9:/src/msw/dib.cpp diff --git a/src/msw/dib.cpp b/src/msw/dib.cpp index f79d16a113..16bc7178b3 100644 --- a/src/msw/dib.cpp +++ b/src/msw/dib.cpp @@ -45,7 +45,7 @@ #include #include -#if !defined(__MWERKS__) && !defined(__SALFORDC__) +#if !defined(__MWERKS__) #include #endif @@ -96,39 +96,33 @@ bool wxDIB::Create(int width, int height, int depth) depth = 24; // allocate memory for bitmap structures - static const int sizeHeader = sizeof(BITMAPINFOHEADER); + BITMAPINFO info; + wxZeroMemory(info); - BITMAPINFO *info = (BITMAPINFO *)malloc(sizeHeader); - wxCHECK_MSG( info, false, _T("malloc(BITMAPINFO) failed") ); - - memset(info, 0, sizeHeader); - - info->bmiHeader.biSize = sizeHeader; - info->bmiHeader.biWidth = width; + info.bmiHeader.biSize = sizeof(BITMAPINFOHEADER); + info.bmiHeader.biWidth = width; // we use positive height here which corresponds to a DIB with normal, i.e. // bottom to top, order -- normally using negative height (which means // reversed for MS and hence natural for all the normal people top to // bottom line scan order) could be used to avoid the need for the image // reversal in Create(image) but this doesn't work under NT, only Win9x! - info->bmiHeader.biHeight = height; + info.bmiHeader.biHeight = height; - info->bmiHeader.biPlanes = 1; - info->bmiHeader.biBitCount = (WORD)depth; - info->bmiHeader.biSizeImage = GetLineSize(width, depth)*height; + info.bmiHeader.biPlanes = 1; + info.bmiHeader.biBitCount = (WORD)depth; + info.bmiHeader.biSizeImage = GetLineSize(width, depth)*height; m_handle = ::CreateDIBSection ( 0, // hdc (unused with DIB_RGB_COLORS) - info, // bitmap description + &info, // bitmap description DIB_RGB_COLORS, // use RGB, not palette &m_data, // [out] DIB bits NULL, // don't use file mapping 0 // file mapping offset (not used here) ); - free(info); - if ( !m_handle ) { wxLogLastError(wxT("CreateDIBSection")); @@ -564,7 +558,7 @@ HGLOBAL wxDIB::ConvertFromBitmap(HBITMAP hbmp) { // this is an error which does risk to happen especially under Win9x // and which the user may understand so let him know about it - wxLogError(_("Failed to allocated %luKb of memory for bitmap data."), + wxLogError(_("Failed to allocate %luKb of memory for bitmap data."), (unsigned long)(size / 1024)); return NULL; @@ -789,9 +783,9 @@ wxImage wxDIB::ConvertToImage() const *alpha++ = a; if ( a > 0 ) { - dst[0] = (dst[0] * 255 - 127) / a; - dst[1] = (dst[1] * 255 - 127) / a; - dst[2] = (dst[2] * 255 - 127) / a; + dst[0] = (dst[0] * 255) / a; + dst[1] = (dst[1] * 255) / a; + dst[2] = (dst[2] * 255) / a; } }