X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/a8e65eeeae46b9df8577903469c65bb218489372..7b35aa40a06a160ae4a8650c5820880a020697e3:/src/msw/choice.cpp

diff --git a/src/msw/choice.cpp b/src/msw/choice.cpp
index 32b36c3603..f57a180cac 100644
--- a/src/msw/choice.cpp
+++ b/src/msw/choice.cpp
@@ -200,13 +200,22 @@ void wxChoice::SetString(int n, const wxString& s)
 
 wxString wxChoice::GetString(int n) const
 {
-    size_t len = (size_t)::SendMessage(GetHwnd(), CB_GETLBTEXTLEN, n, 0);
+    int len = (int)::SendMessage(GetHwnd(), CB_GETLBTEXTLEN, n, 0);
+
     wxString str;
-    if (len) {
-        if ( ::SendMessage(GetHwnd(), CB_GETLBTEXT, n,
-                           (LPARAM)str.GetWriteBuf(len)) == CB_ERR ) {
+    if ( len != CB_ERR && len > 0 )
+    {
+        if ( ::SendMessage
+               (
+                GetHwnd(),
+                CB_GETLBTEXT,
+                n,
+                (LPARAM)(wxChar *)wxStringBuffer(str, len)
+               ) == CB_ERR )
+        {
             wxLogLastError(wxT("SendMessage(CB_GETLBTEXT)"));
         }
+
         str.UngetWriteBuf();
     }
 
@@ -281,8 +290,7 @@ void wxChoice::DoSetSize(int x, int y,
     // the _displayed_ size (NOT the drop down menu size) so
     // setting-getting-setting size would not work.
 
-    wxSize sz = GetSize();
-    wxControl::DoSetSize(x, y, width, sz.y, sizeFlags);
+    wxControl::DoSetSize(x, y, width, -1, sizeFlags);
 }
 
 wxSize wxChoice::DoGetBestSize() const