X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/a8780ad5bbd52c859eaeba01c2f739cbb15c1576..6aaee6afdcde7c9e677f642303d4988a66cb9dc9:/src/cocoa/window.mm diff --git a/src/cocoa/window.mm b/src/cocoa/window.mm index 23fee50c2a..01c776073b 100644 --- a/src/cocoa/window.mm +++ b/src/cocoa/window.mm @@ -23,7 +23,9 @@ #include "wx/cocoa/autorelease.h" #include "wx/cocoa/string.h" #include "wx/cocoa/trackingrectmanager.h" +#include "wx/mac/corefoundation/cfref.h" +#import #import #include "wx/cocoa/objc/NSView.h" #import @@ -33,6 +35,7 @@ #import #import #import +#import // Turn this on to paint green over the dummy views for debugging #undef WXCOCOA_FILL_DUMMY_VIEW @@ -41,6 +44,9 @@ #import #endif //def WXCOCOA_FILL_DUMMY_VIEW +// STL list used by wxCocoaMouseMovedEventSynthesizer +#include + /* NSComparisonResult is typedef'd as an enum pre-Leopard but typedef'd as * NSInteger post-Leopard. Pre-Leopard the Cocoa toolkit expects a function * returning int and not NSComparisonResult. Post-Leopard the Cocoa toolkit @@ -58,6 +64,10 @@ typedef int CocoaWindowCompareFunctionResult; - (void)getRectsBeingDrawn:(const NSRect **)rects count:(int *)count; @end +// ======================================================================== +// Helper functions for converting to/from wxWidgets coordinates and a +// specified NSView's coordinate system. +// ======================================================================== NSPoint CocoaTransformNSViewBoundsToWx(NSView *nsview, NSPoint pointBounds) { wxCHECK_MSG(nsview, pointBounds, wxT("Need to have a Cocoa view to do translation")); @@ -110,6 +120,149 @@ NSRect CocoaTransformNSViewWxToBounds(NSView *nsview, NSRect rectWx) ); } +// ============================================================================ +// Screen coordinate helpers +// ============================================================================ + +/* +General observation about Cocoa screen coordinates: +It is documented that the first object of the [NSScreen screens] array is the screen with the menubar. + +It is not documented (but true as far as I can tell) that (0,0) in Cocoa screen coordinates is always +the BOTTOM-right corner of this screen. Recall that Cocoa uses cartesian coordinates so y-increase is up. + +It isn't clearly documented but visibleFrame returns a rectangle in screen coordinates, not a rectangle +relative to that screen's frame. The only real way to test this is to configure two screens one atop +the other such that the menubar screen is on top. The Dock at the bottom of the screen will then +eat into the visibleFrame of screen 1 by incrementing it's y-origin. Thus if you arrange two +1920x1200 screens top/bottom then screen 1 (the bottom screen) will have frame origin (0,-1200) and +visibleFrame origin (0,-1149) which is exactly 51 pixels higher than the full frame origin. + +In wxCocoa, we somewhat arbitrarily declare that wx (0,0) is the TOP-left of screen 0's frame (the entire screen). +However, this isn't entirely arbitrary because the Quartz Display Services (CGDisplay) uses this same scheme. +This works out nicely because wxCocoa's wxDisplay is implemented using Quartz Display Services instead of NSScreen. +*/ + +namespace { // file namespace + +class wxCocoaPrivateScreenCoordinateTransformer +{ + DECLARE_NO_COPY_CLASS(wxCocoaPrivateScreenCoordinateTransformer) +public: + wxCocoaPrivateScreenCoordinateTransformer(); + ~wxCocoaPrivateScreenCoordinateTransformer(); + wxPoint OriginInWxDisplayCoordinatesForRectInCocoaScreenCoordinates(NSRect windowFrame); + NSPoint OriginInCocoaScreenCoordinatesForRectInWxDisplayCoordinates(wxCoord x, wxCoord y, wxCoord width, wxCoord height, bool keepOriginVisible); + +protected: + NSScreen *m_screenZero; + NSRect m_screenZeroFrame; +}; + +// NOTE: This is intended to be a short-lived object. A future enhancment might +// make it a global and reconfigure it upon some notification that the screen layout +// has changed. +inline wxCocoaPrivateScreenCoordinateTransformer::wxCocoaPrivateScreenCoordinateTransformer() +{ + NSArray *screens = [NSScreen screens]; + + [screens retain]; + + m_screenZero = nil; + if(screens != nil && [screens count] > 0) + m_screenZero = [[screens objectAtIndex:0] retain]; + + [screens release]; + + if(m_screenZero != nil) + m_screenZeroFrame = [m_screenZero frame]; + else + { + wxLogWarning(wxT("Can't translate to/from wx screen coordinates and Cocoa screen coordinates")); + // Just blindly assume 1024x768 so that at least we can sort of flip things around into + // Cocoa coordinates. + // NOTE: Theoretically this case should never happen anyway. + m_screenZeroFrame = NSMakeRect(0,0,1024,768); + } +} + +inline wxCocoaPrivateScreenCoordinateTransformer::~wxCocoaPrivateScreenCoordinateTransformer() +{ + [m_screenZero release]; + m_screenZero = nil; +} + +inline wxPoint wxCocoaPrivateScreenCoordinateTransformer::OriginInWxDisplayCoordinatesForRectInCocoaScreenCoordinates(NSRect windowFrame) +{ + // x and y are in wx screen coordinates which we're going to arbitrarily define such that + // (0,0) is the TOP-left of screen 0 (the one with the menubar) + // NOTE WELL: This means that (0,0) is _NOT_ an appropriate position for a window. + + wxPoint theWxOrigin; + + // Working in Cocoa's screen coordinates we must realize that the x coordinate we want is + // the distance between the left side (origin.x) of the window's frame and the left side of + // screen zero's frame. + theWxOrigin.x = windowFrame.origin.x - m_screenZeroFrame.origin.x; + + // Working in Cocoa's screen coordinates we must realize that the y coordinate we want is + // actually the distance between the top-left of the screen zero frame and the top-left + // of the window's frame. + + theWxOrigin.y = (m_screenZeroFrame.origin.y + m_screenZeroFrame.size.height) - (windowFrame.origin.y + windowFrame.size.height); + + return theWxOrigin; +} + +inline NSPoint wxCocoaPrivateScreenCoordinateTransformer::OriginInCocoaScreenCoordinatesForRectInWxDisplayCoordinates(wxCoord x, wxCoord y, wxCoord width, wxCoord height, bool keepOriginVisible) +{ + NSPoint theCocoaOrigin; + + // The position is in wx screen coordinates which we're going to arbitrarily define such that + // (0,0) is the TOP-left of screen 0 (the one with the menubar) + + // NOTE: The usable rectangle is smaller and hence we have the keepOriginVisible flag + // which will move the origin downward and/or left as necessary if the origin is + // inside the screen0 rectangle (i.e. x/y >= 0 in wx coordinates) and outside the + // visible frame (i.e. x/y < the top/left of the screen0 visible frame in wx coordinates) + // We don't munge origin coordinates < 0 because it actually is possible that the menubar is on + // the top of the bottom screen and thus that origin is completely valid! + if(keepOriginVisible && (m_screenZero != nil)) + { + // Do al of this in wx coordinates because it's far simpler since we're dealing with top/left points + wxPoint visibleOrigin = OriginInWxDisplayCoordinatesForRectInCocoaScreenCoordinates([m_screenZero visibleFrame]); + if(x >= 0 && x < visibleOrigin.x) + x = visibleOrigin.x; + if(y >= 0 && y < visibleOrigin.y) + y = visibleOrigin.y; + } + + // The x coordinate is simple as it's just relative to screen zero's frame + theCocoaOrigin.x = m_screenZeroFrame.origin.x + x; + // Working in Cocoa's coordinates think to start at the bottom of screen zero's frame and add + // the height of that rect which gives us the coordinate for the top of the visible rect. Now realize that + // the wx coordinates are flipped so if y is say 10 then we want to be 10 pixels down from that and thus + // we subtract y. But then we still need to take into account the size of the window which is h and subtract + // that to get the bottom-left origin of the rectangle. + theCocoaOrigin.y = m_screenZeroFrame.origin.y + m_screenZeroFrame.size.height - y - height; + + return theCocoaOrigin; +} + +} // namespace + +wxPoint wxWindowCocoa::OriginInWxDisplayCoordinatesForRectInCocoaScreenCoordinates(NSRect windowFrame) +{ + wxCocoaPrivateScreenCoordinateTransformer transformer; + return transformer.OriginInWxDisplayCoordinatesForRectInCocoaScreenCoordinates(windowFrame); +} + +NSPoint wxWindowCocoa::OriginInCocoaScreenCoordinatesForRectInWxDisplayCoordinates(wxCoord x, wxCoord y, wxCoord width, wxCoord height, bool keepOriginVisible) +{ + wxCocoaPrivateScreenCoordinateTransformer transformer; + return transformer.OriginInCocoaScreenCoordinatesForRectInWxDisplayCoordinates(x,y,width,height,keepOriginVisible); +} + // ======================================================================== // wxWindowCocoaHider // ======================================================================== @@ -387,7 +540,6 @@ void wxWindowCocoa::CocoaAddChild(wxWindowCocoa *child) wxASSERT(childView); [m_cocoaNSView addSubview: childView]; - child->m_isShown = !m_cocoaHider; } void wxWindowCocoa::CocoaRemoveFromParent(void) @@ -558,7 +710,7 @@ bool wxWindowCocoa::Cocoa_mouseEntered(WX_NSEvent theEvent) wxMouseEvent event(wxEVT_ENTER_WINDOW); InitMouseEvent(event,theEvent); - wxLogTrace(wxTRACE_COCOA,wxT("wxwin=%p Mouse Entered @%d,%d"),this,event.m_x,event.m_y); + wxLogTrace(wxTRACE_COCOA_TrackingRect,wxT("wxwin=%p Mouse Entered TR#%d @%d,%d"),this,[theEvent trackingNumber], event.m_x,event.m_y); return GetEventHandler()->ProcessEvent(event); } else @@ -573,7 +725,7 @@ bool wxWindowCocoa::Cocoa_mouseExited(WX_NSEvent theEvent) wxMouseEvent event(wxEVT_LEAVE_WINDOW); InitMouseEvent(event,theEvent); - wxLogTrace(wxTRACE_COCOA,wxT("wxwin=%p Mouse Exited @%d,%d"),this,event.m_x,event.m_y); + wxLogTrace(wxTRACE_COCOA_TrackingRect,wxT("wxwin=%p Mouse Exited TR#%d @%d,%d"),this,[theEvent trackingNumber],event.m_x,event.m_y); return GetEventHandler()->ProcessEvent(event); } else @@ -658,8 +810,21 @@ void wxWindowCocoa::Cocoa_FrameChanged(void) bool wxWindowCocoa::Cocoa_resetCursorRects() { wxLogTrace(wxTRACE_COCOA,wxT("wxWindow=%p::Cocoa_resetCursorRects"),this); + + // When we are called there may be a queued tracking rect event (mouse entered or exited) and + // we won't know it. A specific example is wxGenericHyperlinkCtrl changing the cursor from its + // mouse exited event. If the control happens to share the edge with its parent window which is + // also tracking mouse events then Cocoa receives two mouse exited events from the window server. + // The first one will cause wxGenericHyperlinkCtrl to call wxWindow::SetCursor which will + // invaildate the cursor rect causing Cocoa to schedule cursor rect reset with the run loop + // which willl in turn call us before exiting for the next user event. + + // If we are the parent window then rebuilding our tracking rectangle will cause us to miss + // our mouse exited event because the already queued event will have the old tracking rect + // tag. The simple solution is to only rebuild our tracking rect if we need to. + if(m_visibleTrackingRectManager != NULL) - m_visibleTrackingRectManager->RebuildTrackingRect(); + m_visibleTrackingRectManager->RebuildTrackingRectIfNeeded(); if(!m_cursor.GetNSCursor()) return false; @@ -673,7 +838,15 @@ bool wxWindowCocoa::SetCursor(const wxCursor &cursor) { if(!wxWindowBase::SetCursor(cursor)) return false; + + // Set up the cursor rect so that invalidateCursorRectsForView: will destroy it. + // If we don't do this then Cocoa thinks (rightly) that we don't have any cursor + // rects and thus won't ever call resetCursorRects. + [GetNSView() addCursorRect: [GetNSView() visibleRect] cursor: m_cursor.GetNSCursor()]; + // Invalidate the cursor rects so the cursor will change + // Note that it is not enough to remove the old one (if any) and add the new one. + // For the rects to work properly, Cocoa itself must call resetCursorRects. [[GetNSView() window] invalidateCursorRectsForView:GetNSView()]; return true; } @@ -908,12 +1081,49 @@ void wxWindow::DoReleaseMouse() void wxWindow::DoScreenToClient(int *x, int *y) const { - // TODO + // Point in cocoa screen coordinates: + NSPoint cocoaScreenPoint = OriginInCocoaScreenCoordinatesForRectInWxDisplayCoordinates(x!=NULL?*x:0, y!=NULL?*y:0, 0, 0, false); + NSView *clientView = const_cast(this)->GetNSView(); + NSWindow *theWindow = [clientView window]; + + // Point in window's base coordinate system: + NSPoint windowPoint = [theWindow convertScreenToBase:cocoaScreenPoint]; + // Point in view's bounds coordinate system + NSPoint boundsPoint = [clientView convertPoint:windowPoint fromView:nil]; + // Point in wx client coordinates: + NSPoint theWxClientPoint = CocoaTransformNSViewBoundsToWx(clientView, boundsPoint); + if(x!=NULL) + *x = theWxClientPoint.x; + if(y!=NULL) + *y = theWxClientPoint.y; } void wxWindow::DoClientToScreen(int *x, int *y) const { - // TODO + // Point in wx client coordinates + NSPoint theWxClientPoint = NSMakePoint(x!=NULL?*x:0, y!=NULL?*y:0); + + NSView *clientView = const_cast(this)->GetNSView(); + + // Point in the view's bounds coordinate system + NSPoint boundsPoint = CocoaTransformNSViewWxToBounds(clientView, theWxClientPoint); + + // Point in the window's base coordinate system + NSPoint windowPoint = [clientView convertPoint:boundsPoint toView:nil]; + + NSWindow *theWindow = [clientView window]; + // Point in Cocoa's screen coordinates + NSPoint screenPoint = [theWindow convertBaseToScreen:windowPoint]; + + // Act as though this was the origin of a 0x0 rectangle + NSRect screenPointRect = NSMakeRect(screenPoint.x, screenPoint.y, 0, 0); + + // Convert that rectangle to wx coordinates + wxPoint theWxScreenPoint = OriginInWxDisplayCoordinatesForRectInCocoaScreenCoordinates(screenPointRect); + if(*x) + *x = theWxScreenPoint.x; + if(*y) + *y = theWxScreenPoint.y; } // Get size *available for subwindows* i.e. excluding menu bar etc. @@ -954,19 +1164,24 @@ wxString wxWindow::GetLabel() const int wxWindow::GetCharHeight() const { // TODO - return 0; + return 10; } int wxWindow::GetCharWidth() const { // TODO - return 0; + return 5; } -void wxWindow::GetTextExtent(const wxString& string, int *x, int *y, - int *descent, int *externalLeading, const wxFont *theFont) const +void wxWindow::GetTextExtent(const wxString& string, int *outX, int *outY, + int *outDescent, int *outExternalLeading, const wxFont *inFont) const { - // TODO + // FIXME: This obviously ignores the window's font (if any) along with any size + // transformations. However, it's better than nothing. + // We don't create a wxClientDC because we don't want to accidently be able to use + // it for drawing. + wxDC tmpdc; + return tmpdc.GetTextExtent(string, outX, outY, outDescent, outExternalLeading, inFont); } // Coordinates relative to the window @@ -1022,17 +1237,50 @@ void wxWindow::ScrollWindow(int dx, int dy, const wxRect *rect) // TODO } +static inline int _DoFixupDistance(int vDistance, int cDistance) +{ + // If the virtual distance is wxDefaultCoord, set it to the client distance + // This definitely has to be done or else we literally get views with a -1 size component! + if(vDistance == wxDefaultCoord) + vDistance = cDistance; + // NOTE: Since cDistance should always be >= 0 and since wxDefaultCoord is -1, the above + // test is more or less useless because it gets covered by the next one. However, just in + // case anyone decides that the next test is not correct, I want them to be aware that + // the above test would still be needed. + + // I am not entirely sure about this next one but I believe it makes sense because + // otherwise the virtual view (which is the m_cocoaNSView that got wrapped by the scrolling + // machinery) can be smaller than the NSClipView (the client area) which + // means that, for instance, mouse clicks inside the client area as wx sees it but outside + // the virtual area as wx sees it won't be seen by the m_cocoaNSView. + // We make the assumption that if a virtual distance is less than the client distance that + // the real view must already be or will soon be positioned at coordinate 0 within the + // NSClipView that represents the client area. This way, when we increase the distance to + // be the client distance, the real view will exactly fit in the clip view. + else if(vDistance < cDistance) + vDistance = cDistance; + return vDistance; +} + void wxWindow::DoSetVirtualSize( int x, int y ) { + // Call wxWindowBase method which will set m_virtualSize to the appropriate value, + // possibly not what the caller passed in. For example, the current implementation + // clamps the width and height to within the min/max virtual ranges. + // wxDefaultCoord is passed through unchanged which means we need to handle it ourselves + // which we do by using the _DoFixupDistance helper method. wxWindowBase::DoSetVirtualSize(x,y); + // Create the scroll view if it hasn't been already. CocoaCreateNSScrollView(); - [m_cocoaNSView setFrameSize:NSMakeSize(m_virtualSize.x,m_virtualSize.y)]; + // Now use fixed-up distances when setting the frame size + wxSize clientSize = GetClientSize(); + [m_cocoaNSView setFrameSize:NSMakeSize(_DoFixupDistance(m_virtualSize.x, clientSize.x), _DoFixupDistance(m_virtualSize.y, clientSize.y))]; } bool wxWindow::SetFont(const wxFont& font) { - // TODO - return true; + // FIXME: We may need to handle wx font inheritance. + return wxWindowBase::SetFont(font); } #if 0 // these are used when debugging the algorithm. @@ -1222,6 +1470,145 @@ wxWindow* wxFindWindowAtPointer(wxPoint& pt) return NULL; } +// ======================================================================== +// wxCocoaMouseMovedEventSynthesizer +// ======================================================================== + +#define wxTRACE_COCOA_MouseMovedSynthesizer wxT("COCOA_MouseMovedSynthesizer") + +/* This class registers one run loop observer to cover all windows registered with it. + * It will register the observer when the first view is registerd and unregister the + * observer when the last view is unregistered. + * It is instantiated as a static s_mouseMovedSynthesizer in this file although there + * is no reason it couldn't be instantiated multiple times. + */ +class wxCocoaMouseMovedEventSynthesizer +{ + DECLARE_NO_COPY_CLASS(wxCocoaMouseMovedEventSynthesizer) +public: + wxCocoaMouseMovedEventSynthesizer() + { m_lastScreenMouseLocation = NSZeroPoint; + } + ~wxCocoaMouseMovedEventSynthesizer(); + void RegisterWxCocoaView(wxCocoaNSView *aView); + void UnregisterWxCocoaView(wxCocoaNSView *aView); + void SynthesizeMouseMovedEvent(); + +protected: + void AddRunLoopObserver(); + void RemoveRunLoopObserver(); + wxCFRef m_runLoopObserver; + std::list m_registeredViews; + NSPoint m_lastScreenMouseLocation; + static void SynthesizeMouseMovedEvent(CFRunLoopObserverRef observer, CFRunLoopActivity activity, void *info); +}; + +void wxCocoaMouseMovedEventSynthesizer::RegisterWxCocoaView(wxCocoaNSView *aView) +{ + m_registeredViews.push_back(aView); + wxLogTrace(wxTRACE_COCOA_MouseMovedSynthesizer, wxT("Registered wxCocoaNSView=%p"), aView); + + if(!m_registeredViews.empty() && m_runLoopObserver == NULL) + { + AddRunLoopObserver(); + } +} + +void wxCocoaMouseMovedEventSynthesizer::UnregisterWxCocoaView(wxCocoaNSView *aView) +{ + m_registeredViews.remove(aView); + wxLogTrace(wxTRACE_COCOA_MouseMovedSynthesizer, wxT("Unregistered wxCocoaNSView=%p"), aView); + if(m_registeredViews.empty() && m_runLoopObserver != NULL) + { + RemoveRunLoopObserver(); + } +} + +wxCocoaMouseMovedEventSynthesizer::~wxCocoaMouseMovedEventSynthesizer() +{ + if(!m_registeredViews.empty()) + { + // This means failure to clean up so we report on it as a debug message. + wxLogDebug(wxT("There are still %d wxCocoaNSView registered to receive mouse moved events at static destruction time"), m_registeredViews.size()); + m_registeredViews.clear(); + } + if(m_runLoopObserver != NULL) + { + // This should not occur unless m_registeredViews was not empty since the last object unregistered should have done this. + wxLogDebug(wxT("Removing run loop observer during static destruction time.")); + RemoveRunLoopObserver(); + } +} + +void wxCocoaMouseMovedEventSynthesizer::SynthesizeMouseMovedEvent(CFRunLoopObserverRef observer, CFRunLoopActivity activity, void *info) +{ + reinterpret_cast(info)->SynthesizeMouseMovedEvent(); +} + +void wxCocoaMouseMovedEventSynthesizer::AddRunLoopObserver() +{ + CFRunLoopObserverContext observerContext = + { 0 + , this + , NULL + , NULL + , NULL + }; + + // The kCFRunLoopExit observation point is used such that we hook the run loop after it has already decided that + // it is going to exit which is generally for the purpose of letting the event loop process the next Cocoa event. + + // Executing our procedure within the run loop (e.g. kCFRunLoopBeforeWaiting which was used before) results + // in our observer procedure being called before the run loop has decided that it is going to return control to + // the Cocoa event loop. One major problem is uncovered by the wxGenericHyperlinkCtrl (consider this to be "user + // code") which changes the window's cursor and thus causes the cursor rectangle's to be invalidated. + + // Cocoa implements this invalidation using a delayed notification scheme whereby the resetCursorRects method + // won't be called until the CFRunLoop gets around to it. If the CFRunLoop has not yet exited then it will get + // around to it before letting the event loop do its work. This has some very odd effects on the way the + // newly created tracking rects function. In particular, we will often miss the mouseExited: message if the + // user flicks the mouse quickly enough such that the mouse is already outside of the tracking rect by the + // time the new one is built. + + // Observing from the kCFRunLoopExit point gives Cocoa's event loop an opportunity to chew some events before it cedes + // control back to the CFRunLoop, thus causing the delayed notifications to fire at an appropriate time and + // the mouseExited: message to be sent properly. + + m_runLoopObserver.reset(CFRunLoopObserverCreate(kCFAllocatorDefault, kCFRunLoopExit, TRUE, 0, SynthesizeMouseMovedEvent, &observerContext)); + CFRunLoopAddObserver([[NSRunLoop currentRunLoop] getCFRunLoop], m_runLoopObserver, kCFRunLoopCommonModes); + wxLogTrace(wxTRACE_COCOA_TrackingRect, wxT("Added tracking rect run loop observer")); +} + +void wxCocoaMouseMovedEventSynthesizer::RemoveRunLoopObserver() +{ + CFRunLoopRemoveObserver([[NSRunLoop currentRunLoop] getCFRunLoop], m_runLoopObserver, kCFRunLoopCommonModes); + m_runLoopObserver.reset(); + wxLogTrace(wxTRACE_COCOA_TrackingRect, wxT("Removed tracking rect run loop observer")); +} + +void wxCocoaMouseMovedEventSynthesizer::SynthesizeMouseMovedEvent() +{ + NSPoint screenMouseLocation = [NSEvent mouseLocation]; + // Checking the last mouse location is done for a few reasons: + // 1. We are observing every iteration of the event loop so we'd be sending out a lot of extraneous events + // telling the app the mouse moved when the user hit a key for instance. + // 2. When handling the mouse moved event, user code can do something to the view which will cause Cocoa to + // call resetCursorRects. Cocoa does this by using a delayed notification which means the event loop gets + // pumped once which would mean that if we didn't check the mouse location we'd get into a never-ending + // loop causing the tracking rectangles to constantly be reset. + if(screenMouseLocation.x != m_lastScreenMouseLocation.x || screenMouseLocation.y != m_lastScreenMouseLocation.y) + { + m_lastScreenMouseLocation = screenMouseLocation; + wxLogTrace(wxTRACE_COCOA_TrackingRect, wxT("Synthesizing mouse moved at screen (%f,%f)"), screenMouseLocation.x, screenMouseLocation.y); + for(std::list::iterator i = m_registeredViews.begin(); i != m_registeredViews.end(); ++i) + { + (*i)->Cocoa_synthesizeMouseMoved(); + } + } +} + +// Singleton used for all views: +static wxCocoaMouseMovedEventSynthesizer s_mouseMovedSynthesizer; // ======================================================================== // wxCocoaTrackingRectManager @@ -1231,7 +1618,6 @@ wxCocoaTrackingRectManager::wxCocoaTrackingRectManager(wxWindow *window) : m_window(window) { m_isTrackingRectActive = false; - m_runLoopObserver = NULL; BuildTrackingRect(); } @@ -1241,6 +1627,7 @@ void wxCocoaTrackingRectManager::ClearTrackingRect() { [m_window->GetNSView() removeTrackingRect:m_trackingRectTag]; m_isTrackingRectActive = false; + wxLogTrace(wxTRACE_COCOA_TrackingRect, wxT("%s@%p: Removed tracking rect #%d"), m_window->GetClassInfo()->GetClassName(), m_window, m_trackingRectTag); } // If we were doing periodic events we need to clear those too StopSynthesizingEvents(); @@ -1248,12 +1635,7 @@ void wxCocoaTrackingRectManager::ClearTrackingRect() void wxCocoaTrackingRectManager::StopSynthesizingEvents() { - if(m_runLoopObserver != NULL) - { - CFRunLoopRemoveObserver([[NSRunLoop currentRunLoop] getCFRunLoop], m_runLoopObserver, kCFRunLoopCommonModes); - CFRelease(m_runLoopObserver); - m_runLoopObserver = NULL; - } + s_mouseMovedSynthesizer.UnregisterWxCocoaView(m_window); } void wxCocoaTrackingRectManager::BuildTrackingRect() @@ -1262,36 +1644,39 @@ void wxCocoaTrackingRectManager::BuildTrackingRect() wxAutoNSAutoreleasePool pool; wxASSERT_MSG(!m_isTrackingRectActive, wxT("Tracking rect was not cleared")); - if([m_window->GetNSView() window] != nil) + + NSView *theView = m_window->GetNSView(); + + if([theView window] != nil) { - m_trackingRectTag = [m_window->GetNSView() addTrackingRect:[m_window->GetNSView() visibleRect] owner:m_window->GetNSView() userData:NULL assumeInside:NO]; + NSRect visibleRect = [theView visibleRect]; + + m_trackingRectTag = [theView addTrackingRect:visibleRect owner:theView userData:NULL assumeInside:NO]; + m_trackingRectInWindowCoordinates = [theView convertRect:visibleRect toView:nil]; m_isTrackingRectActive = true; + + wxLogTrace(wxTRACE_COCOA_TrackingRect, wxT("%s@%p: Added tracking rect #%d"), m_window->GetClassInfo()->GetClassName(), m_window, m_trackingRectTag); } } -static NSPoint s_lastScreenMouseLocation = NSZeroPoint; - -static void SynthesizeMouseMovedEvent(CFRunLoopObserverRef observer, CFRunLoopActivity activity, void *info) +void wxCocoaTrackingRectManager::BeginSynthesizingEvents() { - NSPoint screenMouseLocation = [NSEvent mouseLocation]; - if(screenMouseLocation.x != s_lastScreenMouseLocation.x || screenMouseLocation.y != s_lastScreenMouseLocation.y) - { - wxCocoaNSView *win = reinterpret_cast(info); - win->Cocoa_synthesizeMouseMoved(); - } + s_mouseMovedSynthesizer.RegisterWxCocoaView(m_window); } -void wxCocoaTrackingRectManager::BeginSynthesizingEvents() +void wxCocoaTrackingRectManager::RebuildTrackingRectIfNeeded() { - CFRunLoopObserverContext observerContext = - { 0 - , static_cast(m_window) - , NULL - , NULL - , NULL - }; - m_runLoopObserver = CFRunLoopObserverCreate(kCFAllocatorDefault, kCFRunLoopBeforeWaiting, TRUE, 0, SynthesizeMouseMovedEvent, &observerContext); - CFRunLoopAddObserver([[NSRunLoop currentRunLoop] getCFRunLoop], m_runLoopObserver, kCFRunLoopCommonModes); + if(m_isTrackingRectActive) + { + NSView *theView = m_window->GetNSView(); + NSRect currentRect = [theView convertRect:[theView visibleRect] toView:nil]; + if(NSEqualRects(m_trackingRectInWindowCoordinates,currentRect)) + { + wxLogTrace(wxTRACE_COCOA_TrackingRect, wxT("Ignored request to rebuild TR#%d"), m_trackingRectTag); + return; + } + } + RebuildTrackingRect(); } void wxCocoaTrackingRectManager::RebuildTrackingRect()