X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/a7c58211dbcef64535223ca550cc8ad34f890cf8..129b8b1a215fc1fcc1b9f06daa0aeaf22bbce614:/src/generic/datectlg.cpp

diff --git a/src/generic/datectlg.cpp b/src/generic/datectlg.cpp
index 4602a9c107..2626290a3b 100644
--- a/src/generic/datectlg.cpp
+++ b/src/generic/datectlg.cpp
@@ -1,5 +1,5 @@
 /////////////////////////////////////////////////////////////////////////////
-// Name:        generic/datectlg.cpp
+// Name:        src/generic/datectlg.cpp
 // Purpose:     generic wxDatePickerCtrlGeneric implementation
 // Author:      Andreas Pflug
 // Modified by:
@@ -29,10 +29,10 @@
 
 // use this version if we're explicitly requested to do it or if it's the only
 // one we have
-#if wxUSE_DATEPICKCTRL_GENERIC || !defined(wxHAS_NATIVE_DATEPICKCTRL)
+#if !defined(wxHAS_NATIVE_DATEPICKCTRL) || \
+        (defined(wxUSE_DATEPICKCTRL_GENERIC) && wxUSE_DATEPICKCTRL_GENERIC)
 
 #ifndef WX_PRECOMP
-    #include "wx/bmpbuttn.h"
     #include "wx/dialog.h"
     #include "wx/dcmemory.h"
     #include "wx/panel.h"
@@ -44,102 +44,337 @@
     // this header is not included from wx/datectrl.h if we have a native
     // version, but we do need it here
     #include "wx/generic/datectrl.h"
-#endif
-
-// we need to define _WX_DEFINE_DATE_EVENTS_ before including wx/dateevt.h to
-// define the event types we use if we're the only date picker control version
-// being compiled -- otherwise it's defined in the native version implementation
-#ifndef wxHAS_NATIVE_DATEPICKCTRL
+#else
+    // we need to define _WX_DEFINE_DATE_EVENTS_ before including wx/dateevt.h to
+    // define the event types we use if we're the only date picker control version
+    // being compiled -- otherwise it's defined in the native version implementation
     #define _WX_DEFINE_DATE_EVENTS_
 #endif
 
 #include "wx/dateevt.h"
 
 #include "wx/calctrl.h"
-#include "wx/renderer.h"
+#include "wx/combo.h"
 
 // ----------------------------------------------------------------------------
 // constants
 // ----------------------------------------------------------------------------
 
-enum
-{
-    CTRLID_TXT = 101,
-    CTRLID_CAL,
-    CTRLID_BTN,
-    CTRLID_PAN
-};
-
-#ifndef DEFAULT_ITEM_WIDTH
-    #define DEFAULT_ITEM_WIDTH 100
+#if defined(__WXMSW__)
+    #define CALBORDER         0
+#else
+    #define CALBORDER         4
 #endif
 
 // ----------------------------------------------------------------------------
-// local classes
+// global variables
 // ----------------------------------------------------------------------------
 
-#if wxUSE_POPUPWIN
 
-#include "wx/popupwin.h"
+// ----------------------------------------------------------------------------
+// local classes
+// ----------------------------------------------------------------------------
 
-class wxDatePopupInternal : public wxPopupTransientWindow
+class wxCalendarComboPopup : public wxCalendarCtrl,
+                             public wxComboPopup
 {
 public:
-    wxDatePopupInternal(wxWindow *parent) : wxPopupTransientWindow(parent) { }
 
-    void ShowAt(int x, int y)
+    wxCalendarComboPopup() : wxCalendarCtrl(),
+                             wxComboPopup()
     {
-        Position(wxPoint(x, y), wxSize(0, 0));
-        Popup();
     }
 
-    void Hide()
+    virtual void Init()
     {
-        Dismiss();
     }
-};
 
-#else // !wxUSE_POPUPWIN
+    // NB: Don't create lazily since it didn't work that way before
+    //     wxComboCtrl was used, and changing behaviour would almost
+    //     certainly introduce new bugs.
+    virtual bool Create(wxWindow* parent)
+    {
+        if ( !wxCalendarCtrl::Create(parent, wxID_ANY, wxDefaultDateTime,
+                              wxPoint(0, 0), wxDefaultSize,
+                              wxCAL_SHOW_HOLIDAYS | wxBORDER_SUNKEN) )
+            return false;
 
-class wxDatePopupInternal : public wxDialog
-{
-public:
-    wxDatePopupInternal(wxWindow *parent)
-        : wxDialog(parent,
-                   wxID_ANY,
-                   wxEmptyString,
-                   wxDefaultPosition,
-                   wxDefaultSize,
-                   wxSIMPLE_BORDER)
+        wxWindow *yearControl = wxCalendarCtrl::GetYearControl();
+
+        wxClientDC dc(yearControl);
+        dc.SetFont(yearControl->GetFont());
+        wxCoord width, dummy;
+        dc.GetTextExtent(wxT("2000"), &width, &dummy);
+        width += ConvertDialogToPixels(wxSize(20, 0)).x;
+
+        wxSize calSize = wxCalendarCtrl::GetBestSize();
+        wxSize yearSize = yearControl->GetSize();
+        yearSize.x = width;
+
+        wxPoint yearPosition = yearControl->GetPosition();
+
+        SetFormat(wxT("%x"));
+
+        width = yearPosition.x + yearSize.x+2+CALBORDER/2;
+        if (width < calSize.x-4)
+            width = calSize.x-4;
+
+        int calPos = (width-calSize.x)/2;
+        if (calPos == -1)
+        {
+            calPos = 0;
+            width += 2;
+        }
+        wxCalendarCtrl::SetSize(calPos, 0, calSize.x, calSize.y);
+        yearControl->SetSize(width-yearSize.x-CALBORDER/2, yearPosition.y,
+                             yearSize.x, yearSize.y);
+        wxCalendarCtrl::GetMonthControl()->Move(0, 0);
+
+        m_useSize.x = width+CALBORDER/2;
+        m_useSize.y = calSize.y-2+CALBORDER;
+
+        wxWindow* tx = m_combo->GetTextCtrl();
+        if ( !tx )
+            tx = m_combo;
+
+        tx->Connect(wxEVT_KILL_FOCUS,
+                    wxFocusEventHandler(wxCalendarComboPopup::OnKillTextFocus),
+                    NULL, this);
+
+        return true;
+    }
+
+    virtual wxSize GetAdjustedSize(int WXUNUSED(minWidth),
+                                   int WXUNUSED(prefHeight),
+                                   int WXUNUSED(maxHeight))
     {
+        return m_useSize;
     }
 
-    void ShowAt(int x, int y)
+    virtual wxWindow *GetControl() { return this; }
+
+    void SetDateValue(const wxDateTime& date)
     {
-        Show();
-        Move(x, y);
+        if ( date.IsValid() )
+        {
+            m_combo->SetText(date.Format(m_format));
+        }
+        else // invalid date
+        {
+            wxASSERT_MSG( HasDPFlag(wxDP_ALLOWNONE),
+                            _T("this control must have a valid date") );
+
+            m_combo->SetText(wxEmptyString);
+        }
+
+        m_currentDate = date;
+    }
+
+    const wxDateTime& GetDateValue() const
+    {
+        return m_currentDate;
+    }
+
+    bool ParseDateTime(const wxString& s, wxDateTime* pDt)
+    {
+        wxASSERT(pDt);
+
+        if ( !s.empty() )
+        {
+            pDt->ParseFormat(s, m_format);
+            if ( !pDt->IsValid() )
+                return false;
+        }
+
+        return true;
     }
 
-    void Hide()
+    void SendDateEvent(const wxDateTime& dt)
     {
-        wxDialog::Hide();
+        //
+        // Sends both wxCalendarEvent and wxDateEvent
+        wxWindow* datePicker = m_combo->GetParent();
+
+        wxCalendarEvent cev((wxCalendarCtrl*) this, wxEVT_CALENDAR_SEL_CHANGED);
+        cev.SetEventObject(datePicker);
+        cev.SetId(datePicker->GetId());
+        cev.SetDate(dt);
+        GetParent()->GetEventHandler()->ProcessEvent(cev);
+
+        wxDateEvent event(datePicker, dt, wxEVT_DATE_CHANGED);
+        datePicker->GetParent()->GetEventHandler()->ProcessEvent(event);
     }
+
+private:
+
+    void OnCalKey(wxKeyEvent & ev)
+    {
+        if (ev.GetKeyCode() == WXK_ESCAPE && !ev.HasModifiers())
+            Dismiss();
+        else
+            ev.Skip();
+    }
+
+    void OnSelChange(wxCalendarEvent &ev)
+    {
+        m_currentDate = wxCalendarCtrl::GetDate();
+        m_combo->SetText(m_currentDate.Format(m_format));
+
+        if ( ev.GetEventType() == wxEVT_CALENDAR_DOUBLECLICKED )
+        {
+            Dismiss();
+        }
+
+        SendDateEvent(m_currentDate);
+    }
+
+    void OnKillTextFocus(wxFocusEvent &ev)
+    {
+        ev.Skip();
+
+        wxDateTime dt;
+        wxString value = m_combo->GetValue();
+        if ( !ParseDateTime(value, &dt) )
+        {
+            if ( !HasDPFlag(wxDP_ALLOWNONE) )
+                dt = m_currentDate;
+        }
+
+        if ( dt.IsValid() )
+            m_combo->SetText(dt.Format(m_format));
+        else
+            m_combo->SetText(wxEmptyString);
+
+        // notify that we had to change the date after validation
+        if ( (dt.IsValid() && (!m_currentDate.IsValid() || m_currentDate != dt)) ||
+                (!dt.IsValid() && m_currentDate.IsValid()) )
+        {
+            m_currentDate = dt;
+            SendDateEvent(dt);
+        }
+    }
+
+    bool HasDPFlag(int flag)
+    {
+        return m_combo->GetParent()->HasFlag(flag);
+    }
+
+    bool SetFormat(const wxChar *fmt)
+    {
+        m_format.clear();
+
+        wxDateTime dt;
+        dt.ParseFormat(wxT("2003-10-13"), wxT("%Y-%m-%d"));
+        wxString str(dt.Format(fmt));
+
+        const wxChar *p = str.c_str();
+        while ( *p )
+        {
+            int n=wxAtoi(p);
+            if (n == dt.GetDay())
+            {
+                m_format.Append(wxT("%d"));
+                p += 2;
+            }
+            else if (n == (int)dt.GetMonth()+1)
+            {
+                m_format.Append(wxT("%m"));
+                p += 2;
+            }
+            else if (n == dt.GetYear())
+            {
+                m_format.Append(wxT("%Y"));
+                p += 4;
+            }
+            else if (n == (dt.GetYear() % 100))
+            {
+                if ( HasDPFlag(wxDP_SHOWCENTURY) )
+                    m_format.Append(wxT("%Y"));
+                else
+                    m_format.Append(wxT("%y"));
+                p += 2;
+            }
+            else
+                m_format.Append(*p++);
+        }
+
+        if ( m_combo )
+        {
+            wxArrayString allowedChars;
+            for ( wxChar c = _T('0'); c <= _T('9'); c++ )
+                allowedChars.Add(wxString(c, 1));
+
+            const wxChar *p2 = m_format.c_str();
+            while ( *p2 )
+            {
+                if ( *p2 == '%')
+                    p2 += 2;
+                else
+                    allowedChars.Add(wxString(*p2++, 1));
+            }
+
+    #if wxUSE_VALIDATORS
+            wxTextValidator tv(wxFILTER_INCLUDE_CHAR_LIST);
+            tv.SetIncludes(allowedChars);
+            m_combo->SetValidator(tv);
+    #endif
+
+            if (m_currentDate.IsValid())
+                m_combo->SetText(m_currentDate.Format(m_format));
+        }
+
+        return true;
+    }
+
+    virtual void SetStringValue(const wxString& s)
+    {
+        wxDateTime dt;
+        if ( ParseDateTime(s, &dt) )
+            m_currentDate = dt;
+        else if ( HasDPFlag(wxDP_ALLOWNONE) )
+            m_currentDate = dt;
+    }
+
+    virtual wxString GetStringValue() const
+    {
+        if ( !m_currentDate.IsValid() ) 
+            return wxEmptyString;
+
+        return m_currentDate.Format(m_format);
+    }
+
+private:
+
+    wxSize          m_useSize;
+    wxString        m_format;
+    wxDateTime      m_currentDate;
+
+    DECLARE_EVENT_TABLE()
 };
 
-#endif // wxUSE_POPUPWIN/!wxUSE_POPUPWIN
+
+BEGIN_EVENT_TABLE(wxCalendarComboPopup, wxCalendarCtrl)
+    EVT_KEY_DOWN(wxCalendarComboPopup::OnCalKey)
+    EVT_CALENDAR_SEL_CHANGED(wxID_ANY, wxCalendarComboPopup::OnSelChange)
+    EVT_CALENDAR_DAY(wxID_ANY, wxCalendarComboPopup::OnSelChange)
+    EVT_CALENDAR_MONTH(wxID_ANY, wxCalendarComboPopup::OnSelChange)
+    EVT_CALENDAR_YEAR(wxID_ANY, wxCalendarComboPopup::OnSelChange)
+    EVT_CALENDAR(wxID_ANY, wxCalendarComboPopup::OnSelChange)
+END_EVENT_TABLE()
+
 
 // ============================================================================
 // wxDatePickerCtrlGeneric implementation
 // ============================================================================
 
 BEGIN_EVENT_TABLE(wxDatePickerCtrlGeneric, wxDatePickerCtrlBase)
-    EVT_BUTTON(CTRLID_BTN, wxDatePickerCtrlGeneric::OnClick)
-    EVT_TEXT(CTRLID_TXT, wxDatePickerCtrlGeneric::OnText)
-    EVT_CHILD_FOCUS(wxDatePickerCtrlGeneric::OnChildSetFocus)
+    EVT_TEXT(wxID_ANY, wxDatePickerCtrlGeneric::OnText)
+    EVT_SIZE(wxDatePickerCtrlGeneric::OnSize)
+    EVT_SET_FOCUS(wxDatePickerCtrlGeneric::OnFocus)
 END_EVENT_TABLE()
 
 #ifndef wxHAS_NATIVE_DATEPICKCTRL
-    IMPLEMENT_DYNAMIC_CLASS(wxDatePickerCtrl, wxDatePickerCtrlBase)
+    IMPLEMENT_DYNAMIC_CLASS(wxDatePickerCtrl, wxControl)
 #endif
 
 // ----------------------------------------------------------------------------
@@ -159,123 +394,32 @@ bool wxDatePickerCtrlGeneric::Create(wxWindow *parent,
                   _T("wxDP_SPIN style not supported, use wxDP_DEFAULT") );
 
     if ( !wxControl::Create(parent, id, pos, size,
-                            style | wxCLIP_CHILDREN | wxWANTS_CHARS,
+                            style | wxCLIP_CHILDREN | wxWANTS_CHARS | wxBORDER_NONE,
                             validator, name) )
-
     {
         return false;
     }
 
     InheritAttributes();
 
-    m_txt = new wxTextCtrl(this, CTRLID_TXT);
-    m_txt->Connect(wxID_ANY, wxID_ANY, wxEVT_KEY_DOWN,
-                   (wxObjectEventFunction)&wxDatePickerCtrlGeneric::OnEditKey,
-                   0, this);
-    m_txt->Connect(wxID_ANY, wxID_ANY, wxEVT_KILL_FOCUS,
-                   (wxObjectEventFunction)&wxDatePickerCtrlGeneric::OnKillFocus,
-                   0, this);
+    m_combo = new wxComboCtrl(this, -1, wxEmptyString,
+                              wxDefaultPosition, wxDefaultSize);
 
-    const int height = m_txt->GetBestSize().y - 4; // FIXME: fudge
-    wxBitmap bmp(height, height);
-    {
-        wxMemoryDC dc;
-        dc.SelectObject(bmp);
-        wxRendererNative::Get().DrawComboBoxDropButton
-                                (
-                                    this,
-                                    dc,
-                                    wxRect(0, 0, height, height)
-                                );
-    }
-
-    wxBitmapButton *btn = new wxBitmapButton(this, CTRLID_BTN, bmp);
-    btn->SetMargins(0, 0);
-    m_btn = btn;
-
-    m_popup = new wxDatePopupInternal(this);
-    m_popup->SetFont(GetFont());
-
-    wxPanel *panel=new wxPanel(m_popup, CTRLID_PAN,
-                               wxPoint(0, 0), wxDefaultSize,
-                               wxSUNKEN_BORDER);
-    m_cal = new wxCalendarCtrl(panel, CTRLID_CAL, wxDefaultDateTime,
-                               wxPoint(0, 0), wxDefaultSize,
-                               wxCAL_SHOW_HOLIDAYS | wxSUNKEN_BORDER);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_SEL_CHANGED,
-                   (wxObjectEventFunction)&wxDatePickerCtrlGeneric::OnSelChange,
-                   0, this);
-    m_cal->Connect(wxID_ANY, wxID_ANY, wxEVT_KEY_DOWN,
-                   (wxObjectEventFunction)&wxDatePickerCtrlGeneric::OnCalKey,
-                   0, this);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_DOUBLECLICKED,
-                   (wxObjectEventFunction)&wxDatePickerCtrlGeneric::OnSelChange,
-                   0, this);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_DAY_CHANGED,
-                   (wxObjectEventFunction)&wxDatePickerCtrlGeneric::OnSelChange,
-                   0, this);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_MONTH_CHANGED,
-                   (wxObjectEventFunction)&wxDatePickerCtrlGeneric::OnSelChange,
-                   0, this);
-    m_cal->Connect(CTRLID_CAL, CTRLID_CAL, wxEVT_CALENDAR_YEAR_CHANGED,
-                   (wxObjectEventFunction)&wxDatePickerCtrlGeneric::OnSelChange,
-                   0, this);
-
-    wxWindow *yearControl = m_cal->GetYearControl();
-
-    Connect(wxID_ANY, wxID_ANY, wxEVT_SET_FOCUS,
-            (wxObjectEventFunction)&wxDatePickerCtrlGeneric::OnSetFocus);
-
-    wxClientDC dc(yearControl);
-    dc.SetFont(m_font);
-    wxCoord width, dummy;
-    dc.GetTextExtent(wxT("2000"), &width, &dummy);
-    width += ConvertDialogToPixels(wxSize(20, 0)).x;
-
-    wxSize calSize = m_cal->GetBestSize();
-    wxSize yearSize = yearControl->GetSize();
-    yearSize.x = width;
-
-    wxPoint yearPosition = yearControl->GetPosition();
-
-    SetFormat(wxT("%x"));
-
-
-#ifdef __WXMSW__
-    #define CALBORDER         0
-    #define RIGHTBUTTONBORDER 2
-    #define TOPBUTTONBORDER   1
-#else
-    #define CALBORDER         4
-    #define RIGHTBUTTONBORDER 0
-    #define TOPBUTTONBORDER   0
-#endif
-
-    width = yearPosition.x + yearSize.x+2+CALBORDER/2;
-    if (width < calSize.x-4)
-        width = calSize.x-4;
-
-    int calPos = (width-calSize.x)/2;
-    if (calPos == -1)
-    {
-        calPos = 0;
-        width += 2;
-    }
-    m_cal->SetSize(calPos, 0, calSize.x, calSize.y);
-    yearControl->SetSize(width-yearSize.x-CALBORDER/2, yearPosition.y,
-                         yearSize.x, yearSize.y);
-    m_cal->GetMonthControl()->Move(0, 0);
+    m_combo->SetCtrlMainWnd(this);
 
+    m_popup = new wxCalendarComboPopup();
 
+#if defined(__WXMSW__)
+    // without this keyboard navigation in month control doesn't work
+    m_combo->UseAltPopupWindow();
+#endif
+    m_combo->SetPopupControl(m_popup);
 
-    panel->SetClientSize(width+CALBORDER/2, calSize.y-2+CALBORDER);
-    m_popup->SetClientSize(panel->GetSize());
-    m_popup->Hide();
+    m_cal = m_popup;
 
-    if (!date.IsValid())
-        date.Today();
+    m_popup->SetDateValue(date.IsValid() ? date : wxDateTime::Today());
 
-    SetValue(date);
+    SetInitialSize(size);
 
     return true;
 }
@@ -283,31 +427,23 @@ bool wxDatePickerCtrlGeneric::Create(wxWindow *parent,
 
 void wxDatePickerCtrlGeneric::Init()
 {
-    m_popup = NULL;
-    m_txt = NULL;
+    m_combo = NULL;
     m_cal = NULL;
-    m_btn = NULL;
-
-    m_dropped = false;
-    m_ignoreDrop = false;
+    m_popup = NULL;
 }
 
+wxDatePickerCtrlGeneric::~wxDatePickerCtrlGeneric()
+{
+}
 
 bool wxDatePickerCtrlGeneric::Destroy()
 {
-    if (m_cal)
-        m_cal->Destroy();
-    if (m_popup)
-        m_popup->Destroy();
-    if (m_txt)
-        m_txt->Destroy();
-    if (m_btn)
-        m_btn->Destroy();
+    if ( m_combo )
+        m_combo->Destroy();
 
-    m_popup = NULL;
-    m_txt = NULL;
+    m_combo = NULL;
     m_cal = NULL;
-    m_btn = NULL;
+    m_popup = NULL;
 
     return wxControl::Destroy();
 }
@@ -316,64 +452,9 @@ bool wxDatePickerCtrlGeneric::Destroy()
 // overridden base class methods
 // ----------------------------------------------------------------------------
 
-void wxDatePickerCtrlGeneric::DoMoveWindow(int x, int y, int w, int h)
-{
-    wxControl::DoMoveWindow(x, y, w, h);
-    wxSize bs=m_btn->GetBestSize();
-    int eh=m_txt->GetBestSize().y;
-
-    m_txt->SetSize(0, 0, w-bs.x-1, h > eh ? eh : h);
-    m_btn->SetSize(w - bs.x-RIGHTBUTTONBORDER, TOPBUTTONBORDER, bs.x, h > bs.y ? bs.y : h);
-
-    if (m_dropped)
-        DropDown(true);
-}
-
 wxSize wxDatePickerCtrlGeneric::DoGetBestSize() const
 {
-    int bh=m_btn->GetBestSize().y;
-    int eh=m_txt->GetBestSize().y;
-    return wxSize(DEFAULT_ITEM_WIDTH, bh > eh ? bh : eh);
-}
-
-
-bool wxDatePickerCtrlGeneric::Show(bool show)
-{
-    if ( !wxControl::Show(show) )
-    {
-        return false;
-    }
-
-    if ( !show )
-    {
-        if ( m_popup )
-        {
-            m_popup->Hide();
-            m_dropped = false;
-        }
-    }
-
-    return true;
-}
-
-
-bool wxDatePickerCtrlGeneric::Enable(bool enable)
-{
-    if ( !wxControl::Enable(enable) )
-    {
-        return false;
-    }
-
-    if ( !enable )
-    {
-        if ( m_cal )
-            m_cal->Hide();
-    }
-
-    if ( m_btn )
-        m_btn->Enable(enable);
-
-    return true;
+    return m_combo->GetBestSize();
 }
 
 // ----------------------------------------------------------------------------
@@ -387,95 +468,16 @@ wxDatePickerCtrlGeneric::SetDateRange(const wxDateTime& lowerdate,
     return m_cal->SetDateRange(lowerdate, upperdate);
 }
 
-bool wxDatePickerCtrlGeneric::SetFormat(const wxChar *fmt)
-{
-    wxDateTime dt;
-    dt.ParseFormat(wxT("2003-10-13"), wxT("%Y-%m-%d"));
-    wxString str=dt.Format(fmt);
-    wxChar *p=(wxChar*)str.c_str();
-
-    m_format=wxEmptyString;
-
-    while (*p)
-    {
-        int n=wxAtoi(p);
-        if (n == dt.GetDay())
-        {
-            m_format.Append(wxT("%d"));
-            p += 2;
-        }
-        else if (n == (int)dt.GetMonth()+1)
-        {
-            m_format.Append(wxT("%m"));
-            p += 2;
-        }
-        else if (n == dt.GetYear())
-        {
-            m_format.Append(wxT("%Y"));
-            p += 4;
-        }
-        else if (n == (dt.GetYear() % 100))
-        {
-            if (GetWindowStyle() & wxDP_SHOWCENTURY)
-                m_format.Append(wxT("%Y"));
-            else
-                m_format.Append(wxT("%y"));
-            p += 2;
-        }
-        else
-            m_format.Append(*p++);
-    }
-
-    if (m_txt)
-    {
-        wxArrayString allowedChars;
-        for ( wxChar c = _T('0'); c <= _T('9'); c++ )
-            allowedChars.Add(wxString(c, 1));
-
-        const wxChar *p = m_format.c_str();
-        while (*p)
-        {
-            if (*p == '%')
-                p += 2;
-            else
-                allowedChars.Add(wxString(*p++, 1));
-        }
-
-        wxTextValidator tv(wxFILTER_INCLUDE_CHAR_LIST);
-        tv.SetIncludes(allowedChars);
-
-        m_txt->SetValidator(tv);
-
-        if (m_currentDate.IsValid())
-            m_txt->SetValue(m_currentDate.Format(m_format));
-    }
-
-    return true;
-}
-
 
 wxDateTime wxDatePickerCtrlGeneric::GetValue() const
 {
-    return m_currentDate;
+    return m_popup->GetDateValue();
 }
 
 
 void wxDatePickerCtrlGeneric::SetValue(const wxDateTime& date)
 {
-    if (m_cal)
-    {
-        if (date.IsValid())
-            m_txt->SetValue(date.Format(m_format));
-        else
-        {
-            wxASSERT_MSG( HasFlag(wxDP_ALLOWNONE),
-                            _T("this control must have a valid date") );
-
-            m_txt->SetValue(wxEmptyString);
-        }
-
-        m_currentDate = date;
-    }
+    m_popup->SetDateValue(date);
 }
 
 
@@ -483,7 +485,7 @@ bool wxDatePickerCtrlGeneric::GetRange(wxDateTime *dt1, wxDateTime *dt2) const
 {
     if (dt1)
         *dt1 = m_cal->GetLowerDateLimit();
-    if (dt1)
+    if (dt2)
         *dt2 = m_cal->GetUpperDateLimit();
     return true;
 }
@@ -499,129 +501,13 @@ wxDatePickerCtrlGeneric::SetRange(const wxDateTime &dt1, const wxDateTime &dt2)
 // event handlers
 // ----------------------------------------------------------------------------
 
-void wxDatePickerCtrlGeneric::DropDown(bool down)
-{
-    if (m_popup)
-    {
-        if (down)
-        {
-            wxDateTime dt;
-            if (!m_txt->GetValue().empty())
-                dt.ParseFormat(m_txt->GetValue(), m_format);
-
-            if (dt.IsValid())
-                m_cal->SetDate(dt);
-            else
-                m_cal->SetDate(wxDateTime::Today());
-
-            wxPoint pos=GetParent()->ClientToScreen(GetPosition());
-            m_popup->ShowAt(pos.x, pos.y + GetSize().y);
-            m_dropped = true;
-            m_cal->SetFocus();
-        }
-        else
-        {
-            if (m_dropped)
-                m_popup->Hide();
-            m_dropped = false;
-        }
-    }
-}
-
-
-void wxDatePickerCtrlGeneric::OnChildSetFocus(wxChildFocusEvent &ev)
-{
-    ev.Skip();
-    m_ignoreDrop = false;
-
-    wxWindow  *w=(wxWindow*)ev.GetEventObject();
-    while (w)
-    {
-        if (w == m_popup)
-            return;
-        w = w->GetParent();
-    }
-
-    if (m_dropped)
-    {
-        DropDown(false);
-        if (ev.GetEventObject() == m_btn)
-            m_ignoreDrop = true;
-    }
-}
-
-
-void wxDatePickerCtrlGeneric::OnClick(wxCommandEvent& WXUNUSED(event))
-{
-    if (m_ignoreDrop)
-    {
-        m_ignoreDrop = false;
-        m_txt->SetFocus();
-    }
-    else
-    {
-        DropDown();
-        m_cal->SetFocus();
-    }
-}
-
 
-void wxDatePickerCtrlGeneric::OnSetFocus(wxFocusEvent& WXUNUSED(ev))
+void wxDatePickerCtrlGeneric::OnSize(wxSizeEvent& event)
 {
-    if (m_txt)
-    {
-        m_txt->SetFocus();
-        m_txt->SetSelection(-1, -1); // select everything
-    }
-}
+    if ( m_combo )
+        m_combo->SetSize(GetClientSize());
 
-
-void wxDatePickerCtrlGeneric::OnKillFocus(wxFocusEvent &ev)
-{
-    ev.Skip();
-
-    wxDateTime dt;
-    dt.ParseFormat(m_txt->GetValue(), m_format);
-    if ( !dt.IsValid() )
-    {
-        if ( !HasFlag(wxDP_ALLOWNONE) )
-            dt = m_currentDate;
-    }
-
-    if(dt.IsValid())
-        m_txt->SetValue(dt.Format(m_format));
-    else
-        m_txt->SetValue(wxEmptyString);
-
-    // notify that we had to change the date after validation
-    if ( (dt.IsValid() && m_currentDate != dt) ||
-            (!dt.IsValid() && m_currentDate.IsValid()) )
-    {
-        m_currentDate = dt;
-        wxDateEvent event(this, dt, wxEVT_DATE_CHANGED);
-        GetEventHandler()->ProcessEvent(event);
-    }
-}
-
-
-void wxDatePickerCtrlGeneric::OnSelChange(wxCalendarEvent &ev)
-{
-    if (m_cal)
-    {
-        m_currentDate = m_cal->GetDate();
-        m_txt->SetValue(m_currentDate.Format(m_format));
-        if (ev.GetEventType() == wxEVT_CALENDAR_DOUBLECLICKED)
-        {
-            DropDown(false);
-            m_txt->SetFocus();
-        }
-    }
-    ev.SetEventObject(this);
-    ev.SetId(GetId());
-    GetParent()->ProcessEvent(ev);
-
-    wxDateEvent dev(this, ev.GetDate(), wxEVT_DATE_CHANGED);
-    GetParent()->ProcessEvent(dev);
+    event.Skip();
 }
 
 
@@ -629,48 +515,24 @@ void wxDatePickerCtrlGeneric::OnText(wxCommandEvent &ev)
 {
     ev.SetEventObject(this);
     ev.SetId(GetId());
-    GetParent()->ProcessEvent(ev);
+    GetParent()->GetEventHandler()->ProcessEvent(ev);
 
     // We'll create an additional event if the date is valid.
     // If the date isn't valid, the user's probably in the middle of typing
-    wxString txt = m_txt->GetValue();
     wxDateTime dt;
-    if (!txt.empty())
-    {
-        dt.ParseFormat(txt, m_format);
-        if (!dt.IsValid())
-            return;
-    }
-
-    wxCalendarEvent cev(m_cal, wxEVT_CALENDAR_SEL_CHANGED);
-    cev.SetEventObject(this);
-    cev.SetId(GetId());
-    cev.SetDate(dt);
+    if ( !m_popup->ParseDateTime(m_combo->GetValue(), &dt) )
+        return;
 
-    GetParent()->ProcessEvent(cev);
-
-    wxDateEvent dev(this, dt, wxEVT_DATE_CHANGED);
-    GetParent()->ProcessEvent(dev);
+    m_popup->SendDateEvent(dt);
 }
 
 
-void wxDatePickerCtrlGeneric::OnEditKey(wxKeyEvent & ev)
+void wxDatePickerCtrlGeneric::OnFocus(wxFocusEvent& WXUNUSED(event))
 {
-    if (ev.GetKeyCode() == WXK_DOWN && !ev.HasModifiers())
-        DropDown(true);
-    else
-        ev.Skip();
+    m_combo->SetFocus();
 }
 
 
-void wxDatePickerCtrlGeneric::OnCalKey(wxKeyEvent & ev)
-{
-    if (ev.GetKeyCode() == WXK_ESCAPE && !ev.HasModifiers())
-        DropDown(false);
-    else
-        ev.Skip();
-}
-
 #endif // wxUSE_DATEPICKCTRL_GENERIC
 
 #endif // wxUSE_DATEPICKCTRL