X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/a69e2a0ac7635d1df2dd36ffab64324a8b915384..ce22ac4592fccaedd8324e7a8f08b510748827e4:/src/msw/datectrl.cpp diff --git a/src/msw/datectrl.cpp b/src/msw/datectrl.cpp index 5dc3929b53..ebe60e9318 100644 --- a/src/msw/datectrl.cpp +++ b/src/msw/datectrl.cpp @@ -1,5 +1,5 @@ ///////////////////////////////////////////////////////////////////////////// -// Name: msw/datectrl.cpp +// Name: src/msw/datectrl.cpp // Purpose: wxDatePickerCtrl implementation // Author: Vadim Zeitlin // Modified by: @@ -23,32 +23,23 @@ #pragma hdrstop #endif +#if wxUSE_DATEPICKCTRL + #ifndef WX_PRECOMP + #include "wx/msw/wrapwin.h" + #include "wx/msw/wrapcctl.h" // include "properly" + #include "wx/app.h" + #include "wx/intl.h" + #include "wx/dcclient.h" + #include "wx/msw/private.h" #endif -#if wxUSE_DATEPICKCTRL - #include "wx/datectrl.h" -#include "wx/app.h" -#include "wx/intl.h" #include "wx/dynlib.h" #define _WX_DEFINE_DATE_EVENTS_ #include "wx/dateevt.h" -#include "wx/msw/wrapwin.h" -#include "wx/msw/wrapcctl.h" -#include "wx/msw/private.h" - -#if defined(__GNUWIN32__) && !wxCHECK_W32API_VERSION( 2, 4 ) -typedef struct tagNMDATETIMECHANGE -{ - NMHDR nmhdr; - DWORD dwFlags; - SYSTEMTIME st; -} NMDATETIMECHANGE; -#endif // old gcc headers - // apparently some versions of mingw define these macros erroneously #ifndef DateTime_GetSystemtime #define DateTime_GetSystemtime DateTime_GetSystemTime @@ -109,32 +100,45 @@ wxDatePickerCtrl::Create(wxWindow *parent, // supposed to initialize all common controls, in comctl32.dll 4.72 (and // presumably earlier versions 4.70 and 4.71, date time picker not being // supported in < 4.70 anyhow) it does not do it and we have to initialize - // it explicitely + // it explicitly static bool s_initDone = false; // MT-ok: used from GUI thread only if ( !s_initDone ) { - if ( wxTheApp->GetComCtl32Version() < 470 ) +#ifndef __WXWINCE__ + if ( wxApp::GetComCtl32Version() < 470 ) { wxLogError(_("This system doesn't support date picker control, please upgrade your version of comctl32.dll")); return false; } +#endif +#if wxUSE_DYNLIB_CLASS INITCOMMONCONTROLSEX icex; icex.dwSize = sizeof(icex); icex.dwICC = ICC_DATE_CLASSES; - wxDynamicLibrary dllComCtl32(_T("comctl32.dll"), wxDL_VERBATIM); - - typedef BOOL (WINAPI *ICCEx_t)(INITCOMMONCONTROLSEX *); - wxDYNLIB_FUNCTION( ICCEx_t, InitCommonControlsEx, dllComCtl32 ); + wxDynamicLibrary dllComCtl32( +#ifdef __WXWINCE__ + _T("commctrl.dll") +#else + _T("comctl32.dll") +#endif + , wxDL_VERBATIM); - if ( pfnInitCommonControlsEx ) + if ( dllComCtl32.IsLoaded() ) { - (*pfnInitCommonControlsEx)(&icex); - } + typedef BOOL (WINAPI *ICCEx_t)(INITCOMMONCONTROLSEX *); + wxDYNLIB_FUNCTION( ICCEx_t, InitCommonControlsEx, dllComCtl32 ); + + if ( pfnInitCommonControlsEx ) + { + (*pfnInitCommonControlsEx)(&icex); + } - s_initDone = true; + s_initDone = true; + } +#endif } @@ -150,7 +154,7 @@ wxDatePickerCtrl::Create(wxWindow *parent, if ( !MSWCreateControl(DATETIMEPICK_CLASS, wxEmptyString, pos, size) ) return false; - if ( dt.IsValid() ) + if ( dt.IsValid() || (style & wxDP_ALLOWNONE) ) SetValue(dt); return true; @@ -162,7 +166,7 @@ WXDWORD wxDatePickerCtrl::MSWGetStyle(long style, WXDWORD *exstyle) const // although MSDN doesn't mention it, DTS_UPDOWN doesn't work with // comctl32.dll 4.72 - if ( wxTheApp->GetComCtl32Version() > 472 && (style & wxDP_SPIN) ) + if ( wxApp::GetComCtl32Version() > 472 && (style & wxDP_SPIN) ) styleMSW |= DTS_UPDOWN; //else: drop down by default @@ -187,9 +191,48 @@ WXDWORD wxDatePickerCtrl::MSWGetStyle(long style, WXDWORD *exstyle) const wxSize wxDatePickerCtrl::DoGetBestSize() const { - const int y = GetCharHeight(); + wxClientDC dc(wx_const_cast(wxDatePickerCtrl *, this)); + dc.SetFont(GetFont()); + + // we can't use FormatDate() here as the CRT doesn't always use the same + // format as the date picker control + wxString s; + for ( int len = 100; ; len *= 2 ) + { + if ( ::GetDateFormat + ( + LOCALE_USER_DEFAULT, // the control should use the same + DATE_SHORTDATE, // the format used by the control + NULL, // use current date (we don't care) + NULL, // no custom format + wxStringBuffer(s, len), // output buffer + len // and its length + ) ) + { + // success + break; + } + + const DWORD rc = ::GetLastError(); + if ( rc != ERROR_INSUFFICIENT_BUFFER ) + { + wxLogApiError(_T("GetDateFormat"), rc); - return wxSize(DEFAULT_ITEM_WIDTH, EDIT_HEIGHT_FROM_CHAR_HEIGHT(y)); + // fall back on wxDateTime, what else to do? + s = wxDateTime::Today().FormatDate(); + break; + } + } + + // the control adds a lot of extra space around separators + s.Replace(_T(","), _T(" , ")); + + int x, y; + dc.GetTextExtent(s, &x, &y); + + wxSize best(x + 40 /* margin + arrows */, EDIT_HEIGHT_FROM_CHAR_HEIGHT(y)); + CacheBestSize(best); + return best; } // ---------------------------------------------------------------------------- @@ -282,6 +325,7 @@ wxDatePickerCtrl::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARAM *result) switch ( hdr->code ) { case DTN_DATETIMECHANGE: + { NMDATETIMECHANGE *dtch = (NMDATETIMECHANGE *)hdr; wxDateTime dt; if ( dtch->dwFlags == GDT_VALID ) @@ -293,10 +337,10 @@ wxDatePickerCtrl::MSWOnNotify(int idCtrl, WXLPARAM lParam, WXLPARAM *result) *result = 0; return true; } + } } return wxDatePickerCtrlBase::MSWOnNotify(idCtrl, lParam, result); } #endif // wxUSE_DATEPICKCTRL -