X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/a5b31f4e11c860fa5d9949c8694a7499793c3b98..64ea838d8f4d1853b7d850db93ee565e901d099a:/src/dfb/dcscreen.cpp diff --git a/src/dfb/dcscreen.cpp b/src/dfb/dcscreen.cpp index 4d9ba71e76..db19dc53a1 100644 --- a/src/dfb/dcscreen.cpp +++ b/src/dfb/dcscreen.cpp @@ -20,7 +20,7 @@ #include "wx/wxprec.h" #include "wx/dcscreen.h" - +#include "wx/dfb/dcscreen.h" #include "wx/dfb/private.h" // =========================================================================== @@ -31,14 +31,38 @@ // wxScreenDC //----------------------------------------------------------------------------- -#warning "FIXME: verify that wxScreenDC works in 2nd DirectFB app started" -// FIXME: maybe use a subsurface as well? +// FIXME: Currently, wxScreenDC doesn't work at all in non-exclusive mode +// (DFSCL_NORMAL). In this mode, requesting primary surface results +// in one of the following actions, depending on directfbrc +// configuration: +// +// (1) if force-desktop, a surface is created and used as *background* +// for the windows managed by DFB WM +// +// (2) otherwise, a dummy surface of the right size and format is +// created, but isn't shown on the screen +// +// (3) furthermore, if autoflip-window option is not used and primary +// surface is requested as single-buffered (which is needed to +// implement wxScreenDC semantics), a warning is issued in addition +// to 2); if autoflip-window is used, then a helper thread is +// created and does periodic flipping, which is even worse +// +// 2) and 3) are obviously unsatisfactory. 1) isn't suitable either, +// because wxScreenDC has to render *on top* of windows. +// +// In conclusion, wxScreenDC as currently implemented is only usable +// for measuring things (e.g. font sizes). For this task, however, it +// is quite expensive to create in DFSCL_NORMAL mode, because it +// involves creation of a new surface as big as the screen. +// +// The surface, as obtained from GetPrimarySurface(), is double-buffered +// for the sole purpose of silencing the warning from 3) above. -IMPLEMENT_DYNAMIC_CLASS(wxScreenDC, wxDC) +IMPLEMENT_ABSTRACT_CLASS(wxScreenDCImpl, wxDFBDCImpl) -wxScreenDC::wxScreenDC() +wxScreenDCImpl::wxScreenDCImpl(wxScreenDC *owner) + : wxDFBDCImpl(owner) { - Init(wxIDirectFB::Get()->GetPrimarySurface()); + DFBInit(wxIDirectFB::Get()->GetPrimarySurface()); } - -#warning "FIXME: does wxScreenDC need Flip call in dtor?"