X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/a2053b27b318fe81918a72c838944d1e8cd1524f..fb8d7eb7a880f1f2e32d8830f9c5e12b2536e05f:/src/gtk/listbox.cpp diff --git a/src/gtk/listbox.cpp b/src/gtk/listbox.cpp index 10c1097045..4f44746313 100644 --- a/src/gtk/listbox.cpp +++ b/src/gtk/listbox.cpp @@ -1,211 +1,285 @@ ///////////////////////////////////////////////////////////////////////////// -// Name: listbox.cpp +// Name: src/gtk/listbox.cpp // Purpose: // Author: Robert Roebling +// Modified By: Ryan Norton (GtkTreeView implementation) // Id: $Id$ // Copyright: (c) 1998 Robert Roebling // Licence: wxWindows licence ///////////////////////////////////////////////////////////////////////////// +// For compilers that support precompilation, includes "wx.h". +#include "wx/wxprec.h" -#ifdef __GNUG__ -#pragma implementation "listbox.h" -#endif +#if wxUSE_LISTBOX -#include "wx/dynarray.h" #include "wx/listbox.h" -#include "wx/utils.h" -#include "wx/intl.h" -#include "wx/checklst.h" -#include "wx/settings.h" -#if wxUSE_TOOLTIPS -#include "wx/tooltip.h" +#ifndef WX_PRECOMP + #include "wx/dynarray.h" + #include "wx/intl.h" + #include "wx/log.h" + #include "wx/utils.h" + #include "wx/settings.h" + #include "wx/checklst.h" + #include "wx/arrstr.h" #endif -#if wxUSE_DRAG_AND_DROP -#include "wx/dnd.h" +#if wxUSE_TOOLTIPS + #include "wx/tooltip.h" #endif -#include "gdk/gdk.h" -#include "gtk/gtk.h" +#include +#include "wx/gtk/private.h" +#include "wx/gtk/private/gtk2-compat.h" +#include "wx/gtk/private/object.h" +#include "wx/gtk/treeentry_gtk.h" + +#include +#ifdef __WXGTK3__ +#include +#endif //----------------------------------------------------------------------------- -// idle system +// data //----------------------------------------------------------------------------- -extern void wxapp_install_idle_handler(); -extern bool g_isIdle; +extern bool g_blockEventsOnDrag; +extern bool g_blockEventsOnScroll; -//------------------------------------------------------------------------- -// conditional compilation -//------------------------------------------------------------------------- -#if (GTK_MINOR_VERSION > 0) -#define NEW_GTK_SCROLL_CODE -#endif //----------------------------------------------------------------------------- -// private functions +// Macro to tell which row the strings are in (1 if native checklist, 0 if not) //----------------------------------------------------------------------------- -#define CHECKBOX_STRING "[-] " +#if wxUSE_CHECKLISTBOX +# define WXLISTBOX_DATACOLUMN_ARG(x) (x->m_hasCheckBoxes ? 1 : 0) +#else +# define WXLISTBOX_DATACOLUMN_ARG(x) (0) +#endif // wxUSE_CHECKLISTBOX + +#define WXLISTBOX_DATACOLUMN WXLISTBOX_DATACOLUMN_ARG(this) -// checklistboxes have "[±] " prepended to their lables, this macro removes it -// (NB: 4 below is the length of CHECKBOX_STRING above) +// ---------------------------------------------------------------------------- +// helper functions +// ---------------------------------------------------------------------------- + +namespace +{ + +// Return the entry for the given listbox item. // -// the argument to it is a "const char *" pointer -#define GET_REAL_LABEL(label) ((m_hasCheckBoxes)?(label)+4 : (label)) +// Return value must be released by caller if non-NULL. +GtkTreeEntry * +GetEntry(GtkListStore *store, GtkTreeIter *iter, const wxListBox *listbox) +{ + GtkTreeEntry* entry; + gtk_tree_model_get(GTK_TREE_MODEL(store), + iter, + WXLISTBOX_DATACOLUMN_ARG(listbox), + &entry, + -1); -//----------------------------------------------------------------------------- -// data -//----------------------------------------------------------------------------- + return entry; +} -extern bool g_blockEventsOnDrag; -extern bool g_blockEventsOnScroll; +} // anonymous namespace //----------------------------------------------------------------------------- -// "button_press_event" +// "row-activated" //----------------------------------------------------------------------------- -static gint -gtk_listbox_button_press_callback( GtkWidget *widget, GdkEventButton *gdk_event, wxListBox *listbox ) +extern "C" { +static void +gtk_listbox_row_activated_callback(GtkTreeView * WXUNUSED(treeview), + GtkTreePath *path, + GtkTreeViewColumn * WXUNUSED(col), + wxListBox *listbox) { - if (g_isIdle) wxapp_install_idle_handler(); + if (g_blockEventsOnDrag) return; + if (g_blockEventsOnScroll) return; - if (g_blockEventsOnDrag) return FALSE; - if (g_blockEventsOnScroll) return FALSE; + // This is triggered by either a double-click or a space press - if (!listbox->m_hasVMT) return FALSE; + int sel = gtk_tree_path_get_indices(path)[0]; - int sel = listbox->GetIndex( widget ); + listbox->GTKOnActivated(sel); +} +} - if ((listbox->m_hasCheckBoxes) && (gdk_event->x < 15) && (gdk_event->type != GDK_2BUTTON_PRESS)) - { - wxCheckListBox *clb = (wxCheckListBox *)listbox; +//----------------------------------------------------------------------------- +// "changed" +//----------------------------------------------------------------------------- - clb->Check( sel, !clb->IsChecked(sel) ); +extern "C" { +static void +gtk_listitem_changed_callback(GtkTreeSelection * WXUNUSED(selection), + wxListBox *listbox ) +{ + if (g_blockEventsOnDrag) return; - wxCommandEvent event( wxEVT_COMMAND_CHECKLISTBOX_TOGGLED, listbox->GetId() ); - event.SetEventObject( listbox ); - event.SetInt( sel ); - listbox->GetEventHandler()->ProcessEvent( event ); - } + listbox->GTKOnSelectionChanged(); +} - if (gdk_event->type == GDK_2BUTTON_PRESS) - { - wxCommandEvent event( wxEVT_COMMAND_LISTBOX_DOUBLECLICKED, listbox->GetId() ); - event.SetEventObject( listbox ); +} - wxArrayInt aSelections; - int count = listbox->GetSelections(aSelections); - if ( count > 0 ) - { - event.m_commandInt = aSelections[0] ; - event.m_clientData = listbox->GetClientData( event.m_commandInt ); - wxString str(listbox->GetString(event.m_commandInt)); - if (!str.IsEmpty()) event.m_commandString = str; - } +//----------------------------------------------------------------------------- +// "key_press_event" +//----------------------------------------------------------------------------- + +extern "C" { +static gboolean +gtk_listbox_key_press_callback( GtkWidget *WXUNUSED(widget), + GdkEventKey *gdk_event, + wxListBox *listbox ) +{ + if ((gdk_event->keyval == GDK_Return) || + (gdk_event->keyval == GDK_ISO_Enter) || + (gdk_event->keyval == GDK_KP_Enter)) + { + int index = -1; + if (!listbox->HasMultipleSelection()) + index = listbox->GetSelection(); else { - event.m_commandInt = -1 ; - event.m_commandString.Empty(); + wxArrayInt sels; + if (listbox->GetSelections( sels ) < 1) + return FALSE; + index = sels[0]; } - listbox->GetEventHandler()->ProcessEvent( event ); + if (index != wxNOT_FOUND) + { + listbox->GTKOnActivated(index); +// wxMac and wxMSW always invoke default action +// if (!ret) + { + // DClick not handled -> invoke default action + wxWindow *tlw = wxGetTopLevelParent( listbox ); + if (tlw) + { + GtkWindow *gtk_window = GTK_WINDOW( tlw->GetHandle() ); + if (gtk_window) + gtk_window_activate_default( gtk_window ); + } + } + + // Always intercept, otherwise we'd get another dclick + // event from row_activated + return TRUE; + } } return FALSE; } +} //----------------------------------------------------------------------------- -// "key_press_event" +// GtkTreeEntry destruction (to destroy client data) //----------------------------------------------------------------------------- -static gint -gtk_listbox_key_press_callback( GtkWidget *widget, GdkEventKey *gdk_event, wxListBox *listbox ) +extern "C" { +static void gtk_tree_entry_destroy_cb(GtkTreeEntry* entry, + wxListBox* listbox) { - if (g_isIdle) wxapp_install_idle_handler(); - - if (g_blockEventsOnDrag) return FALSE; - - if (!listbox->m_hasVMT) return FALSE; - - if (gdk_event->keyval != ' ') return FALSE; - - int sel = listbox->GetIndex( widget ); + if (listbox->HasClientObjectData()) + { + gpointer userdata = gtk_tree_entry_get_userdata(entry); + if (userdata) + delete (wxClientData *)userdata; + } +} +} - wxCheckListBox *clb = (wxCheckListBox *)listbox; +//----------------------------------------------------------------------------- +// Sorting callback (standard CmpNoCase return value) +//----------------------------------------------------------------------------- - clb->Check( sel, !clb->IsChecked(sel) ); +extern "C" { +static gint gtk_listbox_sort_callback(GtkTreeModel * WXUNUSED(model), + GtkTreeIter *a, + GtkTreeIter *b, + wxListBox *listbox) +{ + wxGtkObject entry1(GetEntry(listbox->m_liststore, a, listbox)); + wxCHECK_MSG(entry1, 0, wxT("Could not get first entry")); - wxCommandEvent event( wxEVT_COMMAND_CHECKLISTBOX_TOGGLED, listbox->GetId() ); - event.SetEventObject( listbox ); - event.SetInt( sel ); - listbox->GetEventHandler()->ProcessEvent( event ); + wxGtkObject entry2(GetEntry(listbox->m_liststore, b, listbox)); + wxCHECK_MSG(entry2, 0, wxT("Could not get second entry")); - return FALSE; + //We compare collate keys here instead of calling g_utf8_collate + //as it is rather slow (and even the docs recommend this) + return strcmp(gtk_tree_entry_get_collate_key(entry1), + gtk_tree_entry_get_collate_key(entry2)) >= 0; +} } //----------------------------------------------------------------------------- -// "select" and "deselect" +// Searching callback (TRUE == not equal, FALSE == equal) //----------------------------------------------------------------------------- -static void gtk_listitem_select_callback( GtkWidget *WXUNUSED(widget), wxListBox *listbox ) +extern "C" { +static gboolean gtk_listbox_searchequal_callback(GtkTreeModel * WXUNUSED(model), + gint WXUNUSED(column), + const gchar* key, + GtkTreeIter* iter, + wxListBox* listbox) { - if (g_isIdle) wxapp_install_idle_handler(); - - if (!listbox->m_hasVMT) return; - if (g_blockEventsOnDrag) return; + wxGtkObject + entry(GetEntry(listbox->m_liststore, iter, listbox)); + wxCHECK_MSG(entry, 0, wxT("Could not get entry")); - wxCommandEvent event(wxEVT_COMMAND_LISTBOX_SELECTED, listbox->GetId() ); + wxGtkString keycollatekey(g_utf8_collate_key(key, -1)); - wxArrayInt aSelections; - int count = listbox->GetSelections(aSelections); - if ( count > 0 ) - { - event.m_commandInt = aSelections[0] ; - event.m_clientData = listbox->GetClientData( event.m_commandInt ); - wxString str(listbox->GetString(event.m_commandInt)); - if (!str.IsEmpty()) event.m_commandString = str; - } - else - { - event.m_commandInt = -1 ; - event.m_commandString.Empty(); - } - - event.SetEventObject( listbox ); - - listbox->GetEventHandler()->ProcessEvent( event ); + return strcmp(keycollatekey, gtk_tree_entry_get_collate_key(entry)) != 0; +} } //----------------------------------------------------------------------------- // wxListBox //----------------------------------------------------------------------------- -IMPLEMENT_DYNAMIC_CLASS(wxListBox,wxControl) +// ---------------------------------------------------------------------------- +// construction +// ---------------------------------------------------------------------------- -wxListBox::wxListBox() +void wxListBox::Init() { - m_list = (GtkList *) NULL; - m_hasCheckBoxes = FALSE; + m_treeview = NULL; +#if wxUSE_CHECKLISTBOX + m_hasCheckBoxes = false; +#endif // wxUSE_CHECKLISTBOX } bool wxListBox::Create( wxWindow *parent, wxWindowID id, const wxPoint &pos, const wxSize &size, - int n, const wxString choices[], - long style, const wxValidator& validator, const wxString &name ) + const wxArrayString& choices, + long style, const wxValidator& validator, + const wxString &name ) { - m_needParent = TRUE; - m_acceptsFocus = TRUE; + wxCArrayString chs(choices); - PreCreation( parent, id, pos, size, style, name ); + return Create( parent, id, pos, size, chs.GetCount(), chs.GetStrings(), + style, validator, name ); +} - SetValidator( validator ); +bool wxListBox::Create( wxWindow *parent, wxWindowID id, + const wxPoint &pos, const wxSize &size, + int n, const wxString choices[], + long style, const wxValidator& validator, + const wxString &name ) +{ + if (!PreCreation( parent, pos, size ) || + !CreateBase( parent, id, pos, size, style, validator, name )) + { + wxFAIL_MSG( wxT("wxListBox creation failed") ); + return false; + } - m_widget = gtk_scrolled_window_new( (GtkAdjustment*) NULL, (GtkAdjustment*) NULL ); + m_widget = gtk_scrolled_window_new( NULL, NULL ); + g_object_ref(m_widget); if (style & wxLB_ALWAYS_SB) { gtk_scrolled_window_set_policy( GTK_SCROLLED_WINDOW(m_widget), @@ -217,662 +291,647 @@ bool wxListBox::Create( wxWindow *parent, wxWindowID id, GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC ); } - m_list = GTK_LIST( gtk_list_new() ); - GtkSelectionMode mode = GTK_SELECTION_BROWSE; - if (style & wxLB_MULTIPLE) - mode = GTK_SELECTION_MULTIPLE; - else if (style & wxLB_EXTENDED) - mode = GTK_SELECTION_EXTENDED; + GTKScrolledWindowSetBorder(m_widget, style); - gtk_list_set_selection_mode( GTK_LIST(m_list), mode ); + m_treeview = GTK_TREE_VIEW( gtk_tree_view_new( ) ); -#ifdef NEW_GTK_SCROLL_CODE - gtk_scrolled_window_add_with_viewport( GTK_SCROLLED_WINDOW(m_widget), GTK_WIDGET(m_list) ); -#else - gtk_container_add( GTK_CONTAINER(m_widget), GTK_WIDGET(m_list) ); + //wxListBox doesn't have a header :) + //NB: If enabled SetFirstItem doesn't work correctly + gtk_tree_view_set_headers_visible(m_treeview, FALSE); + +#if wxUSE_CHECKLISTBOX + if(m_hasCheckBoxes) + ((wxCheckListBox*)this)->DoCreateCheckList(); +#endif // wxUSE_CHECKLISTBOX + + // Create the data column + gtk_tree_view_insert_column_with_attributes(m_treeview, -1, "", + gtk_cell_renderer_text_new(), + "text", + WXLISTBOX_DATACOLUMN, NULL); + + // Now create+set the model (GtkListStore) - first argument # of columns +#if wxUSE_CHECKLISTBOX + if(m_hasCheckBoxes) + m_liststore = gtk_list_store_new(2, G_TYPE_BOOLEAN, + GTK_TYPE_TREE_ENTRY); + else #endif + m_liststore = gtk_list_store_new(1, GTK_TYPE_TREE_ENTRY); - gtk_widget_show( GTK_WIDGET(m_list) ); + gtk_tree_view_set_model(m_treeview, GTK_TREE_MODEL(m_liststore)); - wxSize newSize = size; - if (newSize.x == -1) newSize.x = 100; - if (newSize.y == -1) newSize.y = 110; - SetSize( newSize.x, newSize.y ); + g_object_unref (m_liststore); //free on treeview destruction - for (int i = 0; i < n; i++) - { - m_clientDataList.Append( (wxObject*) NULL ); - m_clientObjectList.Append( (wxObject*) NULL ); + // Disable the pop-up textctrl that enables searching - note that + // the docs specify that even if this disabled (which we are doing) + // the user can still have it through the start-interactive-search + // key binding...either way we want to provide a searchequal callback + // NB: If this is enabled a doubleclick event (activate) gets sent + // on a successful search + gtk_tree_view_set_search_column(m_treeview, WXLISTBOX_DATACOLUMN); + gtk_tree_view_set_search_equal_func(m_treeview, + (GtkTreeViewSearchEqualFunc) gtk_listbox_searchequal_callback, + this, + NULL); - GtkWidget *list_item; + gtk_tree_view_set_enable_search(m_treeview, FALSE); - wxString str(choices[i]); - if (m_hasCheckBoxes) - { - str.Prepend(CHECKBOX_STRING); - } + GtkSelectionMode mode; + // GTK_SELECTION_EXTENDED is a deprecated synonym for GTK_SELECTION_MULTIPLE + if ( style & (wxLB_MULTIPLE | wxLB_EXTENDED) ) + { + mode = GTK_SELECTION_MULTIPLE; + } + else // no multi-selection flags specified + { + m_windowStyle |= wxLB_SINGLE; - list_item = gtk_list_item_new_with_label( str.mbc_str() ); + // Notice that we must use BROWSE and not GTK_SELECTION_SINGLE because + // the latter allows to not select any items at all while a single + // selection listbox is supposed to always have a selection (at least + // once the user selected something, it might not have any initially). + mode = GTK_SELECTION_BROWSE; + } - gtk_container_add( GTK_CONTAINER(m_list), list_item ); + GtkTreeSelection* selection = gtk_tree_view_get_selection( m_treeview ); + gtk_tree_selection_set_mode( selection, mode ); - gtk_signal_connect( GTK_OBJECT(list_item), "select", - GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this ); + // Handle sortable stuff + if(HasFlag(wxLB_SORT)) + { + // Setup sorting in ascending (wx) order + gtk_tree_sortable_set_sort_column_id(GTK_TREE_SORTABLE(m_liststore), + WXLISTBOX_DATACOLUMN, + GTK_SORT_ASCENDING); - if (style & wxLB_MULTIPLE) - gtk_signal_connect( GTK_OBJECT(list_item), "deselect", - GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this ); + // Set the sort callback + gtk_tree_sortable_set_sort_func(GTK_TREE_SORTABLE(m_liststore), + WXLISTBOX_DATACOLUMN, + (GtkTreeIterCompareFunc) gtk_listbox_sort_callback, + this, //userdata + NULL //"destroy notifier" + ); + } - gtk_signal_connect( GTK_OBJECT(list_item), - "button_press_event", - (GtkSignalFunc)gtk_listbox_button_press_callback, - (gpointer) this ); - if (m_hasCheckBoxes) - { - gtk_signal_connect( GTK_OBJECT(list_item), - "key_press_event", - (GtkSignalFunc)gtk_listbox_key_press_callback, - (gpointer)this ); - } + gtk_container_add (GTK_CONTAINER (m_widget), GTK_WIDGET(m_treeview) ); - ConnectWidget( list_item ); + gtk_widget_show( GTK_WIDGET(m_treeview) ); + m_focusWidget = GTK_WIDGET(m_treeview); - gtk_widget_show( list_item ); - } + Append(n, choices); // insert initial items - m_parent->DoAddChild( this ); + // generate dclick events + g_signal_connect_after(m_treeview, "row-activated", + G_CALLBACK(gtk_listbox_row_activated_callback), this); - PostCreation(); + // for intercepting dclick generation by + g_signal_connect (m_treeview, "key_press_event", + G_CALLBACK (gtk_listbox_key_press_callback), + this); + m_parent->DoAddChild( this ); - SetBackgroundColour( wxSystemSettings::GetSystemColour( wxSYS_COLOUR_WINDOW ) ); - SetForegroundColour( parent->GetForegroundColour() ); - SetFont( parent->GetFont() ); + PostCreation(size); + SetInitialSize(size); // need this too because this is a wxControlWithItems - Show( TRUE ); + g_signal_connect_after (selection, "changed", + G_CALLBACK (gtk_listitem_changed_callback), this); - return TRUE; + return true; } wxListBox::~wxListBox() { + if (m_treeview) + { + GTKDisconnect(m_treeview); + GtkTreeSelection* selection = gtk_tree_view_get_selection(m_treeview); + if (selection) + GTKDisconnect(selection); + } + Clear(); } -void wxListBox::InsertItems(int nItems, const wxString items[], int pos) +void wxListBox::GTKDisableEvents() { - wxCHECK_RET( m_list != NULL, _T("invalid listbox") ); + GtkTreeSelection* selection = gtk_tree_view_get_selection( m_treeview ); - GList *children = m_list->children; - int length = g_list_length(children); - wxCHECK_RET( pos <= length, _T("invalid index in wxListBox::InsertItems") ); - - // VZ: it seems that GTK 1.0.6 doesn't has a function to insert an item - // into a listbox at the given position, this is why we first delete - // all items after this position, then append these items and then - // reappend back the old ones. + g_signal_handlers_block_by_func(selection, + (gpointer) gtk_listitem_changed_callback, this); +} - // first detach the old items - int n; // loop var +void wxListBox::GTKEnableEvents() +{ + GtkTreeSelection* selection = gtk_tree_view_get_selection( m_treeview ); - if ( pos == length ) - { - // no need to do anything complicated - for ( n = 0; n < nItems; n++ ) - { - Append(items[n]); - } + g_signal_handlers_unblock_by_func(selection, + (gpointer) gtk_listitem_changed_callback, this); - return; - } - - wxArrayString deletedLabels; - wxArrayPtrVoid deletedData; - wxArrayInt deletedChecks; // only for check list boxes + UpdateOldSelections(); +} - GList *child = g_list_nth( children, pos ); - for ( n = 0; child != NULL; n++, child = child->next ) - { - // save label - GtkBin *bin = GTK_BIN( child->data ); - GtkLabel *label = GTK_LABEL( bin->child ); - wxString str(GET_REAL_LABEL(label->label)); - deletedLabels.Add(str); +void wxListBox::Update() +{ + wxWindow::Update(); - // save data - void *clientData = NULL; - wxNode *node = NULL; - - if ( n < (int)m_clientObjectList.GetCount() ) - node = m_clientObjectList.Nth( n ); + if (m_treeview) + gdk_window_process_updates(gtk_widget_get_window(GTK_WIDGET(m_treeview)), true); +} - if ( node ) - { - clientData = node->GetData(); - m_clientObjectList.DeleteNode( node ); - } +// ---------------------------------------------------------------------------- +// adding items +// ---------------------------------------------------------------------------- - if ( !clientData ) - { - if ( n < (int)m_clientDataList.GetCount() ) - node = m_clientDataList.Nth( n ); +int wxListBox::DoInsertItems(const wxArrayStringsAdapter& items, + unsigned int pos, + void **clientData, + wxClientDataType type) +{ + wxCHECK_MSG( m_treeview != NULL, wxNOT_FOUND, wxT("invalid listbox") ); - if ( node ) - { - clientData = node->GetData(); - node = m_clientDataList.Nth( n ); - } - } + InvalidateBestSize(); - deletedData.Add(clientData); + GtkTreeIter* pIter = NULL; // append by default + GtkTreeIter iter; + if ( pos != GetCount() ) + { + wxCHECK_MSG( GTKGetIteratorFor(pos, &iter), wxNOT_FOUND, + wxT("internal wxListBox error in insertion") ); - // save check state - if ( m_hasCheckBoxes ) - { - deletedChecks.Add(((wxCheckListBox *)this)->IsChecked(pos + n)); - } + pIter = &iter; } - int nDeletedCount = n; + const unsigned int numItems = items.GetCount(); + for ( unsigned int i = 0; i < numItems; ++i ) + { + wxGtkObject entry(gtk_tree_entry_new()); + gtk_tree_entry_set_label(entry, wxGTK_CONV(items[i])); + gtk_tree_entry_set_destroy_func(entry, + (GtkTreeEntryDestroy)gtk_tree_entry_destroy_cb, + this); + + GtkTreeIter itercur; + gtk_list_store_insert_before(m_liststore, &itercur, pIter); - gtk_list_clear_items( m_list, pos, length ); + GTKSetItem(itercur, entry); - // now append the new items - for ( n = 0; n < nItems; n++ ) - { - Append(items[n]); + if (clientData) + AssignNewItemClientData(GTKGetIndexFor(itercur), clientData, i, type); } - // and append the old items too - pos += nItems; // now the indices are shifter - for ( n = 0; n < nDeletedCount; n++ ) - { - Append(deletedLabels[n], deletedData[n]); + UpdateOldSelections(); - if ( m_hasCheckBoxes ) - { - ((wxCheckListBox *)this)->Check(pos + n, (bool)deletedChecks[n]); - } - } + return pos + numItems - 1; } -void wxListBox::AppendCommon( const wxString &item ) +// ---------------------------------------------------------------------------- +// deleting items +// ---------------------------------------------------------------------------- + +void wxListBox::DoClear() { - wxCHECK_RET( m_list != NULL, _T("invalid listbox") ); + wxCHECK_RET( m_treeview != NULL, wxT("invalid listbox") ); - GtkWidget *list_item; + GTKDisableEvents(); // just in case - wxString label(item); - if (m_hasCheckBoxes) - { - label.Prepend(CHECKBOX_STRING); - } + InvalidateBestSize(); - list_item = gtk_list_item_new_with_label( label.mbc_str() ); + gtk_list_store_clear( m_liststore ); /* well, THAT was easy :) */ - gtk_container_add( GTK_CONTAINER(m_list), list_item ); + GTKEnableEvents(); - gtk_signal_connect( GTK_OBJECT(list_item), "select", - GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this ); + UpdateOldSelections(); +} - if (HasFlag(wxLB_MULTIPLE)) - gtk_signal_connect( GTK_OBJECT(list_item), "deselect", - GTK_SIGNAL_FUNC(gtk_listitem_select_callback), (gpointer)this ); +void wxListBox::DoDeleteOneItem(unsigned int n) +{ + wxCHECK_RET( m_treeview != NULL, wxT("invalid listbox") ); - gtk_signal_connect( GTK_OBJECT(list_item), - "button_press_event", - (GtkSignalFunc)gtk_listbox_button_press_callback, - (gpointer) this ); + InvalidateBestSize(); - if (m_hasCheckBoxes) - { - gtk_signal_connect( GTK_OBJECT(list_item), - "key_press_event", - (GtkSignalFunc)gtk_listbox_key_press_callback, - (gpointer)this ); - } - - gtk_widget_show( list_item ); + GTKDisableEvents(); // just in case - ConnectWidget( list_item ); + GtkTreeIter iter; + wxCHECK_RET( GTKGetIteratorFor(n, &iter), wxT("wrong listbox index") ); - if (GTK_WIDGET_REALIZED(m_widget)) - { - gtk_widget_realize( list_item ); - gtk_widget_realize( GTK_BIN(list_item)->child ); - - if (m_widgetStyle) ApplyWidgetStyle(); - -#if wxUSE_DRAG_AND_DROP -#ifndef NEW_GTK_DND_CODE - if (m_dropTarget) m_dropTarget->RegisterWidget( list_item ); -#endif -#endif + // this returns false if iter is invalid (e.g. deleting item at end) but + // since we don't use iter, we ignore the return value + gtk_list_store_remove(m_liststore, &iter); -#if wxUSE_TOOLTIPS - if (m_tooltip) m_tooltip->Apply( this ); -#endif - } + GTKEnableEvents(); } -void wxListBox::Append( const wxString &item ) -{ - m_clientDataList.Append( (wxObject*) NULL ); - m_clientObjectList.Append( (wxObject*) NULL ); +// ---------------------------------------------------------------------------- +// helper functions for working with iterators +// ---------------------------------------------------------------------------- - AppendCommon( item ); -} - -void wxListBox::Append( const wxString &item, void *clientData ) +bool wxListBox::GTKGetIteratorFor(unsigned pos, GtkTreeIter *iter) const { - m_clientDataList.Append( (wxObject*) clientData ); - m_clientObjectList.Append( (wxObject*) NULL ); + if ( !gtk_tree_model_iter_nth_child(GTK_TREE_MODEL(m_liststore), + iter, NULL, pos) ) + { + wxLogDebug(wxT("gtk_tree_model_iter_nth_child(%u) failed"), pos); + return false; + } - AppendCommon( item ); + return true; } -void wxListBox::Append( const wxString &item, wxClientData *clientData ) +int wxListBox::GTKGetIndexFor(GtkTreeIter& iter) const { - m_clientObjectList.Append( (wxObject*) clientData ); - m_clientDataList.Append( (wxObject*) NULL ); + GtkTreePath *path = + gtk_tree_model_get_path(GTK_TREE_MODEL(m_liststore), &iter); - AppendCommon( item ); -} + gint* pIntPath = gtk_tree_path_get_indices(path); -void wxListBox::SetClientData( int n, void* clientData ) -{ - wxCHECK_RET( m_widget != NULL, _T("invalid combobox") ); + wxCHECK_MSG( pIntPath, wxNOT_FOUND, wxT("failed to get iterator path") ); - wxNode *node = m_clientDataList.Nth( n ); - if (!node) return; + int idx = pIntPath[0]; - node->SetData( (wxObject*) clientData ); + gtk_tree_path_free( path ); + + return idx; } -void* wxListBox::GetClientData( int n ) +// get GtkTreeEntry from position (note: you need to g_unref it if valid) +GtkTreeEntry *wxListBox::GTKGetEntry(unsigned n) const { - wxCHECK_MSG( m_widget != NULL, NULL, _T("invalid combobox") ); - - wxNode *node = m_clientDataList.Nth( n ); - if (!node) return NULL; + GtkTreeIter iter; + if ( !GTKGetIteratorFor(n, &iter) ) + return NULL; - return node->Data(); + return GetEntry(m_liststore, &iter, this); } -void wxListBox::SetClientObject( int n, wxClientData* clientData ) +void wxListBox::GTKSetItem(GtkTreeIter& iter, const GtkTreeEntry *entry) { - wxCHECK_RET( m_widget != NULL, _T("invalid combobox") ); - - wxNode *node = m_clientObjectList.Nth( n ); - if (!node) return; - - wxClientData *cd = (wxClientData*) node->Data(); - if (cd) delete cd; - - node->SetData( (wxObject*) clientData ); +#if wxUSE_CHECKLISTBOX + if ( m_hasCheckBoxes ) + { + gtk_list_store_set(m_liststore, &iter, + 0, FALSE, // FALSE == not toggled + 1, entry, + -1); + } + else +#endif // wxUSE_CHECKLISTBOX + { + gtk_list_store_set(m_liststore, &iter, 0, entry, -1); + } } -wxClientData* wxListBox::GetClientObject( int n ) -{ - wxCHECK_MSG( m_widget != NULL, (wxClientData*)NULL, _T("invalid combobox") ); +// ---------------------------------------------------------------------------- +// client data +// ---------------------------------------------------------------------------- - wxNode *node = m_clientObjectList.Nth( n ); - if (!node) return (wxClientData*) NULL; +void* wxListBox::DoGetItemClientData(unsigned int n) const +{ + wxGtkObject entry(GTKGetEntry(n)); + wxCHECK_MSG(entry, NULL, wxT("could not get entry")); - return (wxClientData*) node->Data(); + return gtk_tree_entry_get_userdata( entry ); } -void wxListBox::Clear() +void wxListBox::DoSetItemClientData(unsigned int n, void* clientData) { - wxCHECK_RET( m_list != NULL, _T("invalid listbox") ); - - gtk_list_clear_items( m_list, 0, Number() ); - - wxNode *node = m_clientObjectList.First(); - while (node) - { - wxClientData *cd = (wxClientData*)node->Data(); - if (cd) delete cd; - node = node->Next(); - } - m_clientObjectList.Clear(); + wxGtkObject entry(GTKGetEntry(n)); + wxCHECK_RET(entry, wxT("could not get entry")); - m_clientDataList.Clear(); + gtk_tree_entry_set_userdata( entry, clientData ); } -void wxListBox::Delete( int n ) +// ---------------------------------------------------------------------------- +// string list access +// ---------------------------------------------------------------------------- + +void wxListBox::SetString(unsigned int n, const wxString& label) { - wxCHECK_RET( m_list != NULL, _T("invalid listbox") ); + wxCHECK_RET( IsValid(n), wxT("invalid index in wxListBox::SetString") ); + wxCHECK_RET( m_treeview != NULL, wxT("invalid listbox") ); - GList *child = g_list_nth( m_list->children, n ); + GtkTreeEntry* entry = GTKGetEntry(n); + wxCHECK_RET( entry, wxT("wrong listbox index") ); - wxCHECK_RET( child, _T("wrong listbox index") ); + // update the item itself + gtk_tree_entry_set_label(entry, wxGTK_CONV(label)); - GList *list = g_list_append( (GList*) NULL, child->data ); - gtk_list_remove_items( m_list, list ); - g_list_free( list ); + // and update the model which will refresh the tree too + GtkTreeIter iter; + wxCHECK_RET( GTKGetIteratorFor(n, &iter), wxT("failed to get iterator") ); - wxNode *node = m_clientObjectList.Nth( n ); - if (node) - { - wxClientData *cd = (wxClientData*)node->Data(); - if (cd) delete cd; - m_clientObjectList.DeleteNode( node ); - } + // FIXME: this resets the checked status of a wxCheckListBox item - node = m_clientDataList.Nth( n ); - if (node) - { - m_clientDataList.DeleteNode( node ); - } + GTKSetItem(iter, entry); } -void wxListBox::Deselect( int n ) +wxString wxListBox::GetString(unsigned int n) const { - wxCHECK_RET( m_list != NULL, _T("invalid listbox") ); + wxCHECK_MSG( m_treeview != NULL, wxEmptyString, wxT("invalid listbox") ); + + wxGtkObject entry(GTKGetEntry(n)); + wxCHECK_MSG( entry, wxEmptyString, wxT("wrong listbox index") ); - gtk_list_unselect_item( m_list, n ); + return wxGTK_CONV_BACK( gtk_tree_entry_get_label(entry) ); } -int wxListBox::FindString( const wxString &item ) const +unsigned int wxListBox::GetCount() const { - wxCHECK_MSG( m_list != NULL, -1, _T("invalid listbox") ); + wxCHECK_MSG( m_treeview != NULL, 0, wxT("invalid listbox") ); - GList *child = m_list->children; - int count = 0; - while (child) - { - GtkBin *bin = GTK_BIN( child->data ); - GtkLabel *label = GTK_LABEL( bin->child ); + return (unsigned int)gtk_tree_model_iter_n_children(GTK_TREE_MODEL(m_liststore), NULL); +} - wxString str = GET_REAL_LABEL(label->label); +int wxListBox::FindString( const wxString &item, bool bCase ) const +{ + wxCHECK_MSG( m_treeview != NULL, wxNOT_FOUND, wxT("invalid listbox") ); - if (str == item) - return count; + //Sort of hackish - maybe there is a faster way + unsigned int nCount = wxListBox::GetCount(); - count++; - child = child->next; + for(unsigned int i = 0; i < nCount; ++i) + { + if( item.IsSameAs( wxListBox::GetString(i), bCase ) ) + return (int)i; } - // it's not an error if the string is not found -> no wxCHECK - return -1; + // it's not an error if the string is not found -> no wxCHECK + return wxNOT_FOUND; } -int wxListBox::GetSelection() const -{ - wxCHECK_MSG( m_list != NULL, -1, _T("invalid listbox") ); +// ---------------------------------------------------------------------------- +// selection +// ---------------------------------------------------------------------------- - GList *child = m_list->children; - int count = 0; - while (child) - { - if (GTK_WIDGET(child->data)->state == GTK_STATE_SELECTED) return count; - count++; - child = child->next; - } - return -1; +void wxListBox::GTKOnActivated(int item) +{ + SendEvent(wxEVT_LISTBOX_DCLICK, item, IsSelected(item)); } -int wxListBox::GetSelections( wxArrayInt& aSelections ) const +void wxListBox::GTKOnSelectionChanged() { - wxCHECK_MSG( m_list != NULL, -1, _T("invalid listbox") ); - - // get the number of selected items first - GList *child = m_list->children; - int count = 0; - for (child = m_list->children; child != NULL; child = child->next) + if ( HasFlag(wxLB_MULTIPLE | wxLB_EXTENDED) ) { - if (GTK_WIDGET(child->data)->state == GTK_STATE_SELECTED) - count++; + CalcAndSendEvent(); } - - aSelections.Empty(); - - if (count > 0) + else // single selection { - // now fill the list - aSelections.Alloc(count); // optimization attempt - int i = 0; - for (child = m_list->children; child != NULL; child = child->next, i++) - { - if (GTK_WIDGET(child->data)->state == GTK_STATE_SELECTED) - aSelections.Add(i); - } + const int item = GetSelection(); + if ( DoChangeSingleSelection(item) ) + SendEvent(wxEVT_LISTBOX, item, true); } - - return count; } -wxString wxListBox::GetString( int n ) const +int wxListBox::GetSelection() const { - wxCHECK_MSG( m_list != NULL, _T(""), _T("invalid listbox") ); + wxCHECK_MSG( m_treeview != NULL, wxNOT_FOUND, wxT("invalid listbox")); + wxCHECK_MSG( HasFlag(wxLB_SINGLE), wxNOT_FOUND, + wxT("must be single selection listbox")); - GList *child = g_list_nth( m_list->children, n ); - if (child) - { - GtkBin *bin = GTK_BIN( child->data ); - GtkLabel *label = GTK_LABEL( bin->child ); - - wxString str = GET_REAL_LABEL(label->label); + GtkTreeIter iter; + GtkTreeSelection* selection = gtk_tree_view_get_selection(m_treeview); - return str; - } - - wxFAIL_MSG(_T("wrong listbox index")); + // only works on single-sel + if (!gtk_tree_selection_get_selected(selection, NULL, &iter)) + return wxNOT_FOUND; - return _T(""); + return GTKGetIndexFor(iter); } -wxString wxListBox::GetStringSelection() const +int wxListBox::GetSelections( wxArrayInt& aSelections ) const { - wxCHECK_MSG( m_list != NULL, _T(""), _T("invalid listbox") ); + wxCHECK_MSG( m_treeview != NULL, wxNOT_FOUND, wxT("invalid listbox") ); - GList *selection = m_list->selection; - if (selection) - { - GtkBin *bin = GTK_BIN( selection->data ); - GtkLabel *label = GTK_LABEL( bin->child ); + aSelections.Empty(); - wxString str = GET_REAL_LABEL(label->label); + int i = 0; + GtkTreeIter iter; + GtkTreeSelection* selection = gtk_tree_view_get_selection(m_treeview); + + if (gtk_tree_model_get_iter_first(GTK_TREE_MODEL(m_liststore), &iter)) + { //gtk_tree_selection_get_selected_rows is GTK 2.2+ so iter instead + do + { + if (gtk_tree_selection_iter_is_selected(selection, &iter)) + aSelections.Add(i); - return str; + i++; + } while(gtk_tree_model_iter_next(GTK_TREE_MODEL(m_liststore), &iter)); } - wxFAIL_MSG(_T("no listbox selection available")); - return _T(""); + return aSelections.GetCount(); } -int wxListBox::Number() +bool wxListBox::IsSelected( int n ) const { - wxCHECK_MSG( m_list != NULL, -1, _T("invalid listbox") ); + wxCHECK_MSG( m_treeview != NULL, false, wxT("invalid listbox") ); - GList *child = m_list->children; - int count = 0; - while (child) { count++; child = child->next; } - return count; + GtkTreeSelection* selection = gtk_tree_view_get_selection(m_treeview); + + GtkTreeIter iter; + wxCHECK_MSG( GTKGetIteratorFor(n, &iter), false, wxT("Invalid index") ); + + return gtk_tree_selection_iter_is_selected(selection, &iter) != 0; } -bool wxListBox::Selected( int n ) +void wxListBox::DoSetSelection( int n, bool select ) { - wxCHECK_MSG( m_list != NULL, FALSE, _T("invalid listbox") ); + wxCHECK_RET( m_treeview != NULL, wxT("invalid listbox") ); + + GTKDisableEvents(); + + GtkTreeSelection* selection = gtk_tree_view_get_selection(m_treeview); - GList *target = g_list_nth( m_list->children, n ); - if (target) + // passing -1 to SetSelection() is documented to deselect all items + if ( n == wxNOT_FOUND ) { - GList *child = m_list->selection; - while (child) - { - if (child->data == target->data) return TRUE; - child = child->next; - } + gtk_tree_selection_unselect_all(selection); + GTKEnableEvents(); + return; } - wxFAIL_MSG(_T("wrong listbox index")); - return FALSE; -} -void wxListBox::Set( int WXUNUSED(n), const wxString *WXUNUSED(choices) ) -{ - wxFAIL_MSG(_T("wxListBox::Set not implemented")); -} + wxCHECK_RET( IsValid(n), wxT("invalid index in wxListBox::SetSelection") ); -void wxListBox::SetFirstItem( int WXUNUSED(n) ) -{ - wxFAIL_MSG(_T("wxListBox::SetFirstItem not implemented")); -} -void wxListBox::SetFirstItem( const wxString &WXUNUSED(item) ) -{ - wxFAIL_MSG(_T("wxListBox::SetFirstItem not implemented")); -} - -void wxListBox::SetSelection( int n, bool select ) -{ - wxCHECK_RET( m_list != NULL, _T("invalid listbox") ); + GtkTreeIter iter; + wxCHECK_RET( GTKGetIteratorFor(n, &iter), wxT("Invalid index") ); if (select) - gtk_list_select_item( m_list, n ); + gtk_tree_selection_select_iter(selection, &iter); else - gtk_list_unselect_item( m_list, n ); -} + gtk_tree_selection_unselect_iter(selection, &iter); -void wxListBox::SetString( int n, const wxString &string ) -{ - wxCHECK_RET( m_list != NULL, _T("invalid listbox") ); + GtkTreePath* path = gtk_tree_model_get_path( + GTK_TREE_MODEL(m_liststore), &iter); - GList *child = g_list_nth( m_list->children, n ); - if (child) - { - GtkBin *bin = GTK_BIN( child->data ); - GtkLabel *label = GTK_LABEL( bin->child ); + gtk_tree_view_scroll_to_cell(m_treeview, path, NULL, FALSE, 0.0f, 0.0f); - wxString str; - if (m_hasCheckBoxes) - str += CHECKBOX_STRING; - str += string; + gtk_tree_path_free(path); - gtk_label_set( label, str.mbc_str() ); - } - else - { - wxFAIL_MSG(_T("wrong listbox index")); - } + GTKEnableEvents(); } -void wxListBox::SetStringSelection( const wxString &string, bool select ) +void wxListBox::DoScrollToCell(int n, float alignY, float alignX) { - wxCHECK_RET( m_list != NULL, _T("invalid listbox") ); + wxCHECK_RET( m_treeview, wxT("invalid listbox") ); + wxCHECK_RET( IsValid(n), wxT("invalid index")); + + //RN: I have no idea why this line is needed... + if (gtk_widget_has_grab(GTK_WIDGET(m_treeview))) + return; + + GtkTreeIter iter; + if ( !GTKGetIteratorFor(n, &iter) ) + return; + + GtkTreePath* path = gtk_tree_model_get_path( + GTK_TREE_MODEL(m_liststore), &iter); - SetSelection( FindString(string), select ); + // Scroll to the desired cell (0.0 == topleft alignment) + gtk_tree_view_scroll_to_cell(m_treeview, path, NULL, + TRUE, alignY, alignX); + + gtk_tree_path_free(path); } -int wxListBox::GetIndex( GtkWidget *item ) const +void wxListBox::DoSetFirstItem(int n) { - if (item) - { - GList *child = m_list->children; - int count = 0; - while (child) - { - if (GTK_WIDGET(child->data) == item) return count; - count++; - child = child->next; - } - } - return -1; + DoScrollToCell(n, 0, 0); } -#if wxUSE_TOOLTIPS -void wxListBox::ApplyToolTip( GtkTooltips *tips, const wxChar *tip ) +void wxListBox::EnsureVisible(int n) { - GList *child = m_list->children; - while (child) - { - gtk_tooltips_set_tip( tips, GTK_WIDGET( child->data ), wxConv_local.cWX2MB(tip), (gchar*) NULL ); - child = child->next; - } + DoScrollToCell(n, 0.5, 0); } -#endif // wxUSE_TOOLTIPS -#if wxUSE_DRAG_AND_DROP -void wxListBox::SetDropTarget( wxDropTarget *dropTarget ) +// ---------------------------------------------------------------------------- +// hittest +// ---------------------------------------------------------------------------- + +int wxListBox::DoListHitTest(const wxPoint& point) const { - wxCHECK_RET( m_list != NULL, _T("invalid listbox") ); + // gtk_tree_view_get_path_at_pos() also gets items that are not visible and + // we only want visible items we need to check for it manually here + if ( !GetClientRect().Contains(point) ) + return wxNOT_FOUND; + + // need to translate from master window since it is in client coords + gint binx, biny; + gdk_window_get_geometry(gtk_tree_view_get_bin_window(m_treeview), + &binx, &biny, NULL, NULL); -#ifndef NEW_GTK_DND_CODE - if (m_dropTarget) + GtkTreePath* path; + if ( !gtk_tree_view_get_path_at_pos + ( + m_treeview, + point.x - binx, + point.y - biny, + &path, + NULL, // [out] column (always 0 here) + NULL, // [out] x-coord relative to the cell (not interested) + NULL // [out] y-coord relative to the cell + ) ) { - GList *child = m_list->children; - while (child) - { - m_dropTarget->UnregisterWidget( GTK_WIDGET( child->data ) ); - child = child->next; - } + return wxNOT_FOUND; } -#endif - wxWindow::SetDropTarget( dropTarget ); + int index = gtk_tree_path_get_indices(path)[0]; + gtk_tree_path_free(path); -#ifndef NEW_GTK_DND_CODE - if (m_dropTarget) - { - GList *child = m_list->children; - while (child) - { - m_dropTarget->RegisterWidget( GTK_WIDGET( child->data ) ); - child = child->next; - } - } -#endif + return index; } -#endif + +// ---------------------------------------------------------------------------- +// helpers +// ---------------------------------------------------------------------------- GtkWidget *wxListBox::GetConnectWidget() { - return GTK_WIDGET(m_list); + // the correct widget for listbox events (such as mouse clicks for example) + // is m_treeview, not the parent scrolled window + return GTK_WIDGET(m_treeview); } -bool wxListBox::IsOwnGtkWindow( GdkWindow *window ) +GdkWindow *wxListBox::GTKGetWindow(wxArrayGdkWindows& WXUNUSED(windows)) const { - if (wxWindow::IsOwnGtkWindow( window )) return TRUE; + return gtk_tree_view_get_bin_window(m_treeview); +} - GList *child = m_list->children; - while (child) +void wxListBox::DoApplyWidgetStyle(GtkRcStyle *style) +{ +#ifdef __WXGTK3__ + // don't know if this is even necessary, or how to do it +#else + if (m_hasBgCol && m_backgroundColour.IsOk()) { - GtkWidget *bin = GTK_WIDGET( child->data ); - if (bin->window == window) return TRUE; - child = child->next; + GdkWindow *window = gtk_tree_view_get_bin_window(m_treeview); + if (window) + { + m_backgroundColour.CalcPixel( gdk_drawable_get_colormap( window ) ); + gdk_window_set_background( window, m_backgroundColour.GetColor() ); + gdk_window_clear( window ); + } } +#endif - return FALSE; + GTKApplyStyle(GTK_WIDGET(m_treeview), style); } -void wxListBox::ApplyWidgetStyle() +wxSize wxListBox::DoGetBestSize() const { - SetWidgetStyle(); + wxCHECK_MSG(m_treeview, wxDefaultSize, wxT("invalid tree view")); - if (m_backgroundColour.Ok()) + // Start with a minimum size that's not too small + int cx, cy; + GetTextExtent( wxT("X"), &cx, &cy); + int lbWidth = 0; + int lbHeight = 10; + + // Find the widest string. + const unsigned int count = GetCount(); + if ( count ) { - GdkWindow *window = GTK_WIDGET(m_list)->window; - if ( window ) + int wLine; + for ( unsigned int i = 0; i < count; i++ ) { - m_backgroundColour.CalcPixel( gdk_window_get_colormap( window ) ); - gdk_window_set_background( window, m_backgroundColour.GetColor() ); - gdk_window_clear( window ); + GetTextExtent(GetString(i), &wLine, NULL); + if ( wLine > lbWidth ) + lbWidth = wLine; } } - GList *child = m_list->children; - while (child) + lbWidth += 3 * cx; + + // And just a bit more for the checkbox if present and then some + // (these are rough guesses) +#if wxUSE_CHECKLISTBOX + if ( m_hasCheckBoxes ) { - gtk_widget_set_style( GTK_WIDGET(child->data), m_widgetStyle ); + lbWidth += 35; + cy = cy > 25 ? cy : 25; // rough height of checkbox + } +#endif - GtkBin *bin = GTK_BIN( child->data ); - GtkWidget *label = GTK_WIDGET( bin->child ); - gtk_widget_set_style( label, m_widgetStyle ); + // Add room for the scrollbar + lbWidth += wxSystemSettings::GetMetric(wxSYS_VSCROLL_X); - child = child->next; - } + // Don't make the listbox too tall but don't make it too small neither + lbHeight = (cy+4) * wxMin(wxMax(count, 3), 10); + + wxSize best(lbWidth, lbHeight); + CacheBestSize(best); + return best; } + +// static +wxVisualAttributes +wxListBox::GetClassDefaultAttributes(wxWindowVariant WXUNUSED(variant)) +{ + return GetDefaultAttributesFromGTKWidget(gtk_tree_view_new(), true); +} + +#endif // wxUSE_LISTBOX