X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/9dc44eff0235c5f30940f32ccc6d9d82a236e7d2..e68b7b364aff19665e2c6ee8c68266b6f3d56355:/src/gtk/utilsgtk.cpp diff --git a/src/gtk/utilsgtk.cpp b/src/gtk/utilsgtk.cpp index 9c82997f3c..5ba11b4e02 100644 --- a/src/gtk/utilsgtk.cpp +++ b/src/gtk/utilsgtk.cpp @@ -319,10 +319,12 @@ protected: // append this stack frame's info in the dialog if (!frame.GetFileName().empty() || !fncname.empty()) + { gtk_assert_dialog_append_stack_frame(m_dlg, - fncname.mb_str(), - frame.GetFileName().mb_str(), + fncname.utf8_str(), + frame.GetFileName().utf8_str(), frame.GetLine()); + } } private: @@ -333,7 +335,7 @@ static void get_stackframe_callback(void* p) { StackDump* dump = static_cast(p); // skip over frames up to including wxOnAssert() - dump->ProcessFrames(3); + dump->ProcessFrames(7); } #endif // wxDEBUG_LEVEL && wxUSE_STACKWALKER @@ -416,8 +418,6 @@ wxString wxGUIAppTraits::GetDesktopEnvironment() const #endif // __UNIX__ || __OS2__ -#ifdef __WXGTK26__ - // see the hack below in wxCmdLineParser::GetUsageString(). // TODO: replace this hack with a g_option_group_get_entries() // call as soon as such function exists; @@ -463,8 +463,6 @@ wxString wxGetNameFromGtkOptionEntry(const GOptionEntry *opt) return wxT(" ") + ret; } -#endif // __WXGTK26__ - #ifdef __UNIX__ wxString @@ -473,48 +471,36 @@ wxGUIAppTraits::GetStandardCmdLineOptions(wxArrayString& names, { wxString usage; -#ifdef __WXGTK26__ -#ifndef __WXGTK3__ - if (!gtk_check_version(2,6,0)) -#endif + // check whether GLib version is greater than 2.6 but also lower than 2.33 + // because, as we use the undocumented _GOptionGroup struct, we don't want + // to run this code with future versions which might change it (2.32 is the + // latest one at the time of this writing) + if (glib_check_version(2,33,0)) { - // since GTK>=2.6, we can use the glib_check_version() symbol... + usage << _("The following standard GTK+ options are also supported:\n"); - // check whether GLib version is greater than 2.6 but also lower than 2.33 - // because, as we use the undocumented _GOptionGroup struct, we don't want - // to run this code with future versions which might change it (2.32 is the - // latest one at the time of this writing) - if (glib_check_version(2,6,0) == NULL && glib_check_version(2,33,0)) - { - usage << _("The following standard GTK+ options are also supported:\n"); + // passing true here means that the function can open the default + // display while parsing (not really used here anyhow) + GOptionGroup *gtkOpts = gtk_get_option_group(true); - // passing true here means that the function can open the default - // display while parsing (not really used here anyhow) - GOptionGroup *gtkOpts = gtk_get_option_group(true); + // WARNING: here we access the internals of GOptionGroup: + GOptionEntry *entries = ((_GOptionGroup*)gtkOpts)->entries; + unsigned int n_entries = ((_GOptionGroup*)gtkOpts)->n_entries; + wxArrayString namesOptions, descOptions; - // WARNING: here we access the internals of GOptionGroup: - GOptionEntry *entries = ((_GOptionGroup*)gtkOpts)->entries; - unsigned int n_entries = ((_GOptionGroup*)gtkOpts)->n_entries; - wxArrayString namesOptions, descOptions; - - for ( size_t n = 0; n < n_entries; n++ ) - { - if ( entries[n].flags & G_OPTION_FLAG_HIDDEN ) - continue; // skip - - names.push_back(wxGetNameFromGtkOptionEntry(&entries[n])); + for ( size_t n = 0; n < n_entries; n++ ) + { + if ( entries[n].flags & G_OPTION_FLAG_HIDDEN ) + continue; // skip - const gchar * const entryDesc = entries[n].description; - desc.push_back(wxString(entryDesc)); - } + names.push_back(wxGetNameFromGtkOptionEntry(&entries[n])); - g_option_group_free (gtkOpts); + const gchar * const entryDesc = entries[n].description; + desc.push_back(wxString(entryDesc)); } + + g_option_group_free (gtkOpts); } -#else - wxUnusedVar(names); - wxUnusedVar(desc); -#endif // __WXGTK26__ return usage; }