X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/9d769508fb54392e63c5d2d4d96de02bee7887b8..3bf93e1e9ac6b61e5220967d2ada2d4faec4dd9c:/src/msw/icon.cpp diff --git a/src/msw/icon.cpp b/src/msw/icon.cpp index 5cab68a51c..2fbdb94996 100644 --- a/src/msw/icon.cpp +++ b/src/msw/icon.cpp @@ -109,16 +109,12 @@ wxObjectRefData *wxIcon::CloneRefData(const wxObjectRefData *dataOrig) const if ( !data ) return NULL; - wxIcon *self = wx_const_cast(wxIcon *, this); - lf->UnRef(); - lf->m_refData = new wxIconRefData(*data); - - if ( data->m_hIcon ) - { - ::CopyIcon(HICON(data->m_hIcon)); - } - - return m_refData; + // we don't have to copy m_hIcon because we're only called from SetHICON() + // which overwrites m_hIcon anyhow currently + // + // and if we're called from SetWidth/Height/Depth(), it doesn't make sense + // to copy it neither as the handle would be inconsistent with the new size + return new wxIconRefData(*data); } void wxIcon::CopyFromBitmap(const wxBitmap& bmp)