X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/9b11752c4f9e1fd4b11ba3d184246267facb3ad3..d5e71e81ecc15691d10b992867e08375c69c7b63:/src/common/event.cpp diff --git a/src/common/event.cpp b/src/common/event.cpp index ce2a081526..7b58e77c3c 100644 --- a/src/common/event.cpp +++ b/src/common/event.cpp @@ -29,6 +29,7 @@ #ifndef WX_PRECOMP #include "wx/list.h" + #include "wx/log.h" #include "wx/app.h" #include "wx/utils.h" #include "wx/stopwatch.h" @@ -125,7 +126,7 @@ const wxEventTableEntry wxEvtHandler::sm_eventTableEntries[] = // the memory leaks when using it, however this breaks re-initializing the // library (i.e. repeated calls to wxInitialize/wxUninitialize) because the // event tables won't be rebuilt the next time, so disable this by default -#if defined(__WXDEBUG__) && wxUSE_MEMORY_TRACING +#if wxUSE_MEMORY_TRACING class wxEventTableEntryModule: public wxModule { @@ -139,22 +140,12 @@ public: IMPLEMENT_DYNAMIC_CLASS(wxEventTableEntryModule, wxModule) -#endif // __WXDEBUG__ && wxUSE_MEMORY_TRACING +#endif // wxUSE_MEMORY_TRACING // ---------------------------------------------------------------------------- // global variables // ---------------------------------------------------------------------------- -// List containing event handlers with pending events (each handler can occur -// at most once here) -wxList *wxHandlersWithPendingEvents = NULL; -wxList *wxHandlersWithPendingDelayedEvents = NULL; - -#if wxUSE_THREADS - // protects wxHandlersWithPendingEvents list - wxCriticalSection *wxHandlersWithPendingEventsLocker = NULL; -#endif - // common event types are defined here, other event types are defined by the // components which use them @@ -186,6 +177,8 @@ wxDEFINE_EVENT( wxEVT_COMMAND_TOOL_ENTER, wxCommandEvent ); wxDEFINE_EVENT( wxEVT_COMMAND_SPINCTRL_UPDATED, wxCommandEvent ); wxDEFINE_EVENT( wxEVT_COMMAND_SPINCTRLDOUBLE_UPDATED, wxCommandEvent ); wxDEFINE_EVENT( wxEVT_COMMAND_TOOL_DROPDOWN_CLICKED, wxCommandEvent ); +wxDEFINE_EVENT( wxEVT_COMMAND_COMBOBOX_DROPDOWN, wxCommandEvent); +wxDEFINE_EVENT( wxEVT_COMMAND_COMBOBOX_CLOSEUP, wxCommandEvent); // Mouse event types wxDEFINE_EVENT( wxEVT_LEFT_DOWN, wxMouseEvent ); @@ -411,10 +404,9 @@ wxEvent& wxEvent::operator=(const wxEvent& src) #if wxUSE_GUI -/* - * Command events - * - */ +// ---------------------------------------------------------------------------- +// wxCommandEvent +// ---------------------------------------------------------------------------- #ifdef __VISUALC__ // 'this' : used in base member initializer list (for m_commandString) @@ -456,9 +448,9 @@ wxString wxCommandEvent::GetString() const } } -/* - * UI update events - */ +// ---------------------------------------------------------------------------- +// wxUpdateUIEvent +// ---------------------------------------------------------------------------- #if wxUSE_LONGLONG wxLongLong wxUpdateUIEvent::sm_lastUpdate = 0; @@ -515,9 +507,9 @@ void wxUpdateUIEvent::ResetUpdateTime() #endif } -/* - * Scroll events - */ +// ---------------------------------------------------------------------------- +// wxScrollEvent +// ---------------------------------------------------------------------------- wxScrollEvent::wxScrollEvent(wxEventType commandType, int id, @@ -529,9 +521,9 @@ wxScrollEvent::wxScrollEvent(wxEventType commandType, m_commandInt = pos; } -/* - * ScrollWin events - */ +// ---------------------------------------------------------------------------- +// wxScrollWinEvent +// ---------------------------------------------------------------------------- wxScrollWinEvent::wxScrollWinEvent(wxEventType commandType, int pos, @@ -542,10 +534,9 @@ wxScrollWinEvent::wxScrollWinEvent(wxEventType commandType, m_commandInt = pos; } -/* - * Mouse events - * - */ +// ---------------------------------------------------------------------------- +// wxMouseEvent +// ---------------------------------------------------------------------------- wxMouseEvent::wxMouseEvent(wxEventType commandType) { @@ -760,17 +751,14 @@ wxPoint wxMouseEvent::GetLogicalPosition(const wxDC& dc) const return pt; } - -/* - * Keyboard event - * - */ +// ---------------------------------------------------------------------------- +// wxKeyEvent +// ---------------------------------------------------------------------------- wxKeyEvent::wxKeyEvent(wxEventType type) { m_eventType = type; m_keyCode = 0; - m_scanCode = 0; #if wxUSE_UNICODE m_uniChar = 0; #endif @@ -784,8 +772,6 @@ wxKeyEvent::wxKeyEvent(const wxKeyEvent& evt) m_y = evt.m_y; m_keyCode = evt.m_keyCode; - - m_scanCode = evt.m_scanCode; m_rawCode = evt.m_rawCode; m_rawFlags = evt.m_rawFlags; @@ -794,18 +780,30 @@ wxKeyEvent::wxKeyEvent(const wxKeyEvent& evt) #endif } +// ---------------------------------------------------------------------------- +// wxWindowCreateEvent +// ---------------------------------------------------------------------------- + wxWindowCreateEvent::wxWindowCreateEvent(wxWindow *win) { SetEventType(wxEVT_CREATE); SetEventObject(win); } +// ---------------------------------------------------------------------------- +// wxWindowDestroyEvent +// ---------------------------------------------------------------------------- + wxWindowDestroyEvent::wxWindowDestroyEvent(wxWindow *win) { SetEventType(wxEVT_DESTROY); SetEventObject(win); } +// ---------------------------------------------------------------------------- +// wxChildFocusEvent +// ---------------------------------------------------------------------------- + wxChildFocusEvent::wxChildFocusEvent(wxWindow *win) : wxCommandEvent(wxEVT_CHILD_FOCUS) { @@ -880,7 +878,7 @@ void wxEventHashTable::Clear() m_size = 0; } -#if defined(__WXDEBUG__) && wxUSE_MEMORY_TRACING +#if wxUSE_MEMORY_TRACING // Clear all tables void wxEventHashTable::ClearAll() @@ -893,7 +891,7 @@ void wxEventHashTable::ClearAll() } } -#endif // __WXDEBUG__ && wxUSE_MEMORY_TRACING +#endif // wxUSE_MEMORY_TRACING bool wxEventHashTable::HandleEvent(wxEvent &event, wxEvtHandler *self) { @@ -1037,10 +1035,6 @@ void wxEventHashTable::GrowEventTypeTable() // wxEvtHandler // ---------------------------------------------------------------------------- -/* - * Event handler - */ - wxEvtHandler::wxEvtHandler() { m_nextHandler = NULL; @@ -1085,41 +1079,13 @@ wxEvtHandler::~wxEvtHandler() delete entry; } delete m_dynamicEvents; - }; - - if (m_pendingEvents) - m_pendingEvents->DeleteContents(true); - delete m_pendingEvents; - - // Remove us from wxHandlersWithPendingEvents if necessary. - if ( wxHandlersWithPendingEvents ) - { -#if wxUSE_THREADS - if (wxHandlersWithPendingEventsLocker) - wxENTER_CRIT_SECT(*wxHandlersWithPendingEventsLocker); -#endif + } - if ( wxHandlersWithPendingEvents->DeleteObject(this) ) - { - // check that we were present only once in the list - wxASSERT_MSG( !wxHandlersWithPendingEvents->Find(this), - "Handler occurs twice in wxHandlersWithPendingEvents list" ); - } - //else: we weren't in this list at all, it's ok + // Remove us from the list of the pending events if necessary. + if (wxTheApp) + wxTheApp->RemovePendingEventHandler(this); - if ( wxHandlersWithPendingDelayedEvents->DeleteObject(this) ) - { - // check that we were present only once in the list - wxASSERT_MSG( !wxHandlersWithPendingDelayedEvents->Find(this), - "Handler occurs twice in wxHandlersWithPendingDelayedEvents list" ); - } - //else: we weren't in this list at all, it's ok - -#if wxUSE_THREADS - if (wxHandlersWithPendingEventsLocker) - wxLEAVE_CRIT_SECT(*wxHandlersWithPendingEventsLocker); -#endif - } + DeletePendingEvents(); // we only delete object data, not untyped if ( m_clientDataType == wxClientData_Object ) @@ -1165,25 +1131,30 @@ void wxEvtHandler::QueueEvent(wxEvent *event) { wxCHECK_RET( event, "NULL event can't be posted" ); + if (!wxTheApp) + { + // we need an event loop which manages the list of event handlers with + // pending events... cannot proceed without it! + wxLogDebug("No application object! Cannot queue this event!"); + + // anyway delete the given event to avoid memory leaks + delete event; + + return; + } + // 1) Add this event to our list of pending events wxENTER_CRIT_SECT( m_pendingEventsLock ); if ( !m_pendingEvents ) - m_pendingEvents = new wxList; + m_pendingEvents = new wxList; m_pendingEvents->Append(event); // 2) Add this event handler to list of event handlers that // have pending events. - wxENTER_CRIT_SECT(*wxHandlersWithPendingEventsLocker); - - if ( !wxHandlersWithPendingEvents ) - wxHandlersWithPendingEvents = new wxList; - if ( !wxHandlersWithPendingEvents->Find(this) ) - wxHandlersWithPendingEvents->Append(this); - - wxLEAVE_CRIT_SECT(*wxHandlersWithPendingEventsLocker); + wxTheApp->AppendPendingEventHandler(this); // only release m_pendingEventsLock now because otherwise there is a race // condition as described in the ticket #9093: we could process the event @@ -1198,8 +1169,23 @@ void wxEvtHandler::QueueEvent(wxEvent *event) wxWakeUpIdle(); } +void wxEvtHandler::DeletePendingEvents() +{ + if (m_pendingEvents) + m_pendingEvents->DeleteContents(true); + wxDELETE(m_pendingEvents); +} + void wxEvtHandler::ProcessPendingEvents() { + if (!wxTheApp) + { + // we need an event loop which manages the list of event handlers with + // pending events... cannot proceed without it! + wxLogDebug("No application object! Cannot process pending events!"); + return; + } + // we need to process only a single pending event in this call because // each call to ProcessEvent() could result in the destruction of this // same event handler (see the comment at the end of this function) @@ -1215,9 +1201,10 @@ void wxEvtHandler::ProcessPendingEvents() wxEvent* pEvent = static_cast(node->GetData()); // find the first event which can be processed now: - if (wxTheApp && wxTheApp->IsYielding()) + wxEventLoopBase* evtLoop = wxEventLoopBase::GetActive(); + if (evtLoop && evtLoop->IsYielding()) { - while (node && pEvent && !wxTheApp->IsEventAllowedInsideYield(pEvent->GetEventCategory())) + while (node && pEvent && !evtLoop->IsEventAllowedInsideYield(pEvent->GetEventCategory())) { node = node->GetNext(); pEvent = node ? static_cast(node->GetData()) : NULL; @@ -1226,19 +1213,11 @@ void wxEvtHandler::ProcessPendingEvents() if (!node) { // all our events are NOT processable now... signal this: -#if wxUSE_THREADS - if (wxHandlersWithPendingEventsLocker) - wxENTER_CRIT_SECT(*wxHandlersWithPendingEventsLocker); -#endif - // move us from the list of handlers with processable pending events - // to the list of handlers with pending events which needs to be processed later - wxHandlersWithPendingEvents->DeleteObject(this); - if ( !wxHandlersWithPendingDelayedEvents->Find(this) ) - wxHandlersWithPendingDelayedEvents->Append(this); -#if wxUSE_THREADS - if (wxHandlersWithPendingEventsLocker) - wxLEAVE_CRIT_SECT(*wxHandlersWithPendingEventsLocker); -#endif + wxTheApp->DelayPendingEventHandler(this); + + // see the comment at the beginning of evtloop.h header for the + // logic behind YieldFor() and behind DelayPendingEventHandler() + wxLEAVE_CRIT_SECT( m_pendingEventsLock ); return; @@ -1252,19 +1231,11 @@ void wxEvtHandler::ProcessPendingEvents() // same event again. m_pendingEvents->Erase(node); - // if there are no more pending events left, we don't need to stay in this - // list if ( m_pendingEvents->IsEmpty() ) { -#if wxUSE_THREADS - if (wxHandlersWithPendingEventsLocker) - wxENTER_CRIT_SECT(*wxHandlersWithPendingEventsLocker); -#endif - wxHandlersWithPendingEvents->DeleteObject(this); -#if wxUSE_THREADS - if (wxHandlersWithPendingEventsLocker) - wxLEAVE_CRIT_SECT(*wxHandlersWithPendingEventsLocker); -#endif + // if there are no more pending events left, we don't need to + // stay in this list + wxTheApp->RemovePendingEventHandler(this); } wxLEAVE_CRIT_SECT( m_pendingEventsLock ); @@ -1276,13 +1247,10 @@ void wxEvtHandler::ProcessPendingEvents() // of this object any more } -/* - * Event table stuff - */ -/* static */ bool -wxEvtHandler::ProcessEventIfMatchesId(const wxEventTableEntryBase& entry, - wxEvtHandler *handler, - wxEvent& event) +/* static */ +bool wxEvtHandler::ProcessEventIfMatchesId(const wxEventTableEntryBase& entry, + wxEvtHandler *handler, + wxEvent& event) { int tableId1 = entry.m_id, tableId2 = entry.m_lastId; @@ -1320,15 +1288,8 @@ wxEvtHandler::ProcessEventIfMatchesId(const wxEventTableEntryBase& entry, return false; } -bool wxEvtHandler::TryParent(wxEvent& event) +bool wxEvtHandler::DoTryApp(wxEvent& event) { - if ( GetNextHandler() ) - { - // the next handler will pass it to wxTheApp if it doesn't process it, - // so return from here to avoid doing it again - return GetNextHandler()->TryParent(event); - } - if ( wxTheApp && (this != wxTheApp) ) { // Special case: don't pass wxEVT_IDLE to wxApp, since it'll always @@ -1344,6 +1305,27 @@ bool wxEvtHandler::TryParent(wxEvent& event) return false; } +bool wxEvtHandler::TryBefore(wxEvent& event) +{ +#if WXWIN_COMPATIBILITY_2_8 + // call the old virtual function to keep the code overriding it working + return TryValidator(event); +#else + wxUnusedVar(event); + return false; +#endif +} + +bool wxEvtHandler::TryAfter(wxEvent& event) +{ +#if WXWIN_COMPATIBILITY_2_8 + // as above, call the old virtual function for compatibility + return TryParent(event); +#else + return DoTryApp(event); +#endif +} + bool wxEvtHandler::ProcessEvent(wxEvent& event) { // allow the application to hook into event processing @@ -1355,27 +1337,6 @@ bool wxEvtHandler::ProcessEvent(wxEvent& event) { if ( wxTheApp ) { -/* - CANNOT ENABLE: ProcessEvent() must always immediately process the event! - - if (wxTheApp->IsYielding() && - !wxTheApp->IsEventAllowedInsideYield(event.GetEventCategory())) - { - wxEvent* queuedEv = event.Clone(); - - // queue this event rather than processing it now - QueueEvent(queuedEv); - // the wxWakeUpIdle call shouldn't probably be done - // in this context (there's wxYield in the call stack) - - return true; - // it's not completely true that the event was processed; - // but we cannot even say it was skipped or discarded... - } - //else: either we're not inside a wxYield() call or if we are, - // we can process this event immediately. -*/ - int rc = wxTheApp->FilterEvent(event); if ( rc != -1 ) { @@ -1392,14 +1353,14 @@ bool wxEvtHandler::ProcessEvent(wxEvent& event) return true; // pass the event to the next handler, notice that we shouldn't call - // TryParent() even if it doesn't handle the event as the last handler in + // TryAfter() even if it doesn't handle the event as the last handler in // the chain will do it if ( GetNextHandler() ) return GetNextHandler()->ProcessEvent(event); // propagate the event upwards the window chain and/or to the application // object if it wasn't processed at this level - return TryParent(event); + return TryAfter(event); } bool wxEvtHandler::ProcessEventHere(wxEvent& event) @@ -1408,9 +1369,8 @@ bool wxEvtHandler::ProcessEventHere(wxEvent& event) if ( !GetEvtHandlerEnabled() ) return false; - // If we have a validator, it has higher priority than our own event - // handlers - if ( TryValidator(event) ) + // Try the hooks which should be called before our own handlers + if ( TryBefore(event) ) return true; // Handle per-instance dynamic event tables first @@ -1436,9 +1396,15 @@ bool wxEvtHandler::SafelyProcessEvent(wxEvent& event) } catch ( ... ) { - wxEventLoopBase *loop = wxEventLoopBase::GetActive(); + // notice that we do it in 2 steps to avoid warnings about possibly + // uninitialized loop variable from some versions of g++ which are not + // smart enough to figure out that GetActive() doesn't throw and so + // that loop will always be initialized + wxEventLoopBase *loop = NULL; try { + loop = wxEventLoopBase::GetActive(); + if ( !wxTheApp || !wxTheApp->OnExceptionInMainLoop() ) { if ( loop ) @@ -1461,7 +1427,6 @@ bool wxEvtHandler::SafelyProcessEvent(wxEvent& event) #endif // wxUSE_EXCEPTIONS } - bool wxEvtHandler::SearchEventTable(wxEventTable& table, wxEvent& event) { const wxEventType eventType = event.GetEventType();