X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/9b00bb1626a28272e58728633f431c0c2996cd2d..66b6b04535cf261b7bae7da77332835b242abd04:/src/generic/treectrl.cpp

diff --git a/src/generic/treectrl.cpp b/src/generic/treectrl.cpp
index 36f8be5bfa..af2d4cf2e3 100644
--- a/src/generic/treectrl.cpp
+++ b/src/generic/treectrl.cpp
@@ -167,8 +167,8 @@ private:
                                           // children but has a [+] button
     int                 m_isBold      :1; // render the label in bold font
 
-    int                 m_x, m_y;
-    long                m_height, m_width;
+    wxCoord             m_x, m_y;
+    wxCoord             m_height, m_width;
     int                 m_xCross, m_yCross;
     int                 m_level;
 
@@ -208,13 +208,18 @@ BEGIN_EVENT_TABLE(wxTreeTextCtrl,wxTextCtrl)
     EVT_KILL_FOCUS     (wxTreeTextCtrl::OnKillFocus)
 END_EVENT_TABLE()
 
-wxTreeTextCtrl::wxTreeTextCtrl( wxWindow *parent, const wxWindowID id,
-    bool *accept, wxString *res, wxTreeCtrl *owner,
-    const wxString &value, const wxPoint &pos, const wxSize &size,
-#if wxUSE_VALIDATORS
-    int style, const wxValidator& validator, const wxString &name ) :
-#endif
-  wxTextCtrl( parent, id, value, pos, size, style, validator, name )
+wxTreeTextCtrl::wxTreeTextCtrl( wxWindow *parent,
+                                const wxWindowID id,
+                                bool *accept,
+                                wxString *res,
+                                wxTreeCtrl *owner,
+                                const wxString &value,
+                                const wxPoint &pos,
+                                const wxSize &size,
+                                int style,
+                                const wxValidator& validator,
+                                const wxString &name )
+              : wxTextCtrl( parent, id, value, pos, size, style, validator, name )
 {
     m_res = res;
     m_accept = accept;
@@ -263,8 +268,8 @@ IMPLEMENT_DYNAMIC_CLASS(wxTreeEvent, wxNotifyEvent)
 wxTreeEvent::wxTreeEvent( wxEventType commandType, int id )
            : wxNotifyEvent( commandType, id )
 {
-  m_code = 0;
-  m_itemOld = (wxGenericTreeItem *)NULL;
+    m_code = 0;
+    m_itemOld = (wxGenericTreeItem *)NULL;
 }
 
 // -----------------------------------------------------------------------------
@@ -273,191 +278,188 @@ wxTreeEvent::wxTreeEvent( wxEventType commandType, int id )
 
 wxGenericTreeItem::wxGenericTreeItem(wxGenericTreeItem *parent,
                                      const wxString& text,
-                                     wxDC& dc,
+                                     wxDC& WXUNUSED(dc),
                                      int image, int selImage,
                                      wxTreeItemData *data)
                  : m_text(text)
 {
-  m_images[wxTreeItemIcon_Normal] = image;
-  m_images[wxTreeItemIcon_Selected] = selImage;
-  m_images[wxTreeItemIcon_Expanded] = NO_IMAGE;
-  m_images[wxTreeItemIcon_SelectedExpanded] = NO_IMAGE;
-
-  m_data = data;
-  m_x = m_y = 0;
-  m_xCross = m_yCross = 0;
+    m_images[wxTreeItemIcon_Normal] = image;
+    m_images[wxTreeItemIcon_Selected] = selImage;
+    m_images[wxTreeItemIcon_Expanded] = NO_IMAGE;
+    m_images[wxTreeItemIcon_SelectedExpanded] = NO_IMAGE;
 
-  m_level = 0;
+    m_data = data;
+    m_x = m_y = 0;
+    m_xCross = m_yCross = 0;
 
-  m_isCollapsed = TRUE;
-  m_hasHilight = FALSE;
-  m_hasPlus = FALSE;
-  m_isBold = FALSE;
+    m_level = 0;
 
-  m_parent = parent;
+    m_isCollapsed = TRUE;
+    m_hasHilight = FALSE;
+    m_hasPlus = FALSE;
+    m_isBold = FALSE;
 
-  m_attr = (wxTreeItemAttr *)NULL;
+    m_parent = parent;
 
-  dc.GetTextExtent( m_text, &m_width, &m_height );
-  // TODO : Add the width of the image
-  // PB   : We don't know which image is shown (image, selImage)
-  //        We don't even know imageList from the treectrl this item belongs to !!!
-  // At this point m_width doesn't mean much, this can be remove !
+    m_attr = (wxTreeItemAttr *)NULL;
+  
+    // We don't know the height here yet.
+    m_width = 0;
+    m_height = 0;
 }
 
 wxGenericTreeItem::~wxGenericTreeItem()
 {
-  delete m_data;
+    delete m_data;
 
-  delete m_attr;
+    delete m_attr;
 
-  wxASSERT_MSG( m_children.IsEmpty(),
-                wxT("please call DeleteChildren() before deleting the item") );
+    wxASSERT_MSG( m_children.IsEmpty(),
+                  wxT("please call DeleteChildren() before deleting the item") );
 }
 
 void wxGenericTreeItem::DeleteChildren(wxTreeCtrl *tree)
 {
-  size_t count = m_children.Count();
-  for ( size_t n = 0; n < count; n++ )
-  {
-    wxGenericTreeItem *child = m_children[n];
-    if ( tree )
+    size_t count = m_children.Count();
+    for ( size_t n = 0; n < count; n++ )
     {
-      tree->SendDeleteEvent(child);
-    }
+        wxGenericTreeItem *child = m_children[n];
+        if (tree)
+            tree->SendDeleteEvent(child);
 
-    child->DeleteChildren(tree);
-    delete child;
-  }
+        child->DeleteChildren(tree);
+        delete child;
+    }
 
-  m_children.Empty();
+    m_children.Empty();
 }
 
 void wxGenericTreeItem::SetText( const wxString &text )
 {
-  m_text = text;
+    m_text = text;
 }
 
 void wxGenericTreeItem::Reset()
 {
-  m_text.Empty();
-  for ( int i = 0; i < wxTreeItemIcon_Max; i++ )
-  {
-    m_images[i] = NO_IMAGE;
-  }
+    m_text.Empty();
+    for ( int i = 0; i < wxTreeItemIcon_Max; i++ )
+    {
+        m_images[i] = NO_IMAGE;
+    }
 
-  m_data = NULL;
-  m_x = m_y =
-  m_height = m_width = 0;
-  m_xCross =
-  m_yCross = 0;
+    m_data = NULL;
+    m_x = m_y =
+    m_height = m_width = 0;
+    m_xCross =
+    m_yCross = 0;
 
-  m_level = 0;
+    m_level = 0;
 
-  DeleteChildren();
-  m_isCollapsed = TRUE;
+    DeleteChildren();
+    m_isCollapsed = TRUE;
 
-  m_parent = (wxGenericTreeItem *)NULL;
+    m_parent = (wxGenericTreeItem *)NULL;
 }
 
 size_t wxGenericTreeItem::GetChildrenCount(bool recursively) const
 {
-  size_t count = m_children.Count();
-  if ( !recursively )
-    return count;
+    size_t count = m_children.Count();
+    if ( !recursively )
+        return count;
 
-  size_t total = count;
-  for ( size_t n = 0; n < count; ++n )
-  {
-    total += m_children[n]->GetChildrenCount();
-  }
+    size_t total = count;
+    for (size_t n = 0; n < count; ++n)
+    {
+        total += m_children[n]->GetChildrenCount();
+    }
 
-  return total;
+    return total;
 }
 
 void wxGenericTreeItem::SetCross( int x, int y )
 {
-  m_xCross = x;
-  m_yCross = y;
+    m_xCross = x;
+    m_yCross = y;
 }
 
 void wxGenericTreeItem::GetSize( int &x, int &y, const wxTreeCtrl *theTree )
 {
-  int bottomY=m_y+theTree->GetLineHeight(this);
-  if ( y < bottomY ) y = bottomY;
-  int width = m_x +  m_width;
-  if ( x < width ) x = width;
+    int bottomY=m_y+theTree->GetLineHeight(this);
+    if ( y < bottomY ) y = bottomY;
+    int width = m_x +  m_width;
+    if ( x < width ) x = width;
 
-  if (IsExpanded())
-  {
-    size_t count = m_children.Count();
-    for ( size_t n = 0; n < count; ++n )
+    if (IsExpanded())
     {
-      m_children[n]->GetSize( x, y, theTree );
+        size_t count = m_children.Count();
+        for ( size_t n = 0; n < count; ++n )
+        {
+            m_children[n]->GetSize( x, y, theTree );
+        }
     }
-  }
 }
 
 wxGenericTreeItem *wxGenericTreeItem::HitTest( const wxPoint& point,
                                                const wxTreeCtrl *theTree,
                                                int &flags)
 {
-  if ((point.y > m_y) && (point.y < m_y + theTree->GetLineHeight(this)))
-  {
-    if (point.y<m_y+theTree->GetLineHeight(this)/2)
-        flags |= wxTREE_HITTEST_ONITEMUPPERPART;
-    else
-        flags |= wxTREE_HITTEST_ONITEMLOWERPART;
-
-    // 5 is the size of the plus sign
-    if ((point.x > m_xCross-5) && (point.x < m_xCross+5) &&
-        (point.y > m_yCross-5) && (point.y < m_yCross+5) &&
-        (IsExpanded() || HasPlus()))
+    if ((point.y > m_y) && (point.y < m_y + theTree->GetLineHeight(this)))
     {
-      flags|=wxTREE_HITTEST_ONITEMBUTTON;
-      return this;
-    }
+        if (point.y<m_y+theTree->GetLineHeight(this)/2)
+            flags |= wxTREE_HITTEST_ONITEMUPPERPART;
+        else
+            flags |= wxTREE_HITTEST_ONITEMLOWERPART;
 
-    if ((point.x >= m_x) && (point.x <= m_x+m_width))
-    {
-      int image_w = -1;
-      int image_h;
+        // 5 is the size of the plus sign
+        if ((point.x > m_xCross-5) && (point.x < m_xCross+5) &&
+            (point.y > m_yCross-5) && (point.y < m_yCross+5) &&
+            (IsExpanded() || HasPlus()))
+        {
+            flags|=wxTREE_HITTEST_ONITEMBUTTON;
+            return this;
+        }
 
-      // assuming every image (normal and selected ) has the same size !
-      if ( (GetImage() != NO_IMAGE) && theTree->m_imageListNormal )
-          theTree->m_imageListNormal->GetSize(GetImage(), image_w, image_h);
+        if ((point.x >= m_x) && (point.x <= m_x+m_width))
+        {
+            int image_w = -1;
+            int image_h;
 
-      if ((image_w != -1) && (point.x <= m_x + image_w + 1))
-        flags |= wxTREE_HITTEST_ONITEMICON;
-      else
-        flags |= wxTREE_HITTEST_ONITEMLABEL;
+            // assuming every image (normal and selected ) has the same size !
+            if ( (GetImage() != NO_IMAGE) && theTree->m_imageListNormal )
+                theTree->m_imageListNormal->GetSize(GetImage(), image_w, image_h);
 
-      return this;
-    }
+            if ((image_w != -1) && (point.x <= m_x + image_w + 1))
+                flags |= wxTREE_HITTEST_ONITEMICON;
+            else
+                flags |= wxTREE_HITTEST_ONITEMLABEL;
 
-    if (point.x < m_x)
-        flags |= wxTREE_HITTEST_ONITEMINDENT;
-    if (point.x > m_x+m_width)
-        flags |= wxTREE_HITTEST_ONITEMRIGHT;
+            return this;
+        }
 
-    return this;
-  }
-  else
-  {
-    if (!m_isCollapsed)
+        if (point.x < m_x)
+            flags |= wxTREE_HITTEST_ONITEMINDENT;
+        if (point.x > m_x+m_width)
+            flags |= wxTREE_HITTEST_ONITEMRIGHT;
+
+        return this;
+    }
+    else
     {
-      size_t count = m_children.Count();
-      for ( size_t n = 0; n < count; n++ )
-      {
-        wxGenericTreeItem *res = m_children[n]->HitTest( point, theTree, flags );
-        if ( res != NULL )
-          return res;
-      }
+        if (!m_isCollapsed)
+        {
+            size_t count = m_children.Count();
+            for ( size_t n = 0; n < count; n++ )
+            {
+                wxGenericTreeItem *res = m_children[n]->HitTest( point, theTree, flags );
+                if ( res != NULL )
+                    return res;
+            }
+        }
     }
-  }
 
-  flags|=wxTREE_HITTEST_NOWHERE;
-  return NULL;
+    flags|=wxTREE_HITTEST_NOWHERE;
+    
+    return (wxGenericTreeItem*) NULL;
 }
 
 int wxGenericTreeItem::GetCurrentImage() const
@@ -500,12 +502,12 @@ int wxGenericTreeItem::GetCurrentImage() const
 IMPLEMENT_DYNAMIC_CLASS(wxTreeCtrl, wxScrolledWindow)
 
 BEGIN_EVENT_TABLE(wxTreeCtrl,wxScrolledWindow)
-  EVT_PAINT          (wxTreeCtrl::OnPaint)
-  EVT_MOUSE_EVENTS   (wxTreeCtrl::OnMouse)
-  EVT_CHAR           (wxTreeCtrl::OnChar)
-  EVT_SET_FOCUS      (wxTreeCtrl::OnSetFocus)
-  EVT_KILL_FOCUS     (wxTreeCtrl::OnKillFocus)
-  EVT_IDLE           (wxTreeCtrl::OnIdle)
+    EVT_PAINT          (wxTreeCtrl::OnPaint)
+    EVT_MOUSE_EVENTS   (wxTreeCtrl::OnMouse)
+    EVT_CHAR           (wxTreeCtrl::OnChar)
+    EVT_SET_FOCUS      (wxTreeCtrl::OnSetFocus)
+    EVT_KILL_FOCUS     (wxTreeCtrl::OnKillFocus)
+    EVT_IDLE           (wxTreeCtrl::OnIdle)
 END_EVENT_TABLE()
 
 // -----------------------------------------------------------------------------
@@ -514,33 +516,33 @@ END_EVENT_TABLE()
 
 void wxTreeCtrl::Init()
 {
-  m_current =
-  m_key_current =
-  m_anchor = (wxGenericTreeItem *) NULL;
-  m_hasFocus = FALSE;
-  m_dirty = FALSE;
+    m_current =
+    m_key_current =
+    m_anchor = (wxGenericTreeItem *) NULL;
+    m_hasFocus = FALSE;
+    m_dirty = FALSE;
 
-  m_xScroll = 0;
-  m_yScroll = 0;
-  m_lineHeight = 10;
-  m_indent = 15;
-  m_spacing = 18;
+    m_xScroll = 0;
+    m_yScroll = 0;
+    m_lineHeight = 10;
+    m_indent = 15;
+    m_spacing = 18;
 
-  m_hilightBrush = new wxBrush
+    m_hilightBrush = new wxBrush
     (
       wxSystemSettings::GetSystemColour(wxSYS_COLOUR_HIGHLIGHT),
       wxSOLID
     );
 
-  m_imageListNormal =
-  m_imageListState = (wxImageList *) NULL;
+    m_imageListNormal =
+    m_imageListState = (wxImageList *) NULL;
 
-  m_dragCount = 0;
+    m_dragCount = 0;
 
-  m_renameTimer = new wxTreeRenameTimer( this );
+    m_renameTimer = new wxTreeRenameTimer( this );
 
-  m_normalFont = wxSystemSettings::GetSystemFont( wxSYS_DEFAULT_GUI_FONT );
-  m_boldFont = wxFont( m_normalFont.GetPointSize(),
+    m_normalFont = wxSystemSettings::GetSystemFont( wxSYS_DEFAULT_GUI_FONT );
+    m_boldFont = wxFont( m_normalFont.GetPointSize(),
                             m_normalFont.GetFamily(),
                             m_normalFont.GetStyle(),
                             wxBOLD,
@@ -550,33 +552,31 @@ void wxTreeCtrl::Init()
 bool wxTreeCtrl::Create(wxWindow *parent, wxWindowID id,
                         const wxPoint& pos, const wxSize& size,
                         long style,
-#if wxUSE_VALIDATORS
-            const wxValidator &validator,
-#endif
-            const wxString& name )
+                        const wxValidator &validator,
+                        const wxString& name )
 {
-  Init();
+    Init();
 
-  wxScrolledWindow::Create( parent, id, pos, size, style|wxHSCROLL|wxVSCROLL, name );
+    wxScrolledWindow::Create( parent, id, pos, size, style|wxHSCROLL|wxVSCROLL, name );
 
 #if wxUSE_VALIDATORS
-  SetValidator( validator );
+    SetValidator( validator );
 #endif
 
-  SetBackgroundColour( *wxWHITE );
-//  m_dottedPen = wxPen( "grey", 0, wxDOT );
-  m_dottedPen = wxPen( "grey", 0, 0 );
+    SetBackgroundColour( *wxWHITE );
+//  m_dottedPen = wxPen( "grey", 0, wxDOT );  too slow under XFree86
+    m_dottedPen = wxPen( "grey", 0, 0 );
 
-  return TRUE;
+    return TRUE;
 }
 
 wxTreeCtrl::~wxTreeCtrl()
 {
-  wxDELETE( m_hilightBrush );
+    wxDELETE( m_hilightBrush );
 
-  DeleteAllItems();
+    DeleteAllItems();
 
-  delete m_renameTimer;
+    delete m_renameTimer;
 }
 
 // -----------------------------------------------------------------------------
@@ -585,28 +585,26 @@ wxTreeCtrl::~wxTreeCtrl()
 
 size_t wxTreeCtrl::GetCount() const
 {
-  return m_anchor == NULL ? 0u : m_anchor->GetChildrenCount();
+    return m_anchor == NULL ? 0u : m_anchor->GetChildrenCount();
 }
 
 void wxTreeCtrl::SetIndent(unsigned int indent)
 {
-  m_indent = indent;
-  m_dirty = TRUE;
-  Refresh();
+    m_indent = indent;
+    m_dirty = TRUE;
 }
 
 void wxTreeCtrl::SetSpacing(unsigned int spacing)
 {
-  m_spacing = spacing;
-  m_dirty = TRUE;
-  Refresh();
+    m_spacing = spacing;
+    m_dirty = TRUE;
 }
 
 size_t wxTreeCtrl::GetChildrenCount(const wxTreeItemId& item, bool recursively)
 {
-  wxCHECK_MSG( item.IsOk(), 0u, wxT("invalid tree item") );
+    wxCHECK_MSG( item.IsOk(), 0u, wxT("invalid tree item") );
 
-  return item.m_pItem->GetChildrenCount(recursively);
+    return item.m_pItem->GetChildrenCount(recursively);
 }
 
 // -----------------------------------------------------------------------------
@@ -615,35 +613,35 @@ size_t wxTreeCtrl::GetChildrenCount(const wxTreeItemId& item, bool recursively)
 
 wxString wxTreeCtrl::GetItemText(const wxTreeItemId& item) const
 {
-  wxCHECK_MSG( item.IsOk(), wxT(""), wxT("invalid tree item") );
+    wxCHECK_MSG( item.IsOk(), wxT(""), wxT("invalid tree item") );
 
-  return item.m_pItem->GetText();
+    return item.m_pItem->GetText();
 }
 
 int wxTreeCtrl::GetItemImage(const wxTreeItemId& item,
                              wxTreeItemIcon which) const
 {
-  wxCHECK_MSG( item.IsOk(), -1, wxT("invalid tree item") );
+    wxCHECK_MSG( item.IsOk(), -1, wxT("invalid tree item") );
 
-  return item.m_pItem->GetImage(which);
+    return item.m_pItem->GetImage(which);
 }
 
 wxTreeItemData *wxTreeCtrl::GetItemData(const wxTreeItemId& item) const
 {
-  wxCHECK_MSG( item.IsOk(), NULL, wxT("invalid tree item") );
+    wxCHECK_MSG( item.IsOk(), NULL, wxT("invalid tree item") );
 
-  return item.m_pItem->GetData();
+    return item.m_pItem->GetData();
 }
 
 void wxTreeCtrl::SetItemText(const wxTreeItemId& item, const wxString& text)
 {
-  wxCHECK_RET( item.IsOk(), wxT("invalid tree item") );
+    wxCHECK_RET( item.IsOk(), wxT("invalid tree item") );
 
-  wxClientDC dc(this);
-  wxGenericTreeItem *pItem = item.m_pItem;
-  pItem->SetText(text);
-  CalculateSize(pItem, dc);
-  RefreshLine(pItem);
+    wxClientDC dc(this);
+    wxGenericTreeItem *pItem = item.m_pItem;
+    pItem->SetText(text);
+    CalculateSize(pItem, dc);
+    RefreshLine(pItem);
 }
 
 void wxTreeCtrl::SetItemImage(const wxTreeItemId& item,
@@ -662,18 +660,18 @@ void wxTreeCtrl::SetItemImage(const wxTreeItemId& item,
 
 void wxTreeCtrl::SetItemData(const wxTreeItemId& item, wxTreeItemData *data)
 {
-  wxCHECK_RET( item.IsOk(), wxT("invalid tree item") );
+    wxCHECK_RET( item.IsOk(), wxT("invalid tree item") );
 
-  item.m_pItem->SetData(data);
+    item.m_pItem->SetData(data);
 }
 
 void wxTreeCtrl::SetItemHasChildren(const wxTreeItemId& item, bool has)
 {
-  wxCHECK_RET( item.IsOk(), wxT("invalid tree item") );
+    wxCHECK_RET( item.IsOk(), wxT("invalid tree item") );
 
-  wxGenericTreeItem *pItem = item.m_pItem;
-  pItem->SetHasPlus(has);
-  RefreshLine(pItem);
+    wxGenericTreeItem *pItem = item.m_pItem;
+    pItem->SetHasPlus(has);
+    RefreshLine(pItem);
 }
 
 void wxTreeCtrl::SetItemBold(const wxTreeItemId& item, bool bold)
@@ -724,37 +722,37 @@ void wxTreeCtrl::SetItemFont(const wxTreeItemId& item, const wxFont& font)
 
 bool wxTreeCtrl::IsVisible(const wxTreeItemId& WXUNUSED(item)) const
 {
-  wxFAIL_MSG(wxT("not implemented"));
+    wxFAIL_MSG(wxT("not implemented"));
 
-  return TRUE;
+    return TRUE;
 }
 
 bool wxTreeCtrl::ItemHasChildren(const wxTreeItemId& item) const
 {
-  wxCHECK_MSG( item.IsOk(), FALSE, wxT("invalid tree item") );
+    wxCHECK_MSG( item.IsOk(), FALSE, wxT("invalid tree item") );
 
-  return !item.m_pItem->GetChildren().IsEmpty();
+    return !item.m_pItem->GetChildren().IsEmpty();
 }
 
 bool wxTreeCtrl::IsExpanded(const wxTreeItemId& item) const
 {
-  wxCHECK_MSG( item.IsOk(), FALSE, wxT("invalid tree item") );
+    wxCHECK_MSG( item.IsOk(), FALSE, wxT("invalid tree item") );
 
-  return item.m_pItem->IsExpanded();
+    return item.m_pItem->IsExpanded();
 }
 
 bool wxTreeCtrl::IsSelected(const wxTreeItemId& item) const
 {
-  wxCHECK_MSG( item.IsOk(), FALSE, wxT("invalid tree item") );
+    wxCHECK_MSG( item.IsOk(), FALSE, wxT("invalid tree item") );
 
-  return item.m_pItem->IsSelected();
+    return item.m_pItem->IsSelected();
 }
 
 bool wxTreeCtrl::IsBold(const wxTreeItemId& item) const
 {
-  wxCHECK_MSG( item.IsOk(), FALSE, wxT("invalid tree item") );
+    wxCHECK_MSG( item.IsOk(), FALSE, wxT("invalid tree item") );
 
-  return item.m_pItem->IsBold();
+    return item.m_pItem->IsBold();
 }
 
 // -----------------------------------------------------------------------------
@@ -915,7 +913,7 @@ wxTreeItemId wxTreeCtrl::AddRoot(const wxString& text,
     if (!HasFlag(wxTR_MULTIPLE))
     {
         m_current = m_key_current = m_anchor;
-	m_current->SetHilight( TRUE );
+	    m_current->SetHilight( TRUE );
     }
 
     Refresh();
@@ -929,7 +927,7 @@ wxTreeItemId wxTreeCtrl::PrependItem(const wxTreeItemId& parent,
                                      int image, int selImage,
                                      wxTreeItemData *data)
 {
-  return DoInsertItem(parent, 0u, text, image, selImage, data);
+    return DoInsertItem(parent, 0u, text, image, selImage, data);
 }
 
 wxTreeItemId wxTreeCtrl::InsertItem(const wxTreeItemId& parentId,
@@ -938,17 +936,34 @@ wxTreeItemId wxTreeCtrl::InsertItem(const wxTreeItemId& parentId,
                                     int image, int selImage,
                                     wxTreeItemData *data)
 {
-  wxGenericTreeItem *parent = parentId.m_pItem;
-  if ( !parent )
-  {
-    // should we give a warning here?
-    return AddRoot(text, image, selImage, data);
-  }
+    wxGenericTreeItem *parent = parentId.m_pItem;
+    if ( !parent )
+    {
+        // should we give a warning here?
+        return AddRoot(text, image, selImage, data);
+    }
+
+    int index = parent->GetChildren().Index(idPrevious.m_pItem);
+    wxASSERT_MSG( index != wxNOT_FOUND,
+                  wxT("previous item in wxTreeCtrl::InsertItem() is not a sibling") );
+                
+    return DoInsertItem(parentId, (size_t)++index, text, image, selImage, data);
+}
+
+wxTreeItemId wxTreeCtrl::InsertItem(const wxTreeItemId& parentId,
+                                    size_t before,
+                                    const wxString& text,
+                                    int image, int selImage,
+                                    wxTreeItemData *data)
+{
+    wxGenericTreeItem *parent = parentId.m_pItem;
+    if ( !parent )
+    {
+        // should we give a warning here?
+        return AddRoot(text, image, selImage, data);
+    }
 
-  int index = parent->GetChildren().Index(idPrevious.m_pItem);
-  wxASSERT_MSG( index != wxNOT_FOUND,
-                wxT("previous item in wxTreeCtrl::InsertItem() is not a sibling") );
-  return DoInsertItem(parentId, (size_t)++index, text, image, selImage, data);
+    return DoInsertItem(parentId, before, text, image, selImage, data);
 }
 
 wxTreeItemId wxTreeCtrl::AppendItem(const wxTreeItemId& parentId,
@@ -956,23 +971,23 @@ wxTreeItemId wxTreeCtrl::AppendItem(const wxTreeItemId& parentId,
                                     int image, int selImage,
                                     wxTreeItemData *data)
 {
-  wxGenericTreeItem *parent = parentId.m_pItem;
-  if ( !parent )
-  {
-    // should we give a warning here?
-    return AddRoot(text, image, selImage, data);
-  }
+    wxGenericTreeItem *parent = parentId.m_pItem;
+    if ( !parent )
+    {
+        // should we give a warning here?
+        return AddRoot(text, image, selImage, data);
+    }
 
-  return DoInsertItem(parent, parent->GetChildren().Count(), text,
-                      image, selImage, data);
+    return DoInsertItem( parent, parent->GetChildren().Count(), text,
+                         image, selImage, data);
 }
 
 void wxTreeCtrl::SendDeleteEvent(wxGenericTreeItem *item)
 {
-  wxTreeEvent event( wxEVT_COMMAND_TREE_DELETE_ITEM, GetId() );
-  event.m_item = item;
-  event.SetEventObject( this );
-  ProcessEvent( event );
+    wxTreeEvent event( wxEVT_COMMAND_TREE_DELETE_ITEM, GetId() );
+    event.m_item = item;
+    event.SetEventObject( this );
+    ProcessEvent( event );
 }
 
 void wxTreeCtrl::DeleteChildren(const wxTreeItemId& itemId)
@@ -1015,109 +1030,114 @@ void wxTreeCtrl::DeleteAllItems()
 
 void wxTreeCtrl::Expand(const wxTreeItemId& itemId)
 {
-  wxGenericTreeItem *item = itemId.m_pItem;
+    wxGenericTreeItem *item = itemId.m_pItem;
 
-  if ( !item->HasPlus() )
-    return;
+    if ( !item->HasPlus() )
+        return;
 
-  if ( item->IsExpanded() )
-    return;
+    if ( item->IsExpanded() )
+        return;
 
-  wxTreeEvent event( wxEVT_COMMAND_TREE_ITEM_EXPANDING, GetId() );
-  event.m_item = item;
-  event.SetEventObject( this );
+    wxTreeEvent event( wxEVT_COMMAND_TREE_ITEM_EXPANDING, GetId() );
+    event.m_item = item;
+    event.SetEventObject( this );
 
 //  if ( ProcessEvent( event ) && event.m_code )  TODO: Was this a typo ?
-  if ( ProcessEvent( event ) && !event.IsAllowed() )
-  {
-    // cancelled by program
-    return;
-  }
+    if ( ProcessEvent( event ) && !event.IsAllowed() )
+    {
+        // cancelled by program
+        return;
+    }
 
-  item->Expand();
-  CalculatePositions();
+    item->Expand();
+    CalculatePositions();
 
-  RefreshSubtree(item);
+    RefreshSubtree(item);
 
-  event.SetEventType(wxEVT_COMMAND_TREE_ITEM_EXPANDED);
-  ProcessEvent( event );
+    event.SetEventType(wxEVT_COMMAND_TREE_ITEM_EXPANDED);
+    ProcessEvent( event );
 }
 
 void wxTreeCtrl::Collapse(const wxTreeItemId& itemId)
 {
-  wxGenericTreeItem *item = itemId.m_pItem;
+    wxGenericTreeItem *item = itemId.m_pItem;
 
-  if ( !item->IsExpanded() )
-    return;
+    if ( !item->IsExpanded() )
+        return;
 
-  wxTreeEvent event( wxEVT_COMMAND_TREE_ITEM_COLLAPSING, GetId() );
-  event.m_item = item;
-  event.SetEventObject( this );
-  if ( ProcessEvent( event ) && !event.IsAllowed() )
-  {
-    // cancelled by program
-    return;
-  }
+    wxTreeEvent event( wxEVT_COMMAND_TREE_ITEM_COLLAPSING, GetId() );
+    event.m_item = item;
+    event.SetEventObject( this );
+    if ( ProcessEvent( event ) && !event.IsAllowed() )
+    {
+        // cancelled by program
+        return;
+    }
 
-  item->Collapse();
+    item->Collapse();
 
-  wxArrayGenericTreeItems& children = item->GetChildren();
-  size_t count = children.Count();
-  for ( size_t n = 0; n < count; n++ )
-  {
-    Collapse(children[n]);
-  }
+    wxArrayGenericTreeItems& children = item->GetChildren();
+    size_t count = children.Count();
+    for ( size_t n = 0; n < count; n++ )
+    {
+        Collapse(children[n]);
+    }
 
-  CalculatePositions();
+    CalculatePositions();
 
-  RefreshSubtree(item);
+    RefreshSubtree(item);
 
-  event.SetEventType(wxEVT_COMMAND_TREE_ITEM_COLLAPSED);
-  ProcessEvent( event );
+    event.SetEventType(wxEVT_COMMAND_TREE_ITEM_COLLAPSED);
+    ProcessEvent( event );
 }
 
 void wxTreeCtrl::CollapseAndReset(const wxTreeItemId& item)
 {
-  Collapse(item);
-  DeleteChildren(item);
+    Collapse(item);
+    DeleteChildren(item);
 }
 
 void wxTreeCtrl::Toggle(const wxTreeItemId& itemId)
 {
-  wxGenericTreeItem *item = itemId.m_pItem;
+    wxGenericTreeItem *item = itemId.m_pItem;
 
-  if ( item->IsExpanded() )
-    Collapse(itemId);
-  else
-    Expand(itemId);
+    if (item->IsExpanded())
+        Collapse(itemId);
+    else
+        Expand(itemId);
 }
 
 void wxTreeCtrl::Unselect()
 {
-  if ( m_current )
-  {
-    m_current->SetHilight( FALSE );
-    RefreshLine( m_current );
-  }
+    if (m_current)
+    {
+        m_current->SetHilight( FALSE );
+        RefreshLine( m_current );
+    }
 }
 
 void wxTreeCtrl::UnselectAllChildren(wxGenericTreeItem *item)
 {
-  item->SetHilight(FALSE);
-  RefreshLine(item);
+    if (item->IsSelected())
+    {
+        item->SetHilight(FALSE);
+        RefreshLine(item);
+    }
 
-  if (item->HasChildren())
+    if (item->HasChildren())
     {
-      wxArrayGenericTreeItems& children = item->GetChildren();
-      size_t count = children.Count();
-      for ( size_t n = 0; n < count; ++n )
-        UnselectAllChildren(children[n]);
+        wxArrayGenericTreeItems& children = item->GetChildren();
+        size_t count = children.Count();
+        for ( size_t n = 0; n < count; ++n )
+        {
+            UnselectAllChildren(children[n]);
+        }
     }
 }
 
 void wxTreeCtrl::UnselectAll()
 {
-  UnselectAllChildren(GetRootItem().m_pItem);
+    UnselectAllChildren(GetRootItem().m_pItem);
 }
 
 // Recursive function !
@@ -1130,8 +1150,8 @@ bool wxTreeCtrl::TagNextChildren(wxGenericTreeItem *crt_item, wxGenericTreeItem
 {
     wxGenericTreeItem *parent = crt_item->GetParent();
 
-    if ( parent == NULL ) // This is root item
-      return TagAllChildrenUntilLast(crt_item, last_item, select);
+    if (parent == NULL) // This is root item
+        return TagAllChildrenUntilLast(crt_item, last_item, select);
 
     wxArrayGenericTreeItems& children = parent->GetChildren();
     int index = children.Index(crt_item);
@@ -1139,24 +1159,30 @@ bool wxTreeCtrl::TagNextChildren(wxGenericTreeItem *crt_item, wxGenericTreeItem
 
     size_t count = children.Count();
     for (size_t n=(size_t)(index+1); n<count; ++n)
-      if (TagAllChildrenUntilLast(children[n], last_item, select)) return TRUE;
+    {
+        if (TagAllChildrenUntilLast(children[n], last_item, select)) return TRUE;
+    }
 
     return TagNextChildren(parent, last_item, select);
 }
 
 bool wxTreeCtrl::TagAllChildrenUntilLast(wxGenericTreeItem *crt_item, wxGenericTreeItem *last_item, bool select)
 {
-  crt_item->SetHilight(select);
-  RefreshLine(crt_item);
+    crt_item->SetHilight(select);
+    RefreshLine(crt_item);
 
-  if (crt_item==last_item) return TRUE;
+    if (crt_item==last_item) 
+        return TRUE;
 
-  if (crt_item->HasChildren())
+    if (crt_item->HasChildren())
     {
-      wxArrayGenericTreeItems& children = crt_item->GetChildren();
-      size_t count = children.Count();
-      for ( size_t n = 0; n < count; ++n )
-        if (TagAllChildrenUntilLast(children[n], last_item, select)) return TRUE;
+        wxArrayGenericTreeItems& children = crt_item->GetChildren();
+        size_t count = children.Count();
+        for ( size_t n = 0; n < count; ++n )
+        {
+            if (TagAllChildrenUntilLast(children[n], last_item, select)) 
+                return TRUE;
+	    }
     }
 
   return FALSE;
@@ -1164,27 +1190,27 @@ bool wxTreeCtrl::TagAllChildrenUntilLast(wxGenericTreeItem *crt_item, wxGenericT
 
 void wxTreeCtrl::SelectItemRange(wxGenericTreeItem *item1, wxGenericTreeItem *item2)
 {
-  // item2 is not necessary after item1
-  wxGenericTreeItem *first=NULL, *last=NULL;
+    // item2 is not necessary after item1
+    wxGenericTreeItem *first=NULL, *last=NULL;
 
-  // choice first' and 'last' between item1 and item2
-  if (item1->GetY()<item2->GetY())
-  {
-      first=item1;
-      last=item2;
-  }
-  else
-  {
-      first=item2;
-      last=item1;
-  }
+    // choice first' and 'last' between item1 and item2
+    if (item1->GetY()<item2->GetY())
+    {   
+        first=item1;
+        last=item2;
+    }
+    else
+    {
+        first=item2;
+        last=item1;
+    }
 
-  bool select = m_current->IsSelected();
+    bool select = m_current->IsSelected();
 
-  if ( TagAllChildrenUntilLast(first,last,select) )
-      return;
+    if ( TagAllChildrenUntilLast(first,last,select) )
+        return;
 
-  TagNextChildren(first,last,select);
+    TagNextChildren(first,last,select);
 }
 
 void wxTreeCtrl::SelectItem(const wxTreeItemId& itemId,
@@ -1327,21 +1353,23 @@ void wxTreeCtrl::ScrollTo(const wxTreeItemId &item)
         int y = 0;
         m_anchor->GetSize( x, y, this );
         y += PIXELS_PER_UNIT+2; // one more scrollbar unit + 2 pixels
+        x += PIXELS_PER_UNIT+2; // one more scrollbar unit + 2 pixels
         int x_pos = GetScrollPos( wxHORIZONTAL );
         // Item should appear at top
         SetScrollbars( PIXELS_PER_UNIT, PIXELS_PER_UNIT, x/PIXELS_PER_UNIT, y/PIXELS_PER_UNIT, x_pos, item_y/PIXELS_PER_UNIT );
     }
     else if (item_y+GetLineHeight(gitem) > start_y+client_h)
     {
-       // going up
-       int x = 0;
-       int y = 0;
-       m_anchor->GetSize( x, y, this );
-       y += PIXELS_PER_UNIT+2; // one more scrollbar unit + 2 pixels
-       item_y += PIXELS_PER_UNIT+2;
-       int x_pos = GetScrollPos( wxHORIZONTAL );
+        // going up
+        int x = 0;
+        int y = 0;
+        m_anchor->GetSize( x, y, this );
+        y += PIXELS_PER_UNIT+2; // one more scrollbar unit + 2 pixels
+        x += PIXELS_PER_UNIT+2; // one more scrollbar unit + 2 pixels
+        item_y += PIXELS_PER_UNIT+2;
+        int x_pos = GetScrollPos( wxHORIZONTAL );
         // Item should appear at bottom
-       SetScrollbars( PIXELS_PER_UNIT, PIXELS_PER_UNIT, x/PIXELS_PER_UNIT, y/PIXELS_PER_UNIT, x_pos, (item_y+GetLineHeight(gitem)-client_h)/PIXELS_PER_UNIT );
+        SetScrollbars( PIXELS_PER_UNIT, PIXELS_PER_UNIT, x/PIXELS_PER_UNIT, y/PIXELS_PER_UNIT, x_pos, (item_y+GetLineHeight(gitem)-client_h)/PIXELS_PER_UNIT );
     }
 }
 
@@ -1395,27 +1423,27 @@ wxImageList *wxTreeCtrl::GetStateImageList() const
 
 void wxTreeCtrl::SetImageList(wxImageList *imageList)
 {
-   m_imageListNormal = imageList;
+    m_imageListNormal = imageList;
 
-   // Calculate a m_lineHeight value from the image sizes.
-   // May be toggle off. Then wxTreeCtrl will spread when
-   // necessary (which might look ugly).
+    // Calculate a m_lineHeight value from the image sizes.
+    // May be toggle off. Then wxTreeCtrl will spread when
+    // necessary (which might look ugly).
 #if 1
-   wxClientDC dc(this);
-   m_lineHeight = (int)(dc.GetCharHeight() + 4);
-   int
-      width = 0,
-      height = 0,
-      n = m_imageListNormal->GetImageCount();
-   for(int i = 0; i < n ; i++)
-   {
-      m_imageListNormal->GetSize(i, width, height);
-      if(height > m_lineHeight) m_lineHeight = height;
-   }
-
-   if (m_lineHeight<40) m_lineHeight+=4; // at least 4 pixels (odd such that a line can be drawn in between)
-   else m_lineHeight+=m_lineHeight/10;   // otherwise 10% extra spacing
+    wxClientDC dc(this);
+    m_lineHeight = (int)(dc.GetCharHeight() + 4);
+    int width = 0, height = 0,
+        n = m_imageListNormal->GetImageCount();
+        
+    for (int i = 0; i < n ; i++)
+    {
+        m_imageListNormal->GetSize(i, width, height);
+        if (height > m_lineHeight) m_lineHeight = height;
+    }
 
+    if (m_lineHeight < 40) 
+        m_lineHeight += 2;                 // at least 2 pixels
+    else 
+        m_lineHeight += m_lineHeight/10;   // otherwise 10% extra spacing
 #endif
 }
 
@@ -1435,8 +1463,8 @@ void wxTreeCtrl::AdjustMyScrollbars()
         int x = 0;
         int y = 0;
         m_anchor->GetSize( x, y, this );
-        //y += GetLineHeight(m_anchor);
         y += PIXELS_PER_UNIT+2; // one more scrollbar unit + 2 pixels
+        x += PIXELS_PER_UNIT+2; // one more scrollbar unit + 2 pixels
         int x_pos = GetScrollPos( wxHORIZONTAL );
         int y_pos = GetScrollPos( wxVERTICAL );
         SetScrollbars( PIXELS_PER_UNIT, PIXELS_PER_UNIT, x/PIXELS_PER_UNIT, y/PIXELS_PER_UNIT, x_pos, y_pos );
@@ -2077,8 +2105,10 @@ void wxTreeCtrl::CalculateSize( wxGenericTreeItem *item, wxDC &dc )
 
     int total_h = (image_h > text_h) ? image_h : text_h;
 
-    if (total_h<40) total_h+=4; // at least 4 pixels
-    else total_h+=total_h/10;   // otherwise 10% extra spacing
+    if (total_h < 40) 
+        total_h += 2;            // at least 2 pixels
+    else 
+        total_h += total_h/10;   // otherwise 10% extra spacing
 
     item->SetHeight(total_h);
     if (total_h>m_lineHeight) m_lineHeight=total_h;
@@ -2109,7 +2139,7 @@ void wxTreeCtrl::CalculateLevel( wxGenericTreeItem *item, wxDC &dc, int level, i
     wxArrayGenericTreeItems& children = item->GetChildren();
     size_t n, count = children.Count();
     for (n = 0; n < count; ++n )
-      CalculateLevel( children[n], dc, level+1, y );  // recurse
+        CalculateLevel( children[n], dc, level+1, y );  // recurse
 }
 
 void wxTreeCtrl::CalculatePositions()
@@ -2131,6 +2161,8 @@ void wxTreeCtrl::CalculatePositions()
 
 void wxTreeCtrl::RefreshSubtree(wxGenericTreeItem *item)
 {
+    if (m_dirty) return;
+
     wxClientDC dc(this);
     PrepareDC(dc);
 
@@ -2151,6 +2183,8 @@ void wxTreeCtrl::RefreshSubtree(wxGenericTreeItem *item)
 
 void wxTreeCtrl::RefreshLine( wxGenericTreeItem *item )
 {
+    if (m_dirty) return;
+
     wxClientDC dc(this);
     PrepareDC( dc );