X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/9a83f860948059b0273b5cc6d9e43fadad3ebfca..cdbd62d6ff290fd58acd1bc5574dfc79db3a6f70:/src/msw/radiobut.cpp?ds=sidebyside diff --git a/src/msw/radiobut.cpp b/src/msw/radiobut.cpp index 01e5fd8dbb..17323a9c1f 100644 --- a/src/msw/radiobut.cpp +++ b/src/msw/radiobut.cpp @@ -4,7 +4,6 @@ // Author: Julian Smart // Modified by: // Created: 04/01/98 -// RCS-ID: $Id$ // Copyright: (c) Julian Smart // Licence: wxWindows licence ///////////////////////////////////////////////////////////////////////////// @@ -44,62 +43,6 @@ // wxRadioButton creation // ---------------------------------------------------------------------------- - -#if wxUSE_EXTENDED_RTTI -WX_DEFINE_FLAGS( wxRadioButtonStyle ) - -wxBEGIN_FLAGS( wxRadioButtonStyle ) - // new style border flags, we put them first to - // use them for streaming out - wxFLAGS_MEMBER(wxBORDER_SIMPLE) - wxFLAGS_MEMBER(wxBORDER_SUNKEN) - wxFLAGS_MEMBER(wxBORDER_DOUBLE) - wxFLAGS_MEMBER(wxBORDER_RAISED) - wxFLAGS_MEMBER(wxBORDER_STATIC) - wxFLAGS_MEMBER(wxBORDER_NONE) - - // old style border flags - wxFLAGS_MEMBER(wxSIMPLE_BORDER) - wxFLAGS_MEMBER(wxSUNKEN_BORDER) - wxFLAGS_MEMBER(wxDOUBLE_BORDER) - wxFLAGS_MEMBER(wxRAISED_BORDER) - wxFLAGS_MEMBER(wxSTATIC_BORDER) - wxFLAGS_MEMBER(wxBORDER) - - // standard window styles - wxFLAGS_MEMBER(wxTAB_TRAVERSAL) - wxFLAGS_MEMBER(wxCLIP_CHILDREN) - wxFLAGS_MEMBER(wxTRANSPARENT_WINDOW) - wxFLAGS_MEMBER(wxWANTS_CHARS) - wxFLAGS_MEMBER(wxFULL_REPAINT_ON_RESIZE) - wxFLAGS_MEMBER(wxALWAYS_SHOW_SB ) - wxFLAGS_MEMBER(wxVSCROLL) - wxFLAGS_MEMBER(wxHSCROLL) - - wxFLAGS_MEMBER(wxRB_GROUP) - -wxEND_FLAGS( wxRadioButtonStyle ) - -IMPLEMENT_DYNAMIC_CLASS_XTI(wxRadioButton, wxControl,"wx/radiobut.h") - -wxBEGIN_PROPERTIES_TABLE(wxRadioButton) - wxEVENT_PROPERTY( Click , wxEVT_COMMAND_RADIOBUTTON_SELECTED , wxCommandEvent ) - wxPROPERTY( Font , wxFont , SetFont , GetFont , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) - wxPROPERTY( Label,wxString, SetLabel, GetLabel, wxString(), 0 /*flags*/ , wxT("Helpstring") , wxT("group") ) - wxPROPERTY( Value ,bool, SetValue, GetValue, EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group") ) - wxPROPERTY_FLAGS( WindowStyle , wxRadioButtonStyle , long , SetWindowStyleFlag , GetWindowStyleFlag , EMPTY_MACROVALUE , 0 /*flags*/ , wxT("Helpstring") , wxT("group")) // style -wxEND_PROPERTIES_TABLE() - -wxBEGIN_HANDLERS_TABLE(wxRadioButton) -wxEND_HANDLERS_TABLE() - -wxCONSTRUCTOR_6( wxRadioButton , wxWindow* , Parent , wxWindowID , Id , wxString , Label , wxPoint , Position , wxSize , Size , long , WindowStyle ) - -#else -IMPLEMENT_DYNAMIC_CLASS(wxRadioButton, wxControl) -#endif - - void wxRadioButton::Init() { m_isChecked = false; @@ -117,25 +60,10 @@ bool wxRadioButton::Create(wxWindow *parent, if ( !CreateControl(parent, id, pos, size, style, validator, name) ) return false; - long msStyle = WS_TABSTOP; - if ( HasFlag(wxRB_GROUP) ) - msStyle |= WS_GROUP; + WXDWORD exstyle = 0; + WXDWORD msStyle = MSWGetStyle(style, &exstyle); - // we use BS_RADIOBUTTON and not BS_AUTORADIOBUTTON because the use of the - // latter can easily result in the application entering an infinite loop - // inside IsDialogMessage() - // - // we used to use BS_RADIOBUTTON only for wxRB_SINGLE buttons but there - // doesn't seem to be any harm to always use it and it prevents some hangs, - // see #9786 - msStyle |= BS_RADIOBUTTON; - - if ( HasFlag(wxCLIP_SIBLINGS) ) - msStyle |= WS_CLIPSIBLINGS; - if ( HasFlag(wxALIGN_RIGHT) ) - msStyle |= BS_LEFTTEXT | BS_RIGHT; - - if ( !MSWCreateControl(wxT("BUTTON"), msStyle, pos, size, label, 0) ) + if ( !MSWCreateControl(wxT("BUTTON"), msStyle, pos, size, label, exstyle) ) return false; // for compatibility with wxGTK, the first radio button in a group is @@ -288,7 +216,7 @@ bool wxRadioButton::MSWCommand(WXUINT param, WXWORD WXUNUSED(id)) // and not BS_AUTORADIOBUTTON SetValue(true); - wxCommandEvent event(wxEVT_COMMAND_RADIOBUTTON_SELECTED, GetId()); + wxCommandEvent event(wxEVT_RADIOBUTTON, GetId()); event.SetEventObject( this ); event.SetInt(true); // always checked @@ -345,12 +273,27 @@ wxSize wxRadioButton::DoGetBestSize() const WXDWORD wxRadioButton::MSWGetStyle(long style, WXDWORD *exstyle) const { - WXDWORD styleMSW = wxControl::MSWGetStyle(style, exstyle); + WXDWORD msStyle = wxControl::MSWGetStyle(style, exstyle); + + if ( HasFlag(wxRB_GROUP) ) + msStyle |= WS_GROUP; + + // we use BS_RADIOBUTTON and not BS_AUTORADIOBUTTON because the use of the + // latter can easily result in the application entering an infinite loop + // inside IsDialogMessage() + // + // we used to use BS_RADIOBUTTON only for wxRB_SINGLE buttons but there + // doesn't seem to be any harm to always use it and it prevents some hangs, + // see #9786 + msStyle |= BS_RADIOBUTTON; + + if ( style & wxCLIP_SIBLINGS ) + msStyle |= WS_CLIPSIBLINGS; + if ( style & wxALIGN_RIGHT ) + msStyle |= BS_LEFTTEXT | BS_RIGHT; - if ( style & wxRB_GROUP ) - styleMSW |= WS_GROUP; - return styleMSW; + return msStyle; } #endif // wxUSE_RADIOBTN