X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/9670dfc4bebf107fff652a8facab25524ef4c0eb..cbc82a22cc4cb21fe3ca705ed5da5644cef90e3a:/src/cocoa/evtloop.mm diff --git a/src/cocoa/evtloop.mm b/src/cocoa/evtloop.mm index 9381f37e59..add5528e94 100644 --- a/src/cocoa/evtloop.mm +++ b/src/cocoa/evtloop.mm @@ -6,12 +6,13 @@ // Created: 2003/10/02 // RCS-ID: $Id$ // Copyright: (c) 2003 David Elliott -// License: wxWindows licence +// License: wxWidgets licence /////////////////////////////////////////////////////////////////////////////// #include "wx/wxprec.h" #ifndef WX_PRECOMP #include "wx/log.h" + #include "wx/app.h" #endif //WX_PRECOMP #include "wx/evtloop.h" @@ -47,25 +48,17 @@ private: // wxEventLoop running and exiting // ---------------------------------------------------------------------------- -wxEventLoop *wxEventLoop::ms_activeLoop = NULL; - wxEventLoop::~wxEventLoop() { wxASSERT_MSG( !m_impl, _T("should have been deleted in Run()") ); } -bool wxEventLoop::IsRunning() const -{ - return m_impl; -} - int wxEventLoop::Run() { // event loops are not recursive, you need to create another loop! wxCHECK_MSG( !IsRunning(), -1, _T("can't reenter a message loop") ); - wxEventLoop *oldLoop = ms_activeLoop; - ms_activeLoop = this; + wxEventLoopActivator activate(this); m_impl = new wxEventLoopImpl; @@ -75,8 +68,6 @@ int wxEventLoop::Run() delete m_impl; m_impl = NULL; - ms_activeLoop = oldLoop; - return exitcode; } @@ -87,18 +78,13 @@ void wxEventLoop::Exit(int rc) m_impl->SetExitCode(rc); NSApplication *cocoaApp = [NSApplication sharedApplication]; - wxLogDebug("wxEventLoop::Exit isRunning=%d", (int)[cocoaApp isRunning]); - // This works around a bug in Cocoa. - [NSEvent startPeriodicEventsAfterDelay:0.0 withPeriod:5.0]; + wxLogTrace(wxTRACE_COCOA,wxT("wxEventLoop::Exit isRunning=%d"), (int)[cocoaApp isRunning]); + wxTheApp->WakeUpIdle(); /* Notes: - This function is most often called during idle time. See - wxApp::CocoaInstallIdleHandler() for an overview of the implications - of idle event time. In short, Cocoa must have at least one real event - in the queue (of which an idle "event" is not) in order for it to - realize that the application has been stopped. The above method - generates the first periodic event immediately, and would generate - further events every 5 seconds if not for the fact that the next - method stops the event loop. + If we're being called from idle time (which occurs while checking the + queue for new events) there may or may not be any events in the queue. + In order to successfully stop the event loop, at least one event must + be processed. To ensure this always happens, WakeUpIdle is called. If the application was active when closed then this is unnecessary because it would receive a deactivate event anyway. However, if the