X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/90a6f1cca8cfc0c80f1c68bef429d2dce2ba8999..1ac76609146a74466b88e53b551e9ea01c5c8801:/src/msw/dirdlg.cpp diff --git a/src/msw/dirdlg.cpp b/src/msw/dirdlg.cpp index e736175a5c..5f2f111abb 100644 --- a/src/msw/dirdlg.cpp +++ b/src/msw/dirdlg.cpp @@ -1,11 +1,11 @@ ///////////////////////////////////////////////////////////////////////////// -// Name: dirdlg.cpp +// Name: src/msw/dirdlg.cpp // Purpose: wxDirDialog // Author: Julian Smart // Modified by: // Created: 01/02/97 // RCS-ID: $Id$ -// Copyright: (c) Julian Smart and Markus Holzem +// Copyright: (c) Julian Smart // Licence: wxWindows licence ///////////////////////////////////////////////////////////////////////////// @@ -17,10 +17,6 @@ // headers // ---------------------------------------------------------------------------- -#ifdef __GNUG__ - #pragma implementation "dirdlg.h" -#endif - // For compilers that support precompilation, includes "wx.h". #include "wx/wxprec.h" @@ -30,29 +26,37 @@ #if wxUSE_DIRDLG -#if defined(__WIN95__) && !defined(__GNUWIN32_OLD__) && wxUSE_OLE +#if wxUSE_OLE && !defined(__GNUWIN32_OLD__) && (!defined(__WXWINCE__) || (defined(__HANDHELDPC__) && (_WIN32_WCE >= 500))) #ifndef WX_PRECOMP #include "wx/utils.h" #include "wx/dialog.h" #include "wx/dirdlg.h" #include "wx/log.h" + #include "wx/app.h" // for GetComCtl32Version() #endif #include "wx/msw/private.h" - -#include // Win95 shell +#include "wx/msw/wrapshl.h" // ---------------------------------------------------------------------------- // constants // ---------------------------------------------------------------------------- -#ifndef MAX_PATH - #define MAX_PATH 4096 // be generous +#ifndef BIF_NEWDIALOGSTYLE + #define BIF_NEWDIALOGSTYLE 0x0040 +#endif + +#ifndef BIF_NONEWFOLDERBUTTON + #define BIF_NONEWFOLDERBUTTON 0x0200 +#endif + +#ifndef BIF_EDITBOX + #define BIF_EDITBOX 16 #endif // ---------------------------------------------------------------------------- -// wxWindows macros +// wxWidgets macros // ---------------------------------------------------------------------------- IMPLEMENT_CLASS(wxDirDialog, wxDialog) @@ -61,9 +65,6 @@ IMPLEMENT_CLASS(wxDirDialog, wxDialog) // private functions prototypes // ---------------------------------------------------------------------------- -// free the parameter -static void ItemListFree(LPITEMIDLIST pidl); - // the callback proc for the dir dlg static int CALLBACK BrowseCallbackProc(HWND hwnd, UINT uMsg, LPARAM lp, LPARAM pData); @@ -114,10 +115,6 @@ void wxDirDialog::SetPath(const wxString& path) } } -#ifndef BIF_NEWDIALOGSTYLE -#define BIF_NEWDIALOGSTYLE 0x0040 -#endif - int wxDirDialog::ShowModal() { wxWindow *parent = GetParent(); @@ -126,43 +123,65 @@ int wxDirDialog::ShowModal() bi.hwndOwner = parent ? GetHwndOf(parent) : NULL; bi.pidlRoot = NULL; bi.pszDisplayName = NULL; + // Please don't change this without checking it compiles + // with eVC++ first. +#if defined(__POCKETPC__) || defined(__SMARTPHONE__) + bi.lpszTitle = m_message.mb_str(); +#else bi.lpszTitle = m_message.c_str(); +#endif bi.ulFlags = BIF_RETURNONLYFSDIRS | BIF_STATUSTEXT; bi.lpfn = BrowseCallbackProc; bi.lParam = (LPARAM)m_path.c_str(); // param for the callback - if ((GetStyle() & wxDD_NEW_DIR_BUTTON) && - (wxApp::GetComCtl32Version() >= 500)) - { - bi.ulFlags |= BIF_NEWDIALOGSTYLE; - } - - LPITEMIDLIST pidl = SHBrowseForFolder(&bi); + static const int verComCtl32 = wxApp::GetComCtl32Version(); - if ( bi.pidlRoot ) + // we always add the edit box (it doesn't hurt anybody, does it?) if it is + // supported by the system + if ( verComCtl32 >= 471 ) { - ItemListFree((LPITEMIDLIST)bi.pidlRoot); + bi.ulFlags |= BIF_EDITBOX; } - if ( !pidl ) + // to have the "New Folder" button we must use the "new" dialog style which + // is also the only way to have a resizable dialog + // + // "new" style is only available in the version 5.0+ of comctl32.dll + const bool needNewDir = HasFlag(wxDD_NEW_DIR_BUTTON); + if ( (needNewDir || HasFlag(wxRESIZE_BORDER)) && (verComCtl32 >= 500) ) { - // Cancel button pressed - return wxID_CANCEL; + if (needNewDir) + { + bi.ulFlags |= BIF_NEWDIALOGSTYLE; + } + else + { + // Versions < 600 doesn't support BIF_NONEWFOLDERBUTTON + // The only way to get rid of the Make New Folder button is use + // the old dialog style which doesn't have the button thus we + // simply don't set the New Dialog Style for such comctl versions. + if (verComCtl32 >= 600) + { + bi.ulFlags |= BIF_NEWDIALOGSTYLE; + bi.ulFlags |= BIF_NONEWFOLDERBUTTON; + } + } } - BOOL ok = SHGetPathFromIDList(pidl, m_path.GetWriteBuf(MAX_PATH)); - m_path.UngetWriteBuf(); + // do show the dialog + wxItemIdList pidl(SHBrowseForFolder(&bi)); - ItemListFree(pidl); + wxItemIdList::Free((LPITEMIDLIST)bi.pidlRoot); - if ( !ok ) + if ( !pidl ) { - wxLogLastError(wxT("SHGetPathFromIDList")); - + // Cancel button pressed return wxID_CANCEL; } - return wxID_OK; + m_path = pidl.GetPath(); + + return m_path.empty() ? wxID_CANCEL : wxID_OK; } // ---------------------------------------------------------------------------- @@ -174,28 +193,42 @@ BrowseCallbackProc(HWND hwnd, UINT uMsg, LPARAM lp, LPARAM pData) { switch(uMsg) { +#ifdef BFFM_SETSELECTION case BFFM_INITIALIZED: // sent immediately after initialisation and so we may set the // initial selection here // // wParam = TRUE => lParam is a string and not a PIDL - SendMessage(hwnd, BFFM_SETSELECTION, TRUE, pData); + ::SendMessage(hwnd, BFFM_SETSELECTION, TRUE, pData); break; +#endif // BFFM_SETSELECTION + case BFFM_SELCHANGED: + // note that this doesn't work with the new style UI (MSDN doesn't + // say anything about it, but the comments in shlobj.h do!) but we + // still execute this code in case it starts working again with the + // "new new UI" (or would it be "NewUIEx" according to tradition?) { // Set the status window to the currently selected path. - TCHAR szDir[MAX_PATH]; - if ( SHGetPathFromIDList((LPITEMIDLIST)lp, szDir) ) + wxString strDir; + if ( SHGetPathFromIDList((LPITEMIDLIST)lp, + wxStringBuffer(strDir, MAX_PATH)) ) { - wxString strDir(szDir); - int maxChars = 40; // Have to truncate string else it displays incorrectly - if (strDir.Len() > (size_t) (maxChars - 3)) + // NB: this shouldn't be necessary with the new style box + // (which is resizable), but as for now it doesn't work + // anyhow (see the comment above) no harm in doing it + + // need to truncate or it displays incorrectly + static const size_t maxChars = 37; + if ( strDir.length() > maxChars ) { - strDir = strDir.Right(maxChars - 3); + strDir = strDir.Right(maxChars); strDir = wxString(wxT("...")) + strDir; } - SendMessage(hwnd, BFFM_SETSTATUSTEXT, 0, (LPARAM) (const wxChar*) strDir); + + SendMessage(hwnd, BFFM_SETSTATUSTEXT, + 0, (LPARAM)strDir.c_str()); } } break; @@ -207,27 +240,7 @@ BrowseCallbackProc(HWND hwnd, UINT uMsg, LPARAM lp, LPARAM pData) return 0; } - -static void ItemListFree(LPITEMIDLIST pidl) -{ - if ( pidl ) - { - LPMALLOC pMalloc; - SHGetMalloc(&pMalloc); - if ( pMalloc ) - { - pMalloc->Free(pidl); - pMalloc->Release(); - } - else - { - wxLogLastError(wxT("SHGetMalloc")); - } - } -} - -#else - #include "../generic/dirdlgg.cpp" #endif // compiler/platform on which the code here compiles #endif // wxUSE_DIRDLG +