X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/907789a0f72354f30ec04f79f03a0b7e2a29ac9a..d284c07534af75014345a80363a7036897b5e388:/src/gtk1/mdi.cpp

diff --git a/src/gtk1/mdi.cpp b/src/gtk1/mdi.cpp
index 3612109580..6f88db3f39 100644
--- a/src/gtk1/mdi.cpp
+++ b/src/gtk1/mdi.cpp
@@ -7,21 +7,39 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
-#ifdef __GNUG__
+#if defined(__GNUG__) && !defined(NO_GCC_PRAGMA)
 #pragma implementation "mdi.h"
 #endif
 
+// For compilers that support precompilation, includes "wx.h".
+#include "wx/wxprec.h"
+
 #include "wx/mdi.h"
+
+#if wxUSE_MDI_ARCHITECTURE
+
 #include "wx/dialog.h"
 #include "wx/menu.h"
+#include "wx/intl.h"
+#include "wx/gtk/private.h"
+
+#include <glib.h>
+#include <gdk/gdk.h>
+#include <gtk/gtk.h>
 #include "wx/gtk/win_gtk.h"
-#include <wx/intl.h>
 
 //-----------------------------------------------------------------------------
 // constants
 //-----------------------------------------------------------------------------
 
-const int wxMENU_HEIGHT    = 27;
+const int wxMENU_HEIGHT = 27;
+
+//-----------------------------------------------------------------------------
+// idle system
+//-----------------------------------------------------------------------------
+
+extern void wxapp_install_idle_handler();
+extern bool g_isIdle;
 
 //-----------------------------------------------------------------------------
 // globals
@@ -30,45 +48,57 @@ const int wxMENU_HEIGHT    = 27;
 extern wxList wxPendingDelete;
 
 //-----------------------------------------------------------------------------
-// "size_allocate"
+// "switch_page"
 //-----------------------------------------------------------------------------
 
-static void gtk_page_size_callback( GtkWidget *WXUNUSED(widget), GtkAllocation* alloc, wxWindow *win )
+static void
+gtk_mdi_page_change_callback( GtkNotebook *WXUNUSED(widget),
+                              GtkNotebookPage *page,
+                              gint WXUNUSED(page_num),
+                              wxMDIParentFrame *parent )
 {
-  if ((win->m_x == alloc->x) &&
-      (win->m_y == alloc->y) &&
-      (win->m_width == alloc->width) &&
-      (win->m_height == alloc->height) &&
-      (win->m_sizeSet))
-  {
-    return;
-  }
+    if (g_isIdle)
+        wxapp_install_idle_handler();
 
-  win->SetSize( alloc->x, alloc->y, alloc->width, alloc->height );
-}
+    // send deactivate event to old child
 
-//-----------------------------------------------------------------------------
-// page change callback
-//-----------------------------------------------------------------------------
+    wxMDIChildFrame *child = parent->GetActiveChild();
+    if (child)
+    {
+        wxActivateEvent event1( wxEVT_ACTIVATE, false, child->GetId() );
+        event1.SetEventObject( child);
+        child->GetEventHandler()->ProcessEvent( event1 );
+    }
 
-static void gtk_page_change_callback( GtkNotebook *WXUNUSED(widget),
-                                      GtkNotebookPage *page,
-                                      gint WXUNUSED(nPage),
-                                      wxMDIClientWindow *client_win )
-{
-  wxNode *node = client_win->m_children.First();
-  while (node)
-  {
-    wxMDIChildFrame *child_frame = (wxMDIChildFrame *)node->Data();
-    if (child_frame->m_page == page)
+    // send activate event to new child
+
+    wxMDIClientWindow *client_window = parent->GetClientWindow();
+    if (!client_window)
+        return;
+
+    child = (wxMDIChildFrame*) NULL;
+
+    wxWindowList::compatibility_iterator node = client_window->GetChildren().GetFirst();
+    while (node)
     {
-      wxMDIParentFrame *mdi_frame = (wxMDIParentFrame*)client_win->m_parent;
-      mdi_frame->m_currentChild = child_frame;
-      mdi_frame->SetMDIMenuBar( child_frame->m_menuBar );
-      return;
+        wxMDIChildFrame *child_frame = wxDynamicCast( node->GetData(), wxMDIChildFrame );
+
+        wxASSERT_MSG( child_frame, _T("child is not a wxMDIChildFrame") );
+
+        if (child_frame->m_page == page)
+        {
+            child = child_frame;
+            break;
+        }
+        node = node->GetNext();
     }
-    node = node->Next();
-  }
+
+    if (!child)
+         return;
+
+    wxActivateEvent event2( wxEVT_ACTIVATE, true, child->GetId() );
+    event2.SetEventObject( child);
+    child->GetEventHandler()->ProcessEvent( event2 );
 }
 
 //-----------------------------------------------------------------------------
@@ -77,113 +107,185 @@ static void gtk_page_change_callback( GtkNotebook *WXUNUSED(widget),
 
 IMPLEMENT_DYNAMIC_CLASS(wxMDIParentFrame,wxFrame)
 
-BEGIN_EVENT_TABLE(wxMDIParentFrame, wxFrame)
-END_EVENT_TABLE()
-
-wxMDIParentFrame::wxMDIParentFrame(void)
-{
-  m_clientWindow = (wxMDIClientWindow *) NULL;
-  m_currentChild = (wxMDIChildFrame *) NULL;
-  m_parentFrameActive = TRUE;
-}
-
-wxMDIParentFrame::wxMDIParentFrame( wxWindow *parent,
-      wxWindowID id, const wxString& title,
-      const wxPoint& pos, const wxSize& size,
-      long style, const wxString& name )
+void wxMDIParentFrame::Init()
 {
-  m_clientWindow = (wxMDIClientWindow *) NULL;
-  m_currentChild = (wxMDIChildFrame *) NULL;
-  m_parentFrameActive = TRUE;
-  Create( parent, id, title, pos, size, style, name );
+    m_justInserted = false;
+    m_clientWindow = (wxMDIClientWindow *) NULL;
 }
 
-wxMDIParentFrame::~wxMDIParentFrame(void)
+wxMDIParentFrame::~wxMDIParentFrame()
 {
 }
 
-bool wxMDIParentFrame::Create( wxWindow *parent,
-      wxWindowID id, const wxString& title,
-      const wxPoint& pos, const wxSize& size,
-      long style, const wxString& name )
+bool wxMDIParentFrame::Create(wxWindow *parent,
+                              wxWindowID id,
+                              const wxString& title,
+                              const wxPoint& pos,
+                              const wxSize& size,
+                              long style,
+                              const wxString& name )
 {
-  wxFrame::Create( parent, id, title, pos, size, style, name );
+    wxFrame::Create( parent, id, title, pos, size, style, name );
 
-  OnCreateClient();
+    OnCreateClient();
 
-  return TRUE;
+    return true;
 }
 
 void wxMDIParentFrame::GtkOnSize( int x, int y, int width, int height )
 {
-  wxFrame::GtkOnSize( x, y, width, height );
+    wxFrame::GtkOnSize( x, y, width, height );
 
-  if (m_mdiMenuBar)
-  {
-    m_mdiMenuBar->m_x = 0;  
-    m_mdiMenuBar->m_y = 0;
-    m_mdiMenuBar->m_width = m_width;
-    m_mdiMenuBar->m_height = wxMENU_HEIGHT;
-    gtk_myfixed_move( GTK_MYFIXED(m_wxwindow), m_mdiMenuBar->m_widget, 0, 0 );
-    gtk_widget_set_usize( m_mdiMenuBar->m_widget, m_width, wxMENU_HEIGHT );
-  }
-}
+    wxMDIChildFrame *child_frame = GetActiveChild();
+    if (!child_frame) return;
 
-void wxMDIParentFrame::SetMDIMenuBar( wxMenuBar *menu_bar )
-{
-  if (m_mdiMenuBar) m_mdiMenuBar->Show( FALSE );
-  m_mdiMenuBar = menu_bar;
-  if (m_mdiMenuBar)
-  {
-    m_mdiMenuBar->m_x = 0;  
-    m_mdiMenuBar->m_y = 0;
-    m_mdiMenuBar->m_width = m_width;
-    m_mdiMenuBar->m_height = wxMENU_HEIGHT;
-    gtk_myfixed_move( GTK_MYFIXED(m_wxwindow), m_mdiMenuBar->m_widget, 0, 0 );
-    gtk_widget_set_usize( m_mdiMenuBar->m_widget, m_width, wxMENU_HEIGHT );
-    m_mdiMenuBar->Show( TRUE );
-  }
-}
+    wxMenuBar *menu_bar = child_frame->m_menuBar;
+    if (!menu_bar) return;
+    if (!menu_bar->m_widget) return;
 
-void wxMDIParentFrame::GetClientSize(int *width, int *height ) const
-{
-  wxFrame::GetClientSize( width, height );
+    menu_bar->m_x = 0;
+    menu_bar->m_y = 0;
+    menu_bar->m_width = m_width;
+    menu_bar->m_height = wxMENU_HEIGHT;
+    gtk_pizza_set_size( GTK_PIZZA(m_mainWidget),
+                          menu_bar->m_widget,
+                          0, 0, m_width, wxMENU_HEIGHT );
 }
 
-wxMDIChildFrame *wxMDIParentFrame::GetActiveChild(void) const
+void wxMDIParentFrame::OnInternalIdle()
 {
-  return m_currentChild;
+    /* if a an MDI child window has just been inserted
+       it has to be brought to the top in idle time. we
+       simply set the last notebook page active as new
+       pages can only be appended at the end */
+
+    if (m_justInserted)
+    {
+        GtkNotebook *notebook = GTK_NOTEBOOK(m_clientWindow->m_widget);
+        gtk_notebook_set_page( notebook, g_list_length( notebook->children ) - 1 );
+
+        m_justInserted = false;
+        return;
+    }
+
+    wxFrame::OnInternalIdle();
+
+    wxMDIChildFrame *active_child_frame = GetActiveChild();
+    bool visible_child_menu = false;
+
+    wxWindowList::compatibility_iterator node = m_clientWindow->GetChildren().GetFirst();
+    while (node)
+    {
+        wxMDIChildFrame *child_frame = wxDynamicCast( node->GetData(), wxMDIChildFrame );
+
+        if ( child_frame )
+        {
+            wxMenuBar *menu_bar = child_frame->m_menuBar;
+            if ( menu_bar )
+            {
+                if (child_frame == active_child_frame)
+                {
+                    if (menu_bar->Show(true))
+                    {
+                        menu_bar->m_width = m_width;
+                        menu_bar->m_height = wxMENU_HEIGHT;
+                        gtk_pizza_set_size( GTK_PIZZA(m_mainWidget),
+                                            menu_bar->m_widget,
+                                            0, 0, m_width, wxMENU_HEIGHT );
+                        menu_bar->SetInvokingWindow( child_frame );
+                    }
+                    visible_child_menu = true;
+                }
+                else
+                {
+                    if (menu_bar->Show(false))
+                    {
+                        menu_bar->UnsetInvokingWindow( child_frame );
+                    }
+                }
+            }
+        }
+
+        node = node->GetNext();
+    }
+
+    /* show/hide parent menu bar as required */
+    if ((m_frameMenuBar) &&
+        (m_frameMenuBar->IsShown() == visible_child_menu))
+    {
+        if (visible_child_menu)
+        {
+            m_frameMenuBar->Show( false );
+            m_frameMenuBar->UnsetInvokingWindow( this );
+        }
+        else
+        {
+            m_frameMenuBar->Show( true );
+            m_frameMenuBar->SetInvokingWindow( this );
+
+            m_frameMenuBar->m_width = m_width;
+            m_frameMenuBar->m_height = wxMENU_HEIGHT;
+            gtk_pizza_set_size( GTK_PIZZA(m_mainWidget),
+                                m_frameMenuBar->m_widget,
+                                0, 0, m_width, wxMENU_HEIGHT );
+        }
+    }
 }
 
-wxMDIClientWindow *wxMDIParentFrame::GetClientWindow(void) const
+void wxMDIParentFrame::DoGetClientSize(int *width, int *height ) const
 {
-  return m_clientWindow;
+    wxFrame::DoGetClientSize( width, height );
 }
 
-wxMDIClientWindow *wxMDIParentFrame::OnCreateClient(void)
+wxMDIChildFrame *wxMDIParentFrame::GetActiveChild() const
 {
-  m_clientWindow = new wxMDIClientWindow( this );
-  return m_clientWindow;
+    if (!m_clientWindow) return (wxMDIChildFrame*) NULL;
+
+    GtkNotebook *notebook = GTK_NOTEBOOK(m_clientWindow->m_widget);
+    if (!notebook) return (wxMDIChildFrame*) NULL;
+
+    gint i = gtk_notebook_get_current_page( notebook );
+    if (i < 0) return (wxMDIChildFrame*) NULL;
+
+    GtkNotebookPage* page = (GtkNotebookPage*) (g_list_nth(notebook->children,i)->data);
+    if (!page) return (wxMDIChildFrame*) NULL;
+
+    wxWindowList::compatibility_iterator node = m_clientWindow->GetChildren().GetFirst();
+    while (node)
+    {
+        wxMDIChildFrame *child_frame = wxDynamicCast( node->GetData(), wxMDIChildFrame );
+
+        wxASSERT_MSG( child_frame, _T("child is not a wxMDIChildFrame") );
+
+        if (child_frame->m_page == page)
+            return child_frame;
+        node = node->GetNext();
+    }
+
+    return (wxMDIChildFrame*) NULL;
 }
 
-void wxMDIParentFrame::ActivateNext(void)
+wxMDIClientWindow *wxMDIParentFrame::GetClientWindow() const
 {
-  if (m_clientWindow)
-    gtk_notebook_next_page( GTK_NOTEBOOK(m_clientWindow->m_widget) );
+    return m_clientWindow;
 }
 
-void wxMDIParentFrame::ActivatePrevious(void)
+wxMDIClientWindow *wxMDIParentFrame::OnCreateClient()
 {
-  if (m_clientWindow)
-    gtk_notebook_prev_page( GTK_NOTEBOOK(m_clientWindow->m_widget) );
+    m_clientWindow = new wxMDIClientWindow( this );
+    return m_clientWindow;
 }
 
-void wxMDIParentFrame::OnActivate( wxActivateEvent& WXUNUSED(event) )
+void wxMDIParentFrame::ActivateNext()
 {
+    if (m_clientWindow)
+      gtk_notebook_next_page( GTK_NOTEBOOK(m_clientWindow->m_widget) );
 }
 
-void wxMDIParentFrame::OnSysColourChanged( wxSysColourChangedEvent& WXUNUSED(event) )
+void wxMDIParentFrame::ActivatePrevious()
 {
+    if (m_clientWindow)
+      gtk_notebook_prev_page( GTK_NOTEBOOK(m_clientWindow->m_widget) );
 }
 
 //-----------------------------------------------------------------------------
@@ -191,15 +293,16 @@ void wxMDIParentFrame::OnSysColourChanged( wxSysColourChangedEvent& WXUNUSED(eve
 //-----------------------------------------------------------------------------
 
 IMPLEMENT_DYNAMIC_CLASS(wxMDIChildFrame,wxFrame)
-  
+
 BEGIN_EVENT_TABLE(wxMDIChildFrame, wxFrame)
-  EVT_ACTIVATE(wxMDIChildFrame::OnActivate)
+    EVT_ACTIVATE(wxMDIChildFrame::OnActivate)
+    EVT_MENU_HIGHLIGHT_ALL(wxMDIChildFrame::OnMenuHighlight)
 END_EVENT_TABLE()
 
-wxMDIChildFrame::wxMDIChildFrame(void)
+wxMDIChildFrame::wxMDIChildFrame()
 {
-  m_menuBar = (wxMenuBar *) NULL;
-  m_page = (GtkNotebookPage *) NULL;
+    m_menuBar = (wxMenuBar *) NULL;
+    m_page = (GtkNotebookPage *) NULL;
 }
 
 wxMDIChildFrame::wxMDIChildFrame( wxMDIParentFrame *parent,
@@ -207,23 +310,15 @@ wxMDIChildFrame::wxMDIChildFrame( wxMDIParentFrame *parent,
       const wxPoint& WXUNUSED(pos), const wxSize& size,
       long style, const wxString& name )
 {
-  m_menuBar = (wxMenuBar *) NULL;
-  m_page = (GtkNotebookPage *) NULL;
-  Create( parent, id, title, wxDefaultPosition, size, style, name );
+    m_menuBar = (wxMenuBar *) NULL;
+    m_page = (GtkNotebookPage *) NULL;
+    Create( parent, id, title, wxDefaultPosition, size, style, name );
 }
 
-wxMDIChildFrame::~wxMDIChildFrame(void)
+wxMDIChildFrame::~wxMDIChildFrame()
 {
-  if (m_menuBar)
-  {
-    wxMDIParentFrame *mdi_frame = (wxMDIParentFrame*)m_parent->m_parent;
-    if (mdi_frame->m_currentChild == this)
-    {
-      mdi_frame->SetMDIMenuBar( (wxMenuBar *) NULL );
-      mdi_frame->m_currentChild = (wxMDIChildFrame *) NULL;
-    }
-    delete m_menuBar;
-  }
+    if (m_menuBar)
+        delete m_menuBar;
 }
 
 bool wxMDIChildFrame::Create( wxMDIParentFrame *parent,
@@ -231,72 +326,110 @@ bool wxMDIChildFrame::Create( wxMDIParentFrame *parent,
       const wxPoint& WXUNUSED(pos), const wxSize& size,
       long style, const wxString& name )
 {
-  m_title = title;
-  
-  return wxWindow::Create( parent->GetClientWindow(), id, wxDefaultPosition, size, style, name );
+    m_title = title;
+
+    return wxWindow::Create( parent->GetClientWindow(), id, wxDefaultPosition, size, style, name );
+}
+
+void wxMDIChildFrame::DoSetSize( int x, int y, int width, int height, int sizeFlags )
+{
+    wxWindow::DoSetSize( x, y, width, height, sizeFlags );
 }
 
-void wxMDIChildFrame::GetClientSize( int *width, int *height ) const
+void wxMDIChildFrame::DoSetClientSize(int width, int height)
 {
-  wxWindow::GetClientSize( width, height );
+    wxWindow::DoSetClientSize( width, height );
 }
 
-void wxMDIChildFrame::AddChild( wxWindow *child )
+void wxMDIChildFrame::DoGetClientSize( int *width, int *height ) const
 {
-  wxWindow::AddChild( child );
+    wxWindow::DoGetClientSize( width, height );
 }
-  
-static void SetInvokingWindow( wxMenu *menu, wxWindow *win )
+
+void wxMDIChildFrame::AddChild( wxWindowBase *child )
 {
-  menu->SetInvokingWindow( win );
-  wxNode *node = menu->m_items.First();
-  while (node)
-  {
-    wxMenuItem *menuitem = (wxMenuItem*)node->Data();
-    if (menuitem->IsSubMenu())
-      SetInvokingWindow( menuitem->GetSubMenu(), win );
-    node = node->Next();
-  }
+    wxWindow::AddChild(child);
 }
 
 void wxMDIChildFrame::SetMenuBar( wxMenuBar *menu_bar )
 {
-  m_menuBar = menu_bar;
+    wxASSERT_MSG( m_menuBar == NULL, wxT("Only one menubar allowed") );
 
-  if (m_menuBar)
-  {
-    wxMDIParentFrame *mdi_frame = (wxMDIParentFrame*)m_parent->m_parent;
+    m_menuBar = menu_bar;
 
-    if (m_menuBar->m_parent != this)
+    if (m_menuBar)
     {
-      wxNode *node = m_menuBar->m_menus.First();
-      while (node)
-      {
-        wxMenu *menu = (wxMenu*)node->Data();
-        SetInvokingWindow( menu, this );
-        node = node->Next();
-      }
-
-      m_menuBar->m_parent = mdi_frame;
+        wxMDIParentFrame *mdi_frame = (wxMDIParentFrame*)m_parent->GetParent();
+
+        m_menuBar->SetParent( mdi_frame );
+
+        /* insert the invisible menu bar into the _parent_ mdi frame */
+        gtk_pizza_put( GTK_PIZZA(mdi_frame->m_mainWidget),
+                         m_menuBar->m_widget,
+                         0, 0,  mdi_frame->m_width, wxMENU_HEIGHT );
     }
-    mdi_frame->SetMDIMenuBar( m_menuBar );
+}
+
+wxMenuBar *wxMDIChildFrame::GetMenuBar() const
+{
+    return m_menuBar;
+}
+
+void wxMDIChildFrame::Activate()
+{
+    wxMDIParentFrame* parent = (wxMDIParentFrame*) GetParent();
+    GtkNotebook* notebook = GTK_NOTEBOOK(parent->m_widget);
+    gint pageno = gtk_notebook_page_num( notebook, m_widget );
+    gtk_notebook_set_page( notebook, pageno );
+}
 
-    gtk_myfixed_put( GTK_MYFIXED(mdi_frame->m_wxwindow),
-      m_menuBar->m_widget, m_menuBar->m_x, m_menuBar->m_y );
-  }
+void wxMDIChildFrame::OnActivate( wxActivateEvent& WXUNUSED(event) )
+{
 }
 
-wxMenuBar *wxMDIChildFrame::GetMenuBar()
+void wxMDIChildFrame::OnMenuHighlight( wxMenuEvent& event )
 {
-  return m_menuBar;
+#if wxUSE_STATUSBAR
+    wxMDIParentFrame *mdi_frame = (wxMDIParentFrame*)m_parent->GetParent();
+    if ( !ShowMenuHelp(mdi_frame->GetStatusBar(), event.GetMenuId()) )
+    {
+        // we don't have any help text for this item, but may be the MDI frame
+        // does?
+        mdi_frame->OnMenuHighlight(event);
+    }
+#endif // wxUSE_STATUSBAR
 }
 
-void wxMDIChildFrame::Activate(void)
+void wxMDIChildFrame::SetTitle( const wxString &title )
 {
+    if ( title == m_title )
+        return;
+
+    m_title = title;
+
+    wxMDIParentFrame* parent = (wxMDIParentFrame*) GetParent();
+    GtkNotebook* notebook = GTK_NOTEBOOK(parent->m_widget);
+    gtk_notebook_set_tab_label_text(notebook, m_widget, wxGTK_CONV( title ) );
 }
 
-void wxMDIChildFrame::OnActivate( wxActivateEvent &WXUNUSED(event) )
+//-----------------------------------------------------------------------------
+// "size_allocate"
+//-----------------------------------------------------------------------------
+
+static void gtk_page_size_callback( GtkWidget *WXUNUSED(widget), GtkAllocation* alloc, wxWindow *win )
 {
+    if (g_isIdle) wxapp_install_idle_handler();
+
+    if ((win->m_x == alloc->x) &&
+        (win->m_y == alloc->y) &&
+        (win->m_width == alloc->width) &&
+        (win->m_height == alloc->height) &&
+        (win->m_sizeSet))
+    {
+        return;
+    }
+
+    win->SetSize( alloc->x, alloc->y, alloc->width, alloc->height );
 }
 
 //-----------------------------------------------------------------------------
@@ -305,24 +438,23 @@ void wxMDIChildFrame::OnActivate( wxActivateEvent &WXUNUSED(event) )
 
 static void wxInsertChildInMDI( wxMDIClientWindow* parent, wxMDIChildFrame* child )
 {
-  wxString s = child->m_title;
-  if (s.IsNull()) s = _("MDI child");
+    wxString s = child->m_title;
+    if (s.IsNull()) s = _("MDI child");
+
+    GtkWidget *label_widget = gtk_label_new( s.mbc_str() );
+    gtk_misc_set_alignment( GTK_MISC(label_widget), 0.0, 0.5 );
+
+    gtk_signal_connect( GTK_OBJECT(child->m_widget), "size_allocate",
+      GTK_SIGNAL_FUNC(gtk_page_size_callback), (gpointer)child );
 
-  GtkWidget *label_widget = gtk_label_new( s );
-  gtk_misc_set_alignment( GTK_MISC(label_widget), 0.0, 0.5 );
+    GtkNotebook *notebook = GTK_NOTEBOOK(parent->m_widget);
 
-  gtk_signal_connect( GTK_OBJECT(child->m_widget), "size_allocate",
-    GTK_SIGNAL_FUNC(gtk_page_size_callback), (gpointer)child );
-    
-  GtkNotebook *notebook = GTK_NOTEBOOK(parent->m_widget);
-    
-  gtk_notebook_append_page( notebook, child->m_widget, label_widget );
+    gtk_notebook_append_page( notebook, child->m_widget, label_widget );
 
-  child->m_page = (GtkNotebookPage*) (g_list_last(notebook->children)->data);
+    child->m_page = (GtkNotebookPage*) (g_list_last(notebook->children)->data);
 
-  gtk_notebook_set_page( notebook, parent->m_children.Number()-1 );
-  
-  gtk_page_change_callback( (GtkNotebook *) NULL, child->m_page, 0, parent );
+    wxMDIParentFrame *parent_frame = (wxMDIParentFrame*) parent->GetParent();
+    parent_frame->m_justInserted = true;
 }
 
 //-----------------------------------------------------------------------------
@@ -331,44 +463,46 @@ static void wxInsertChildInMDI( wxMDIClientWindow* parent, wxMDIChildFrame* chil
 
 IMPLEMENT_DYNAMIC_CLASS(wxMDIClientWindow,wxWindow)
 
-wxMDIClientWindow::wxMDIClientWindow(void)
+wxMDIClientWindow::wxMDIClientWindow()
 {
 }
 
 wxMDIClientWindow::wxMDIClientWindow( wxMDIParentFrame *parent, long style )
 {
-  CreateClient( parent, style );
+    CreateClient( parent, style );
 }
 
-wxMDIClientWindow::~wxMDIClientWindow(void)
+wxMDIClientWindow::~wxMDIClientWindow()
 {
 }
 
 bool wxMDIClientWindow::CreateClient( wxMDIParentFrame *parent, long style )
 {
-  m_needParent = TRUE;
-  
-  m_insertCallback = (wxInsertChildFunction)wxInsertChildInMDI;
+    m_needParent = true;
 
-  PreCreation( parent, -1, wxPoint(10,10), wxSize(100,100), style, "wxMDIClientWindow" );
+    m_insertCallback = (wxInsertChildFunction)wxInsertChildInMDI;
 
-  m_widget = gtk_notebook_new();
-
-  gtk_signal_connect( GTK_OBJECT(m_widget), "switch_page",
-                      GTK_SIGNAL_FUNC(gtk_page_change_callback), (gpointer)this );
+    if (!PreCreation( parent, wxDefaultPosition, wxDefaultSize ) ||
+        !CreateBase( parent, -1, wxDefaultPosition, wxDefaultSize, style, wxDefaultValidator, wxT("wxMDIClientWindow") ))
+    {
+        wxFAIL_MSG( wxT("wxMDIClientWindow creation failed") );
+        return false;
+    }
 
-  gtk_notebook_set_scrollable( GTK_NOTEBOOK(m_widget), 1 );
+    m_widget = gtk_notebook_new();
 
-  m_parent->AddChild( this );
+    gtk_signal_connect( GTK_OBJECT(m_widget), "switch_page",
+      GTK_SIGNAL_FUNC(gtk_mdi_page_change_callback), (gpointer)parent );
 
-  (m_parent->m_insertCallback)( m_parent, this );
-  
-  PostCreation();
+    gtk_notebook_set_scrollable( GTK_NOTEBOOK(m_widget), 1 );
 
-  Show( TRUE );
+    m_parent->DoAddChild( this );
 
-  return TRUE;
-}
+    PostCreation();
 
+    Show( true );
 
+    return true;
+}
 
+#endif