X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/8eb2940f7f226b068007928465096e2b9bec67d0..8ad6ad991c39081d513f7d277bd3509fbbaa42fc:/src/html/htmlwin.cpp?ds=inline

diff --git a/src/html/htmlwin.cpp b/src/html/htmlwin.cpp
index 0f0b5d67a8..31cc7feb00 100644
--- a/src/html/htmlwin.cpp
+++ b/src/html/htmlwin.cpp
@@ -27,7 +27,7 @@
 
 #include "wx/html/htmlwin.h"
 #include "wx/html/forcelnk.h"
-
+#include "wx/log.h"
 
 
 //-----------------------------------------------------------------------------
@@ -41,10 +41,10 @@ WX_DEFINE_OBJARRAY(HtmlHistoryArray)
 
 
 wxHtmlWindow::wxHtmlWindow(wxWindow *parent, wxWindowID id, const wxPoint& pos, const wxSize& size,
-                long style, const wxString& name) : wxScrolledWindow(parent, id, pos, size, wxVSCROLL, name)
+                long style, const wxString& name) : wxScrolledWindow(parent, id, pos, size, wxVSCROLL | wxHSCROLL, name)
 {
     m_tmpMouseMoved = FALSE;
-    m_tmpLastLink = wxEmptyString;
+    m_tmpLastLink = NULL;
     m_tmpCanDrawLocks = 0;
     m_FS = new wxFileSystem();
     m_RelatedStatusBar = -1;
@@ -69,9 +69,6 @@ wxHtmlWindow::~wxHtmlWindow()
 
     if (m_Cell) delete m_Cell;
 
-    wxList *parser_data = m_Parser -> GetTempData();
-    if (parser_data) delete parser_data;
-
     delete m_Parser;
     delete m_FS;
 }
@@ -158,10 +155,8 @@ bool wxHtmlWindow::LoadPage(const wxString& location)
         if (f == NULL) {
             wxString err;
 
-            err.Printf(_("The browser is unable to open requested location :\n\n%s"), WXSTRINGCAST location);
+            wxLogError(_("Unable to open requested HTML document: %s"), location.mb_str());
             m_tmpCanDrawLocks--;
-            Refresh();
-            wxMessageBox(err, "Error");
 
             SetCursor(*wxSTANDARD_CURSOR);
             return FALSE;
@@ -228,7 +223,11 @@ bool wxHtmlWindow::LoadPage(const wxString& location)
 bool wxHtmlWindow::ScrollToAnchor(const wxString& anchor)
 {
     const wxHtmlCell *c = m_Cell -> Find(wxHTML_COND_ISANCHOR, &anchor);
-    if (!c) return FALSE;
+    if (!c)
+    {
+        wxLogWarning(_("HTML anchor %s does not exist."), anchor.mb_str());
+        return FALSE;
+    }
     else {
         int y;
 
@@ -274,11 +273,12 @@ void wxHtmlWindow::CreateLayout()
 #endif
         GetClientSize(&ClientWidth, &ClientHeight);
         m_Cell -> Layout(ClientWidth);
-        if (ClientHeight < m_Cell -> GetHeight()) {
-            SetScrollbars(wxHTML_SCROLL_STEP, wxHTML_SCROLL_STEP,
-                          m_Cell -> GetWidth() / wxHTML_SCROLL_STEP,
-                          m_Cell -> GetHeight() / wxHTML_SCROLL_STEP
-                          /*cheat: top-level frag is always container*/);
+        if (ClientHeight < m_Cell -> GetHeight() + GetCharHeight()) {
+            SetScrollbars(
+                  wxHTML_SCROLL_STEP, wxHTML_SCROLL_STEP,
+                  m_Cell -> GetWidth() / wxHTML_SCROLL_STEP,
+                  (m_Cell -> GetHeight() + GetCharHeight()) / wxHTML_SCROLL_STEP
+                  /*cheat: top-level frag is always container*/);
         }
         else { /* we fit into window, no need for scrollbars */
             SetScrollbars(wxHTML_SCROLL_STEP, 1, m_Cell -> GetWidth() / wxHTML_SCROLL_STEP, 0); // disable...
@@ -421,9 +421,9 @@ void wxHtmlWindow::AddFilter(wxHtmlFilter *filter)
 
 
 
-void wxHtmlWindow::OnLinkClicked(const wxString& link)
+void wxHtmlWindow::OnLinkClicked(const wxHtmlLinkInfo& link)
 {
-    LoadPage(link);
+    LoadPage(link.GetHref());
 }
 
 
@@ -436,8 +436,12 @@ void wxHtmlWindow::OnDraw(wxDC& dc)
 
     if (m_tmpCanDrawLocks > 0) return;
     dc.SetMapMode(wxMM_TEXT);
+#if 0
+/* VS - I don't think this is neccessary any longer 
+        MSC_VER 1200 means MSVC 6.0 and it works fine */
 #if defined(_MSC_VER) && (_MSC_VER == 1200)
     ::SetMapMode((HDC)dc.GetHDC(), MM_TEXT);
+#endif
 #endif
     dc.SetBackgroundMode(wxTRANSPARENT);
     ViewStart(&x, &y);
@@ -472,12 +476,12 @@ void wxHtmlWindow::OnKeyDown(wxKeyEvent& event)
 
     switch (event.KeyCode()) {
         case WXK_PAGEUP :
-    case WXK_PRIOR :
-                Scroll(-1, sty - cliy);
+        case WXK_PRIOR :
+                Scroll(-1, sty - (5 * cliy / 6));
                 break;
         case WXK_PAGEDOWN :
-    case WXK_NEXT :
-                Scroll(-1, sty + cliy);
+        case WXK_NEXT :
+                Scroll(-1, sty + (5 * cliy / 6));
                 break;
         case WXK_HOME :
                 Scroll(-1, 0);
@@ -509,7 +513,7 @@ void wxHtmlWindow::OnMouseEvent(wxMouseEvent& event)
         pos = event.GetPosition();
 
         if (m_Cell)
-            m_Cell -> OnMouseClick(this, sx + pos.x, sy + pos.y, event.ButtonDown(1), event.ButtonDown(2), event.ButtonDown(3));
+            m_Cell -> OnMouseClick(this, sx + pos.x, sy + pos.y, event);
     }
 }
 
@@ -522,7 +526,7 @@ void wxHtmlWindow::OnIdle(wxIdleEvent& event)
     if (m_tmpMouseMoved && (m_Cell != NULL)) {
         int sx, sy;
         int x, y;
-        wxString lnk;
+        wxHtmlLinkInfo *lnk;
 
         ViewStart(&sx, &sy); sx *= wxHTML_SCROLL_STEP; sy *= wxHTML_SCROLL_STEP;
         wxGetMousePosition(&x, &y);
@@ -530,13 +534,14 @@ void wxHtmlWindow::OnIdle(wxIdleEvent& event)
         lnk = m_Cell -> GetLink(sx + x, sy + y);
 
         if (lnk != m_tmpLastLink) {
-            if (lnk == wxEmptyString) {
+            if (lnk == NULL) {
                 SetCursor(cur_arrow);
                 if (m_RelatedStatusBar != -1) m_RelatedFrame -> SetStatusText(wxEmptyString, m_RelatedStatusBar);
             }
             else {
                 SetCursor(cur_hand);
-                if (m_RelatedStatusBar != -1) m_RelatedFrame -> SetStatusText(lnk, m_RelatedStatusBar);
+                if (m_RelatedStatusBar != -1) 
+                    m_RelatedFrame -> SetStatusText(lnk -> GetHref(), m_RelatedStatusBar);
             }
             m_tmpLastLink = lnk;
         }
@@ -590,6 +595,7 @@ FORCE_LINK(m_pre)
 FORCE_LINK(m_hline)
 FORCE_LINK(m_links)
 FORCE_LINK(m_tables)
+FORCE_LINK(m_meta)
 
 
 #endif