X-Git-Url: https://git.saurik.com/wxWidgets.git/blobdiff_plain/8957e55ed3292874c54db019be74ef152c962d96..66c2bf7b1d9326fb650acfaae22ec50528cfbf7c:/include/wx/msw/datetimectrl.h?ds=inline

diff --git a/include/wx/msw/datetimectrl.h b/include/wx/msw/datetimectrl.h
index 1efcaa242c..eb93f26ae1 100644
--- a/include/wx/msw/datetimectrl.h
+++ b/include/wx/msw/datetimectrl.h
@@ -3,7 +3,6 @@
 // Purpose:     wxDateTimePickerCtrl for Windows.
 // Author:      Vadim Zeitlin
 // Created:     2011-09-22 (extracted from wx/msw/datectrl.h).
-// RCS-ID:      $Id$
 // Copyright:   (c) 2005-2011 Vadim Zeitlin <vadim@wxwindows.org>
 // Licence:     wxWindows licence
 ///////////////////////////////////////////////////////////////////////////////
@@ -47,15 +46,37 @@ protected:
                                  const wxValidator& validator,
                                  const wxString& name);
 
+    // Notice that the methods below must be overridden in all native MSW
+    // classes inheriting from this one but they can't be pure virtual because
+    // the generic implementations, not needing nor able to implement them, is
+    // also derived from this class currently. The real problem is, of course,
+    // this wrong class structure because the generic classes also inherit the
+    // wrong implementations of Set/GetValue() and DoGetBestSize() but as they
+    // override these methods anyhow, it does work -- but is definitely ugly
+    // and need to be changed (but how?) in the future.
+
     // Override to return the date/time format used by this control.
-    virtual wxLocaleInfo MSWGetFormat() const = 0;
+    virtual wxLocaleInfo MSWGetFormat() const /* = 0 */
+    {
+        wxFAIL_MSG( "Unreachable" );
+        return wxLOCALE_TIME_FMT;
+    }
 
     // Override to indicate whether we can have no date at all.
-    virtual bool MSWAllowsNone() const = 0;
+    virtual bool MSWAllowsNone() const /* = 0 */
+    {
+        wxFAIL_MSG( "Unreachable" );
+        return false;
+    }
 
     // Override to update m_date and send the event when the control contents
     // changes, return true if the event was handled.
-    virtual bool MSWOnDateTimeChange(const tagNMDATETIMECHANGE& dtch) = 0;
+    virtual bool MSWOnDateTimeChange(const tagNMDATETIMECHANGE& dtch) /* = 0 */
+    {
+        wxUnusedVar(dtch);
+        wxFAIL_MSG( "Unreachable" );
+        return false;
+    }
 
 
     // the date currently shown by the control, may be invalid